create_node() is called only for issued xenstore commands. This means that the "conn" parameter is never NULL. Remove checking whether "conn" is not NULL. Signed-off-by: Juergen Gross <jgross@suse.com> --- tools/xenstored/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index XXXXXXX..XXXXXXX 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -XXX,XX +XXX,XX @@ static struct node *create_node(struct connection *conn, const void *ctx, if (!node) return NULL; - if (conn && conn->transaction) + if (conn->transaction) ta_node_created(conn->transaction); node->data = data; -- 2.53.0 create_node() is called only for issued xenstore commands. This means that the "conn" parameter is never NULL. Remove checking whether "conn" is not NULL. Coverity ID: 1690859 Signed-off-by: Juergen Gross <jgross@suse.com> --- V2: - added Coverity ID (Jan Beulich) --- tools/xenstored/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c index XXXXXXX..XXXXXXX 100644 --- a/tools/xenstored/core.c +++ b/tools/xenstored/core.c @@ -XXX,XX +XXX,XX @@ static struct node *create_node(struct connection *conn, const void *ctx, if (!node) return NULL; - if (conn && conn->transaction) + if (conn->transaction) ta_node_created(conn->transaction); node->data = data; -- 2.53.0