[PATCH] swiotlb-xen: remove redundant NULL check

Daniil Dulov posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
There is a newer version of this series
drivers/xen/swiotlb-xen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] swiotlb-xen: remove redundant NULL check
Posted by Daniil Dulov 2 weeks ago
In this case hwdev cannot be NULL, so remove redundant NULL check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b097186fd29d ("swiotlb-xen: SWIOTLB library for Xen PV guest with PCI passthrough.")
Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
---
 drivers/xen/swiotlb-xen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 2b385c1b4a99..b166f6efea26 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -305,7 +305,7 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	if (!ret)
 		return ret;
 
-	if (hwdev && hwdev->coherent_dma_mask)
+	if (hwdev->coherent_dma_mask)
 		dma_mask = hwdev->coherent_dma_mask;
 
 	/* At this point dma_handle is the dma address, next we are
-- 
2.25.1
Re: [PATCH] swiotlb-xen: remove redundant NULL check
Posted by Stefano Stabellini 1 week, 6 days ago
Hi Daniil,

Against which Linux branch was this patch generated?

Cheers,

Stefano


On Sun, 11 Feb 2024, Daniil Dulov wrote:
> In this case hwdev cannot be NULL, so remove redundant NULL check.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: b097186fd29d ("swiotlb-xen: SWIOTLB library for Xen PV guest with PCI passthrough.")
> Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
> ---
>  drivers/xen/swiotlb-xen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 2b385c1b4a99..b166f6efea26 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -305,7 +305,7 @@ xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
>  	if (!ret)
>  		return ret;
>  
> -	if (hwdev && hwdev->coherent_dma_mask)
> +	if (hwdev->coherent_dma_mask)
>  		dma_mask = hwdev->coherent_dma_mask;
>  
>  	/* At this point dma_handle is the dma address, next we are
> -- 
> 2.25.1
>