drivers/net/xen-netback/netback.c | 5 ----- 1 file changed, 5 deletions(-)
building with gcc and W=1 reports
drivers/net/xen-netback/netback.c:886:21: error: variable
‘pending_idx’ set but not used [-Werror=unused-but-set-variable]
886 | u16 pending_idx;
| ^~~~~~~~~~~
pending_idx is not used so remove it. Since index was only
used to set pending_idx, remove index as well.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/xen-netback/netback.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index bf627af723bf..1b42676ca141 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -883,11 +883,9 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
struct xen_netif_tx_request txfrags[XEN_NETBK_LEGACY_SLOTS_MAX];
struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX-1];
unsigned int extra_count;
- u16 pending_idx;
RING_IDX idx;
int work_to_do;
unsigned int data_len;
- pending_ring_idx_t index;
if (queue->tx.sring->req_prod - queue->tx.req_cons >
XEN_NETIF_TX_RING_SIZE) {
@@ -983,9 +981,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
break;
}
- index = pending_index(queue->pending_cons);
- pending_idx = queue->pending_ring[index];
-
if (ret >= XEN_NETBK_LEGACY_SLOTS_MAX - 1 && data_len < txreq.size)
data_len = txreq.size;
--
2.27.0
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 26 Feb 2023 11:34:29 -0500 you wrote: > building with gcc and W=1 reports > drivers/net/xen-netback/netback.c:886:21: error: variable > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] > 886 | u16 pending_idx; > | ^~~~~~~~~~~ > > pending_idx is not used so remove it. Since index was only > used to set pending_idx, remove index as well. > > [...] Here is the summary with links: - xen-netback: remove unused variables pending_idx and index https://git.kernel.org/netdev/net-next/c/ccf8f7d71424 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On 26.02.23 17:34, Tom Rix wrote: > building with gcc and W=1 reports > drivers/net/xen-netback/netback.c:886:21: error: variable > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] > 886 | u16 pending_idx; > | ^~~~~~~~~~~ > > pending_idx is not used so remove it. Since index was only > used to set pending_idx, remove index as well. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On Mon, 27 Feb 2023 09:29:30 +0100 Juergen Gross wrote: > On 26.02.23 17:34, Tom Rix wrote: > > building with gcc and W=1 reports > > drivers/net/xen-netback/netback.c:886:21: error: variable > > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] > > 886 | u16 pending_idx; > > | ^~~~~~~~~~~ > > > > pending_idx is not used so remove it. Since index was only > > used to set pending_idx, remove index as well. > > > > Signed-off-by: Tom Rix <trix@redhat.com> > > Reviewed-by: Juergen Gross <jgross@suse.com> Applied, thanks!
© 2016 - 2024 Red Hat, Inc.