[PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()

Jiapeng Chong posted 1 patch 1 year, 4 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
arch/x86/xen/p2m.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
Posted by Jiapeng Chong 1 year, 4 months ago
The function p2m_top_mfn_init is defined in the p2m.c file,
but not called elsewhere, so remove this unused function.

arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3557
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/xen/p2m.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 58db86f7b384..9bdc3b656b2c 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -134,11 +134,6 @@ static inline unsigned p2m_mid_index(unsigned long pfn)
 	return (pfn / P2M_PER_PAGE) % P2M_MID_PER_PAGE;
 }
 
-static inline unsigned p2m_index(unsigned long pfn)
-{
-	return pfn % P2M_PER_PAGE;
-}
-
 static void p2m_top_mfn_init(unsigned long *top)
 {
 	unsigned i;
-- 
2.20.1.7.g153144c
Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
Posted by Jan Beulich 1 year, 3 months ago
On 27.12.2022 09:21, Jiapeng Chong wrote:
> The function p2m_top_mfn_init is defined in the p2m.c file,
> but not called elsewhere, so remove this unused function.

This and the title are wrong - p2m_top_mfn_init() is used by
xen_build_mfn_list_list().

> arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.

Whereas this and the actual code change look correct to me.

Jan