PCI: Add pci_dev_for_each_resource() helper and

[PATCH v3 0/4] PCI: Add pci_dev_for_each_resource() helper and

Andy Shevchenko posted 4 patches 1 year, 5 months ago

Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

.clang-format                      |  3 +++
arch/alpha/kernel/pci.c            |  5 ++---
arch/arm/kernel/bios32.c           | 16 ++++++-------
arch/mips/pci/pci-legacy.c         |  3 +--
arch/powerpc/kernel/pci-common.c   |  5 ++---
arch/sparc/kernel/leon_pci.c       |  5 ++---
arch/sparc/kernel/pci.c            | 10 ++++-----
arch/sparc/kernel/pcic.c           |  5 ++---
drivers/eisa/pci_eisa.c            |  4 ++--
drivers/pci/bus.c                  |  7 +++---
drivers/pci/hotplug/shpchp_sysfs.c |  8 +++----
drivers/pci/pci.c                  |  5 ++---
drivers/pci/probe.c                |  2 +-
drivers/pci/remove.c               |  5 ++---
drivers/pci/setup-bus.c            | 36 ++++++++++++------------------
drivers/pci/setup-res.c            |  4 +---
drivers/pci/xen-pcifront.c         |  4 +---
drivers/pcmcia/rsrc_nonstatic.c    |  9 +++-----
drivers/pcmcia/yenta_socket.c      |  3 +--
include/linux/pci.h                | 25 +++++++++++++++++----
20 files changed, 78 insertions(+), 86 deletions(-)

Expand all Fold all

[PATCH v3 0/4] PCI: Add pci_dev_for_each_resource() helper and

Posted by Andy Shevchenko 1 year, 5 months ago

Provide two new helper macros to iterate over PCI device resources and
convert users.

Looking at it, refactor existing pci_bus_for_each_resource() and convert
users accordingly.

This applies on top of this patch Mika sent out earlier:
https://lore.kernel.org/r/20221114115953.40236-1-mika.westerberg@linux.intel.com

Changelog v3:
- rebased on top of v2 by Mika, see above
- added tag to pcmcia patch (Dominik)

Changelog v2:
- refactor to have two macros
- refactor existing pci_bus_for_each_resource() in the same way and
  convert users

Andy Shevchenko (3):
  PCI: Split pci_bus_for_each_resource_p() out of
    pci_bus_for_each_resource()
  EISA: Convert to use pci_bus_for_each_resource_p()
  pcmcia: Convert to use pci_bus_for_each_resource_p()

Mika Westerberg (1):
  PCI: Introduce pci_dev_for_each_resource()

 .clang-format                      |  3 +++
 arch/alpha/kernel/pci.c            |  5 ++---
 arch/arm/kernel/bios32.c           | 16 ++++++-------
 arch/mips/pci/pci-legacy.c         |  3 +--
 arch/powerpc/kernel/pci-common.c   |  5 ++---
 arch/sparc/kernel/leon_pci.c       |  5 ++---
 arch/sparc/kernel/pci.c            | 10 ++++-----
 arch/sparc/kernel/pcic.c           |  5 ++---
 drivers/eisa/pci_eisa.c            |  4 ++--
 drivers/pci/bus.c                  |  7 +++---
 drivers/pci/hotplug/shpchp_sysfs.c |  8 +++----
 drivers/pci/pci.c                  |  5 ++---
 drivers/pci/probe.c                |  2 +-
 drivers/pci/remove.c               |  5 ++---
 drivers/pci/setup-bus.c            | 36 ++++++++++++------------------
 drivers/pci/setup-res.c            |  4 +---
 drivers/pci/xen-pcifront.c         |  4 +---
 drivers/pcmcia/rsrc_nonstatic.c    |  9 +++-----
 drivers/pcmcia/yenta_socket.c      |  3 +--
 include/linux/pci.h                | 25 +++++++++++++++++----
 20 files changed, 78 insertions(+), 86 deletions(-)

-- 
2.35.1

Re: [PATCH v3 0/4] PCI: Add pci_dev_for_each_resource() helper and

Posted by Krzysztof Wilczyński 1 year, 5 months ago

Hello,

> Provide two new helper macros to iterate over PCI device resources and
> convert users.
> 
> Looking at it, refactor existing pci_bus_for_each_resource() and convert
> users accordingly.
> 
> This applies on top of this patch Mika sent out earlier:
> https://lore.kernel.org/r/20221114115953.40236-1-mika.westerberg@linux.intel.com
> 
> Changelog v3:
> - rebased on top of v2 by Mika, see above
> - added tag to pcmcia patch (Dominik)
[...]

Thank you Andy for all the improvements and Mika for the idea!

For the whole series:
  Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Looks very nice!

	Krzysztof