One of the warning message in gnttab_grow_table() refers to a function
was removed in commit 6425f91c72 "xen/gnttab: Fold grant_table_{create,
set_limits}() into grant_table_init()".
Since the commit, gt->active will be allocated while initializing the
grant table at domain creation. Therefore gt-active will always be
valid.
Rather than replacing the warning by another one, drop the check
completely as we will likely not come back to a semi-initialized world.
Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
Changes v2:
- Remove the check completely
- Add Andrew's acked-by
---
xen/common/grant_table.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index bc37acae0e..057c78f620 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1793,12 +1793,6 @@ gnttab_grow_table(struct domain *d, unsigned int req_nr_frames)
struct grant_table *gt = d->grant_table;
unsigned int i, j;
- if ( unlikely(!gt->active) )
- {
- gprintk(XENLOG_WARNING, "grant_table_set_limits() call missing\n");
- return -ENODEV;
- }
-
if ( req_nr_frames < INITIAL_NR_GRANT_FRAMES )
req_nr_frames = INITIAL_NR_GRANT_FRAMES;
ASSERT(req_nr_frames <= gt->max_grant_frames);
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel