From nobody Thu May 2 20:37:53 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1582643036; cv=none; d=zohomail.com; s=zohoarc; b=HlyhvJgoAHwKDFddLhcf7yX5pmR8YCEDfB5GsI0O1J2uvhhZSLAZR3mUtYTLeXZn0f4PeZh6/AYfV8RueylU+nZkrn401lgEseRIIugMFePvdXdrRRZtgh01Wi5CFnrdeU7e1pXH8LrJXPnB1dLmACNisfxwP1/JF2Tl5TD60No= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582643036; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1CvWf+eumwsQsBgIgb2mOEmMvQesH136pvt4ws1qhFE=; b=InwvmhA+XhafytKzhwr940XaodZhH6qFvNxfA2C9Rn8QnyXig/D9Wzo22fWjaNvvG4YYWtMgOl+hiHAGfyhnHhn7GDVt5CBunm6JRRZpIO+O4KZjg7UzREPa0i2lj6fwUvpHfZ1k8Uu5/M326zB8nuO3zXbs11O1ZmPbjdDqmv8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1582643036836602.8096022753432; Tue, 25 Feb 2020 07:03:56 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6bjO-00016E-9f; Tue, 25 Feb 2020 15:02:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6bjN-000169-7g for xen-devel@lists.xenproject.org; Tue, 25 Feb 2020 15:02:41 +0000 Received: from mail-ed1-f67.google.com (unknown [209.85.208.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ddd24e06-57df-11ea-aba8-bc764e2007e4; Tue, 25 Feb 2020 15:02:40 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id c26so16579668eds.8 for ; Tue, 25 Feb 2020 07:02:40 -0800 (PST) Received: from ufe34d9ed68d054.ant.amazon.com (54-240-197-235.amazon.com. [54.240.197.235]) by smtp.gmail.com with ESMTPSA id o88sm1159507eda.41.2020.02.25.07.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 07:02:38 -0800 (PST) X-Inumbo-ID: ddd24e06-57df-11ea-aba8-bc764e2007e4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yC3ES5J/2XN2w8MFSgSYO8leL9zQ8QQv+7aw2xjSeWE=; b=OgB006ORxZyZXK/m1S2PDeEWim5hsjZHVjtadA0kMFnhhAJgcT9UNRyZ6FDDzuwlYo RKamqZ7V4herJzsbOGVQ5BLK9LS9lvTZI27rcNt2qSXeKyEXpcl2AynH9DmxQKoqsJBD 2WcKGxHwG4KbI19a4WBFASHhv3yOrqpwF1WYS9kofpWztvrsmKSxkmnFoiI7UZZE/sA5 M5gGwrCBOoWpd0R7L8TGAb+kSl3X+K6QsEWI17dpIaQ9e3NcL05JB/4nLukf6GEJCXgM 0TQnaEPj0zCYCLso5atuU+PcdfRcFIIZmC5Vk00oQNihu67wYdTsOJy92t2aIQSsYJE/ 5zWA== X-Gm-Message-State: APjAAAUd7MxfCuJle7TIofR3zHKYhWd/IWLB1CXaeEHGcQLKZt0hP7O8 gP5J7YmbOkwglVtPiKqOLmJAh57rRjWIUA== X-Google-Smtp-Source: APXvYqzxVpMlwyHJuqlZ7MYK3K5ixJw1nN9gvl28AMgfdQdtuwSQAokPQwztvoZ+Jvh+UCooSow9fw== X-Received: by 2002:a17:906:27cb:: with SMTP id k11mr53504123ejc.301.1582642959265; Tue, 25 Feb 2020 07:02:39 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 25 Feb 2020 15:02:37 +0000 Message-Id: <20200225150237.9124-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 Subject: [Xen-devel] [PATCH v2] xen/grant-table: Remove outdated warning in gnttab_grow_table() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Julien Grall , Julien Grall MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" One of the warning message in gnttab_grow_table() refers to a function was removed in commit 6425f91c72 "xen/gnttab: Fold grant_table_{create, set_limits}() into grant_table_init()". Since the commit, gt->active will be allocated while initializing the grant table at domain creation. Therefore gt-active will always be valid. Rather than replacing the warning by another one, drop the check completely as we will likely not come back to a semi-initialized world. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Changes v2: - Remove the check completely - Add Andrew's acked-by --- xen/common/grant_table.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index bc37acae0e..057c78f620 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1793,12 +1793,6 @@ gnttab_grow_table(struct domain *d, unsigned int req= _nr_frames) struct grant_table *gt =3D d->grant_table; unsigned int i, j; =20 - if ( unlikely(!gt->active) ) - { - gprintk(XENLOG_WARNING, "grant_table_set_limits() call missing\n"); - return -ENODEV; - } - if ( req_nr_frames < INITIAL_NR_GRANT_FRAMES ) req_nr_frames =3D INITIAL_NR_GRANT_FRAMES; ASSERT(req_nr_frames <=3D gt->max_grant_frames); --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel