x86/shim: copy back the result of EVTCHNOP_status

[Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Roger Pau Monne 4 years, 5 months ago

The event channel data was not copied back to guest memory, fix this
by doing the copy.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/pv/shim.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index 4329eaaefe..35bf3945ac 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -514,6 +514,9 @@ static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         else
             rc = xen_hypercall_event_channel_op(EVTCHNOP_status, &status);
 
+        if ( !rc && __copy_to_guest(arg, &status, 1) )
+            rc = -EFAULT;
+
         break;
     }
 
-- 
2.23.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Wei Liu 4 years, 5 months ago

On Thu, Oct 31, 2019 at 12:58:29PM +0100, Roger Pau Monne wrote:
> The event channel data was not copied back to guest memory, fix this
> by doing the copy.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Jürgen Groß 4 years, 5 months ago

On 31.10.19 12:58, Roger Pau Monne wrote:
> The event channel data was not copied back to guest memory, fix this
> by doing the copy.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Wei Liu 4 years, 5 months ago

On Fri, Nov 01, 2019 at 07:17:57AM +0100, Jürgen Groß wrote:
> On 31.10.19 12:58, Roger Pau Monne wrote:
> > The event channel data was not copied back to guest memory, fix this
> > by doing the copy.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Release-acked-by: Juergen Gross <jgross@suse.com>

Jan? Andrew?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Andrew Cooper 4 years, 5 months ago

On 08/11/2019 11:55, Wei Liu wrote:
> On Fri, Nov 01, 2019 at 07:17:57AM +0100, Jürgen Groß wrote:
>> On 31.10.19 12:58, Roger Pau Monne wrote:
>>> The event channel data was not copied back to guest memory, fix this
>>> by doing the copy.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Release-acked-by: Juergen Gross <jgross@suse.com>
> Jan? Andrew?

Whats up? c/s 0f45bbbc40 not good enough?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status

Posted by Wei Liu 4 years, 5 months ago

On Fri, Nov 08, 2019 at 12:07:08PM +0000, Andrew Cooper wrote:
> On 08/11/2019 11:55, Wei Liu wrote:
> > On Fri, Nov 01, 2019 at 07:17:57AM +0100, Jürgen Groß wrote:
> >> On 31.10.19 12:58, Roger Pau Monne wrote:
> >>> The event channel data was not copied back to guest memory, fix this
> >>> by doing the copy.
> >>>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Release-acked-by: Juergen Gross <jgross@suse.com>
> > Jan? Andrew?
> 
> Whats up? c/s 0f45bbbc40 not good enough?

Oh, I missed that. Sorry for the noise.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel