From nobody Fri Apr 19 00:21:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1572523215; cv=none; d=zoho.com; s=zohoarc; b=YTHiNezCzV4vUVR56owrBYRtMpvkMN8oe5hxSm4gVpslfZDDe/2PLdKbOSCCQxPS24K3f5IDLEtl/ZiK+gknzSfd+kqx4/xtoU5lQY/W41KNC+88bCK6216xpeMjFZe9voy/OCmQk5Derqn3ftmQKyk/n9llNZ5G6T6eIy5mlGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572523215; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ETvY7Wmiav9liNARB2NVBM6+qkMgYEVl+6wc3h5Umek=; b=OI2QTwzdDf+LVqdxcFlJZVBJIcpvuiYhDLiK4KedlbgXaBoL9ZfWCvftnsEnkk9x+oJX5ir69JxSB2Qz+eBRzSNWwc+B1w4LgfkRmPgo7KljMtkZr2VOlrqSmaUeW1DD7KJVkplwCGnNRO9bcmaYlgRl8VMdX8FghvYxrcBAMpE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1572523214867685.9385116205972; Thu, 31 Oct 2019 05:00:14 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQ96P-0004Zv-TF; Thu, 31 Oct 2019 11:58:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQ96O-0004Zq-OH for xen-devel@lists.xenproject.org; Thu, 31 Oct 2019 11:58:56 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cf6e4394-fbd5-11e9-9540-12813bfff9fa; Thu, 31 Oct 2019 11:58:54 +0000 (UTC) X-Inumbo-ID: cf6e4394-fbd5-11e9-9540-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572523135; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6KpluSfwbTHfy0VcNGS1wAu9fu8ko4pNnMNdnNpxnAo=; b=YQ6pDK8daI+7NS9FE5IEPjdl61TNpdUYbq+vaDt6/GA043jIRWrN1VJL clW3n4lASMOKbNnFL+0JuriN9AjKmZui7rvgQNYqowVBBIEct+Wo9C60F tHojQkKRmdFwPhLVw2zXTos5/0ZaYiWXGn33Bnk67sNqVvprT66vnO9nH Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ys8uMz+PtS/QRhfxr5+JZUltNUo5WAf7W1FIqVRd7jNZi7PN09SECDKnd+/5uv9l/+o8LAewF6 Ns6jw75iAWK0s1zCdYP6hE2JS8yoSaXF7Bk5qWqwwrvb1tCc7ZJZCBFuzqIkrVFkjOi5cAJE8u DqY19w1W/1EDIWhT1erSX7Pkj8dg5EYAayvX4UfY2VtXd/ZtoTd9+KtBCzRa9pP5Mi0gTzkGgT J7f8RDqPg3B8Q7SqnDo4Dln6kvlsiMfIQ+qryc4ou0vDPo1ltR4ODtYaOIc3vEueOs3ONhfIJe 8gE= X-SBRS: 2.7 X-MesageID: 7669727 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,250,1569297600"; d="scan'208";a="7669727" From: Roger Pau Monne To: Date: Thu, 31 Oct 2019 12:58:29 +0100 Message-ID: <20191031115829.74378-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH for-4.13] x86/shim: copy back the result of EVTCHNOP_status X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The event channel data was not copied back to guest memory, fix this by doing the copy. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Wei Liu --- Cc: Juergen Gross --- xen/arch/x86/pv/shim.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index 4329eaaefe..35bf3945ac 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -514,6 +514,9 @@ static long pv_shim_event_channel_op(int cmd, XEN_GUEST= _HANDLE_PARAM(void) arg) else rc =3D xen_hypercall_event_channel_op(EVTCHNOP_status, &status= ); =20 + if ( !rc && __copy_to_guest(arg, &status, 1) ) + rc =3D -EFAULT; + break; } =20 --=20 2.23.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel