We are going to want to call this from a site which has a domid which
is good for logging but not the domid of the domain we are creating
(namely, the stub device domain).

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
 tools/libxl/libxl_create.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index d59ac2ab05..32d45dcef0 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -891,7 +891,7 @@ static unsigned long libxl__get_required_iommu_memory(unsigned long maxmem_kb)
 
 int libxl__domain_config_setdefault(libxl__gc *gc,
                                     libxl_domain_config *d_config,
-                                    uint32_t domid)
+                                    uint32_t domid /* for logging, only */)
 {
     libxl_ctx *ctx = libxl__gc_owner(gc);
     int ret;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

On 28.10.19 16:29, Ian Jackson wrote:
> We are going to want to call this from a site which has a domid which
> is good for logging but not the domid of the domain we are creating
> (namely, the stub device domain).
> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Juergen Gross <jgross@suse.com>

For the series: Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

On Mon, Oct 28, 2019 at 03:29:46PM +0000, Ian Jackson wrote:
> We are going to want to call this from a site which has a domid which
> is good for logging but not the domid of the domain we are creating
> (namely, the stub device domain).
> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> ---
>  tools/libxl/libxl_create.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index d59ac2ab05..32d45dcef0 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -891,7 +891,7 @@ static unsigned long libxl__get_required_iommu_memory(unsigned long maxmem_kb)
>  
>  int libxl__domain_config_setdefault(libxl__gc *gc,
>                                      libxl_domain_config *d_config,
> -                                    uint32_t domid)
> +                                    uint32_t domid /* for logging, only */)

Should libxl__arch_passthrough_mode_setdefault() have the same comment?
Just in case, since it's called with that same domid.

Beside that:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Anthony PERARD writes ("Re: [XEN PATCH for-4.13 1/3] libxl: domain_config_setdefault: Document use of domid"):
> Should libxl__arch_passthrough_mode_setdefault() have the same comment?
> Just in case, since it's called with that same domid.

Yes, you are right, it should.  I just added that along with your ack
while pushing.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel