Fix stub dm since pci pt overhaul

[Xen-devel] [XEN PATCH for-4.13 0/3] Fix stub dm since pci pt overhaul

Posted by Ian Jackson 4 years, 5 months ago

This series fixes guest creation with stub device models, which was
broken by ad011ad08843 "libxl/xl: Overhaul passthrough setting logic".

I have tested this with all three patches and it fixes the regression.
I'm not sure about the 3rd and would like an opinion from x86 folks,
for the reasons explained in its commit message.

Ian Jackson (3):
  libxl: domain_config_setdefault: Document use of domid
  libxl: libxl__spawn_stub_dm: Call domain_config_setdefault
  libxl: Set shadow_memkb for stub device model domains

 tools/libxl/libxl_create.c | 2 +-
 tools/libxl/libxl_dm.c     | 9 +--------
 2 files changed, 2 insertions(+), 9 deletions(-)

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13 0/3] Fix stub dm since pci pt overhaul

Posted by Jürgen Groß 4 years, 5 months ago

On 28.10.19 16:29, Ian Jackson wrote:
> This series fixes guest creation with stub device models, which was
> broken by ad011ad08843 "libxl/xl: Overhaul passthrough setting logic".
> 
> I have tested this with all three patches and it fixes the regression.
> I'm not sure about the 3rd and would like an opinion from x86 folks,
> for the reasons explained in its commit message.
> 
> Ian Jackson (3):
>    libxl: domain_config_setdefault: Document use of domid
>    libxl: libxl__spawn_stub_dm: Call domain_config_setdefault
>    libxl: Set shadow_memkb for stub device model domains
> 
>   tools/libxl/libxl_create.c | 2 +-
>   tools/libxl/libxl_dm.c     | 9 +--------
>   2 files changed, 2 insertions(+), 9 deletions(-)
> 

I'd appreciate a rather fast review of these patches, as they repair an
issue blocking an OSStest push.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel