[v3] iommu: fixes for interrupt remapping enabling

[Xen-devel] [PATCH v3 0/4] iommu: fixes for interrupt remapping enabling

Posted by Roger Pau Monne 4 years, 6 months ago

Hello,

The following series contain fixes for issues found when enabling
interrupt remapping and the IO-APIC already has unmasked pins. While I'm
not aware of any system malfunctioning (apart from reporting IOMMU
interrupt remapping faults) I think it would be nice to have those in
4.13.

The series can also be found at:

git://xenbits.xen.org/people/royger/xen.git iommu_intr_v3

Thanks, Roger.

Roger Pau Monne (4):
  iommu/amd: support all delivery modes with x2APIC
  x2APIC: simplify resume
  x2APIC: translate IO-APIC entries when enabling the IOMMU
  iommu: translate IO-APIC pins when enabling interrupt remapping

 xen/arch/x86/apic.c                           |  38 ++---
 xen/arch/x86/io_apic.c                        |   5 +-
 xen/drivers/passthrough/amd/iommu_init.c      |  11 +-
 xen/drivers/passthrough/amd/iommu_intr.c      | 141 +++++++++---------
 xen/drivers/passthrough/x86/iommu.c           |  34 ++++-
 xen/include/asm-x86/hvm/svm/amd-iommu-proto.h |   1 +
 xen/include/asm-x86/io_apic.h                 |   3 +-
 7 files changed, 121 insertions(+), 112 deletions(-)

-- 
2.23.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/4] iommu: fixes for interrupt remapping enabling

Posted by Jürgen Groß 4 years, 6 months ago

On 15.10.19 17:47, Roger Pau Monne wrote:
> Hello,
> 
> The following series contain fixes for issues found when enabling
> interrupt remapping and the IO-APIC already has unmasked pins. While I'm
> not aware of any system malfunctioning (apart from reporting IOMMU
> interrupt remapping faults) I think it would be nice to have those in
> 4.13.
> 
> The series can also be found at:
> 
> git://xenbits.xen.org/people/royger/xen.git iommu_intr_v3

For the series:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/4] iommu: fixes for interrupt remapping enabling

Posted by Jan Beulich 4 years, 6 months ago

On 15.10.2019 17:47, Roger Pau Monne wrote:
> Hello,
> 
> The following series contain fixes for issues found when enabling
> interrupt remapping and the IO-APIC already has unmasked pins. While I'm
> not aware of any system malfunctioning (apart from reporting IOMMU
> interrupt remapping faults) I think it would be nice to have those in
> 4.13.
> 
> The series can also be found at:
> 
> git://xenbits.xen.org/people/royger/xen.git iommu_intr_v3
> 
> Thanks, Roger.
> 
> Roger Pau Monne (4):
>   iommu/amd: support all delivery modes with x2APIC
>   x2APIC: simplify resume
>   x2APIC: translate IO-APIC entries when enabling the IOMMU
>   iommu: translate IO-APIC pins when enabling interrupt remapping

As mentioned in reply to #1, I think that one should go last. The
other three are ready to be committed, but I'd like to double check
that there's no dependency of any of them on the 1st.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/4] iommu: fixes for interrupt remapping enabling

Posted by Roger Pau Monné 4 years, 6 months ago

On Fri, Oct 25, 2019 at 03:19:57PM +0200, Jan Beulich wrote:
> On 15.10.2019 17:47, Roger Pau Monne wrote:
> > Hello,
> > 
> > The following series contain fixes for issues found when enabling
> > interrupt remapping and the IO-APIC already has unmasked pins. While I'm
> > not aware of any system malfunctioning (apart from reporting IOMMU
> > interrupt remapping faults) I think it would be nice to have those in
> > 4.13.
> > 
> > The series can also be found at:
> > 
> > git://xenbits.xen.org/people/royger/xen.git iommu_intr_v3
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (4):
> >   iommu/amd: support all delivery modes with x2APIC
> >   x2APIC: simplify resume
> >   x2APIC: translate IO-APIC entries when enabling the IOMMU
> >   iommu: translate IO-APIC pins when enabling interrupt remapping
> 
> As mentioned in reply to #1, I think that one should go last. The
> other three are ready to be committed, but I'd like to double check
> that there's no dependency of any of them on the 1st.

I think #1 is fully independent of the rest of the series, and the
other three can be committed regardless of #1.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel