passthrough: drop break statement following c/s cd7dedad820

[Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820

Igor Druzhinin posted 1 patch 4 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/1575548022-14213-1-git-send-email-igor.druzhinin@citrix.com

xen/drivers/passthrough/pci.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820

Posted by Igor Druzhinin 4 years, 4 months ago

The locking responsibilities have changed and a premature break in
this section now causes the following assertion:

Assertion '!preempt_count()' failed at preempt.c:36

Suggested-by: Paul Durrant <pdurrant@amazon.com>
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
---
 xen/drivers/passthrough/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index ced0c28..c07a639 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl(
                        seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
                 ret = -EINVAL;
             }
-            break;
         }
         else if ( !ret )
             ret = assign_device(d, seg, bus, devfn, flags);
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel