From nobody Sun May 5 16:35:54 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1575548079; cv=none; d=zohomail.com; s=zohoarc; b=mQVW8wCY6dugfPQKETJqf63o0mqaMbabQ7UL/baa7rx2rWMqntBzj88MLhDOtvNR/ntf3BItQxxOz1Do2b5WLS4Skw8ovh5usl3wfrKzmS369qs3m4QCEvDO/2xQwaJOVWUlYF3UAQupL39cGrLRRwZhVGxZdZHYw/rykjl4lgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575548079; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=QpFGdur+rB/5Yh7lFTb1oORytF2/bjE6z3RZDmNATis=; b=eT9L5ktyU3l03gEzv0Og8kSFguR8W6hqJlanzPdZCi5TcZEBFvTkk7RaM1S8CC0b9EVeyIK34kqLagmBJiWas1xSJcq/PvMtGZ4aUNvv4Kg13Hm6d4/lihA3irtQ8TdEx06O7NuiqtJ9PDk74BMpQQiMgBGbq+MyK+5n4vVf6tU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1575548079505718.9660006929381; Thu, 5 Dec 2019 04:14:39 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icq0z-0006Kv-Az; Thu, 05 Dec 2019 12:13:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icq0y-0006Kq-AX for xen-devel@lists.xenproject.org; Thu, 05 Dec 2019 12:13:48 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id afeffae6-1758-11ea-8223-12813bfff9fa; Thu, 05 Dec 2019 12:13:47 +0000 (UTC) X-Inumbo-ID: afeffae6-1758-11ea-8223-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1575548027; h=from:to:cc:subject:date:message-id:mime-version; bh=H7GgwFaJd2VQcPQnw7nBQ/VlkmsfSIaY7Kkj2JFsc4w=; b=XVT4uy2ZW9G6etUyDDZgq98elQHMuT9wcrQL4JF6f9mk2DUyaDrpJQQl dPSIbyLHtKWuoUx9ct6Vkkcldx3MVQbxcHCKCNPEVa1mOh1PzWoG71K8r vCE4bTrqViK8pBdYfW1kRCwLTTwTmX5zRvx11P9rxLS3iVLLdXrsZB+IW w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 7pwGZE6XuziR2U8r7z5E4nJp8DFgE+QZrha3DoKx3S6OmQCskoqWksPRS+DsEK2mHVP4LP4iKC pg+Y5ZhwsXE2smw19X72p/jCpx/eRKFvVo4kCf1P5cMFJjKM2XV+9qJudYFyKa53S+4o29efHk uLVL6KWW0p5Xqbffg3jhV/29olH04+kT+Ve+J6C9fGMnKEjxfH1NRpj14MeqcNBm8mWaLF6yC0 jO1Ve8DgYtICRUa2rBBnI4mJPdJiylI36aXKJ7NLDlrPMH1lMKeLjuemSs8X+gr2sLOBvZvbOB GdI= X-SBRS: 2.7 X-MesageID: 9244770 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,281,1571716800"; d="scan'208";a="9244770" From: Igor Druzhinin To: Date: Thu, 5 Dec 2019 12:13:42 +0000 Message-ID: <1575548022-14213-1-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux@eikelenboom.it, pdurrant@amazon.com, jbeulich@suse.com, Igor Druzhinin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The locking responsibilities have changed and a premature break in this section now causes the following assertion: Assertion '!preempt_count()' failed at preempt.c:36 Suggested-by: Paul Durrant Reported-by: Sander Eikelenboom Signed-off-by: Igor Druzhinin --- xen/drivers/passthrough/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index ced0c28..c07a639 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl( seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); ret =3D -EINVAL; } - break; } else if ( !ret ) ret =3D assign_device(d, seg, bus, devfn, flags); --=20 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel