src/fw/pciinit.c | 45 ++++++++++++++++++++++++++++----------------- src/hw/pci_ids.h | 1 + 2 files changed, 29 insertions(+), 17 deletions(-)
This patch serial is about QEMU resource reserve capability finding in firmware. Firstly, this fixes a logic bug. When the capability is truncated, return zero instead of the truncated offset. Secondly, this modified the debug messages when the capability is not found and when the vendor ID or device Id doesn't match REDHAT special ones. Last, this enables the firmware recongizing the REDHAT PCI BRIDGE device ID, so that QEMU can also reserve PCI bridge resource capability. Jing Liu (3): pci: fix the return value for truncated capability pci: clean up the debug message for pci capability found pci: recognize RH PCI legacy bridge resource reservation capability src/fw/pciinit.c | 45 ++++++++++++++++++++++++++++----------------- src/hw/pci_ids.h | 1 + 2 files changed, 29 insertions(+), 17 deletions(-) -- 1.8.3.1 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios
On 08/13/18 09:49, Jing Liu wrote: > This patch serial is about QEMU resource reserve capability finding > in firmware. > > Firstly, this fixes a logic bug. When the capability is truncated, > return zero instead of the truncated offset. Secondly, this modified > the debug messages when the capability is not found and when the vendor > ID or device Id doesn't match REDHAT special ones. > > Last, this enables the firmware recongizing the REDHAT PCI BRIDGE device ID, > so that QEMU can also reserve PCI bridge resource capability. > > Jing Liu (3): > pci: fix the return value for truncated capability > pci: clean up the debug message for pci capability found > pci: recognize RH PCI legacy bridge resource reservation capability > > src/fw/pciinit.c | 45 ++++++++++++++++++++++++++++----------------- > src/hw/pci_ids.h | 1 + > 2 files changed, 29 insertions(+), 17 deletions(-) Something looks wrong with this patch set -- the shortlog above indicates that the 3rd patch is called "pci: recognize RH PCI legacy bridge resource reservation capability", but in the actual series I see: [SeaBIOS][PATCH v2 0/3] pci: resource reserve capability found [SeaBIOS][PATCH v2 1/3] pci: fix the return value for truncated capability [SeaBIOS][PATCH v2 2/3] pci: clean up the debug message for pci capability found [SeaBIOS][PATCH v2] pci: recognize RH PCI legacy bridge resource For the last patch, the "3/3" counter is missing in the subject prefix, plus the subject doesn't match the short log. I also see a separate message [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource which is apparently not threaded under v2 0/3, and whose subject line also doesn't match the shortlog. Not sure what Kevin and Gerd prefer, but if these patches are meant to form a series, I'd suggest to repost with correct numbering, threading, and subject lines. Thanks Laszlo _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios
On 8/14/2018 10:01 PM, Laszlo Ersek wrote: > On 08/13/18 09:49, Jing Liu wrote: >> This patch serial is about QEMU resource reserve capability finding >> in firmware. >> >> Firstly, this fixes a logic bug. When the capability is truncated, >> return zero instead of the truncated offset. Secondly, this modified >> the debug messages when the capability is not found and when the vendor >> ID or device Id doesn't match REDHAT special ones. >> >> Last, this enables the firmware recongizing the REDHAT PCI BRIDGE device ID, >> so that QEMU can also reserve PCI bridge resource capability. >> >> Jing Liu (3): >> pci: fix the return value for truncated capability >> pci: clean up the debug message for pci capability found >> pci: recognize RH PCI legacy bridge resource reservation capability >> >> src/fw/pciinit.c | 45 ++++++++++++++++++++++++++++----------------- >> src/hw/pci_ids.h | 1 + >> 2 files changed, 29 insertions(+), 17 deletions(-) > > Something looks wrong with this patch set -- the shortlog above > indicates that the 3rd patch is called "pci: recognize RH PCI legacy > bridge resource reservation capability", but in the actual series I see: > > [SeaBIOS][PATCH v2 0/3] pci: resource reserve capability found > [SeaBIOS][PATCH v2 1/3] pci: fix the return value for truncated capability > [SeaBIOS][PATCH v2 2/3] pci: clean up the debug message for pci capability found > [SeaBIOS][PATCH v2] pci: recognize RH PCI legacy bridge resource > > For the last patch, the "3/3" counter is missing in the subject prefix, > plus the subject doesn't match the short log. > > I also see a separate message > > [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource > > which is apparently not threaded under v2 0/3, and whose subject line > also doesn't match the shortlog. > > Not sure what Kevin and Gerd prefer, but if these patches are meant to > form a series, I'd suggest to repost with correct numbering, threading, > and subject lines. Let me re-send this serial with the same version. Sorry for disturbing. Jing > > Thanks > Laszlo > _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios
© 2016 - 2024 Red Hat, Inc.