tcg/riscv: Fix StoreStore barrier generation

[PATCH] tcg/riscv: Fix StoreStore barrier generation

Roman Artemev posted 1 patch 1 year, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/e2f2131e294a49e79959d4fa9ec02cf4@syntacore.com

Maintainers: Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <Alistair.Francis@wdc.com>, Richard Henderson <richard.henderson@linaro.org>

tcg/riscv/tcg-target.c.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tcg/riscv: Fix StoreStore barrier generation

Posted by Roman Artemev 1 year, 1 month ago

On RISC-V to StoreStore barrier corresponds
`fence w, w` not `fence r, r`

Signed-off-by: Denis Tomashev <denis.tomashev@syntacore.com>
Signed-off-by: Roman Artemev <roman.artemev@syntacore.com>
---
 tcg/riscv/tcg-target.c.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc
index f8331e4688..96f9a7e348 100644
--- a/tcg/riscv/tcg-target.c.inc
+++ b/tcg/riscv/tcg-target.c.inc
@@ -1624,7 +1624,7 @@ static void tcg_out_mb(TCGContext *s, TCGArg a0)
         insn |= 0x02100000;
     }
     if (a0 & TCG_MO_ST_ST) {
-        insn |= 0x02200000;
+        insn |= 0x01100000;
     }
     tcg_out32(s, insn);
 }
-- 
2.39.2

Re: [PATCH] tcg/riscv: Fix StoreStore barrier generation

Posted by Richard Henderson 1 year, 1 month ago

On 12/11/24 01:40, Roman Artemev wrote:
> On RISC-V to StoreStore barrier corresponds
> `fence w, w` not `fence r, r`
> 
> Signed-off-by: Denis Tomashev <denis.tomashev@syntacore.com>
> Signed-off-by: Roman Artemev <roman.artemev@syntacore.com>
> ---
>   tcg/riscv/tcg-target.c.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc
> index f8331e4688..96f9a7e348 100644
> --- a/tcg/riscv/tcg-target.c.inc
> +++ b/tcg/riscv/tcg-target.c.inc
> @@ -1624,7 +1624,7 @@ static void tcg_out_mb(TCGContext *s, TCGArg a0)
>           insn |= 0x02100000;
>       }
>       if (a0 & TCG_MO_ST_ST) {
> -        insn |= 0x02200000;
> +        insn |= 0x01100000;
>       }
>       tcg_out32(s, insn);
>   }

Fixes: efbea94c76b ("tcg/riscv: Add slowpath load and store instructions")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Wow, that typo has been around for a while.
Thanks, queued.


r~