Hello,

I have these patches from last October when we've looked at what
causes problems with mac99 and USB. We've found the main problem is
likely not allowing pending packets per endpoint which we did not fix
but these patches came out of debugging that and trying to improve the
device model so eventually the real problem could be fixed more
easily. So these are just clean ups and fixing one potential issue
with isochronous transfers breaking pending async packet but it does
not solve all problems OHCI currently has. I'm sending it anyway as I
don't plan to work further on this so this series could be taken as is
for now.

Regards,

BALATON Zoltan (5):
  usb/ohci: Move trace point and log ep number to help debugging
  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
  usb/ohci: Move USBPortOps related functions together
  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
  usb/ohci: Don't use packet from OHCIState for isochronous transfers

 hw/usb/hcd-ohci.c   | 295 +++++++++++++++++++++-----------------------
 hw/usb/trace-events |   2 +-
 2 files changed, 144 insertions(+), 153 deletions(-)

-- 
2.30.2

On Sun, 16 Jan 2022, BALATON Zoltan wrote:
> Hello,
>
> I have these patches from last October when we've looked at what
> causes problems with mac99 and USB. We've found the main problem is
> likely not allowing pending packets per endpoint which we did not fix
> but these patches came out of debugging that and trying to improve the
> device model so eventually the real problem could be fixed more
> easily. So these are just clean ups and fixing one potential issue
> with isochronous transfers breaking pending async packet but it does
> not solve all problems OHCI currently has. I'm sending it anyway as I
> don't plan to work further on this so this series could be taken as is
> for now.

Ping?

> Regards,
>
> BALATON Zoltan (5):
>  usb/ohci: Move trace point and log ep number to help debugging
>  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
>  usb/ohci: Move USBPortOps related functions together
>  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
>  usb/ohci: Don't use packet from OHCIState for isochronous transfers
>
> hw/usb/hcd-ohci.c   | 295 +++++++++++++++++++++-----------------------
> hw/usb/trace-events |   2 +-
> 2 files changed, 144 insertions(+), 153 deletions(-)
>
>

On Mon, Jan 24, 2022 at 06:09:12PM +0100, BALATON Zoltan wrote:
> On Sun, 16 Jan 2022, BALATON Zoltan wrote:
> > Hello,
> > 
> > I have these patches from last October when we've looked at what
> > causes problems with mac99 and USB. We've found the main problem is
> > likely not allowing pending packets per endpoint which we did not fix
> > but these patches came out of debugging that and trying to improve the
> > device model so eventually the real problem could be fixed more
> > easily. So these are just clean ups and fixing one potential issue
> > with isochronous transfers breaking pending async packet but it does
> > not solve all problems OHCI currently has. I'm sending it anyway as I
> > don't plan to work further on this so this series could be taken as is
> > for now.
> 
> Ping?

Queued now.

thanks,
  Gerd

On Tue, Jan 25, 2022 at 08:44:30AM +0100, Gerd Hoffmann wrote:
> On Mon, Jan 24, 2022 at 06:09:12PM +0100, BALATON Zoltan wrote:
> > On Sun, 16 Jan 2022, BALATON Zoltan wrote:
> > > Hello,
> > > 
> > > I have these patches from last October when we've looked at what
> > > causes problems with mac99 and USB. We've found the main problem is
> > > likely not allowing pending packets per endpoint which we did not fix
> > > but these patches came out of debugging that and trying to improve the
> > > device model so eventually the real problem could be fixed more
> > > easily. So these are just clean ups and fixing one potential issue
> > > with isochronous transfers breaking pending async packet but it does
> > > not solve all problems OHCI currently has. I'm sending it anyway as I
> > > don't plan to work further on this so this series could be taken as is
> > > for now.
> > 
> > Ping?
> 
> Queued now.

Oops, have to take that back, checkpatch throws errors:

HEAD is now at 00abd6f54a24 usb/ohci: Don't use packet from OHCIState for isochronous transfers

error: no note found for object 00abd6f54a246db5877ceb466755374b297d97cf.
ERROR: braces {} are necessary for all arms of this statement
#131: FILE: hw/usb/hcd-ohci.c:1115:
+                if (ohci_service_iso_td(ohci, &ed))
[...]

total: 1 errors, 0 warnings, 153 lines checked

Please check all patches & resend.

take care,
  Gerd

On Tue, 25 Jan 2022, Gerd Hoffmann wrote:
> On Tue, Jan 25, 2022 at 08:44:30AM +0100, Gerd Hoffmann wrote:
>> On Mon, Jan 24, 2022 at 06:09:12PM +0100, BALATON Zoltan wrote:
>>> On Sun, 16 Jan 2022, BALATON Zoltan wrote:
>>>> Hello,
>>>>
>>>> I have these patches from last October when we've looked at what
>>>> causes problems with mac99 and USB. We've found the main problem is
>>>> likely not allowing pending packets per endpoint which we did not fix
>>>> but these patches came out of debugging that and trying to improve the
>>>> device model so eventually the real problem could be fixed more
>>>> easily. So these are just clean ups and fixing one potential issue
>>>> with isochronous transfers breaking pending async packet but it does
>>>> not solve all problems OHCI currently has. I'm sending it anyway as I
>>>> don't plan to work further on this so this series could be taken as is
>>>> for now.
>>>
>>> Ping?
>>
>> Queued now.
>
> Oops, have to take that back, checkpatch throws errors:
>
> HEAD is now at 00abd6f54a24 usb/ohci: Don't use packet from OHCIState for isochronous transfers
>
> error: no note found for object 00abd6f54a246db5877ceb466755374b297d97cf.
> ERROR: braces {} are necessary for all arms of this statement
> #131: FILE: hw/usb/hcd-ohci.c:1115:
> +                if (ohci_service_iso_td(ohci, &ed))
> [...]
>
> total: 1 errors, 0 warnings, 153 lines checked
>
> Please check all patches & resend.

Sorry, I'll resend. I usually run checkpatch before submitting and I think 
I've checked these when first sent them and haven't got the error but 
maybe this was a last minute change. Not sure how it was missed.

Regards,
BALATON Zoltan