[v2] Misc OHCI clean ups

[PATCH v2 0/5] Misc OHCI clean ups

Posted by BALATON Zoltan 2 years, 2 months ago

v2 - Fixed checkpatch errors

Hello,

I have these patches from last October when we've looked at what
causes problems with mac99 and USB. We've found the main problem is
likely not allowing pending packets per endpoint which we did not fix
but these patches came out of debugging that and trying to improve the
device model so eventually the real problem could be fixed more
easily. So these are just clean ups and fixing one potential issue
with isochronous transfers breaking pending async packet but it does
not solve all problems OHCI currently has. I'm sending it anyway as I
don't plan to work further on this so this series could be taken as is
for now.

Regards,

BALATON Zoltan (5):
  usb/ohci: Move trace point and log ep number to help debugging
  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
  usb/ohci: Move USBPortOps related functions together
  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
  usb/ohci: Don't use packet from OHCIState for isochronous transfers

 hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
 hw/usb/trace-events |   2 +-
 2 files changed, 146 insertions(+), 153 deletions(-)

-- 
2.30.2

Re: [PATCH v2 0/5] Misc OHCI clean ups

Posted by BALATON Zoltan 2 years, 2 months ago

On Tue, 25 Jan 2022, BALATON Zoltan wrote:
> v2 - Fixed checkpatch errors
>
> Hello,

Ping?

Regards,
BALATON Zoltan

> I have these patches from last October when we've looked at what
> causes problems with mac99 and USB. We've found the main problem is
> likely not allowing pending packets per endpoint which we did not fix
> but these patches came out of debugging that and trying to improve the
> device model so eventually the real problem could be fixed more
> easily. So these are just clean ups and fixing one potential issue
> with isochronous transfers breaking pending async packet but it does
> not solve all problems OHCI currently has. I'm sending it anyway as I
> don't plan to work further on this so this series could be taken as is
> for now.
>
> Regards,
>
> BALATON Zoltan (5):
>  usb/ohci: Move trace point and log ep number to help debugging
>  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
>  usb/ohci: Move USBPortOps related functions together
>  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
>  usb/ohci: Don't use packet from OHCIState for isochronous transfers
>
> hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
> hw/usb/trace-events |   2 +-
> 2 files changed, 146 insertions(+), 153 deletions(-)
>
>

Re: [PATCH v2 0/5] Misc OHCI clean ups

Posted by BALATON Zoltan 2 years, 2 months ago

On Tue, 8 Feb 2022, BALATON Zoltan wrote:
> On Tue, 25 Jan 2022, BALATON Zoltan wrote:
>> v2 - Fixed checkpatch errors
>> 
>> Hello,
>
> Ping?

Ping^2

https://patchew.org/QEMU/cover.1643117600.git.balaton@eik.bme.hu/

Regards,
BALATON Zoltan

>> I have these patches from last October when we've looked at what
>> causes problems with mac99 and USB. We've found the main problem is
>> likely not allowing pending packets per endpoint which we did not fix
>> but these patches came out of debugging that and trying to improve the
>> device model so eventually the real problem could be fixed more
>> easily. So these are just clean ups and fixing one potential issue
>> with isochronous transfers breaking pending async packet but it does
>> not solve all problems OHCI currently has. I'm sending it anyway as I
>> don't plan to work further on this so this series could be taken as is
>> for now.
>> 
>> Regards,
>> 
>> BALATON Zoltan (5):
>>  usb/ohci: Move trace point and log ep number to help debugging
>>  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
>>  usb/ohci: Move USBPortOps related functions together
>>  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
>>  usb/ohci: Don't use packet from OHCIState for isochronous transfers
>> 
>> hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
>> hw/usb/trace-events |   2 +-
>> 2 files changed, 146 insertions(+), 153 deletions(-)
>> 
>> 
>

Re: [PATCH v2 0/5] Misc OHCI clean ups

Posted by BALATON Zoltan 2 years, 1 month ago

On Wed, 16 Feb 2022, BALATON Zoltan wrote:
> On Tue, 8 Feb 2022, BALATON Zoltan wrote:
>> On Tue, 25 Jan 2022, BALATON Zoltan wrote:
>>> v2 - Fixed checkpatch errors
>>> 
>>> Hello,
>> 
>> Ping?
>
> Ping^2

Ping^3

> https://patchew.org/QEMU/cover.1643117600.git.balaton@eik.bme.hu/
>
> Regards,
> BALATON Zoltan
>
>>> I have these patches from last October when we've looked at what
>>> causes problems with mac99 and USB. We've found the main problem is
>>> likely not allowing pending packets per endpoint which we did not fix
>>> but these patches came out of debugging that and trying to improve the
>>> device model so eventually the real problem could be fixed more
>>> easily. So these are just clean ups and fixing one potential issue
>>> with isochronous transfers breaking pending async packet but it does
>>> not solve all problems OHCI currently has. I'm sending it anyway as I
>>> don't plan to work further on this so this series could be taken as is
>>> for now.
>>> 
>>> Regards,
>>> 
>>> BALATON Zoltan (5):
>>>  usb/ohci: Move trace point and log ep number to help debugging
>>>  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
>>>  usb/ohci: Move USBPortOps related functions together
>>>  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
>>>  usb/ohci: Don't use packet from OHCIState for isochronous transfers
>>> 
>>> hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
>>> hw/usb/trace-events |   2 +-
>>> 2 files changed, 146 insertions(+), 153 deletions(-)
>>> 
>>> 
>> 
>
>

Re: [PATCH v2 0/5] Misc OHCI clean ups

Posted by BALATON Zoltan 2 years, 1 month ago

On Fri, 25 Feb 2022, BALATON Zoltan wrote:
> On Wed, 16 Feb 2022, BALATON Zoltan wrote:
>> On Tue, 8 Feb 2022, BALATON Zoltan wrote:
>>> On Tue, 25 Jan 2022, BALATON Zoltan wrote:
>>>> v2 - Fixed checkpatch errors
>>>> 
>>>> Hello,
>>> 
>>> Ping?
>> 
>> Ping^2
>
> Ping^3

Ping^4 Why is this getting ignored?

>> https://patchew.org/QEMU/cover.1643117600.git.balaton@eik.bme.hu/
>> 
>> Regards,
>> BALATON Zoltan
>> 
>>>> I have these patches from last October when we've looked at what
>>>> causes problems with mac99 and USB. We've found the main problem is
>>>> likely not allowing pending packets per endpoint which we did not fix
>>>> but these patches came out of debugging that and trying to improve the
>>>> device model so eventually the real problem could be fixed more
>>>> easily. So these are just clean ups and fixing one potential issue
>>>> with isochronous transfers breaking pending async packet but it does
>>>> not solve all problems OHCI currently has. I'm sending it anyway as I
>>>> don't plan to work further on this so this series could be taken as is
>>>> for now.
>>>> 
>>>> Regards,
>>>> 
>>>> BALATON Zoltan (5):
>>>>  usb/ohci: Move trace point and log ep number to help debugging
>>>>  usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
>>>>  usb/ohci: Move USBPortOps related functions together
>>>>  usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
>>>>  usb/ohci: Don't use packet from OHCIState for isochronous transfers
>>>> 
>>>> hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
>>>> hw/usb/trace-events |   2 +-
>>>> 2 files changed, 146 insertions(+), 153 deletions(-)
>>>> 
>>>> 
>>> 
>> 
>> 
>
>