[PATCH 0/6] More SH4 clean ups

BALATON Zoltan posted 6 patches 4 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1635298341.git.balaton@eik.bme.hu
Maintainers: Magnus Damm <magnus.damm@gmail.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
hw/char/sh_serial.c   | 149 ++++++++++++++++++++++++------------------
hw/char/trace-events  |   3 +
hw/intc/sh_intc.c     |  79 ++++++----------------
hw/intc/trace-events  |   8 +++
hw/sh4/r2d.c          |   5 +-
hw/sh4/sh7750.c       |  83 +++++++++++++++--------
hw/sh4/trace-events   |   3 +
hw/sh4/trace.h        |   1 +
hw/timer/sh_timer.c   |  14 +---
hw/timer/trace-events |   3 +
include/hw/sh4/sh.h   |   9 +--
meson.build           |   1 +
12 files changed, 186 insertions(+), 172 deletions(-)
create mode 100644 hw/sh4/trace-events
create mode 100644 hw/sh4/trace.h
[PATCH 0/6] More SH4 clean ups
Posted by BALATON Zoltan 4 years, 3 months ago
Based-on: <cover.1635036053.git.balaton@eik.bme.hu>
^ (hw/sh4: Codeing style fixes)

Continuing the clean up stared in previous series this now removes
printfs and QOM-ify sh_serial.

Is there somebody who will merge these? I don't think there's anybody
sending pull request for SH4 so maybe Peret/Richard might need to take
it.

Regards,

BALATON Zoltan (6):
  hw/sh4: Fix a typo in a comment
  hw//sh4: Use qemu_log instead of fprintf to stderr
  hw/sh4: Change debug printfs to traces
  hw/sh4/r2d: Use error_report instead of fprintf to stderr
  hw/char/sh_serial: QOM-ify
  hw/char/sh_serial: Add device id to trace output

 hw/char/sh_serial.c   | 149 ++++++++++++++++++++++++------------------
 hw/char/trace-events  |   3 +
 hw/intc/sh_intc.c     |  79 ++++++----------------
 hw/intc/trace-events  |   8 +++
 hw/sh4/r2d.c          |   5 +-
 hw/sh4/sh7750.c       |  83 +++++++++++++++--------
 hw/sh4/trace-events   |   3 +
 hw/sh4/trace.h        |   1 +
 hw/timer/sh_timer.c   |  14 +---
 hw/timer/trace-events |   3 +
 include/hw/sh4/sh.h   |   9 +--
 meson.build           |   1 +
 12 files changed, 186 insertions(+), 172 deletions(-)
 create mode 100644 hw/sh4/trace-events
 create mode 100644 hw/sh4/trace.h

-- 
2.21.4


Re: [PATCH 0/6] More SH4 clean ups
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
On 10/27/21 03:32, BALATON Zoltan wrote:
> Based-on: <cover.1635036053.git.balaton@eik.bme.hu>
> ^ (hw/sh4: Codeing style fixes)
> 
> Continuing the clean up stared in previous series this now removes
> printfs and QOM-ify sh_serial.
> 
> Is there somebody who will merge these? I don't think there's anybody
> sending pull request for SH4 so maybe Peret/Richard might need to take
> it.

It would be nice if Yoshinori takes care of it,
otherwise I could to offload Richard.