1. Patchew
  2. QEMU
  3. [PATCH v2 0/5] Mac Old World ROM experiment
  4. View patch

[PATCH v2 3/5] grackle: Set revision in PCI config to match hardware

BALATON Zoltan posted 5 patches 5 years, 8 months ago
Maintainers: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, David Gibson <david@gibson.dropbear.id.au>
There is a newer version of this series
[PATCH v2 3/5] grackle: Set revision in PCI config to match hardware
Posted by BALATON Zoltan 5 years, 8 months ago 
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/pci-host/grackle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c
index 4b3af0c704..48d11f13ab 100644
--- a/hw/pci-host/grackle.c
+++ b/hw/pci-host/grackle.c
@@ -130,7 +130,7 @@ static void grackle_pci_class_init(ObjectClass *klass, void *data)
     k->realize   = grackle_pci_realize;
     k->vendor_id = PCI_VENDOR_ID_MOTOROLA;
     k->device_id = PCI_DEVICE_ID_MOTOROLA_MPC106;
-    k->revision  = 0x00;
+    k->revision  = 0x40;
     k->class_id  = PCI_CLASS_BRIDGE_HOST;
     /*
      * PCI-facing part of the host bridge, not usable without the
-- 
2.21.3
Re: [PATCH v2 3/5] grackle: Set revision in PCI config to match hardware
Posted by Mark Cave-Ayland 5 years, 7 months ago 
On 13/06/2020 14:36, BALATON Zoltan wrote:

> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/pci-host/grackle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c
> index 4b3af0c704..48d11f13ab 100644
> --- a/hw/pci-host/grackle.c
> +++ b/hw/pci-host/grackle.c
> @@ -130,7 +130,7 @@ static void grackle_pci_class_init(ObjectClass *klass, void *data)
>      k->realize   = grackle_pci_realize;
>      k->vendor_id = PCI_VENDOR_ID_MOTOROLA;
>      k->device_id = PCI_DEVICE_ID_MOTOROLA_MPC106;
> -    k->revision  = 0x00;
> +    k->revision  = 0x40;
>      k->class_id  = PCI_CLASS_BRIDGE_HOST;
>      /*
>       * PCI-facing part of the host bridge, not usable without the

Out of curiosity does the BIOS you are using require this, or is it purely for
cosmetic purposes? I'm sure I've seen device trees with several different revisions
here...


ATB,

Mark.
Re: [PATCH v2 3/5] grackle: Set revision in PCI config to match hardware
Posted by BALATON Zoltan 5 years, 7 months ago 
On Sun, 14 Jun 2020, Mark Cave-Ayland wrote:
> On 13/06/2020 14:36, BALATON Zoltan wrote:
>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>>  hw/pci-host/grackle.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c
>> index 4b3af0c704..48d11f13ab 100644
>> --- a/hw/pci-host/grackle.c
>> +++ b/hw/pci-host/grackle.c
>> @@ -130,7 +130,7 @@ static void grackle_pci_class_init(ObjectClass *klass, void *data)
>>      k->realize   = grackle_pci_realize;
>>      k->vendor_id = PCI_VENDOR_ID_MOTOROLA;
>>      k->device_id = PCI_DEVICE_ID_MOTOROLA_MPC106;
>> -    k->revision  = 0x00;
>> +    k->revision  = 0x40;
>>      k->class_id  = PCI_CLASS_BRIDGE_HOST;
>>      /*
>>       * PCI-facing part of the host bridge, not usable without the
>
> Out of curiosity does the BIOS you are using require this, or is it purely for
> cosmetic purposes? I'm sure I've seen device trees with several different revisions
> here...

Don't know, got it from here:

https://github.com/dingusdev/dingusppc/blob/master/devices/mpc106.h

Regards,
BALATON Zoltan

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.