[Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC

Stafford Horne posted 11 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1493593744.git.shorne@gmail.com
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
MAINTAINERS                         |  4 +-
hw/openrisc/cputimer.c              |  1 +
include/migration/cpu.h             |  7 ++++
include/migration/vmstate.h         | 15 ++++++++
linux-user/elfload.c                |  2 +-
linux-user/main.c                   | 18 ++++-----
linux-user/openrisc/target_cpu.h    |  6 +--
linux-user/openrisc/target_signal.h |  2 +-
linux-user/signal.c                 | 16 ++++----
target/openrisc/cpu.c               | 16 +++-----
target/openrisc/cpu.h               | 46 ++++++++++++++--------
target/openrisc/gdbstub.c           |  4 +-
target/openrisc/interrupt.c         | 11 +++++-
target/openrisc/machine.c           | 76 +++++++++++++++++++++++++++++++++++--
target/openrisc/mmu.c               | 23 +++++++++--
target/openrisc/sys_helper.c        | 35 +++++++++++++++++
target/openrisc/translate.c         |  5 ++-
17 files changed, 225 insertions(+), 62 deletions(-)
[Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC
Posted by Stafford Horne 6 years, 11 months ago
Hello,

This are the openrisc patches I have been circulating on the mailing list
of the last few months.  We have had help from a few new people and added
the following:
 * Fixes for gdb memory debugging
 * Added support for Shadow Registers, EVBAR, EPH
 * Added support for idle state, no more 100% pegged cpu's
 * Fixed VM state persisting

Please consider for pull.

The following changes since commit 359c41abe32638adad503e386969fa428cecff52:

  Update version for v2.9.0 release (2017-04-20 15:31:34 +0100)

are available in the git repository at:

  git://github.com/stffrdhrn/qemu.git tags/pull-or-20170429

for you to fetch changes up to 700a330fbf023429a82222449a3f9bf0a884c767:

  target/openrisc: Support non-busy idle state using PMR SPR (2017-04-29 19:12:28 +0900)

----------------------------------------------------------------
QEMU fixes and features for openrisc.

----------------------------------------------------------------
Stafford Horne (9):
      MAINTAINERS: Add myself as openrisc maintainer
      target/openrisc: Fixes for memory debugging
      target/openrisc: add numcores and coreid support
      migration: Add VMSTATE_UINTTL_2DARRAY()
      target/openrisc: implement shadow registers
      migration: Add VMSTATE_STRUCT_2DARRAY()
      target/openrisc: Implement full vmstate serialization
      target/openrisc: Remove duplicate features property
      target/openrisc: Support non-busy idle state using PMR SPR

Tim 'mithro' Ansell (2):
      target/openrisc: Implement EVBAR register
      target/openrisc: Implement EPH bit

 MAINTAINERS                         |  4 +-
 hw/openrisc/cputimer.c              |  1 +
 include/migration/cpu.h             |  7 ++++
 include/migration/vmstate.h         | 15 ++++++++
 linux-user/elfload.c                |  2 +-
 linux-user/main.c                   | 18 ++++-----
 linux-user/openrisc/target_cpu.h    |  6 +--
 linux-user/openrisc/target_signal.h |  2 +-
 linux-user/signal.c                 | 16 ++++----
 target/openrisc/cpu.c               | 16 +++-----
 target/openrisc/cpu.h               | 46 ++++++++++++++--------
 target/openrisc/gdbstub.c           |  4 +-
 target/openrisc/interrupt.c         | 11 +++++-
 target/openrisc/machine.c           | 76 +++++++++++++++++++++++++++++++++++--
 target/openrisc/mmu.c               | 23 +++++++++--
 target/openrisc/sys_helper.c        | 35 +++++++++++++++++
 target/openrisc/translate.c         |  5 ++-
 17 files changed, 225 insertions(+), 62 deletions(-)
-- 
2.9.3


Re: [Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC
Posted by no-reply@patchew.org 6 years, 11 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: cover.1493593744.git.shorne@gmail.com
Type: series
Subject: [Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7989364 target/openrisc: Support non-busy idle state using PMR SPR
2b4b86b target/openrisc: Remove duplicate features property
fe20698 target/openrisc: Implement full vmstate serialization
d647ed5 migration: Add VMSTATE_STRUCT_2DARRAY()
b06a1f7 target/openrisc: implement shadow registers
5ac9dfa migration: Add VMSTATE_UINTTL_2DARRAY()
5fd970d target/openrisc: add numcores and coreid support
6a012fb target/openrisc: Fixes for memory debugging
da141c5 target/openrisc: Implement EPH bit
8d983cb target/openrisc: Implement EVBAR register
9088518 MAINTAINERS: Add myself as openrisc maintainer

=== OUTPUT BEGIN ===
Checking PATCH 1/11: MAINTAINERS: Add myself as openrisc maintainer...
Checking PATCH 2/11: target/openrisc: Implement EVBAR register...
Checking PATCH 3/11: target/openrisc: Implement EPH bit...
Checking PATCH 4/11: target/openrisc: Fixes for memory debugging...
WARNING: line over 80 characters
#45: FILE: target/openrisc/mmu.c:232:
+        miss = cpu_openrisc_get_phys_addr(cpu, &phys_addr, &prot, addr, MMU_INST_FETCH);

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/11: target/openrisc: add numcores and coreid support...
Checking PATCH 6/11: migration: Add VMSTATE_UINTTL_2DARRAY()...
Checking PATCH 7/11: target/openrisc: implement shadow registers...
WARNING: line over 80 characters
#135: FILE: linux-user/signal.c:4492:
+    __put_user(sas_ss_flags(cpu_get_gpr(env, 1)), &frame->uc.tuc_stack.ss_flags);

total: 0 errors, 1 warnings, 230 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/11: migration: Add VMSTATE_STRUCT_2DARRAY()...
ERROR: line over 90 characters
#20: FILE: include/migration/vmstate.h:503:
+#define VMSTATE_STRUCT_2DARRAY_TEST(_field, _state, _n1, _n2, _test, _version, _vmsd, _type) { \

ERROR: spaces required around that '|' (ctx:VxV)
#27: FILE: include/migration/vmstate.h:510:
+    .flags        = VMS_STRUCT|VMS_ARRAY,                                   \
                               ^

WARNING: line over 80 characters
#38: FILE: include/migration/vmstate.h:761:
+#define VMSTATE_STRUCT_2DARRAY(_field, _state, _n1, _n2, _version, _vmsd, _type) \

total: 2 errors, 1 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/11: target/openrisc: Implement full vmstate serialization...
Checking PATCH 10/11: target/openrisc: Remove duplicate features property...
Checking PATCH 11/11: target/openrisc: Support non-busy idle state using PMR SPR...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC
Posted by Stefan Hajnoczi 6 years, 11 months ago
On Mon, May 01, 2017 at 08:14:14AM +0900, Stafford Horne wrote:
> This are the openrisc patches I have been circulating on the mailing list
> of the last few months.  We have had help from a few new people and added
> the following:
>  * Fixes for gdb memory debugging
>  * Added support for Shadow Registers, EVBAR, EPH
>  * Added support for idle state, no more 100% pegged cpu's
>  * Fixed VM state persisting
> 
> Please consider for pull.

Hi Stafford,
I'm handling qemu.git pull requests while Peter Maydell is away in May.

Please take a look at the checkpatch.pl errors that the patchew
continuous integration system found (there is an email reply to this
thread).  Thanks!

Stefan
Re: [Qemu-devel] [PULL 00/11] Fixes and features for OpenRISC
Posted by Stafford Horne 6 years, 11 months ago
On Tue, May 02, 2017 at 03:20:17PM +0100, Stefan Hajnoczi wrote:
> On Mon, May 01, 2017 at 08:14:14AM +0900, Stafford Horne wrote:
> > This are the openrisc patches I have been circulating on the mailing list
> > of the last few months.  We have had help from a few new people and added
> > the following:
> >  * Fixes for gdb memory debugging
> >  * Added support for Shadow Registers, EVBAR, EPH
> >  * Added support for idle state, no more 100% pegged cpu's
> >  * Fixed VM state persisting
> > 
> > Please consider for pull.
> 
> Hi Stafford,
> I'm handling qemu.git pull requests while Peter Maydell is away in May.
> 
> Please take a look at the checkpatch.pl errors that the patchew
> continuous integration system found (there is an email reply to this
> thread).  Thanks!

Hello Stefan,

Is there one that you think is particulary important?  I had a look through
them before submitting these patches but I thought these were ok.

Example errors:
  - include/migration/vmstate.h
   * line over 90 characters
   * space required around '|'

If you look at the file these are consistent with the rest of the file.
Which I thought is more important usually.

-Stafford