hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The code that introduced "virtio-blk: Configure all host notifiers in
a single MR transaction" introduced a second loop variable to perform
cleanup in second loop, but mistakenly still refers to the first
loop variable within the second loop body.
Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a
single MR transaction")
Signed-off-by: Mark Mielke <mark.mielke@gmail.com>
---
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 252c3a7a23..ee5a5352dc 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -222,7 +222,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
memory_region_transaction_commit();
while (j--) {
- virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
+ virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), j);
}
goto fail_host_notifiers;
}
--
2.33.1
--
Mark Mielke <mark.mielke@gmail.com>
Sorry... I missed copy maintainers and qemu-stable. This should be
considered a regression.
---------- Forwarded message ---------
From: Mark Mielke <mark.mielke@gmail.com>
Date: Thu, Dec 2, 2021 at 11:26 AM
Subject: [PATCH] virtio-blk: Fix clean up of host notifiers for single
MR transaction.
To: <qemu-devel@nongnu.org>
The code that introduced "virtio-blk: Configure all host notifiers in
a single MR transaction" introduced a second loop variable to perform
cleanup in second loop, but mistakenly still refers to the first
loop variable within the second loop body.
Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a
single MR transaction")
Signed-off-by: Mark Mielke <mark.mielke@gmail.com>
---
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 252c3a7a23..ee5a5352dc 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -222,7 +222,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
memory_region_transaction_commit();
while (j--) {
- virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
+ virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), j);
}
goto fail_host_notifiers;
}
--
2.33.1
--
Mark Mielke <mark.mielke@gmail.com>
On Thu, Dec 2, 2021 at 10:34 PM Mark Mielke <mark.mielke@gmail.com> wrote: > > Sorry... I missed copy maintainers and qemu-stable. This should be > considered a regression. > > ---------- Forwarded message --------- > From: Mark Mielke <mark.mielke@gmail.com> > Date: Thu, Dec 2, 2021 at 11:26 AM > Subject: [PATCH] virtio-blk: Fix clean up of host notifiers for single > MR transaction. > To: <qemu-devel@nongnu.org> > > > The code that introduced "virtio-blk: Configure all host notifiers in > a single MR transaction" introduced a second loop variable to perform > cleanup in second loop, but mistakenly still refers to the first > loop variable within the second loop body. > > Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a > single MR transaction") > Signed-off-by: Mark Mielke <mark.mielke@gmail.com> Reviewed-by: Ani Sinha <ani@anisinha.ca> > --- > hw/block/dataplane/virtio-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index 252c3a7a23..ee5a5352dc 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -222,7 +222,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev) > memory_region_transaction_commit(); > > while (j--) { > - virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i); > + virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), j); > } > goto fail_host_notifiers; > } > -- > 2.33.1 > > -- > Mark Mielke <mark.mielke@gmail.com> >
© 2016 - 2024 Red Hat, Inc.