From nobody Thu May 2 02:20:04 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1638464815; cv=none; d=zohomail.com; s=zohoarc; b=Dtz5lbd41ZS6CvDq6nssXT65PBEEV5abOOIfHw5keWG73oPdGd7kUC/ZeXHVPnAFbrG5LANoDOPVSWkk9zz+dO8A3vbwRRCsTegZTQIMFbGI4VxHXP7A71HEMNpbEOEyEDpzgeYIpc+hEIMZLdGd5SiJJTI2Zrji+z+c/v88W4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638464815; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rMDRBAE6JqfCQ6zLRXgMOIeYyBLV3PVfS5lIALN12ww=; b=Eedpkgg/1zH96HCgV522/JqCEejhm2O6SKLY0EmSAM/YTKb3AK0EZ6OWwUlri/IVX4Y2KTruo8t3+IKTJrf/cXWiB1wDp60Oc75VUG43EhrWiamJJ95XOYfTGCPMqQ6U+VjuGVlUfPJcv5EjjJgRcEmsv7TzZBT4LbLJwrV3aSM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1638464815107608.2513721507738; Thu, 2 Dec 2021 09:06:55 -0800 (PST) Received: from localhost ([::1]:32986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mspXp-00011m-Dq for importer@patchew.org; Thu, 02 Dec 2021 12:06:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msovQ-0000MB-PT for qemu-devel@nongnu.org; Thu, 02 Dec 2021 11:27:13 -0500 Received: from [2a00:1450:4864:20::536] (port=43990 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msovL-0000kl-Nx for qemu-devel@nongnu.org; Thu, 02 Dec 2021 11:27:12 -0500 Received: by mail-ed1-x536.google.com with SMTP id o20so176589eds.10 for ; Thu, 02 Dec 2021 08:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=rMDRBAE6JqfCQ6zLRXgMOIeYyBLV3PVfS5lIALN12ww=; b=qrxpqqMowlL7UdsKsxC11fe60lt+NjavOncTA3wuUxfZLZOLED6+m9zoWYS8pNaPt6 PsXxDdtzJV9ytLmeRA93BdHWTTtSH8LPiFrtlHBokqBqOuEQm7NxDOS39Ex7rPsjzznj W1+ikPQJzgMCP9AQeVC/ig98Zp3BuJYfvJkX+8fl6ogCpsUl/gTRyck2RXt5sHyUpfXw yJaliUABnXUl+XXs313776ONdctYlRJB0pDgFCWLYyYMYiyMszrbYVTQfFcCUvRDfKMb kE3KE9ZKiqRc2wVtaOswXHJJF1sIeJ7SpDYVGBNjTXoJrLF/q3f5j6vTCjtzIL7Ytyxj 5DMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rMDRBAE6JqfCQ6zLRXgMOIeYyBLV3PVfS5lIALN12ww=; b=bhvJSQeEr6DVaKIOiPH/920aGDlwFkZpn4caxMnq1mj0q1rtQHgYimY01zwFKs7gV6 tgEOLCFL4oLp0hl5kkiH4LZl4a1v2L7krJtirdK/0qNs3Pl7/o3eyf2IGuwTdlvD/UNv WSnolkRimMO1jdQjjn0vnqk7YSQUxZyKa52jJbyV8kKyHrPIGeJ6qgPpY1ED01SgQ8L3 OQTSc9icEYcs4OSQn9NqKU6eOY6OCsdBXflWX4wOxd7ZXIe9qyW29nphkmx6jd3Z3zO8 ZosxgbVVRxIBMKfanrYHM5kCTDQD79LwjiqOGYNl+n++diZA7nhLmt9+pFRydB3M0vQ4 8jkg== X-Gm-Message-State: AOAM530DLoghKC7e4jhfFulGb9zUCNMIW2Px1XjuO5AjjzTT4zrMH1sM WxgrElzqXid2Tg5OKgTUNADW5iq+kdLVjq/gybSt4Y+Srj4= X-Google-Smtp-Source: ABdhPJzeVbDrm1XjPKm6L9YG668MPc98JJy0xeWUV0HcmF1RLuOP9xi8yuDCyi1/mOxa6XwXKykAzzSysMV9QyCXvOo= X-Received: by 2002:a50:d88b:: with SMTP id p11mr18496026edj.287.1638462422547; Thu, 02 Dec 2021 08:27:02 -0800 (PST) MIME-Version: 1.0 From: Mark Mielke Date: Thu, 2 Dec 2021 11:26:51 -0500 Message-ID: Subject: [PATCH] virtio-blk: Fix clean up of host notifiers for single MR transaction. To: qemu-devel@nongnu.org X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=mark.mielke@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 02 Dec 2021 12:04:19 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1638464816587100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code that introduced "virtio-blk: Configure all host notifiers in a single MR transaction" introduced a second loop variable to perform cleanup in second loop, but mistakenly still refers to the first loop variable within the second loop body. Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a single MR transaction") Signed-off-by: Mark Mielke --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-bl= k.c index 252c3a7a23..ee5a5352dc 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -222,7 +222,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev) memory_region_transaction_commit(); while (j--) { - virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i); + virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), j); } goto fail_host_notifiers; } --=20 2.33.1 --=20 Mark Mielke