Hi Peter,
Thanks for the help here.

I had a look at the v1 pull. I will rebase the patches with latest changes and send next version with changes.

Regards,
Vikram

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, September 14, 2020 8:06 AM
> To: Vikram Garhwal <fnuv@xilinx.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; Francisco Eduardo
> Iglesias <figlesia@xilinx.com>
> Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller
> 
> On Mon, 14 Sep 2020 at 14:16, Peter Maydell <peter.maydell@linaro.org>
> wrote:
> >
> > On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal <fnu.vikram@xilinx.com>
> wrote:
> > > Vikram Garhwal (4):
> > >   hw/net/can: Introduce Xilinx ZynqMP CAN controller
> > >   xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
> > >   tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
> > >   MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller
> >
> > Applied to target-arm.next, thanks. (I had to make some minor fixups
> > to convert the makefile changes to the new meson build system.)
> 
> I had to drop these patches because in the full merge build test configs they
> failed to link because nothing was pulling in the generic CONFIG_CAN_BUS
> files.
> 
> Could you rebase this, make the necessary changes to get it to work with
> meson[*], and also make whatever Kconfig changes are necessary so that
> the ZynqMP CAN controller device declares its dependency on the generic
> CONFIG_CAN_BUS code, please?
> 
> [*] you might want to look at the versions of the patches I just sent out in
> my v1 pullreq today, but basically instead of the Makefile.include changes
> you want some simple one-liner changes to meson.build files, and also
> tests/qtest/xlnx-can-test.c needs to #include "libqos/libqtest.h"
> rather than just "libqtest.h".
> 
> thanks
> -- PMM