Hi Peter, I sent rebased V10 series three weeks back as there were some issues with meson build on v9. Would it possible for you to apply the patch series? Link for series: https://patchew.org/QEMU/1600121324-31337-1-git-send-email-fnu.vikram@xilinx.com/ Regards, Vikram > -----Original Message----- > From: Vikram Garhwal <fnu.vikram@xilinx.com> > Sent: Monday, September 14, 2020 3:29 PM > To: Peter Maydell <peter.maydell@linaro.org> > Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller > > Hi Peter, > I just sent the v10 series which is rebased with latest master branch > changes. > > Thanks again for the help. > > Regards, > Vikram > > On Mon, Sep 14, 2020 at 04:06:29PM +0100, Peter Maydell wrote: > > On Mon, 14 Sep 2020 at 14:16, Peter Maydell > <peter.maydell@linaro.org> wrote: > > > > > > On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal > <fnu.vikram@xilinx.com> wrote: > > > > Vikram Garhwal (4): > > > > hw/net/can: Introduce Xilinx ZynqMP CAN controller > > > > xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers > > > > tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller > > > > MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN > > > > controller > > > > > > Applied to target-arm.next, thanks. (I had to make some minor fixups > > > to convert the makefile changes to the new meson build system.) > > > > I had to drop these patches because in the full merge build test > > configs they failed to link because nothing was pulling in the generic > > CONFIG_CAN_BUS files. > > > > Could you rebase this, make the necessary changes to get it to work > > with meson[*], and also make whatever Kconfig changes are necessary so > > that the ZynqMP CAN controller device declares its dependency on the > > generic CONFIG_CAN_BUS code, please? > > > > [*] you might want to look at the versions of the patches I just sent > > out in my v1 pullreq today, but basically instead of the > > Makefile.include changes you want some simple one-liner changes to > > meson.build files, and also tests/qtest/xlnx-can-test.c needs to > > #include "libqos/libqtest.h" > > rather than just "libqtest.h". > > > > thanks > > -- PMM
On Thu, 1 Oct 2020 at 18:57, Vikram Garhwal <fnuv@xilinx.com> wrote: > > Hi Peter, > I sent rebased V10 series three weeks back as there were some issues with meson build on v9. Would it possible for you to apply the patch series? Oops, sorry -- I didn't notice the resent series. I've put it on my list to handle. thanks -- PMM
© 2016 - 2024 Red Hat, Inc.