[PATCH v2 00/12] hw/arm/aspeed: Use a table for unimplemented devices

Jamin Lin posted 12 patches 1 week, 3 days ago
include/hw/arm/aspeed_ast1700.h     |  2 --
include/hw/arm/aspeed_coprocessor.h |  5 +--
include/hw/arm/aspeed_soc.h         | 14 +-------
include/hw/misc/unimp.h             | 21 +++++++++++
hw/arm/aspeed_ast1040.c             | 40 +++++++--------------
hw/arm/aspeed_ast10x0.c             | 55 ++++++++---------------------
hw/arm/aspeed_ast1700.c             | 21 +++++------
hw/arm/aspeed_ast2400.c             | 25 ++++++-------
hw/arm/aspeed_ast2600.c             | 44 +++++++----------------
hw/arm/aspeed_ast27x0-ssp.c         | 44 +++++++----------------
hw/arm/aspeed_ast27x0-tsp.c         | 44 +++++++----------------
hw/arm/aspeed_ast27x0.c             | 41 +++++++--------------
hw/arm/aspeed_soc_common.c          | 11 ------
hw/misc/unimp.c                     | 20 +++++++++++
14 files changed, 138 insertions(+), 249 deletions(-)
[PATCH v2 00/12] hw/arm/aspeed: Use a table for unimplemented devices
Posted by Jamin Lin 1 week, 3 days ago
v1:
 1. Use unimp array and table for unimplemented devices
 2. Sort device IDs alphabetically

v2:
 1. Add a common create_unimplemented_devices() helper and
    UnimplementedDeviceConfig in hw/misc/unimp, as suggested by Philippe.
 2. Define the unimplemented device table at the SoC class level
 3. Drop the "unimp" array and the AspeedUnimpDevice table.
 4. Remove aspeed_mmio_map_unimplemented(), which is not used anymore.
 
Jamin Lin (12):
  hw/misc/unimp: Add create_unimplemented_devices() helper
  hw/arm/aspeed_ast2400: Use a table for unimplemented devices
  hw/arm/aspeed_ast2600: Use a table for unimplemented devices
  hw/arm/aspeed_ast27x0: Use a table for unimplemented devices
  hw/arm/aspeed_ast10x0: Use a table for unimplemented devices
  hw/arm/aspeed_ast1040: Use a table for unimplemented devices
  hw/arm/aspeed: Remove unused unimplemented device fields
  hw/arm/aspeed_ast27x0: Use a table for unimplemented devices for
    SSP/TSP
  hw/arm/aspeed_coprocessor: Remove unused unimplemented device fields
  hw/arm/aspeed_ast1700: Use a table for unimplemented devices
  hw/arm/aspeed_ast1700: Remove unused unimplemented device field
  hw/arm/aspeed: Remove unused aspeed_mmio_map_unimplemented()

 include/hw/arm/aspeed_ast1700.h     |  2 --
 include/hw/arm/aspeed_coprocessor.h |  5 +--
 include/hw/arm/aspeed_soc.h         | 14 +-------
 include/hw/misc/unimp.h             | 21 +++++++++++
 hw/arm/aspeed_ast1040.c             | 40 +++++++--------------
 hw/arm/aspeed_ast10x0.c             | 55 ++++++++---------------------
 hw/arm/aspeed_ast1700.c             | 21 +++++------
 hw/arm/aspeed_ast2400.c             | 25 ++++++-------
 hw/arm/aspeed_ast2600.c             | 44 +++++++----------------
 hw/arm/aspeed_ast27x0-ssp.c         | 44 +++++++----------------
 hw/arm/aspeed_ast27x0-tsp.c         | 44 +++++++----------------
 hw/arm/aspeed_ast27x0.c             | 41 +++++++--------------
 hw/arm/aspeed_soc_common.c          | 11 ------
 hw/misc/unimp.c                     | 20 +++++++++++
 14 files changed, 138 insertions(+), 249 deletions(-)

-- 
2.53.0
Re: [PATCH v2 00/12] hw/arm/aspeed: Use a table for unimplemented devices
Posted by Cédric Le Goater 1 week, 2 days ago
On 10/12/26 08:44, Jamin Lin wrote:
> v1:
>   1. Use unimp array and table for unimplemented devices
>   2. Sort device IDs alphabetically
> 
> v2:
>   1. Add a common create_unimplemented_devices() helper and
>      UnimplementedDeviceConfig in hw/misc/unimp, as suggested by Philippe.
>   2. Define the unimplemented device table at the SoC class level
>   3. Drop the "unimp" array and the AspeedUnimpDevice table.
>   4. Remove aspeed_mmio_map_unimplemented(), which is not used anymore.
>   
> Jamin Lin (12):
>    hw/misc/unimp: Add create_unimplemented_devices() helper
>    hw/arm/aspeed_ast2400: Use a table for unimplemented devices
>    hw/arm/aspeed_ast2600: Use a table for unimplemented devices
>    hw/arm/aspeed_ast27x0: Use a table for unimplemented devices
>    hw/arm/aspeed_ast10x0: Use a table for unimplemented devices
>    hw/arm/aspeed_ast1040: Use a table for unimplemented devices
>    hw/arm/aspeed: Remove unused unimplemented device fields
>    hw/arm/aspeed_ast27x0: Use a table for unimplemented devices for
>      SSP/TSP
>    hw/arm/aspeed_coprocessor: Remove unused unimplemented device fields
>    hw/arm/aspeed_ast1700: Use a table for unimplemented devices
>    hw/arm/aspeed_ast1700: Remove unused unimplemented device field
>    hw/arm/aspeed: Remove unused aspeed_mmio_map_unimplemented()
> 
>   include/hw/arm/aspeed_ast1700.h     |  2 --
>   include/hw/arm/aspeed_coprocessor.h |  5 +--
>   include/hw/arm/aspeed_soc.h         | 14 +-------
>   include/hw/misc/unimp.h             | 21 +++++++++++
>   hw/arm/aspeed_ast1040.c             | 40 +++++++--------------
>   hw/arm/aspeed_ast10x0.c             | 55 ++++++++---------------------
>   hw/arm/aspeed_ast1700.c             | 21 +++++------
>   hw/arm/aspeed_ast2400.c             | 25 ++++++-------
>   hw/arm/aspeed_ast2600.c             | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-ssp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-tsp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0.c             | 41 +++++++--------------
>   hw/arm/aspeed_soc_common.c          | 11 ------
>   hw/misc/unimp.c                     | 20 +++++++++++
>   14 files changed, 138 insertions(+), 249 deletions(-)
> 

Applied to

     https://github.com/legoater/qemu aspeed-next

Thanks,

C.
Re: [PATCH v2 00/12] hw/arm/aspeed: Use a table for unimplemented devices
Posted by Philippe Mathieu-Daudé 1 week, 2 days ago
On 12/10/26 08:44, Jamin Lin wrote:

>   include/hw/arm/aspeed_ast1700.h     |  2 --
>   include/hw/arm/aspeed_coprocessor.h |  5 +--
>   include/hw/arm/aspeed_soc.h         | 14 +-------
>   include/hw/misc/unimp.h             | 21 +++++++++++
>   hw/arm/aspeed_ast1040.c             | 40 +++++++--------------
>   hw/arm/aspeed_ast10x0.c             | 55 ++++++++---------------------
>   hw/arm/aspeed_ast1700.c             | 21 +++++------
>   hw/arm/aspeed_ast2400.c             | 25 ++++++-------
>   hw/arm/aspeed_ast2600.c             | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-ssp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-tsp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0.c             | 41 +++++++--------------
>   hw/arm/aspeed_soc_common.c          | 11 ------
>   hw/misc/unimp.c                     | 20 +++++++++++
>   14 files changed, 138 insertions(+), 249 deletions(-)

Per the diff-stat it was worth it IMHO :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

Re: [PATCH v2 00/12] hw/arm/aspeed: Use a table for unimplemented devices
Posted by Cédric Le Goater 1 week, 3 days ago
On 10/12/26 08:44, Jamin Lin wrote:
> v1:
>   1. Use unimp array and table for unimplemented devices
>   2. Sort device IDs alphabetically
> 
> v2:
>   1. Add a common create_unimplemented_devices() helper and
>      UnimplementedDeviceConfig in hw/misc/unimp, as suggested by Philippe.
>   2. Define the unimplemented device table at the SoC class level
>   3. Drop the "unimp" array and the AspeedUnimpDevice table.
>   4. Remove aspeed_mmio_map_unimplemented(), which is not used anymore.
>   
> Jamin Lin (12):
>    hw/misc/unimp: Add create_unimplemented_devices() helper
>    hw/arm/aspeed_ast2400: Use a table for unimplemented devices
>    hw/arm/aspeed_ast2600: Use a table for unimplemented devices
>    hw/arm/aspeed_ast27x0: Use a table for unimplemented devices
>    hw/arm/aspeed_ast10x0: Use a table for unimplemented devices
>    hw/arm/aspeed_ast1040: Use a table for unimplemented devices
>    hw/arm/aspeed: Remove unused unimplemented device fields
>    hw/arm/aspeed_ast27x0: Use a table for unimplemented devices for
>      SSP/TSP
>    hw/arm/aspeed_coprocessor: Remove unused unimplemented device fields
>    hw/arm/aspeed_ast1700: Use a table for unimplemented devices
>    hw/arm/aspeed_ast1700: Remove unused unimplemented device field
>    hw/arm/aspeed: Remove unused aspeed_mmio_map_unimplemented()
> 
>   include/hw/arm/aspeed_ast1700.h     |  2 --
>   include/hw/arm/aspeed_coprocessor.h |  5 +--
>   include/hw/arm/aspeed_soc.h         | 14 +-------
>   include/hw/misc/unimp.h             | 21 +++++++++++
>   hw/arm/aspeed_ast1040.c             | 40 +++++++--------------
>   hw/arm/aspeed_ast10x0.c             | 55 ++++++++---------------------
>   hw/arm/aspeed_ast1700.c             | 21 +++++------
>   hw/arm/aspeed_ast2400.c             | 25 ++++++-------
>   hw/arm/aspeed_ast2600.c             | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-ssp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0-tsp.c         | 44 +++++++----------------
>   hw/arm/aspeed_ast27x0.c             | 41 +++++++--------------
>   hw/arm/aspeed_soc_common.c          | 11 ------
>   hw/misc/unimp.c                     | 20 +++++++++++
>   14 files changed, 138 insertions(+), 249 deletions(-)
> 

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.