From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787534; cv=pass; d=zohomail.com; s=zohoarc; b=U38MbEOYyx82OBZc6dDXLzoQpTLWl6KKcdD6yOfmSiQ6gzFAgTWJUTTXag/bDvnt7/RxX42AuwSSr0NIyf9rompoqu2qgB91lHrKxRBqg7ZNXh5+f3Jkga4sS7gUVI7y/QlXvlTcEMyZjwJPZR1WamU0pIAR5EwuAolZl3vLB98= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787534; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9OY27Qx08dW8Zys0s0KmIAxX730KvsQ8Jrawdepy6vQ=; b=HsF0eYa6W0sjT9jT84NrW/1wYqay9EyYFHZ7OXD+iSVKzaHanXGDjbrf0+VX5iEBCNfgqLzOiaeGFEaWtZHN5RicQulwjHzGqX6D5zQB9pAZtoKx0GcICR3cGPGFSMpnsWCj3YCWZe4EUCZns7r4HL7xYbBTGAXNdKsOfyUkd0I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787533831428.15474535559804; Sun, 11 Oct 2026 23:45:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mS-0001jt-Fv; Mon, 12 Oct 2026 02:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mM-0001ii-Is; Mon, 12 Oct 2026 02:45:00 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mK-0006MT-I1; Mon, 12 Oct 2026 02:44:58 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:47 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kCqMji+yFyD6vM0oH/G405cHPbcwHyzpPwKef2hOut5k0py1tadGjDxFAkNszsjze/oMkn6FLpItO1pQJC6KUwEWYD9rDYGpSIMpKwjNQsChlTsg4UXNKMbXWjFVNaRWtuTwOXwo7bm6Zl7g7bUR+nR8frIPIjClZYOaB418zs21/booOT5HeVUXrS4HT8ZlEH9zBaDLXoe4wzPQ5byjBwKZK9fSqbjFNWkMq0zC2Go7+PiPET/JMuIG/+9OyU9rBLWd8dTLny9090kUkT8yxLGuFFBKQLVCWBMZ95U+6uek2oabxwnB+LkdUQV7lZmLeCOPZ3kI6znQm8KPymnCTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9OY27Qx08dW8Zys0s0KmIAxX730KvsQ8Jrawdepy6vQ=; b=cYlI/H0q4a9MOEaA67XvyZ2MGW1cS4dizF1ayvAZ/URtFVFu5rfnFO96KaAN3/T/kktYJe5PpAVf23jNEvc5P4QipAC0bJ4X55qS4lIlwalQ67aJmxGgySnXhEz+FnFqtWfQR6otZNEe0tP35vYbGEemOFa/kWfVwDlMaxvlA6Z7xeagcKADzD7QZG2uVqTZbQWIyYEZ9HHZ05jFGj3RVOR88tV0AgQTZreCov45J2j+jX4MLEF04QMEMsu8Sv6xMVnIPDEc8S1Ij+P+JB+2/O/C7l8IjW5Z7p4dxfzy78HZPXL5w2PqioRatI95VLAeA0ox7T3TCtsgjwasc3zlCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9OY27Qx08dW8Zys0s0KmIAxX730KvsQ8Jrawdepy6vQ=; b=E230XVgyYhKVk9QQIeAK/n+7Om5gIWVOIwpVV7vNWUqvOGIEQ062kLjqk0WxDyfdc17nWDpYTC1Y3c/zYSBlgm3I3Loe/9JTnHXKPy9J6J9TqQmEa3cWmrpWkRzU9Bf/n/cDgeDjlKoe8OVtqBzfb2pgRuCMmSikst0VusrEPjUz6x/Na4lYm3mcNegFad+QYoGvktJDt7G8vZUPhIiMy9WJq0C+nUqqrx0Mp4uEJDTRrG+Qpw54NWtZNIiIo+fi4gYuXZvTMg5k3amltE2K+ubyNY0iqYFHqqyNrbi2rxLMdyGYfNlGhUPt8W6ZOfhTiKGUYi0FrWCdEBpudZCY/Q== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 01/12] hw/misc/unimp: Add create_unimplemented_devices() helper Thread-Topic: [PATCH v2 01/12] hw/misc/unimp: Add create_unimplemented_devices() helper Thread-Index: AQHdWhUsNiuZTkRDnU+UXALkHv/p8g== Date: Mon, 12 Oct 2026 06:44:47 +0000 Message-ID: <20261012064445.2571633-2-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 377113dd-cd0f-450d-eca2-08df282c4e8b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: /r3B926Pmu0p8Sqh1nSBVqkUztlqDRjBCp4kjZZxtRw1baLUhhc8SyuFGjKcq3CKzaA+FjHZeZr7tWXDLg2NqqS+D3iJwe0MNsQctENqLIcfdB1DBMbOQEtbAoiFb3gemfK/NyYAjC7+vPSIF0yOq3wUlnWOTvWyJMaL5G8mjXNxKLU6siavr4O7Hjm8YamAgh++8mZUmcHOKIZvJs1DCbYqfwrKkJhAlpPtfBZZtt7XZg8JYsNIS9QQoMpSz61xxHdvBdEyhxkK63h8jDpXK9nNpYi73K/3WwO/w5hZCw+EdjLN0oZ4OhaZy9mTkXdiextaGyAQzI8vXaSpBgHZsd4qIaGSzzNuYhDC1B+pNPxew9yYFWU+8gAfh+GseUfK+RO6slCTsN2v2QXN2cGHFrAnvjfTr4tME8/YsgoIUtbA9RWlAwSljHscDw/EwBsgRhmdIyfKmM1lbmEAJ9WqvzFTdNtTKD14BQr5gaDYqVvlMTCKcWB4qOTdZLST6fW3ZnAPo66vNWYx08hFNKI65L0A/a2dRxlohMNnrncG8/nA/cDIyVIhcKK0Pegidx7Jmp1jFrdt5MCQJKfDbqidN6OpNALpMYC3HylNS0a5SA1h1H3RWpIkFIfJsntW/S/JEu6XWTT82xivbpWah8ZTXdsAh8J81+VGBqucM5qzmCF56DcDEg2Ue02bgsujDp09ifxqv0leO3wS+0EH9BTnGL/072C2WrsaWrioSzkNFXUrwfE3h5KjvqXvJJaUFV2F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HaGTO3UxQ9xBQRw7UgMzDzTHtQWWOcq4ZM7MPwc3QkqG2GYvSxg90e+OWz?= =?iso-8859-1?Q?Kyv2uQKk7x6CZHDPZmo2h3raX5puVY2ZeiXjlk3HU2313Du/o6A+ZAZ13O?= =?iso-8859-1?Q?kxa9gsWVXGxUqRyYkqmT/wFsi751uH8Ah5M47FdSM4I4QcCG6SPDeZVyQF?= =?iso-8859-1?Q?RRFo+WGo7bgbfZiYkZdzlX5ZTBq3HHE5aoccUX6y3mKGjw/Te24/i6whh3?= =?iso-8859-1?Q?5W9CQiPd9UsaNKCtah8Ibcyv9P4FOdN/aGJy6I6JywSW4JWnl4VhmCmWlj?= =?iso-8859-1?Q?fQ8FrXptK2HBnPipUlo+dn5086+H9YdMBYvklJ8TtNMtDFifQOiPa74uYw?= =?iso-8859-1?Q?aJ13JJ7575YFye0PNyPPy7aGb8RyBBH6gkyeKIpHQZ0ikhdsvZnLJgBFwb?= =?iso-8859-1?Q?uhTKR3BuRx376SdGWfx+UMzIpKIUNzUOd8+5X7bhMhkjEwVhRJRSh4hMyP?= =?iso-8859-1?Q?++NNVMcCjR2l85v9ZYPA+WOrcIywtwxZ/PNrZfMIVMY6WOMd9QIZVH860c?= =?iso-8859-1?Q?Vu/WcIh2M2jdBeWQF7bzQSWe49lX3fYo23jUMtlh9nlZ4s9gdomo16kbyc?= =?iso-8859-1?Q?YGuNd8WnSijTYsa9brEYxQlyxWCfySQof2HffGxa2JP/am2I/vyyxaAJF5?= =?iso-8859-1?Q?CfHuWawR4OYtYhM9IIHYwJ22M7DmXlFv8E3B0f3OW/7/0QasGy450nxmhw?= =?iso-8859-1?Q?Jb8HjuTjlEUTJt2+/EO9RdE4yzP2GNk3BhIdYTy1GEEvjX+O913ycGX8ro?= =?iso-8859-1?Q?GDf6WO6mAew3pF31TPJKVDN4LoCkzwsLfWWnsfJxLy1K3/viB6eF1Lookb?= =?iso-8859-1?Q?cW73BrjIshkLBf5Gc8FwDg20idiO7yCPcWur20S5gVohmTEghzHkKz+b+/?= =?iso-8859-1?Q?BaiXnSDl5yanhvuwK7zCI06DzJaIpL4LmC61ZFib0oyQT883S6/6/lgmmx?= =?iso-8859-1?Q?w2UHPgLVpYIXu/cV4mVaxM6q71SCl+U4eAYgO7+xCgcSaMPz3V8ITkFZcj?= =?iso-8859-1?Q?LphuxlOM817r94sn78j3UQKI4prlyF0KHytI/6lTk4Q4E4p+r752hcKcZj?= =?iso-8859-1?Q?xEb+8TQhabyLHlORHZA8iEy/Fu7iueRCQLn7Bc7Hwc0waG2otw7LwAviMP?= =?iso-8859-1?Q?WWjZWJBQJSdlsHEeVOlOyMASbwDCICeD8ygiTnJqcbcM5qD+afjKiWvC8J?= =?iso-8859-1?Q?NlcM/D5fO1E4ys/GiJToYGrUUMrTOBPtW10qTslTa/BIriJRBfbdnW6fdR?= =?iso-8859-1?Q?GM/lMlMGaMXCY530Y2KH3TcUJmcqj6wpijYOTMZq9Obac4j2xM+4+T0ZW9?= =?iso-8859-1?Q?aEnT4JiB7wEpiPbe67SzToB1PiSJIsFkxcBW2qreDGwtFhToQDjzJaWgA+?= =?iso-8859-1?Q?AfsS5IAdHFzMSJF2jnhfSKFdPuu0YfZZ9CnjhqCvfni1qRLvsPnUdspm0K?= =?iso-8859-1?Q?dwyipmO4JVhBlJ1kqg5IQCcUVc0f+bRn6WUfunFYmWEi2ag4t8Qsl7IsVw?= =?iso-8859-1?Q?yO2DBn4bKc528vlq3U/pumUfosi9ncsp/DEC5YUZXxLJXsp07APDuJMySu?= =?iso-8859-1?Q?G7jvPcSpjd3enIAwWqD1O2IpXo9NY1GRSDXoixV+xKk98yjmsodtTwXtDr?= =?iso-8859-1?Q?KjTnfLjtvkWH3+lPO10AsxEOEvwo5jjXExMZa7De8L3ggEChjgh8v1ut4g?= =?iso-8859-1?Q?Te3SE4rCbshtAmxgqI2xm1sZQQhVWRqa1bRu1vxPk1IEB95qRbm4fYThUQ?= =?iso-8859-1?Q?GskGL0rIHERLAs+GXVVQO06CI4aTneIMGGw75w4/NYpm7NgxoCwUZR9ndr?= =?iso-8859-1?Q?27SUoohoCA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: MQieRVqGVrIY6fe1sQMr80cW4OZ9WWVwL7pb/l0SDaCiFmNYgOC0TVTcjxGAnk+NPvUv5BICp4UKTeJH9pum1gY/BIDwPFUc6zS0YwgkY1UVrkvsvn06xrFYBH5SCPtVYB96AgVrtDSvKNJeXDghf3MwkclDOBN2Ectpn7KOCIqEG67T6g9ztII78mwV4T6Xck9dUuoqo8is7sGPXQCrDPyJTId4YGDLWJ+lTu8rtR2p0tFXe4IlKdBCXS5GaOLCuIkuejKWv1272ZO7bgOWeuVPr5GhdqYhJU23BtKSE+ku/IdjiTu3YOEjxUg4ovU4o0BZg1evGNzhnpG0v8tFTA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 377113dd-cd0f-450d-eca2-08df282c4e8b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:47.0750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: drm0RmvWDjbGMmaoqXed3Ikkg0HLg4mEuwHN9ML3RPpHHLRdNMJgK4UbXuYqAaZszHrbZ6vu4aDqVLHrJcRQOG6qrLVp90m+x6T5qcbpMcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787537117158500 Content-Type: text/plain; charset="utf-8" Several boards and SoCs create many unimplemented devices. Each of them uses its own structure and helper to describe and map these devices. Add an UnimplementedDeviceConfig structure and a create_unimplemented_devices() helper. The helper creates an unimplemented device for each entry of a table, adds it as a QOM child of the parent object, and maps it in a memory region container with the given priority. The table is terminated by an empty entry. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/misc/unimp.h | 21 +++++++++++++++++++++ hw/misc/unimp.c | 20 ++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index 77a5077511..073575159d 100644 --- a/include/hw/misc/unimp.h +++ b/include/hw/misc/unimp.h @@ -25,6 +25,27 @@ struct UnimplementedDeviceState { uint64_t size; }; =20 +typedef struct UnimplementedDeviceConfig { + const char *qom_name; + const char *region_name; + uint64_t offset; + uint64_t size; + int priority; +} UnimplementedDeviceConfig; + +/** + * create_unimplemented_devices: + * @parentobj: the parent object + * @container: a #MemoryRegion within which @addr is a relative address + * @devconfigs: NULL terminated array of #UnimplementedDeviceConfig + * + * For each entries in @devconfigs, create a TYPE_UNIMPLEMENTED_DEVICE + * and mmap it in @container at UnimplementedDeviceConfig::offset. + * @container is expected to be a QOM child of @parentobj. + */ +void create_unimplemented_devices(Object *parentobj, MemoryRegion *contain= er, + const UnimplementedDeviceConfig *devconf= igs); + /** * create_unimplemented_device: create and map a dummy device * @name: name of the device for debug logging diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index 521b84bf20..4c8dcbdff3 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -96,3 +96,23 @@ static void unimp_register_types(void) } =20 type_init(unimp_register_types) + +void create_unimplemented_devices(Object *parentobj, MemoryRegion *contain= er, + const UnimplementedDeviceConfig *devconf= igs) +{ + const UnimplementedDeviceConfig *cfg; + + for (cfg =3D devconfigs; cfg->qom_name; cfg++) { + DeviceState *dev =3D qdev_new(TYPE_UNIMPLEMENTED_DEVICE); + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + + object_property_add_child(parentobj, cfg->qom_name, OBJECT(dev)); + qdev_prop_set_string(dev, "name", cfg->region_name); + qdev_prop_set_uint64(dev, "size", cfg->size); + sysbus_realize_and_unref(sbd, &error_fatal); + + memory_region_add_subregion_overlap(container, cfg->offset, + sysbus_mmio_get_region(sbd, 0), + cfg->priority); + } +} --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787624; cv=pass; d=zohomail.com; s=zohoarc; b=j7HA67/pj/qD4z7Wn0iIthn3hVzclQpOSWlLwCp3OW3Eg7yoqviQ+I0nk3I6eUVf5/gjZmBLFrbPO+W5nJ61DRPGMwKVqMfBW95fNehlobV8QIn5C+2SbiSe8UTHRw5YlZCyiNZ09UlMLQEcf1qS4zmuW3NWKHU+zEL01bAJaL4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787624; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xrh2gjTTcrdmVDm/JU8V0+cqIE/AHIAuDpY8W9oAd7U=; b=ACbf2bw/d9Oj7dB1e0BNykOZEFBZ5LE5KyU7BR9daYTU7LyN/nLaNdshUWr93qXFsy6PT5udDp9CWgVY33td8LilIscoYeRsSS0Plu0OsvYU2ovbOBVbZrOIOXk9qMIS1VelAtNVxNLNRPR++guFR8Jrrq1EcClg18VuvjghKVg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787624937771.8367519333151; Sun, 11 Oct 2026 23:47:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mW-0001m5-Io; Mon, 12 Oct 2026 02:45:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mS-0001k7-2H; Mon, 12 Oct 2026 02:45:04 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mP-0006Ms-2V; Mon, 12 Oct 2026 02:45:02 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:48 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L6jCmIEi4S2SVjgYtvhioJytcfyiCfnV/cu/DvvBerGPAz5+GutUhhk6oaq+9Y27YMTYb+0JqrRM1YoHignEJYK/mTzeP/eZ0pE1mVakTXX5bDnGgXkFQjiXR2IIxBNuA5/xWyIGWxacN5Cxm6UShKvwKGEF1Kvfp1YYvDhcgCjT1Z3ekwzhIQZ6IYxZPVKi7X1hEJvBx0RPGVOHHfJFG5FMbnzAfrv77WgFT3d8dD/aUdKowYc6WtBFBwtZSWa6F356dHbcbaAeZJaYkkR0TZvF+dxhgx71Piuf+qBQRSzfPt9qV3eBBw5+g33PXvpYo6M3m6L60SvLRBzA0SNPXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xrh2gjTTcrdmVDm/JU8V0+cqIE/AHIAuDpY8W9oAd7U=; b=ZwhhTCEvtCrz3GWDstWKYA/Kk1kknBcqQ/uhr+tTyqgmH+dPaAGup2HPbCXBgpVnNY6A07h7+o1U2y+Tx4gXuYhdnK3WCyhRBBzU4dek7EJ+QObxcxf5zv+59+G7PGfmhu7iNZkILxrGZXeby8det8Sfo/OxoHSUdiMukdgyReh7O5QPh1yldnKJ8wSjWiJSVoab3JpQxtBRJkR/43Q9hnoftMTPJmUupmvVRdYQdvJ7Sjo7qHq811/AgejX8W086cAb3ZQZl/stl4iNirxwMAhOOW6fXJe+wRV3iK48rT3vAdrKEoUTGMnGNYoxw+gAPWOAXoYBNRFxhdHm4fcVNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xrh2gjTTcrdmVDm/JU8V0+cqIE/AHIAuDpY8W9oAd7U=; b=ileEXgreE65oP9bLWZ5C1j6sJCb26Of6PBazU9389zorxELHppy3SKDdtWjMnfnayf/j1q94xXvGPYP1HKWkdkgnt3lcPDTmKdls9vU8lM2G5Hhp059zW8LBdtlW4s3wxDSMXTpoYN54Y7x4sBAU+GNoWFx7gt4Lgc0zUOtKOGyZlg7tVxZU80wNA2eWRwfn7Z9SlEL2Mj8YRoSSEUAAMPnwBmqZpJ29yC4UmEfbqmY8IUWYkHzpJlEO5qigfPAtZcrN86q6/tWB32yRmwzQUaA6bzAlctK7TO82Sunz4oWVRF0SebjXUBUAa7vW436RJXK+fD5jw4AtY3TcYXM3dw== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 02/12] hw/arm/aspeed_ast2400: Use a table for unimplemented devices Thread-Topic: [PATCH v2 02/12] hw/arm/aspeed_ast2400: Use a table for unimplemented devices Thread-Index: AQHdWhUsT11ipMqmeEyWoIhrZbrxwg== Date: Mon, 12 Oct 2026 06:44:48 +0000 Message-ID: <20261012064445.2571633-3-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 49588668-c0b5-4867-2908-08df282c4f3d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|260925021311599003|260925022911599003|260925021911599003|10067099003|261009221227099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: HhQsOTHbEKnZx0VYKLS/BiaEkhWMwXZwCNejLa7vv5pXgeD2UYnqhCEAixUelcQa782IC5kumcIPVTP76aL8omX7qLB8kjCTjyVJnsPimwgkzCPd3qciK2xvuaxICqhU+VIMf4iyi+BJuv3iJZziqJ1ZAff0rEcbbHWYuGIa/Dz4nHzRAVjONUSvUoIf8PPdlTcS2ZCt/UWtgV7X4z6qxsM8unsYX5js8EclouIEpRArlbvu9orlXEPzL+JRadWEKAS2fwqtQGZZcPL7+bDrDBzniXlvlKhpnS580N8qTSl9mfjo1/qUjrHwwSrSqmvyD4R0wkRO7kRd55l5BTVaj6OuWi6pWA16M/6oCWC2onM3GX4P5OvWLsYvV993h3VsLbxiOlhThKcP/cD7lkjSw5jWWFRTzJ0Aoqk0XU+1jShGdGt6OwtuEuBkN+lr3ExQUAnEmiukTinuufEIG1xP812t5cADqVNxcXnu2rW5Ok7jD9Hw473qAhFwMVl12F6pz5JVOxnwxWrewVsAzYhM87Dwf0b98HbhXU1jglOdQQJj7p7sa1oRCizAqXA6UqtE09aNw2JqEvZbHPKMeh7oq94TdbpXdnGcp2vONFrf+S3dH3+izamVEXBzegMnkHpiFe25aO00jIdL9FUFgJUMJlPhK/RWiCR6CNT+kvU3Y9CKPfjoHSIM1PyycbCWDuMf3CoUj9iwvUvA522q/ZeJfUQJnjJZmedoFoZ5BswaNLUB8gXRtcJsmaK+PvG21gNU x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(260925021311599003)(260925022911599003)(260925021911599003)(10067099003)(261009221227099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?28nXk6LwOHQVzMwEIDxThMzUCIlHCj3wolWh4nJGP/CutmnnrKfo0t/oE9?= =?iso-8859-1?Q?kmCUg4CLwJZNjwbv9YRhLknekltY6BWq/2ositPF8wEnaKei5XwX2nKPsx?= =?iso-8859-1?Q?7F+e7tJF7AcX306L0jObQPNjN/PX6IehSpGDnFuNdBM2MBznAux2Vj712c?= =?iso-8859-1?Q?LgdTBsAjkGbbKEZvKKWIJeUrEwBdMZ9v6L5zIGkuafbSe1mxudbDJ8tsFF?= =?iso-8859-1?Q?nSzYPEr/lrNQxncMFaRgLHC29FhlvN7iur3lQKpklq8H5xlrNZ/BFL1IaO?= =?iso-8859-1?Q?YKTZzbEse8yquRbOB4VkBVUZewca06/Sp5U4vNMXPBLaQT6s4NRs4Z2G7t?= =?iso-8859-1?Q?NaDHovNUnPJcR0xyW8nZcTpjal+311rL5qPstXYlPfZ59tjANKlei0COdM?= =?iso-8859-1?Q?T7/v9LN43k1Rpzerbq7n3mmN0fYqtKFqzAWSVIFXGyk8A2PHXkn8lPlf6T?= =?iso-8859-1?Q?FwY8434QRQfaR4dm8kG3vn8I1zH5wumacTg10IiTTkwpEzSlW2mb7B6Y9U?= =?iso-8859-1?Q?I1uz2W9qSaQfY+Su5rOEvaPZFG0LqzSs6eYcONU0P5IDFxPAsz7hGShjCy?= =?iso-8859-1?Q?3SjB91xQG4iDad4KijEl+vPUB3gMvo9aXbjilqEyAs8Tz2R34G2aQOor38?= =?iso-8859-1?Q?fyMA24Aro49GnAj/5Ic6wMggVLiZmDk13Ojv/avXhAbB0vLPKdNMFBR5/l?= =?iso-8859-1?Q?2Db7Jyl8XQI/992vuQJSfAIZH+wIavO1u8rfaLHf1OjMvP5DoNC2vq7Arm?= =?iso-8859-1?Q?tmEu7mvEPKWFyAT4GNHTTBvnHqFmiijz297tGjG8nJn666G1lLZnsiLCSy?= =?iso-8859-1?Q?YuFK5hOaOc5gxP5sQgqoiS+ymcemRZ8CbhGAvJ09MDA0ZbiOyMhX1rtPzn?= =?iso-8859-1?Q?rkgVXOtGmTAB8yFDmHLBaT05QtRjnp/4kgv9ngEN3mPsmAIAYh1IjOjWhi?= =?iso-8859-1?Q?s/lP9ZIhIEOxlQfVD8VSYbpxhvTBpC+NhF1hb+86/NZ+/yvM4Xw6f6E47U?= =?iso-8859-1?Q?8zC15kRfsbDzuzFMNA6XN8jPUSbXvNrOqzQWhuolwk8+O/RLS7CCbW0EM+?= =?iso-8859-1?Q?l65pB8I/78y0vqIbLhD12XfcWnxMgnjO9Tvd3yeK+oW3SawzUtOSTWNXKI?= =?iso-8859-1?Q?69ljTeeFC3JqIDIKytwMZAmhmUxGnX/nusK2d9CFhSXVrlaKRBuqENYsfC?= =?iso-8859-1?Q?3xzg0lq8Kl9u7n3TbktJWhxrp8l9deIAFZgq3ni3rUJu2lCUTmP52sWvx0?= =?iso-8859-1?Q?IdQM037wOBj7xM/wEsSjbGKWthND9S7/A6y3CS4eb8Ly+O71tY0I3UcQz9?= =?iso-8859-1?Q?5lhcGM1rRObGgGN5WVFraQI2pOqbBD66DJfmJ/nVw+ASZqIP0LGy/mNFAJ?= =?iso-8859-1?Q?xGQNxDDazfjEMIOsSVfLQs+b4fN1wCamcnESnBKzThMROrnr/zNsoGwW/B?= =?iso-8859-1?Q?Ci2ikLDDsv4C+sKFxkoOi9fXKRg8LvYtt8j1sxYANTp90muziEBEOHoigE?= =?iso-8859-1?Q?DSiXXuGvSThg3hoMOto9yoiuiKYFOpdTgpKOmiIjBsB2EQfh5pB1jDkiKk?= =?iso-8859-1?Q?nJoFCwu10nXVRGe0RYLDsjffaHvBSgnRaqbeaYwNpoGJXJZzeALQ1u3VGn?= =?iso-8859-1?Q?KqAQ9Yh3CAHp3WydGB12q8v4QJkGM4UlZg+r81Fdr76A0KAnl7qfOswZiQ?= =?iso-8859-1?Q?1tYgWo4cfPyJIkocCejqocKirY+jrYkUZZOAzU0kI3hKwDY4Ljk74KHfq6?= =?iso-8859-1?Q?U7qlfexNk+Sb4/KU/YMWqvHZh4G2GeWkJKJQDk2FAefyx6jcIeah50T8zO?= =?iso-8859-1?Q?lxg93jrDUQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: HE/xAaip8767WQeEh3tvTJRKcVCRah0OeNOPExoLV6nK6CvPOUVrEe4IA4KvQBoQFVReB0FwZwS0maZWddSJ/oQIbYpw6x/dwKxqjskD6X8RH8q360r0mIGJh9G9RUZcd+utr0GetHCQCV/OZZvfDRKIO5mTR3V56CNoXJOoxrGl7C/XFic7jItHQl6vg4KPf9Fj8mjsLx7dZzFKnl4j3iJPgr6JxUX9YK8MZsKpizp00o7nNCsrgREphUesNYk4IlSVFtNVKyOi2yqA1Z1n1FMdGnbPa61B7OMHqyoKngtIcRh8dUNjjMN0B2Sq5DPpPLWbu9LdRzbHwOzRT2tghA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49588668-c0b5-4867-2908-08df282c4f3d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:48.1864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PkjSt70cWYnM1QsC7MwJ4CylsOn3aIzZPoqpFLJayGJJedYAmD4qCmjGu+F7krp+ztB3kSa5Tt6lohsP3tJc+R3B3QGX+J8UiYuFWSjN75E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787626174158500 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in AspeedSoCState. This made the variable names confusing. For example, AspeedSoCState has "udc" as an unimplemented device, but Aspeed2600SoCState also has "udc" as the real UDC model. Add an unimp_devs table in AspeedSoCClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST2400/AST2500 to use them. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_soc.h | 1 + hw/arm/aspeed_ast2400.c | 25 ++++++++++--------------- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 38226d9b80..8426134223 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -190,6 +190,7 @@ struct AspeedSoCClass { int ioexp_num; const int *irqmap; const hwaddr *memmap; + const UnimplementedDeviceConfig *unimp_devs; uint32_t num_cpus; bool (*boot_from_emmc)(AspeedSoCState *s); }; diff --git a/hw/arm/aspeed_ast2400.c b/hw/arm/aspeed_ast2400.c index 79a653f65f..fa2782da61 100644 --- a/hw/arm/aspeed_ast2400.c +++ b/hw/arm/aspeed_ast2400.c @@ -23,8 +23,6 @@ #include "system/system.h" #include "target/arm/cpu-qom.h" =20 -#define ASPEED_SOC_IOMEM_SIZE 0x00200000 - static const hwaddr aspeed_soc_ast2400_memmap[] =3D { [ASPEED_DEV_SPI_BOOT] =3D 0x00000000, [ASPEED_DEV_IOMEM] =3D 0x1E600000, @@ -134,6 +132,12 @@ static const int aspeed_soc_ast2400_irqmap[] =3D { =20 #define aspeed_soc_ast2500_irqmap aspeed_soc_ast2400_irqmap =20 +static const UnimplementedDeviceConfig aspeed_soc_ast2400_unimp_devs[] =3D= { + { "iomem", "aspeed.io", 0x1E600000, 0x00200000, -1000 }, + { "video", "aspeed.video", 0x1E700000, 0x1000, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast2400_get_irq(AspeedSoCState *s, int dev) { Aspeed2400SoCState *a =3D ASPEED2400_SOC(s); @@ -239,9 +243,6 @@ static void aspeed_ast2400_soc_init(Object *obj) =20 snprintf(typename, sizeof(typename), "aspeed.hace-%s", socname); object_initialize_child(obj, "hace", &s->hace, typename); - - object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DE= VICE); - object_initialize_child(obj, "video", &s->video, TYPE_UNIMPLEMENTED_DE= VICE); } =20 static void aspeed_ast2400_soc_realize(DeviceState *dev, Error **errp) @@ -259,16 +260,8 @@ static void aspeed_ast2400_soc_realize(DeviceState *de= v, Error **errp) memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_SPI_BOOT], &s->spi_boot_container); =20 - /* IO space */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem), - "aspeed.io", - sc->memmap[ASPEED_DEV_IOMEM], - ASPEED_SOC_IOMEM_SIZE); - - /* Video engine stub */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->video), - "aspeed.video", - sc->memmap[ASPEED_DEV_VIDEO], 0x1000); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); =20 /* CPU */ for (i =3D 0; i < sc->num_cpus; i++) { @@ -542,6 +535,7 @@ static void aspeed_soc_ast2400_class_init(ObjectClass *= oc, const void *data) sc->uarts_base =3D ASPEED_DEV_UART1; sc->irqmap =3D aspeed_soc_ast2400_irqmap; sc->memmap =3D aspeed_soc_ast2400_memmap; + sc->unimp_devs =3D aspeed_soc_ast2400_unimp_devs; sc->num_cpus =3D 1; } =20 @@ -569,6 +563,7 @@ static void aspeed_soc_ast2500_class_init(ObjectClass *= oc, const void *data) sc->uarts_base =3D ASPEED_DEV_UART1; sc->irqmap =3D aspeed_soc_ast2500_irqmap; sc->memmap =3D aspeed_soc_ast2500_memmap; + sc->unimp_devs =3D aspeed_soc_ast2400_unimp_devs; sc->num_cpus =3D 1; } =20 --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787604; cv=pass; d=zohomail.com; s=zohoarc; b=Q7p1C7zXIGiGRjTHHgLWICE/3LnsOjgtpJX8G/rcBqEF8g8ealxguC2qDNp3WwuW5ETkN7bddgXBZAQb6YhW0C14gJS9trZFRSnLIQSDGZTbekVhl8WYsefdE5lKtK9x2EUzkoFQa79XlhAZ4Ai1v+eSMDuBqshYYl29hd/bR/s= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787604; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GHni+JWHMnmTvjF6Qba6EqDzI3YT46Uh6pXr3+JFu4M=; b=WS28y0S8Hq+wOLFvgiSSVq2SlDGer2mm0LtsI5xkvgDqGlZLr1EYlqNQg6+d47o15I8+SwiIQg0InQKN8cWQ+mvKKa7EIXzf6scZIyFlpTyn7+O2Rb6sBIQvrVsviIrYp1WDwy2ACJf462SxVdRt/0aQAEzjIkkMoTcii8D+nAA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787603851378.5883380871072; Sun, 11 Oct 2026 23:46:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mU-0001ks-3v; Mon, 12 Oct 2026 02:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mP-0001j0-7o; Mon, 12 Oct 2026 02:45:01 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mN-0006MT-De; Mon, 12 Oct 2026 02:45:00 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:49 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xM/6mPccPgP9eUuu/8m2/KSONo6Gv4IrPB1I151pzQTguMpCRalSzC/3PdPmbLekfPABej6+bJw9fBng24C2fzKtylzodtNse4KnxUkZK6YjXFx0Lrd2dwHCnXpgAYr5fsXgyNBax7PiU8AslHZ+5KSsdmdPamSwcULvatKiocsNiFI6zDZ0CUopmilpVfOrlnOb3XvnTH65ZZe5mZFqGi9qgbAoNtKXepXwQmeA8052itQpFkd3rkI2a18qVRT525QDs3LL/2NuBurnrv5k13p0GC0Ee7DeMVfID1/ezN1pFYs4HN1J7AAXKw/4apulLroY7124C2dYcWu+cmNfIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GHni+JWHMnmTvjF6Qba6EqDzI3YT46Uh6pXr3+JFu4M=; b=wvrvkLvw9vPxcosO44kRZK1yFFrYARqgWMN+PUb+4E8UBw1aCBGweRTKTlCxh12zt/IOByS9XL50D0Ncv5M9o/7QUUMItLM6F72oDT34xu1kvyyeJVDcvPM4Q3jtDSVHqgKvqXdDdLdd6ojHxOqwTplozqzsBURhlVybvfwc/6cqjQ7O8fmHmFzGBVYvfuSxM3HeUPaFdP2TxxzB871t4tABYTZKsSdg+rLqeaiUfdsZzl27WjlMzN/mx+59896DCRhzRil2EYs9pILVNQ+QuxKzKhbexckZL+C3cUFAeYl2q0AZN7epLPOWncgW7T1C3kODA93Kn+d9YQoOW/h82w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GHni+JWHMnmTvjF6Qba6EqDzI3YT46Uh6pXr3+JFu4M=; b=mkmhRuz0rTNkviaLjg+S2VtsJYKByTzfp6zsTfeysKGOovHD/s8SXKoWZwewbSnIIVTfSr6rgBsZu4ooyq5rGL7V9XdgOaoRV93H3P3nx/UiyetDElKfT5/mSxSPDrxkbddeZEvf+Zf2RfNoHVqcetQKi2BWdIPWWqTIhvY5ghp1w5ZNxggc1Bau7bv9zMQAbxN2NMBibvhoMdkweY5yc6STHFbNSAnkIYviNR9c85gMy1KBseyoJzT3VOxbLMFJ/66Xe31V/GRHTqlyrpFiPVvfafE0PpDxkwwpSSjmkfNIaBbOsicfyHXSWV1EiB48rTdIc9wltASdYhrvd1cE8g== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 03/12] hw/arm/aspeed_ast2600: Use a table for unimplemented devices Thread-Topic: [PATCH v2 03/12] hw/arm/aspeed_ast2600: Use a table for unimplemented devices Thread-Index: AQHdWhUt0k7GyQbC00CUBhE97SHkVg== Date: Mon, 12 Oct 2026 06:44:49 +0000 Message-ID: <20261012064445.2571633-4-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 739ff9fc-d32e-4c9b-131f-08df282c4fdd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009221227099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: 9S99hyfrgPGI5CKTOLwQWwiZaM2dBOfNBZv9nA2fUtnZ8vY73LtS4JVqXBbGgaaT5P1XCbZDgIIcUt0zwYP7WoUwAkGy9UlX8MRJWK9xqgU1xj83VU7SLo7FinzFa/EQHPulltyxFeIpVw8IT4x4Ox2FYKfVTrqgwSuRBnFOXtKAZE4gO+BxLrY1BoTEQ8vcchWeT6PxIEtPI9g7GJ3hEoceKe5YJ3h1LRTqrfWI+F0yxQuxKMndK7iRVefSpOkY9alsN5cNh+anhlqnk+t2nYzZrjgIyvcanBjKxwE+UlEJ/hBxnQ2YK3q6WMbiP0gvxChYVJ1tXC6hK4YNii4rhhXvo5BBLTowzrQ+bH3r/JnBHWsqPUP9dcfYFDA/JdlYRwUCOq0RgVib6W+nwyV8grTQTadV43i4eRPSv2kVQTfoty6kMkwDTmrsKWPJ2A40zvmZxdkVlCHv+u8/kMzVTkMicRvTXwbCVL+VpqQxlWhCf1oMwwOMicw4jBBk8rYl1RR8DXz5KUm03YQHhHVi8wOJ3Agg+H2KEjt9JI/3yCPqBhgRzbHLN+Ncusjq3ScKR4V2zMEqt2Z/NMS209IIXHMHGlQnNDQlDJCUCGrU/M2vb/rbHRwoRuiEgnacgMN7xiHKUhkHc2fgTroxoUAbTT+6wkhum8eMj0mT5xiGjiguSFvjESRg7KG5Nn9SBdCponaGQOcH649txw9pEypg4I6p5u3o1Ckju1TIBMqzbLjLE1Ro8SK8vwSrsahfJh0w x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009221227099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?hbAoNEQ3xk441EwI6T+7HIVl2OrF1pDkV+tgrQJ2tUE5uX3nepAr+hCnP5?= =?iso-8859-1?Q?wHL5hU6MU0b9Xcr3p6U3YwndR5+0z8jPYOJXyZaht4EFmBB3e5oNHzC0w5?= =?iso-8859-1?Q?69u1HgPMKtwxy6ttOYn12yAwT5gPkFWBgusagFZBUkEETE8u80GQmyqec1?= =?iso-8859-1?Q?IlQ6lE95A2LqKYfwR4zP46Kg89F/yF0RCSVTO7+LKVQdekBPisx1mYKcJQ?= =?iso-8859-1?Q?65QbF+j7vEjqS9031YrIvkLYPfpLIcdix0vO65Q2xeW1U4QWyGFjwv0UKf?= =?iso-8859-1?Q?/fKhmM3p4N+9ntGfRrzqgU223F9LJ6z/dukqCYpS3eACGwu27Zr4YmWuL0?= =?iso-8859-1?Q?X+HDfTUhzjhgAxTLlSe78TgdLVj8I6r0tL5ibH9/a2z4OfwVwpofKDaU01?= =?iso-8859-1?Q?0cSiJzZuJZfv94LMDTdBOEviX+niq7lGl1Ek7yJ6S7Dv3l4cLF3cVWRfn9?= =?iso-8859-1?Q?VgsWCGbA0VVaceDrmKDNBd7k0c9RVK9Ex62gOZqLkXZzUE4eL6C6xUagED?= =?iso-8859-1?Q?zcOFZWEJebNENW9kfgwBBzmBFfAgkjPci5cFXvLfiIOW/xKb4NcKkwFx7F?= =?iso-8859-1?Q?G7HCmPUcjB0uyqSTfmUat8ZuSz1yjbTemUKEO/hZDpXOzMfMzs59S3U2wI?= =?iso-8859-1?Q?6D25kHlZe5d+zteumfreIRV8rVDhjNWsFQ2Sl477AD4Q4f5fSuNM53ZA4d?= =?iso-8859-1?Q?IcfOYbVDr4FSa2xJXA94Zsvd1U9XW74l2xGdrG8QMU1h4axn2CWz/0NEOJ?= =?iso-8859-1?Q?vdUsbiwe16NlDpK+iMV3Cy7kPv3ObELJUENboDZwQTY9JTQxMnWRgcfLEb?= =?iso-8859-1?Q?+zY5X1uUkGqHu1jYBOLPE0DRtCeK+Qbk0hpx0GGSMGPL/z6bY3A9VDWuR/?= =?iso-8859-1?Q?4QApenCwzMG3x9NvDylZyfBRZPxeZ67MfRfx06nleEpTNKVJ1tTaKvf+KA?= =?iso-8859-1?Q?3TXJFymM8ofTw1tUdUyZRWrhXJcqF62ayeHq9v26cgUD/eRC8pMRDgWAIu?= =?iso-8859-1?Q?JBd+RsrpR1sN536VvW2zTHTD2CE+O4ke9MvWLmqH+PstoB1TbRLeKEYBGM?= =?iso-8859-1?Q?yVB0Voqbwug17RGppGCghwJjOm1AfhsZhnBO/pOBW+/bQ4BovQ54j/Eqtq?= =?iso-8859-1?Q?ihgxwur9WfvH5bbrkQKctrpyvz7ukO0CPuRDP9qgU5qF91uLVs/YqdJZG2?= =?iso-8859-1?Q?3smH69DGctCfZhBhg2CU2Of6YpYHH/s/b/3QVQaz+nOmvxGvDiBk9J1nWb?= =?iso-8859-1?Q?XwEV5HQAV4GBcXMfYgb7jspM9lBGwsD3zHiDdpeZ9LbjXOdlHa3Kv4yOlf?= =?iso-8859-1?Q?y+OpHsBMl2KGjX91C2MJpMJJHVUdcHTfXE7aGbZptXmcENTin0fOXjb0aS?= =?iso-8859-1?Q?TvJS3JksEjti7k3MaUliJTFACNTweZmDYDFMfrgSkxOfIXx+oGtbfQcKp5?= =?iso-8859-1?Q?a9Ni5GtVVacarAi6c9y9lvEuh3bFufWjmQlH82e1ekxefT3a0zMYQLa4Fg?= =?iso-8859-1?Q?TVda0x5fQRRXygAT/OUt7cDestYYFJMiiL/7RnOZC5sOxY1yfO8eu7+meB?= =?iso-8859-1?Q?qdmbOnOKsltBzAcn23/ib5Qq49oIHB76c2xJJr2uyEtfPBosDF470+8Zkg?= =?iso-8859-1?Q?53r7fzr9uMDBpK7a+FTFr1S3MLdSm/pCqc6/KJza38iuOlUFpYPvS6h7gq?= =?iso-8859-1?Q?Y22GAPzlGhWyhyLj8pGcTQllH6EDJz+B1Ci0ZXJO1++z3KuwkfBh1wyC46?= =?iso-8859-1?Q?Lz56mj/5I+lCy8v8oCGzQ6UgK5DaIUhhjbgGbjwAQFa8VVtvJ26aWJ2/3G?= =?iso-8859-1?Q?FPDJPDLtuw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: XkhxTmUEsSV5eZzJEMmIoiDVKTWFiyslG80deELks+SD137RyR2dX0gnqtcFatMKMKHHJqSsCxOhpksd3Gz9yidOzcMBQ1tN1EUuoLqWVzxd5fDtyfpL9/8ap5+hd7+uKU0TgeOxhKPjEnX2qpCw8VP8IfQZOuGsTiBf9aA9yExzAZVArCkXq3dWEdLjcC2XQsJYU5o0Pd++RYxLypjGuF0brKSiuQITb35ijNrrsTlsmvE9SyAHwSH4BO5mdlnbv2WyKfuXxbMyzRtmnMxYA2xsjqvPopC6E9qME7gZmP/bMnfYLRTHsJPfPompzyvnyjDZ8Kn3IyDF20qMa0AoeA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 739ff9fc-d32e-4c9b-131f-08df282c4fdd X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:49.3089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YKhJEWQ2Phief9ygQNApB0OC/NUW6FKr3Wc3feVUMm7gD6tkeHCyzVs6dugA4RNqvSlzdEFzIYF4ozdB79IYTLv613Ck1zKch71p95WD4Lo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787605796158500 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in AspeedSoCState. This made the variable names confusing. For example, AspeedSoCState has "udc" as an unimplemented device, but Aspeed2600SoCState also has "udc" as the real UDC model. Use the unimp_devs table in AspeedSoCClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST2600 to use them. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_ast2600.c | 44 +++++++++++------------------------------ 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index 1a10d0fe1e..ebaf07d312 100644 --- a/hw/arm/aspeed_ast2600.c +++ b/hw/arm/aspeed_ast2600.c @@ -19,9 +19,6 @@ #include "system/system.h" #include "target/arm/cpu-qom.h" =20 -#define ASPEED_SOC_IOMEM_SIZE 0x00200000 -#define ASPEED_SOC_DPMCU_SIZE 0x00040000 - static const hwaddr aspeed_soc_ast2600_memmap[] =3D { [ASPEED_DEV_SPI_BOOT] =3D 0x00000000, [ASPEED_DEV_SRAM0] =3D 0x10000000, @@ -149,6 +146,15 @@ static const int aspeed_soc_ast2600_irqmap[] =3D { [ASPEED_DEV_ACRY] =3D 160, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast2600_unimp_devs[] =3D= { + { "iomem", "aspeed.io", 0x1E600000, 0x00200000, -1000 }, + { "video", "aspeed.video", 0x1E700000, 0x1000, -1000 }, + { "dpmcu", "aspeed.dpmcu", 0x18000000, 0x00040000, -1000 }, + { "emmc-boot-controller", "aspeed.emmc-boot-controller", + 0x1E6F5000, 0x1000, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast2600_get_irq(AspeedSoCState *s, int dev) { Aspeed2600SoCState *a =3D ASPEED2600_SOC(s); @@ -282,13 +288,6 @@ static void aspeed_soc_ast2600_init(Object *obj) =20 object_initialize_child(obj, "sbc", &s->sbc, TYPE_ASPEED_AST2600_SBC); =20 - object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DE= VICE); - object_initialize_child(obj, "video", &s->video, TYPE_UNIMPLEMENTED_DE= VICE); - object_initialize_child(obj, "dpmcu", &s->dpmcu, TYPE_UNIMPLEMENTED_DE= VICE); - object_initialize_child(obj, "emmc-boot-controller", - &s->emmc_boot_controller, - TYPE_UNIMPLEMENTED_DEVICE); - for (i =3D 0; i < ASPEED_FSI_NUM; i++) { object_initialize_child(obj, "fsi[*]", &s->fsi[i], TYPE_ASPEED_APB= 2OPB); } @@ -382,22 +381,8 @@ static void aspeed_soc_ast2600_realize(DeviceState *de= v, Error **errp) memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_SPI_BOOT], &s->spi_boot_container); =20 - /* IO space */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem), - "aspeed.io", - sc->memmap[ASPEED_DEV_IOMEM], - ASPEED_SOC_IOMEM_SIZE); - - /* Video engine stub */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->video), - "aspeed.video", - sc->memmap[ASPEED_DEV_VIDEO], 0x1000); - - /* eMMC Boot Controller stub */ - aspeed_mmio_map_unimplemented(s->memory, - SYS_BUS_DEVICE(&s->emmc_boot_controller), - "aspeed.emmc-boot-controller", - sc->memmap[ASPEED_DEV_EMMC_BC], 0x1000); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); =20 /* CPU */ for (i =3D 0; i < sc->num_cpus; i++) { @@ -469,12 +454,6 @@ static void aspeed_soc_ast2600_realize(DeviceState *de= v, Error **errp) memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_SRAM1], &s->sram_container[1]); =20 - /* DPMCU */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), - "aspeed.dpmcu", - sc->memmap[ASPEED_DEV_DPMCU], - ASPEED_SOC_DPMCU_SIZE); - /* SCU */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->scu), errp)) { return; @@ -838,6 +817,7 @@ static void aspeed_soc_ast2600_class_init(ObjectClass *= oc, const void *data) sc->uarts_base =3D ASPEED_DEV_UART1; sc->irqmap =3D aspeed_soc_ast2600_irqmap; sc->memmap =3D aspeed_soc_ast2600_memmap; + sc->unimp_devs =3D aspeed_soc_ast2600_unimp_devs; sc->num_cpus =3D 2; sc->boot_from_emmc =3D aspeed_soc_ast2600_boot_from_emmc; } --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787610; cv=pass; d=zohomail.com; s=zohoarc; b=NJKtg9zLkMhZcF+Twop20wCQ4SRIgzHjPjQzskL/4fbH3qllejQsFAUD7ObPee0BMAogruyo/JAelkTcizOT2IYF7sMTAgj86CEDYe1TT5b2ktTy0642Qw1fRLd9I7gTjPKAeUKQAredc782xN9gjOoDmDsHZtbiCR3BJpMxCEE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787610; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V5uC+u26CxmU9tcBwQ+VQCuJD1i5gWinZRYDog6jts4=; b=CYK9dGZ9lsxkxom5XQqh9890XAnmn1cpPQtb+hUF+JFyRY0IGs2C3pVopmYvVbwoKDUwgHOSshkRpC9D6JoPkFVw5qTz3QJ/h9hd4slo7Ld2ZoTTSabgVzavu6Ep0HtE/oj89t1i6gnMLV7J3CJ08OStWBRgmje8y5DCnRjhaLM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787610462494.23932107018413; Sun, 11 Oct 2026 23:46:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mV-0001lc-Id; Mon, 12 Oct 2026 02:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mS-0001k6-2H; Mon, 12 Oct 2026 02:45:04 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mQ-0006MT-5l; Mon, 12 Oct 2026 02:45:03 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:51 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vDOJhM7dnN4/1JFlbftT6nXmJ61+W1qh0U3w1R9qEkfCQwPUzUrtcb+DqUapwaNR3LbZzbAC8b5wbyX5ZvDK43MiS2pyY/uByTSkvxaa2yAeGY6G1F+2aR68jX7sNkD82rmgU9ei6KvLNjW9wB3WyJ/25P4iSQmUgWq3yvefCAp/FDO6fdHh9ioMq7FiD1kfE7Ug3TpxI1OcWbur6KcUwf0rdJKHQOUADaX53nClmjCm+sUIgBfxBxQ877DzuryjgBHfv1Y2XazALy+9DEcwLy/CKqGB60Fw6uajjy23JUvtV8uA1QFHOhyu5vbfqRNLceXTS1D4ARkdvT6JSKNPpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5uC+u26CxmU9tcBwQ+VQCuJD1i5gWinZRYDog6jts4=; b=ARIDiP/7Y0HBrESOBgl6Lb0O0FYS2DfCKDFdUh4B/W6bSntxGABvxRWgHeoxSJ+ux12vhmVGFLJqMlw+pU99J5PAmezIN4DVpkx1Ob+wTArdCyISNTLrECCclf4dVbNzMh3afmM2qml9lJeVIChyMTlB28nuQez2m036lXuJt8RoinFDBIVM1Nj95G+xm+JjfLnbpCbzdsarM91FjWIy+Esq2cizvKpSCV2XoVwjuvdbUAWvMq1ob/9K2L+WfGSTxlJ9uw059rBuln31U6BIzMcy6+ApVCZaarCZ/QnkIIAqXtQpgc29zvWYoMIPHh5n9BvJBvDTymPiM8matKUsqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5uC+u26CxmU9tcBwQ+VQCuJD1i5gWinZRYDog6jts4=; b=qPtp4gcyEXtGQDsqKSPHJfuHfryTn7lYsfkK21BYFFSrmeL0929ENQPmKb96z3CPr7de0xCIO4BicdlbQLl1aH+IsTdkA57OoKzT4hOSMczm79MW3Mc/FtxaBnP90qMc72bG60RgchNsBcIHOAavUM3dGRuprM1AHqGVmcydDYd2Pj4xR2ZJnEASt3UdTucdTPL++akzyO9A5h5vWCBv1Omn1Zt4UoXbuaavNsoFTo9kHTRR/U3+1j4FI6kNfRM9NWRl3Y4BXZJjSS4Id+gDVO0ua0YTM5pNol8FEMFnpJeQKunT13NX71JgToD7BZZwCXHyqJ0AAOzx96TUjxw6oA== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 04/12] hw/arm/aspeed_ast27x0: Use a table for unimplemented devices Thread-Topic: [PATCH v2 04/12] hw/arm/aspeed_ast27x0: Use a table for unimplemented devices Thread-Index: AQHdWhUu7qIl64TSWkSMtNags/llkw== Date: Mon, 12 Oct 2026 06:44:50 +0000 Message-ID: <20261012064445.2571633-5-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: e29bf27b-fe1b-4e8f-8ff6-08df282c508a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: uRD8/KWBZecoyqdJrgiVrI7ONFpQQyLYDNFByGVkeyMDqQXBSx+QrgtZQjWO6+z9EUDlsWphsMxAuConOWjyudELMm6FKTcd5U1Y8UY3KGizeSgowXG4Nco4DcHRFpPsvmatVhgjE7JrjkZoxFwU9+8Qg9aHYq0l34GQ/I1sT47dPYK4MWCYH1z3itdmmMZgitBOrp1dWe1ImmDrMS8KnE6ZoYSrmaFqO3o1fco3PK1sUprWChqsKIlr107lhXBo36O2QOthydU7TkQXNvExS7TjgO0/pp/Z30n8eCwRgM7vmnSbU9Wjy2K8ecBJsXtRbLI308NirnfvRCJHoDIbSLuqsJtbgP7AZ9nUEQLoRSlB8zElHKIbYNBlF2OCUKF2enJ6E8DBjIXGSvBmDKNDK5QqcRKY953sj140qVHs3A2h2opyxCQdecs4PtqTPnm/YfPbFgaXceqNlLL067Le91RPH9LO2dczshOYMWp5oYcsMRV6V5wDU0iFTYlaTKM8bOHjIByxTpiRleS12tTL6PsdosTLaYpRqC448kafnDeXYWBUT1xXa4sUnGwwFeqN902SqQ2YIzVknOiR0SDflAOkm0WbO58BRbq4dO7rEA+KCNCSGtnIVcX25ITYc5r5L3CU19L2QwZ2DQyGrBEMoxOdMOUi6QkN2ldzcyPSsGf6qMyrrpNHa3fsE+SV+0PrQi3ajDxRgiDqCIbzYoorqY39izTw0GOY+NG7vrpxtq8Dv7J5RahlggKF5KsDRbFO x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?V9iayTCTFi5FIV9uuD21oe2Zfz9+6VuEyot8nt4jC0SSdWkNkWVAAOC0de?= =?iso-8859-1?Q?sajg56qKuxWAhYpg5bxsIoKApLfbuNUQz5xuI38ktRClrCMVADQKiXIrpO?= =?iso-8859-1?Q?z6FpNAlSx9UAq7Tlqh9DMdrMxd+buzeuqVhG9W1RNwOHRmNnfGOWOEyOLO?= =?iso-8859-1?Q?POZmgtUMtvXHrARsG/BAW+SDdoKpBi0qhxhudDU5hryhcHDj7OMjKp90A4?= =?iso-8859-1?Q?ZoK7G0tVQVk3KrUw4i5W6Co9BcHhixEXCsw3fUev8L/EI58oVMUdIrBbRq?= =?iso-8859-1?Q?edy9rHhnjHiacpaUjMaYqJHe17+Ie/LJ0wrw5HCU7FXjrH7KgK0Rt4fZyP?= =?iso-8859-1?Q?3CqazF6ZldyvIS++7ga6kNraaz+3KyvtCLYWzkzpLmtQXiVy/GwXehxi7S?= =?iso-8859-1?Q?yJaFZgaTNNTQeho9/sVpzqtHYZ3HKFfGWeH7aWEffJAoG9hcOdG8MF6cST?= =?iso-8859-1?Q?dO4WZH2WBJhc1ixTj7pdCxo5z4YAURdN+jHmoIFEdaUOqx7Y+ZRTMZA/nA?= =?iso-8859-1?Q?2orEYAdja+3fYEiDkXGS0GlBcc9/ivVeN07THq4tJ9LdkCER3JyJeL36Cp?= =?iso-8859-1?Q?EXx2YOa5yjIPeZlPW+N5/rA2LTWOaBZMY71UuWTvX0GyyRb6XsMvkgRhSq?= =?iso-8859-1?Q?1zhqCadWzL0h36ACYDa+cu2AJyE4p2VKz88BNk0Nu92bJURO8okHlESsWa?= =?iso-8859-1?Q?w9M69suH5JoCt3D6AR4L2SuyxNIt6YisIOpEpQ4FLtmvkolVpTW6q0h4dd?= =?iso-8859-1?Q?bHVTJvc9B59grg4mozVlcqDpKLINtOIvUR1gSExjoIHS0wpVqEO0Nyd0LG?= =?iso-8859-1?Q?zg1C2rJa5+wlutsVUYzZX5JQS/2MFmYB7eqEcF6l4RURwxsbG3FykzrX8H?= =?iso-8859-1?Q?uClCIq9bYhMJCBzTlse/sltXGnAOvqEUa3Xa4uRvdRyVrCOsR77slhYbaO?= =?iso-8859-1?Q?CYgK2GOUxh593KHSr43xiNZD+BLOnLAdFB4mC70jTBRTurofHs6Ho03sWD?= =?iso-8859-1?Q?lSVEw1s5RrDEH6cjQ6j9rqo/g8kByoqZXJFJZ3VhR4agli3ko9hQ/BIX28?= =?iso-8859-1?Q?fZSlLDXWAPEtrHaiQgyNtFLJRaB+p+GBn5Bpqxapq+9GhgEPDJaiwGj8gi?= =?iso-8859-1?Q?GY2s85dSgy1vx9oh9WKZCuUBjWcWFyV3NDPXQUcdW51bYqAvlt+59XkwCp?= =?iso-8859-1?Q?bBU7W4s4b+zOHL3FD9fkTkN+i4+eMNH+YGN2hxolsjFbEAR1ijFqk61g0m?= =?iso-8859-1?Q?uBQiJJqAyeQ+4MwvkSprx9qNBi0ncSHRQr6W+hYEeQ004G8dfvzsekxRfF?= =?iso-8859-1?Q?spTVKpPyt7iRzUDnpoYjdxH7Og8nl7bfEutPektZzaddE530EsVq75BNdP?= =?iso-8859-1?Q?7R/7pl/2cWKPCGHw8V56QfLKXh98AdB68BiexjyIxcwyj0maYvCb112Ygt?= =?iso-8859-1?Q?F27qbsmYqcXMpYIwM2xG5HgbBMKBbPRNihekMK3zxUmwCsMvs98ePRm7vV?= =?iso-8859-1?Q?zh8UoHs4rh1toN0pKWUFhLizwqjjGxCFD16Ky1iKZ2DGMlTb7sptGPK26R?= =?iso-8859-1?Q?5jOACtXdmC/QniDxzpJ94ODjs3umQFa1IvbKYqGY3y4kcghYlIHgJKqy7A?= =?iso-8859-1?Q?y+HBIz6Iz8AqmGR25LJqudyujSSPBbBrvmJGyNHfKR3APOFmMillWxeHVk?= =?iso-8859-1?Q?fMVLcYeCGuncu0AVkd5HTE0a9K+2ao72K5C5Yl213darzuD8HtIj42Vu7r?= =?iso-8859-1?Q?qZR+KVQvIblGsZFHIHkZ1Zf0HUh/0iVjpSfsyKzTTglyBq2IeE7DnItgig?= =?iso-8859-1?Q?irhFDd5deQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: 0AZVLMWwX9itYC/Cu9ndDof4Edcubye5SpOpaHovRpXNhj1gLNSGn+TZrC0Hoca0cq2xAS0ydITT03gxOHo3N/57ucfbwZN7wIdewKWZ0oolqVNKCRKfW+Hex4poZBkpZvms7dtkbweWPHDXdvlekgt3L9qiqMUXpa/ENjktr4x1tJn94XecTvv6tgMW+1ySe1I3Ed7i9HY5whVJgcXQ+Da+LaOYdKAifNFSGmw4sYYQMBUUDgPBqtCQqd6ZxPScLm8unfjedTZD//b0O1RKPoZ9yDX2sFgTEJKPa0csZ8O4qTivGmin/+1jVeHRzcJ1Xfn6zovoImp3aZ+BFh20Wg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e29bf27b-fe1b-4e8f-8ff6-08df282c508a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:50.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: moLr3X5IQjsDnmyYvtIEwPR16Q2DPTeD2MiRNL/ZE+ui1RSVNYd1BFszvieGjjROJ70ftaSJSwFasyJXojPs8Z+rYJ2EQl/MsR3mzjItBFM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787611890158501 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in AspeedSoCState. This made the variable names confusing. For example, AspeedSoCState has "udc" as an unimplemented device, but Aspeed2600SoCState also has "udc" as the real UDC model. Use the unimp_devs table in AspeedSoCClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST2700 to use them. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_ast27x0.c | 41 ++++++++++++----------------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 6365dbd638..2ef29e31e9 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -24,10 +24,6 @@ #include "qobject/qlist.h" #include "qemu/log.h" =20 -#define AST2700_SOC_IO_SIZE 0x00FE0000 -#define AST2700_SOC_IOMEM_SIZE 0x01000000 -#define AST2700_SOC_DPMCU_SIZE 0x00040000 - static const hwaddr aspeed_soc_ast2700_memmap[] =3D { [ASPEED_DEV_VBOOTROM] =3D 0x00000000, [ASPEED_DEV_IOMEM] =3D 0x00020000, @@ -263,6 +259,14 @@ static const struct gic_intc_irq_info ast2700_gic_intc= map[] =3D { {201, 3, 1, ast2700_gic201_intcmap}, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast2700_unimp_devs[] =3D= { + { "dpmcu", "aspeed.dpmcu", 0x11000000, 0x00040000, -1000 }, + { "iomem", "aspeed.io", 0x00020000, 0x00FE0000, -1000 }, + { "iomem0", "aspeed.iomem0", 0x12000000, 0x01000000, -1000 }, + { "iomem1", "aspeed.iomem1", 0x14000000, 0x01000000, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev) { Aspeed27x0SoCState *a =3D ASPEED27X0_SOC(s); @@ -558,15 +562,6 @@ static void aspeed_soc_ast2700_init(Object *obj) qdev_prop_set_uint32(DEVICE(&s->ioexp[i]), "silicon-rev", sc->silicon_rev); } - - object_initialize_child(obj, "dpmcu", &s->dpmcu, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "iomem", &s->iomem, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "iomem0", &s->iomem0, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "iomem1", &s->iomem1, - TYPE_UNIMPLEMENTED_DEVICE); } =20 /* @@ -1137,22 +1132,8 @@ static void aspeed_soc_ast2700_realize(DeviceState *= dev, Error **errp) } } =20 - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), - "aspeed.dpmcu", - sc->memmap[ASPEED_DEV_DPMCU], - AST2700_SOC_DPMCU_SIZE); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem), - "aspeed.io", - sc->memmap[ASPEED_DEV_IOMEM], - AST2700_SOC_IO_SIZE); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem0), - "aspeed.iomem0", - sc->memmap[ASPEED_DEV_IOMEM0], - AST2700_SOC_IOMEM_SIZE); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem1), - "aspeed.iomem1", - sc->memmap[ASPEED_DEV_IOMEM1], - AST2700_SOC_IOMEM_SIZE); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); } =20 static void aspeed_soc_ast2700a1_class_init(ObjectClass *oc, const void *d= ata) @@ -1183,6 +1164,7 @@ static void aspeed_soc_ast2700a1_class_init(ObjectCla= ss *oc, const void *data) sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast2700a1_irqmap; sc->memmap =3D aspeed_soc_ast2700_memmap; + sc->unimp_devs =3D aspeed_soc_ast2700_unimp_devs; } =20 static void aspeed_soc_ast2700a2_class_init(ObjectClass *oc, const void *d= ata) @@ -1213,6 +1195,7 @@ static void aspeed_soc_ast2700a2_class_init(ObjectCla= ss *oc, const void *data) sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast2700a1_irqmap; sc->memmap =3D aspeed_soc_ast2700_memmap; + sc->unimp_devs =3D aspeed_soc_ast2700_unimp_devs; } =20 static const TypeInfo aspeed_soc_ast27x0_types[] =3D { --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787563; cv=pass; d=zohomail.com; s=zohoarc; b=K7zCydjwbDq24qPRt7NXqJWYRNEVsgfRYPENIpQ2VxjfSOe5hJPOosfovZkUWSBuPfuG1ZewJgdULaxKjnbPzLbtcAtzgxfpGbs3t744rgYir2gzjE0QR1ER7o//q60wTgxfkUfpADursnKDgmmJachXXrRsAJtzKGdQU190QUw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787563; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mODzydoSRAiIa4JjXvmZnMSDoH0W6tEpC+oWX4ZjAeU=; b=nnvh6G6GLFC4bHOM6vv0RWbIUg+0y7n92magNyXun39/javwvLt7SkeeH7s97KSMSRcPRyTrzjEyOzwfiDrS/l2pi24H/olV1DvIeDY5sybmyhQMVR3ZKRNcAxqS/tuCp6locOzw25OU+4Qid4aPif85xIeDZHkgSuEFnw0zv50= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787563567875.5847401730884; Sun, 11 Oct 2026 23:46:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mb-0001om-KD; Mon, 12 Oct 2026 02:45:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mW-0001lp-8a; Mon, 12 Oct 2026 02:45:08 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mU-0006MT-5N; Mon, 12 Oct 2026 02:45:07 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:52 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n8rCijMJ6aCdjIaOtH/a+UcthiFkjwgiLa8hRgwIEVr5/RdAH+wSWXNh5ii5JJYwUxOj57rmmsjd7O5E44AiALzFN/gpqawRFseVLJasHkEclr27Ef5uYChcX/4G8F40eqkaMmw1JMvFaYLgrCt1hJ10m+RIwyUvHpCvlGs8245m0N8VHPNMCIjEC9IrzF59EiLGIsqrYP1f2EXX+vWIkqHGz0jE4jpK8IA5e2XjzoMGmYf7671ij7KQOm8liltWewGabtZ+RqoygsxVhOSjXAQw8X3sCwRMOa1DwTCFH5uZyio4rGbtcV4TenN+i11eSsP99wUw2gABLP/64OGeAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mODzydoSRAiIa4JjXvmZnMSDoH0W6tEpC+oWX4ZjAeU=; b=xAZmrYUMUKiYsxX42MtU63RmHJGE/r5eHoWA8FP1FN2hMF2EutxTx+D7BH7krBwp8y7SLE5rUBbX4fNHAxEXuanm/hZaTlxVK1HF11hCsqvNKXsX69gKGRpW/eFSxXF85zsAGMX5/Bgw3om8mBBvSIVZoeohn+dmxtVpR8zxUqsIIK7mw4ukI8EquO7+v0Y+0sLdwlBA5vZzrb+7sKvnLw65SJF5l/k5FcR/fue7hdvzseYtswEdU7aDEjn2nckS9Aep/uEo0TJCf5AOWz18ib3pBHR7OASyJm6kBs+78fJdObPPRFiel1hHEd0HxiTXtq7/HOwJ5XUDqXtLAmIFpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mODzydoSRAiIa4JjXvmZnMSDoH0W6tEpC+oWX4ZjAeU=; b=MFGRjJZVaNXSmmCYMjjtwW27mibrPOLSR2dQQx7eCFgtgItvZSeGqOVGylUB0jhOrz5skqSx6FGwBYGjKwgv//kR9BknpYblWCT3U9n+OYmYdxMCjYV5dAEQbOAl8jGfR2Cww8DQu+XTf+0sReUknrJItwH9RKh8mO0r1WoWa6uNX7/dC770kZIeBX710uIwfxVKX03+jEtWunrll1dWU7fGz86ZbHWNeuWgzkNz5OcU6bmud6yeVQv21uJzqQ6K0wBM8y56BxOpCKEZoKmpc7VH4JuC2t9V6zNqqI+UUEVhfQy8wlpeg/cFXQCrG2zcmsYOixa1pNMw3F3zQND16Q== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 05/12] hw/arm/aspeed_ast10x0: Use a table for unimplemented devices Thread-Topic: [PATCH v2 05/12] hw/arm/aspeed_ast10x0: Use a table for unimplemented devices Thread-Index: AQHdWhUu2lflTZKkj0Ws2IlOVog+tQ== Date: Mon, 12 Oct 2026 06:44:51 +0000 Message-ID: <20261012064445.2571633-6-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 45437a85-a083-4c5c-8d34-08df282c516b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|260925021311599003|260925022911599003|260925021911599003|10067099003|261009221227099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: gAuHFgyk/x0tep6Cd8/hb1ZYOOrBsdBoaqqVCUDoH95rZ7kxMOn3dwOF0saqg918HwDAwUnc8CUjRmtk3I2cFgVbUCW+tJ9sCP7Fh0puv5kr6X4ZdeK1W5SVquwrL3llJAn7WdjLXYBMl/y95PuZMsvG9yG+oHv5VGCHPsYhBWs3VRUHUCje0EBEpfq3rzABRLqkLC208dgmPhwHoxeOiZ+4W3BEVWFUXUywmbUdov0w2Q9PGdZWg6r9nFSjKB5iW9AY0nIAxC8StMr9ZZkRz9ngKs1w2zKnAJCuoLDg45G+vuY2zTbwak0/aK/TV0ksFqAj1JvyY2MxM7BF7Vk7oWsp7RE/o2afHOtG00H1jpQ4E8Nqck5AYkKMzRCz+DTOjH+ohBVh15rvd4g634opuvaxIFKvrCSZN546F6NsrXJi5nAqgCHUKtVgxgpfTVDSloIMJgWJiXH7QbpfhvIGL876ap6mX3y9ijxIX9WH26QEwVKBjnLFQYq9NEfBCF5/P5GfHcLknnPdEjABNMJBoNmwwmNlJQGZIfL1ux7bb27Cs5+6RGYbQHr2oT/FSR1KtL1J9U5ebvLzldigezO9uY/n8DxCCwIwLBnIwlM3WO8pSd262MZVj4qSMF6WGgUZVPMXZxgTI5Vy4iL8nyN8nnYCnpR4w7ztcD0+vG0Pz3YXIax01S9Bo5kfXB6L8825lZW7EI70USSjngPOKzAW+X2ay29fNMZ//9+bDKreSfE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(260925021311599003)(260925022911599003)(260925021911599003)(10067099003)(261009221227099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?sI8hAvl1y12l2C13UW0OpghUqNSMVN6jiHxQ8+2TlcqYGH69ZGQQLzweGJ?= =?iso-8859-1?Q?0W4hDqJMqNfS2cFh42nrSJ7iS1Lad5CSlNjhb5Nepx9Y3gItx1r3b7SUtM?= =?iso-8859-1?Q?CC1gRUT9e6y5vhsq0mEPiEzEEFhvPs8a12QiCMAnSwFyd3NYAA3qiDHcQo?= =?iso-8859-1?Q?DCFxT3/h5CQG4N9kB70IW/Pj6Z0udPHku6Y6mfg3VICnMcDsRevk703MTI?= =?iso-8859-1?Q?h+5+g2k2wvG8Nl9EOkOaC6iP2GXThiHI/aCvsnFg5eh9QY+1WYXjRfL9XQ?= =?iso-8859-1?Q?yE96NQ2z84a9fJJnCqE8k8pkoQY2p7colhyE/A1DOjQQL0A37RNn2+CEtW?= =?iso-8859-1?Q?H3X1OOXPDSY+AcEWyN4YaQ0gqwvGRy/PyFPppRQuxMYvx2wm36qduJRRTu?= =?iso-8859-1?Q?zahyT8amrLCx48kfJgzdQiDE6siQ5NulgeKnaMRSXbb4GF29GAUM/G8UQs?= =?iso-8859-1?Q?PLJPACZ5EvVPZyKo1rJqYe+ruGHUH061covOXvZpNjleJmPUY9iZNWCeG3?= =?iso-8859-1?Q?0H8p72Vfl5HtLvlln8a7N4gvcDkWoBTE220+ik+wNNVKuu4jHGuccx0LSc?= =?iso-8859-1?Q?EacyP1vY6CrJpw0t3ofYIzdO0/9P6t45sizIdCNEOcW57WfdYSF+oYHC8N?= =?iso-8859-1?Q?HgUDcvhyDDd2I5+am7+2xaOKc6XifRNT1Zgq0U4uKv+fBZk6CiVXEzjokg?= =?iso-8859-1?Q?S9FStm8/AmAJnWOIySBBqk6ztMQ3LUCn8J32datoLfuN/wTXcKkRVRLxpE?= =?iso-8859-1?Q?pJiHU7Djpxy3wRCxcffdNLY+SyH0XTZX7zK0a+bw8SS5CUFUEPxhnQJeSb?= =?iso-8859-1?Q?OCXUTzW0171lLHIQweGL63ekHV/1+QPsnAphVIoOB7k/VDOwbXZNXooTOp?= =?iso-8859-1?Q?IbunZE/kJtYRRyTAjlrgqTvA8ijW4erC09C5qhJoZxnDegLrnhqBA+yJ3C?= =?iso-8859-1?Q?f5/MBIvlBhMFHqcsx5L3iYedcwVBl0y6K56BuGHVf+ILyn2z5fiCH6kwH8?= =?iso-8859-1?Q?rz/4wrxwvWz7Y0bYI+Xvif/BnY2Wo3+NYWtonwZC/j2NIMguhNDfJmcfNv?= =?iso-8859-1?Q?U4nsj3g80xCYM18wF5RLjHCWOtsN5vwfkFgrhAH8pKUr7i5u2Uf3eA7On+?= =?iso-8859-1?Q?e5CMT9C+zshIIwb+cXS2OxqXdLbag9EVw8fVjdbmdJDa66z2wBwpCC+CJO?= =?iso-8859-1?Q?nsL1VqDL2COd0TnNqx0gSbAmhTqWNa9XolU8+U2eqkb1F4hS0J/pATwXUQ?= =?iso-8859-1?Q?8AyHrjti4AXvx1GKuSiJYQyOeAMnAWGb+JwD9IzQ8Ar7gmLV1yPxEfv29L?= =?iso-8859-1?Q?feiSh0beNhikZ0MPw3l5wIaItdz9rv8y4YhpkIbBhu4eXbuqZ+SUWE2Mux?= =?iso-8859-1?Q?U9rvpck7zftIkg7Ji3/f/jrivGyDlyDFUTkwtbuD6r40m85HZa29igC8ka?= =?iso-8859-1?Q?r3kRnJAUSw4HaCCDaBE7HPhTYDbV5dFeJNQrmQagVVUBEFCf7n8tP8ktb9?= =?iso-8859-1?Q?LsDpGap6OrpnrwjCOo6m2INv5Usdrv3i9qFiX5wMFkkEFPDQzvtwyRUQJd?= =?iso-8859-1?Q?DgaqtZ0qk3gRyn5iKdhEGY6T1XcpwRKZ/Q2go47FRiiYSIZ//AGAc5IjbN?= =?iso-8859-1?Q?WE2OmSeJs6MeDefIJCKvW7T9FPfZS0iXozZi1Y01wIbKkPAm1ZzZQ1bO0T?= =?iso-8859-1?Q?Cy1OxPaWqI8QGrXlDFFrDewdg4UwBP1U2yAdzQJkbtHCYl4gm1Ut2d0e9+?= =?iso-8859-1?Q?RNR3c09LJmEpblUE3gF9VdxJexxrCbItUvVVW3MsapZX+C5iekQ+4mLpRw?= =?iso-8859-1?Q?Lz5y9UUq6g=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: 1fjCEVVSf/dgAzPld5L0I24ais9skpFs+lTKFammIfNwsAX6dlGIm0Gwu6X7H2hQELiSIeUFYfpYWTfIzy5uqiMiwOpB9+xf8wtR9qDqzfbF8MqrOMouxqSR4Wwlr7ipxVDroa0nmLapcbMKWdGUwYZQdz0Jkn/2+v9XkKUNB97acnXB4NJFTfRoAucVI0sdObjwaQHSOgfp+c0xBvFI03DAgLtZH/x/WoJq5yC23iG6FxUawHtfnFuD9dD4RH6PcldVjv5LAZYAd5Hyrt/oFtVCYYyPzxMyri294iNlGKRgfUYkhUJoEhKD4+i9LbTuNvjG0xerMGYrx/2cP4FbWw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45437a85-a083-4c5c-8d34-08df282c516b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:51.5753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IdUgBjU7mYV/zE8HDZEH9mRPKJTE5Qpo6QBh9XvYEsvFZizQ6FbAe7K+mjClTAomSdGtbSba8pt7wwP8JLO/tTbwYLPL6UvO0ZYqRuDISIw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787565091158500 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in AspeedSoCState. This made the variable names confusing. For example, AspeedSoCState has "udc" as an unimplemented device, but Aspeed2600SoCState also has "udc" as the real UDC model. Use the unimp_devs table in AspeedSoCClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST1030/AST1060 to use them. This also fixes a type mismatch. AST10x0 used the "pwm" field (AspeedPWMState) and the "sgpiom" field (AspeedSGPIOState array) to create unimplemented devices. They are not used for that anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_ast10x0.c | 55 +++++++++++------------------------------ 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c index aeb5a4423d..0790859735 100644 --- a/hw/arm/aspeed_ast10x0.c +++ b/hw/arm/aspeed_ast10x0.c @@ -17,8 +17,6 @@ #include "hw/misc/unimp.h" #include "hw/arm/aspeed_soc.h" =20 -#define ASPEED_SOC_IOMEM_SIZE 0x00200000 - static const hwaddr aspeed_soc_ast1030_memmap[] =3D { [ASPEED_DEV_SRAM0] =3D 0x00000000, [ASPEED_DEV_SRAM1] =3D 0x79000000, /* SEC SRAM */ @@ -99,6 +97,17 @@ static const int aspeed_soc_ast1030_irqmap[] =3D { [ASPEED_DEV_JTAG1] =3D 53, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast10x0_unimp_devs[] =3D= { + { "iomem", "aspeed.io", 0x7E600000, 0x00200000, -1000 }, + { "pwm", "aspeed.pwm", 0x7E610000, 0x100, -1000 }, + { "espi", "aspeed.espi", 0x7E6EE000, 0x800, -1000 }, + { "udc", "aspeed.udc", 0x7E6A2000, 0x1000, -1000 }, + { "sgpiom", "aspeed.sgpiom", 0x7E780500, 0x100, -1000 }, + { "jtag[0]", "aspeed.jtag0", 0x7E6E4000, 0x20, -1000 }, + { "jtag[1]", "aspeed.jtag1", 0x7E6E4100, 0x20, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast1030_get_irq(AspeedSoCState *s, int dev) { Aspeed10x0SoCState *a =3D ASPEED10X0_SOC(s); @@ -161,17 +170,6 @@ static void aspeed_soc_ast10x0_init(Object *obj, const= char *socname) =20 snprintf(typename, sizeof(typename), "aspeed.hace-%s", socname); object_initialize_child(obj, "hace", &s->hace, typename); - - object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DE= VICE); - object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); - object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); - object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE= ); - object_initialize_child(obj, "sgpiom", &s->sgpiom, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "jtag[0]", &s->jtag[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "jtag[1]", &s->jtag[1], - TYPE_UNIMPLEMENTED_DEVICE); } =20 static void aspeed_soc_ast1030_init(Object *obj) @@ -215,11 +213,8 @@ static bool aspeed_soc_ast10x0_realize(Aspeed10x0SoCSt= ate *a, Error **errp) return false; } =20 - /* General I/O memory space to catch all unimplemented device */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem), - "aspeed.io", - sc->memmap[ASPEED_DEV_IOMEM], - ASPEED_SOC_IOMEM_SIZE); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); /* AST10x0 CPU Core */ armv7m =3D DEVICE(&a->armv7m); qdev_prop_set_uint32(armv7m, "num-irq", 256); @@ -394,28 +389,6 @@ static bool aspeed_soc_ast10x0_realize(Aspeed10x0SoCSt= ate *a, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0, aspeed_soc_ast1030_get_irq(s, ASPEED_DEV_GPIO)); =20 - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), - "aspeed.pwm", - sc->memmap[ASPEED_DEV_PWM], 0x100); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->espi), - "aspeed.espi", - sc->memmap[ASPEED_DEV_ESPI], 0x800); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->udc), - "aspeed.udc", - sc->memmap[ASPEED_DEV_UDC], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->sgpiom), - "aspeed.sgpiom", - sc->memmap[ASPEED_DEV_SGPIOM0], 0x100); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->jtag[0]), - "aspeed.jtag", - sc->memmap[ASPEED_DEV_JTAG0], 0x20); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->jtag[1]), - "aspeed.jtag", - sc->memmap[ASPEED_DEV_JTAG1], 0x20); - return true; } =20 @@ -503,6 +476,7 @@ static void aspeed_soc_ast1030_class_init(ObjectClass *= klass, const void *data) sc->uarts_base =3D ASPEED_DEV_UART1; sc->irqmap =3D aspeed_soc_ast1030_irqmap; sc->memmap =3D aspeed_soc_ast1030_memmap; + sc->unimp_devs =3D aspeed_soc_ast10x0_unimp_devs; sc->num_cpus =3D 1; } =20 @@ -529,6 +503,7 @@ static void aspeed_soc_ast1060_class_init(ObjectClass *= klass, const void *data) sc->uarts_base =3D ASPEED_DEV_UART5; sc->irqmap =3D aspeed_soc_ast1030_irqmap; sc->memmap =3D aspeed_soc_ast1030_memmap; + sc->unimp_devs =3D aspeed_soc_ast10x0_unimp_devs; sc->num_cpus =3D 1; } =20 --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787551; cv=pass; d=zohomail.com; s=zohoarc; b=D4F4q35clWw9Lu3p6N3iMfvHjdShr3/dp2d3mtJcGVhcPbPJRvUWzUi9zhJF/YkL4POeemF8LAJRjsnS/cD14J/Dk20a29mLd3n837U5qbs4SNEyn46IiaetqE4WOeHdbgHk3CFftinapmt2dAxKsIPdXcqAPzzmQb5ALDSspcg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787551; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Flyzn2w3QcXPMyX7Q4UatH5pwSRlwqH6VA2vmBc/1l8=; b=A0QSWTiO6Qp41ZVmpTGLiOh6zZ4McEe5Ql1swmwS/VxpFP3+V4XRB/JGhdTGA/d5IOp4giRXOsX7rVU9wbqjG3g4jHb0qmpv4+7/nUQoqliLCTHYW4EDFhFeNYq+8EWNgXAODAKPqobQRB8h9MEQfAQuOcoo2yBXmWPmgburyX8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787551703288.22681531508135; Sun, 11 Oct 2026 23:45:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mZ-0001nm-Bk; Mon, 12 Oct 2026 02:45:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mV-0001le-Sp; Mon, 12 Oct 2026 02:45:07 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mU-0006Ms-3u; Mon, 12 Oct 2026 02:45:07 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:52 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u4YFnxxYWaxZsEhQmGm+LxJq9Yjtgzb3o17QBTrmaxgoYHob7mQA0gMIYUaxgRY8tNcKZouqPK8IcIviVQnzSStEmqV2Ftj9EWfzdxrQptHyCrqgfmURTaL7cCIhjqfUoAV531+soqV3nFzdynfKE7jv9FUeBh+JLFbVq8mf5v1Q4KEWG8yYwPK7WbmpKq9jDk542191fvlXD/et7ZQpQckn1B9kwX5buSER877kJiDvTl/9sVskj7Y1Sy4YCbp1DIYHaOemuP5eLcEjZOcHpZRqQGW7PclBaV9rgXx3l99ZUqUOIQKVMPEJwfKVyyy8CPMNdnCxbjVGa+CmocjbNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Flyzn2w3QcXPMyX7Q4UatH5pwSRlwqH6VA2vmBc/1l8=; b=TWBHnA2CIJITU7r7TuY7dY0tSvdZvUnGq7TgU7b64MUNCcBkwVSueKwf/FcvD1OsQP5QLGwN1OD2ObDG7lRG8R5FcHsZY0EATWZs5qfNapVGSuqiNbcU0CxXnF45oIKv8FvvxL+Hqq7Bv70iCoUlyw/QuGWjclY0wmcznIc6M30c5RR6h3ZcGuCECL3zYOysdgRJIWdmQdOlGi4PBzwZqcRreYCdcgI0GPSfrJzA45pHhMHrK6pcVrJ4RdH20G78Ds1Sk9UJejC+/fJFyB+6Q4sCOgn9CNgErWsL07qfJgp36RM2DYHSD/GOOkI/HBW3cXCKl2FektX7fpxbLxjKEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Flyzn2w3QcXPMyX7Q4UatH5pwSRlwqH6VA2vmBc/1l8=; b=rnc2TVVKx/9Zdyx0twERTYxMi7w5gcHUXoSg7AEidf7M+hzEXlCKkyJgDxatDAbXp7G3QjQq2FLT2ssc/MonDcvxRwxHIKyn+Bt4g7/iY8SRE9iKYU6pSOK+hHm7J/i7R3CrAl6ZTXji98sLb++FwGUAOSFlK/fMFcBQdY3UBwEDGmnl2Opao5si5/tO9ZB2tjG9MswbPhkmSnGTS3WHj4Trf+dfQYdSvERggoo/7TKEo5Zw/WckdYGdmX7tbvMzoU4QNszLYD/P/U3BnO6i+WnHFSFdS4GsynsheUKmgGuB2I70drcXyxjsJ9/hLtTYb11xUGhAU+lB2KhSa8c6Dw== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 06/12] hw/arm/aspeed_ast1040: Use a table for unimplemented devices Thread-Topic: [PATCH v2 06/12] hw/arm/aspeed_ast1040: Use a table for unimplemented devices Thread-Index: AQHdWhUvQomWQHpOzEWIZfeM5a870g== Date: Mon, 12 Oct 2026 06:44:52 +0000 Message-ID: <20261012064445.2571633-7-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 9a08ef8f-5756-458e-35dc-08df282c51e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009221227099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: NEGTXm1Xa/mGkE0oHZxX1ctBcCuWRwOqRDJigHxFl0GfA9YRF6lptx7tsorQ9jqVlXKT7+CbZtQhoJ1tBHgu6vXZTyc+vMFqDfVLXycDTuhUf9GhTirUEslOfxaBwlmFzS/QeeUQWAYaqvsIgdaaKXZOcGqU9YSH80mt9IgooBPbtrt3pAQdHHMihTRU5KTdlSp8jn/cBKy4bvKpxcQTUveHa7DyhOteCT1JXEhSEHIvnIJhPm6NcMLjTOHW+oBDaHmNlFw4gti8lqplycYLNxDGCGXJ27oQf5ec/Eci6B7BdyIWh8XaslI/ETLFg23COSgGaQzjuwP2e4EwOadFhRAAZtYWoontJkLzp3UIz+zpvBlj+7A2LC4oHt/j7OaVSsUpCn6h2kaviSzaDnSbhe5zo74ijvGiPZPKlpySrf92bCuhZ4YvjXgyQMAuINCXSwSb2zg4ZgOzuNezvPCfX28OpYBnKLeCmy9mYs3KUCvauwWYhohN7Z9jWuXdvI2xP6vC8pQGV/5LYI8v4VliYOZVRvsvvs+6VUhwyMaIomQaLHJasvaNCQZZkvxQVdzobKqS/3VaAQLUjNhtJ/F/l5ux4esm+R00AvIZjsZ1Ww7xLqQ7BIGdmYF1rPFripu3FV7QRYNgJG1xYLl28WJML2o7z27CMUsc1LeS59lf0xHhCqoCrEse8z6YGSN84/YAni+A2qFHBb8qDoNn+63XzTSCAoKIWi/gANQ3AZSOQyM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009221227099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KVe4B5/179DJlIZhPOCplIyz+cevZODX3iQjEuZAUYqOITyQObS44Dj8Ge?= =?iso-8859-1?Q?/M+bNt9eHaFGicywv++LZw+CGsYXcGhKjiH+DhJgA6ZQ3/BhqnDj1PSm5p?= =?iso-8859-1?Q?WSaYrG2TI+kCBpTQXI/DfZaa94/p9WI/w+cg1Dj9VXhr10bHC/QKVgML9j?= =?iso-8859-1?Q?OzdGhvpHWUZVjQk7gRC4Ftcv3JEj/qZdYNNkSi6JbUEeD4FJHD2zHu4C/m?= =?iso-8859-1?Q?ZYhF1Dhe8KbqByhsJ9IYjWwYLRx+Od63pDg+nGq8+H+Dob0zT0P9RkqESn?= =?iso-8859-1?Q?1Wc/V5TQVtOKgqS015vGvWsengbLxCT1+vwlxeeHEk1hqGB9c0SSnIlOOD?= =?iso-8859-1?Q?20wfKoBX7NmPISw5fZvd4Vn43+UgMpEgRF1U7WfPdQ4d6oDXlLBbHAtO9f?= =?iso-8859-1?Q?CCEJDGjdZBIs1LifsFCQiBqo7PdlGyM5bCM40ZEc5BxE2U+ECJxdrtDE0o?= =?iso-8859-1?Q?bp91pIgkIqhE1zpXfMe0DsBOik96aLYuqs6DgG+3aLcVWE6KX4apd8Cee8?= =?iso-8859-1?Q?4s2NGueDwz0QkvWJVdGssB25MDZSHvg2SSuNjFSU4hH3LPK6Me4VNDsCfE?= =?iso-8859-1?Q?7tY0ovaqcMGbmNBGXJyeJ0YZ7Jrmp3tyt8NiCyA5uqpGq/wDiPQj3E8H9Z?= =?iso-8859-1?Q?RXaCfUtorLAuj/hRQq7L18/kkB/fO7LbOmQqlAN5VH/7nHjBM3ctS+9diS?= =?iso-8859-1?Q?2BMiECuQbrWidlXgR/AqIkpIsptgzeJeiXRimyOO8yJY0O3MCew7t1EeR8?= =?iso-8859-1?Q?oLgHNlJpL962M1D9Xv/MdSx5fFFfmduoGWjKSLMU8g1o8Jzt2Nl8+5EfHo?= =?iso-8859-1?Q?N+jyoWLeCY0mwdSVL1DKVgODevfh+MsKZ08BfcspCjI3eS5wuoCkrlXSbe?= =?iso-8859-1?Q?jG3HfYDRaNUW8izoXPbePd6sd17zEsA7ZdhN2KuWVTnriftWIBnNraWu/G?= =?iso-8859-1?Q?JmXhDz2OlAh1lehw7/WjxGbJTut2xRH0+AMFnt/tFFkye3FnG0J2KvYpqS?= =?iso-8859-1?Q?fjC2jd1ViysZWAYUFHmNJcFDknRFHjfJQk4JUp2TanPs0uk24ToKvBolC4?= =?iso-8859-1?Q?hB2vadv8uCXG6cST0nNvqM8JCzwmuqVKqCcrxpUusP6NJR9wtdrPsYtTPS?= =?iso-8859-1?Q?0dEdIJLkh560M0hdDgtFwJfwDyZ9gDbdPsyqou/G8197xSXeGHN+cLUP0b?= =?iso-8859-1?Q?m5gjBOf8BCdxV2obusvk64F0KqsdO9KaW+5mJRWYOuFVoQeSVifNRt6B4Y?= =?iso-8859-1?Q?V6QjvjHdr1K9k2WF9wu0uo972KzkjQ4fbiQQulp6CvKsfVBCgWfmVatG3G?= =?iso-8859-1?Q?JbsMUZV9T6tLKR0Ft+9L1vz/AVMmOpQIOMFcGetDAhmDU9J1Y2lcpqruak?= =?iso-8859-1?Q?MpTBoNSP/WskPJGk5gLYYbqOrlt0ajddSFKJ1grsJkNytfMw+xJskLSei8?= =?iso-8859-1?Q?WJ4NYxZcjd1/ylUeRr1A91KGwGYRQzReRH1iRmjq89E8gaF4CgVIqoCyMM?= =?iso-8859-1?Q?zFfRTFCmBz9kxR2oXS6qB0zQ/1my6OonLpjwGPFyA6kfsDdLTtTWPhYke2?= =?iso-8859-1?Q?7qo2IWAVB4JRqhZxdSU5y89B8/pZhqxKW6lgEDjLJdCkXeV/exl5Z68pHf?= =?iso-8859-1?Q?1/abytdLR9iiZnFUHiPy9Cr+StF6GVR7hIWQk++aYZ2wZ94G9HMlEkhAJw?= =?iso-8859-1?Q?3fMNem8y7vuvEqQU+ojk7XTp8ao7HK1Ze2uPhI/VlOy+zNDNrymv1KQbl+?= =?iso-8859-1?Q?INkuPkhzi1baUlY2A3c0uKpGBgDt/gUYLU44v6jg0jrOYC1CCza6v0V+lW?= =?iso-8859-1?Q?vU0ElpoDzg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: hsBtJcgsSKpv8crMOfUBr9we5hkenSVQT3EDY+oWqIH7kFVQ7KBmtskhC1hcFsxlApfTbCduA+wjyJVgkzKdssaMO21L2em4AR0yvnf+QZBqLmhnJ9ti3HC8qOgTltcKTV2WhzMax8oERD7TzkQszYI5ug4Gx36gFtXgNozHV2sxYh3Kqhba3i3GcO547aEREoxdnpSEL2V9yHX+G1NOJe950uzs/5pGcPgdexQYcXm8X1JOGj5lQYbm3XVh8Lk/mqWNZAfaZW/Z0iqDGebO2oEOjsOBCxdm7IFFLk2j/Fv+oZFTI0+0G+gMygHDxxMoWRv5l9/yBHpRXus2Qpvrxg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a08ef8f-5756-458e-35dc-08df282c51e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:52.7521 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WqeGaZ4vVYBkavzfbS9Yyr3k/WRgL/cp82Aje5Eg+5wG2mwmJnIe3JnRp+GJ80F//a9XOkVoxqZuZCAB3fHKYci1ROEyUK4D1YY+oDWAdIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787552828158500 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in AspeedSoCState. This made the variable names confusing. For example, AspeedSoCState has "udc" as an unimplemented device, but Aspeed2600SoCState also has "udc" as the real UDC model. Use the unimp_devs table in AspeedSoCClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST1040 to use them. This also fixes a type mismatch. AST1040 used the "pwm" field (AspeedPWMState) to create an unimplemented device. It is not used for that anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_ast1040.c | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index 57ffc0807a..0b078f10c4 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -81,6 +81,15 @@ static const int aspeed_soc_ast1040_irqmap[] =3D { [ASPEED_DEV_PECI] =3D 164, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast1040_unimp_devs[] =3D= { + { "pwm", "aspeed.pwm", 0x740C0000, 0x10000, -1000 }, + { "espi", "aspeed.espi", 0x74C05000, 0x1000, -1000 }, + { "udc", "aspeed.udc", 0x74120000, 0x4000, -1000 }, + { "jtag[0]", "aspeed.jtag0", 0x74C01000, 0x100, -1000 }, + { "jtag[1]", "aspeed.jtag1", 0x74C09000, 0x100, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast1040_get_irq(AspeedSoCState *s, int dev) { Aspeed10x0SoCState *a =3D ASPEED10X0_SOC(s); @@ -123,14 +132,6 @@ static void aspeed_soc_ast1040_init(Object *obj) object_initialize_child(obj, "wdt[*]", &s->wdt[i], "aspeed.wdt-ast2700"); } - - object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); - object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); - object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE= ); - object_initialize_child(obj, "jtag[0]", &s->jtag[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "jtag[1]", &s->jtag[1], - TYPE_UNIMPLEMENTED_DEVICE); } =20 static void aspeed_soc_ast1040_realize(DeviceState *dev_soc, Error **errp) @@ -267,26 +268,8 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->wdt[i]), 0, wdt_offs= et); } =20 - /* Unimplemented peripherals */ - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), - "aspeed.pwm", - sc->memmap[ASPEED_DEV_PWM], 0x10000); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->espi), - "aspeed.espi", - sc->memmap[ASPEED_DEV_ESPI], 0x1000); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->udc), - "aspeed.udc", - sc->memmap[ASPEED_DEV_UDC], 0x4000); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->jtag[0]), - "aspeed.jtag0", - sc->memmap[ASPEED_DEV_JTAG0], 0x100); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->jtag[1]), - "aspeed.jtag1", - sc->memmap[ASPEED_DEV_JTAG1], 0x100); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); } =20 static void aspeed_soc_ast1040_class_init(ObjectClass *klass, const void *= data) @@ -312,6 +295,7 @@ static void aspeed_soc_ast1040_class_init(ObjectClass *= klass, const void *data) sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast1040_irqmap; sc->memmap =3D aspeed_soc_ast1040_memmap; + sc->unimp_devs =3D aspeed_soc_ast1040_unimp_devs; sc->num_cpus =3D 1; } =20 --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787622; cv=pass; d=zohomail.com; s=zohoarc; b=ba9ACAYcz3Fk8jtQapmgSmaj/UlIdbgk0Cl9matzKMpkRs1oRPlaa2WFk0aZhQfokErXgopRc7nFcrpFAAj0SSorfDidNzYWsCgAuccuCck6/a8obfiFgp6dF2InhnE2SAA+fwfGptQMB4kfVjJwVJGkDDJyWxnZA7m6XZZfg28= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787622; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4GEa/hv9cl0/UrYqvk+TgYVNGaN91P5fS5TLFNnTi8o=; b=XFT6FGqc70sxWCFuLswX6pmWKeE8kRqbCUwDhev2eDVVAUIK5i2UO+2uC7w5sVw4Vvch+MOHuNuh1tdCfT0C/AqbQs6nw76SLHFTzYT3h4Y1sqFyG1KybFJMCwbgqCRlhY1c/qAp6p3Fganv7lOpLao8IqKsUE7MJKAlEw6FgDQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787622738350.4504724455919; Sun, 11 Oct 2026 23:47:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mf-0001q9-GJ; Mon, 12 Oct 2026 02:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mY-0001nC-7L; Mon, 12 Oct 2026 02:45:10 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mW-0006Ms-Pv; Mon, 12 Oct 2026 02:45:09 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:54 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qV8pmDVTvjTT7EsNDjxbpCzZU/tr3sTxNTQ/3/rqMYmqt99pgKv9ep7+374lQAfHjEm0LEEn4fjKnk7vKgc5Vru/mAdV6ARFNfSdkN/IMjFI8edBsYkPu+O3VJU5QSVOwPdjo251Tw8gLZlRe0Pg1076q5UPpFGvcw3w7ADtJ64cYU7Cw1II6rjy1NSeWJZv17IONigRhPQEPOfJp66z+gZM/mP5Vyh1emCsZej7EpirpsrBCF3YaqvdHgrWSvANO69X0klU1EQjgrCgel24GzR5VQJnVg3ohrnpYCuFSuFx7HhXc3oVOn0KBW9+0AWWwTvbvWBkN+nVEr6XzweGZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4GEa/hv9cl0/UrYqvk+TgYVNGaN91P5fS5TLFNnTi8o=; b=doqPcpXsYotnzyARHrWJT2RfDkLTplnS5Eh1aHanbfDPiMLklvAlWL7LIgPuK3cH8BZNxuTI9WpmjaFOLoma0psysPcqUlrh5B5dLDGcDQm/BoZVbgQBQBdqMXWIduKY4d+j+r3k5g20JiWpI5MrXytwoHoOgkRlegAjFMw2xIncayko/eMnPzPHJE3gUnD6vJrjFGrTtr8S1PXRV49cHKvdw4rrQh54tNqcMij7C3y9Y8wiugz1wiV+M9h2PZbjUwJzU40Zrn6/DwUxmi22iH0q6OQpjTPc9I/Cd0IB8WVfnJfalAafYJxVLAVHIFpdOOS4CkTEJRS6D7pkGMAO7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4GEa/hv9cl0/UrYqvk+TgYVNGaN91P5fS5TLFNnTi8o=; b=St7ZRiAcs0ebe1fVLxJuhPzFPjFYSBtocKnZ6lRppa/PtUQ1GM6lWIsg+CYZfOjTGA/n1+kp3ssfLxlGFxm5b/ULWvD57PyhDHraFjqqCvp98/LJm4tcWCHg9xQL4C/m/ksdPpLbb2inc+LES08fiaSigLhIjxLvd4MRiY4FQHJLSv4zJd9bPhIBG3wG53jeVOBrKWCcNYYIwIXnvErKOkFk9892eiGkCWtltkNP2zYCEC3Y/5gYwQuBmGDCIIJuATDRgQ/H7di3y114MydVIgf/RzKlHAnH1v4CyuncQrBVjgCQi7rKYqOUflSQGLgxFXHsShKNy3p29yOLcrMU/Q== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 07/12] hw/arm/aspeed: Remove unused unimplemented device fields Thread-Topic: [PATCH v2 07/12] hw/arm/aspeed: Remove unused unimplemented device fields Thread-Index: AQHdWhUwhy7gpj1VfkKqRmQEFdqdaw== Date: Mon, 12 Oct 2026 06:44:53 +0000 Message-ID: <20261012064445.2571633-8-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 1bdaa970-516a-403a-eed5-08df282c529c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|7416014|260925021311599003|260925022911599003|260925021911599003|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: cG7W7uLJTLJ05OBRt7PI2rMPAMOLrcegtBa4YRpf8Yqzrq4ijziNvxcJ4dvszhBnPd6qQJRTdKVtepcZrQHckZ3g2UxrWbZdPqyGEmOzrU/XUbt9aFSTAN0VeWWk7hrL8EE9+aHgU0yv6VCOX+WtUNFvu11JLprWyk02cYfw/h036Hc2MbxiN4w3dnSm54+2yRXrVN0ltbQbwb4lqulSmfPjloNEGZZWoBH0ug2i+9OfLGauOXrlnQgxQsgTQdkAxNhWbyU7I80KXk5XjM/bgq+FokTjZe8O4LHzBt2HxuimCG2GvccXR/S8hiaGmXiTsWGvCBUE+47dPGFTl4FO+gvD8HG6jtDSBk8gviDL3/ulaPHr8F/NUNXLkxRIMSUBpUJQ5B2hikYhY1WDmm9jTE5tUg6nZH7FFXbdsRXRrfyA9jrSAYhbr/GGciqTV7hQ+soxPc91wyCMrQqgXXPr7ySdjVxrmEOgf+U12JCJ2IskhhlV5eC3mVNN9EHBZC3UMdspOVK+RyZZ42BhBnSZvYM8aoUQUl5BtnCdnAC+AyUYuPgYBysMr+guIwdc+dLIFXrEYlqf1mCOcGxse3J7h0K7J2uXMl+6VVFW04vvGZhWRl3owHPsxESCw6vazJW6vSqX3byl/rppkM+6AlkKQqWbhtsD0PsZWkaFUiXcRBNqPIkbhyfg0fRwBGNpZw+yi7uWLbfQW3K9RN5GCxLXp1l5UlCf7P93QNKxdMPjTxdl1WjwVuSNChvFa5TAvV3M x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(7416014)(260925021311599003)(260925022911599003)(260925021911599003)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?16qQ5BhHhm3hqL5zSfRLF6U8fgQEOla8l0UYVvPu2WWTyI6Ca3ahWVomn2?= =?iso-8859-1?Q?84S7j9LGJD08cSxaU9AoYAK/SAnB+ZHtPAoV7yWTat/XBL9sbWEf3O0oo3?= =?iso-8859-1?Q?qIkoRBzK5JpidjWP++NjAQGS+Mw2h6nlyw6rg/5v+OJF05WjtehWMMJSy9?= =?iso-8859-1?Q?480IC2Njh/HCpGePbsK1RuiKoOUoz0DbQ+0YJJY5wfWjRfqi4VKhE3nulW?= =?iso-8859-1?Q?XFkwl5NV9J5oOtJmiauubyAvFE0FaJFwWSSGaSHSf/FcTjF9acAVlPW79E?= =?iso-8859-1?Q?JHK0SflFjNc+fsc0jY1mT/PNcKiY+Cdh87eDMVhpuK5GJLIrETpQb6/DsH?= =?iso-8859-1?Q?qj337coQdaoc50Ec5w4JIYMB4HbFlG4VLTMcdYq/FZ9sQNugXXGwwIboJq?= =?iso-8859-1?Q?PjSabSfwlSLJbKC95PPJcuMvsNmB6LiY/97giRrdQcWZ7/VxUQMr5285bx?= =?iso-8859-1?Q?wg7SnfSFt4duZ/Pek4B3a7cgbD8NvjGXVbHTgM6rz1lLM8eZtAuSlFjgTy?= =?iso-8859-1?Q?1IyEDuAy2Bdfl/Ol9tH+rz3YDBA+3CWnLFosc6l2LGI8pelvo4j7lXqd+9?= =?iso-8859-1?Q?PPNdKNMZmCq5M8TeGVBq4KEP4nnGB6zfe7FFZ5yqRAm8eTTB8RXR4pa9bt?= =?iso-8859-1?Q?lundslRrhVuq3REB2HWXsAfwpLXIxPPCa2ucEYfQs6C0iI2zX3Idc+YmXw?= =?iso-8859-1?Q?YPMfQpQ3jQi4+diCmI/19IdQ1fJKb2uXL1Vr9drl1uygU5NUzROkc7XmJk?= =?iso-8859-1?Q?onyhQyMUHZmy5G0FLhONeepQclqT741GPvV4yDA6BGMOlCvvl3+fQdOBuS?= =?iso-8859-1?Q?o913QArDqd7aVftobg3J+bTCj1N1qlszh2OVT7ADq6hakxcAMcFx1caSq0?= =?iso-8859-1?Q?JQgNrp9ZzRHsvUnh2MOe0yD0AUXVpBEGsKsuII4quCfn1DxzlyINX9OxJW?= =?iso-8859-1?Q?uuwU/CLTpEiUPa9sylml4lMH8l56oxO5U9TroTy9iiWiDkhdlPR/qtauGM?= =?iso-8859-1?Q?nQjljlHPtKFjrXrGlbmJiDO9/En9I50NhDKgJ0gIKdIEhP1oBdu6Zn0T0o?= =?iso-8859-1?Q?lXImWVJQafmygOjvDKC4CMWHTB50fibJaE1G+9pLtGtX1hIW8YeM7Yq/Bg?= =?iso-8859-1?Q?RbUgtDczbeoeCjSVruLTvTwl3SzzVxPIeiniigatbFmlsT2TxEpZ/EtOXQ?= =?iso-8859-1?Q?Buh72qkl359t/R/WpVobxgclc1j+56wONgLq/hEzWb2qWE7gWF15FqKyHR?= =?iso-8859-1?Q?VR5xY6s8ryQyluIivq/Oh99q9CG0FPux2eufTHHMueb9snhmnY9NZsq7lp?= =?iso-8859-1?Q?vzU6wzxPAHjgPeOFDC1EtEPO6cNrkqBn1htXwj22RKNnodfk+ML1SPT/ye?= =?iso-8859-1?Q?Si7D7qTmvB+2YWJwVjWFr7Cbgk0ziLpZFQRr3DvszxKJBNsYhgQMJnVmTy?= =?iso-8859-1?Q?uJ9ZKyZ3GSW+vgjzxFr7pKFhXMwme+JjA5VmmDYw4l2/LvsjXqyQNU4tSt?= =?iso-8859-1?Q?iBsRsylNw46XsVGQIPcdi/9ItYDckmvBoquPQdFzxgx3HrYbu7xxiHVTGC?= =?iso-8859-1?Q?MfCaJ+HX6WQ9IvEae4W5QwI08TicpQfsFC6iBOBHGX024NdWlxxs7MiKGG?= =?iso-8859-1?Q?ZAYLVCm8qqjPiJCgMAtVbMD0OPLPmJtkmQtqT9hxkGwY1lwupc1xgngcKs?= =?iso-8859-1?Q?cd1cliFztGo0sEO7rnqjhW4iFESYCkvNQsnf4oPV+i77Pd5JEmBhKm0OFW?= =?iso-8859-1?Q?LPkvmJaK7THjDvSJ0w1czBh2pMdwqbZEam0epM4XgVB0K49nldGHBSbjJj?= =?iso-8859-1?Q?hU1Z2bZZwQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: e0OZK6OOG2oy7LUs1v6AaqjkK6VMMzs4IfcfGPYUKztkbJi7QNmCUIvVlH7/tWU4/tfDPOelkPu4N22quuvNf9bChnQduJOI7y5q5/gfMDNDr7TWbVgXXh8Dzri1s8y2UrE3zXDZnvAogmaOkh0SZkhpfswl8wWHNSaTgpkYRg84NDFPAhu2wH/zawQSQ2QvCQ3IcZrcerKbBO05jzhWUyxUXZgg5p02T9pwOUe4n5WgamGhb6a2D2kam50GotLL034vCIrzuY4BKkX9VqPbzAYLmeeWNns0TCxRQpDx6ANxLn1Fe6fM4hQUOpULo3RvAd37gaDB2UlpJKp9ymyRpw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bdaa970-516a-403a-eed5-08df282c529c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:53.9311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XvO94IjMxUx3eQ3hCk2Zc5O2HFEnwckvNb494tkxR6YsNGxkE817tqOkytOjLt8ImNjBIysDJ/cMzVsZ3OW+AZgB7dnCVbM3sZgLNegDBcs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787624189158500 Content-Type: text/plain; charset="utf-8" All Aspeed SoCs now use the unimp_devs table and create_unimplemented_devices() for their unimplemented devices. Remove the old fields in AspeedSoCState and the ASPEED_JTAG_NUM define, which are not used anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_soc.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 8426134223..4ef1014ad0 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -59,7 +59,6 @@ #define ASPEED_CPUS_NUM 4 #define ASPEED_MACS_NUM 4 #define ASPEED_UARTS_NUM 13 -#define ASPEED_JTAG_NUM 2 #define ASPEED_PCIE_NUM 3 #define ASPEED_INTC_NUM 2 #define ASPEED_IOEXP_NUM 2 @@ -110,15 +109,6 @@ struct AspeedSoCState { AspeedPECIState peci; SerialMM uart[ASPEED_UARTS_NUM]; Clock *sysclk; - UnimplementedDeviceState iomem; - UnimplementedDeviceState iomem0; - UnimplementedDeviceState iomem1; - UnimplementedDeviceState video; - UnimplementedDeviceState emmc_boot_controller; - UnimplementedDeviceState dpmcu; - UnimplementedDeviceState espi; - UnimplementedDeviceState udc; - UnimplementedDeviceState jtag[ASPEED_JTAG_NUM]; AspeedAPB2OPBState fsi[2]; AspeedLTPIState ltpi_ctrl[ASPEED_IOEXP_NUM]; AspeedAST1700SoCState ioexp[ASPEED_IOEXP_NUM]; --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787586; cv=pass; d=zohomail.com; s=zohoarc; b=AgERO1xV4zkeI8bnW52fjzHv8Ol6O+u1DJJCyzqSxjzQevIQ5AyK+uFkVI7yjzAgLGgidfbrnvkllzCBILgEcmbQWSFIFCu/4PxbtINeygII2S4zoe18s4/XIjbBzKU8nSOLnF9Ttby2TvrN5pogr0lW5ri9jMnYP4MeJ5G0omY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787586; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=l+TSM3tYZif/qzmj60F+nUo1Br1BD5fdIGVLPMR0vN0=; b=HYy9Rv5dC0t0fBxKHr1XhZdGzFVhTBOT28sm4MnGgSK7NHEz4TEcMyUrYHzHI44W6Yb2sxkpbwJr+5O+05s+tja5KFWVGWg4V3qyFpPPNvniywdD30aVDq9KrsIZR2iswA8nvoZehN2nDKQ5PJU2fHSAlYhcnlZyYM4JfbqE//I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787586545705.9073771156939; Sun, 11 Oct 2026 23:46:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mh-0001rT-Nz; Mon, 12 Oct 2026 02:45:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mZ-0001ni-0c; Mon, 12 Oct 2026 02:45:11 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mX-0006MT-54; Mon, 12 Oct 2026 02:45:10 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:55 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NndwIpW7+eMJDe02Rf3czMme5a6wnDI1EGKiAtVB6cOtYVeIbbHRdGOhuZPBHNihpZyUCCHXcRFYY/OCYXK0J6ZwTA0tbUpCVTB+ysVXuYxH7dRuU4Xw1JrxtuEjb8kqgYwuuUcjgXpE0P8/0uFZBnZ8+dJ71qYZs5XTrAGmtE0s5DdC9u1F8UuBusyz6lFljQKsxrPf8EcO0p/9j9P7fQk+QZEXlbd91zHDYh8kVYaVUOeLslSNyGpNGqmFrnU6Oklis8iJomh9c+XJ3B7boAgTq6mHEGUTE1PHk2Crp/rMkciXgD0wbFGpmXO1HsSXRc79Rv+OZM3feE0WlP962Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l+TSM3tYZif/qzmj60F+nUo1Br1BD5fdIGVLPMR0vN0=; b=lPPMTM950VuO4PDHmj3CWtpaqOCFwwpO9nLa76whmC86Re+tZR/4RVJQcxyonaf1l9J2H69SRex4eBaIrxB/YWYNm15lsFJPvVic1P00/DlUefidAd4kISsjKhcJvk0ukpl62e57Oid/VLFxUyUnHcAWXkNxp0Y+litOw4dMpfLs3jV/G53CMRa1nqFv3SKS+GiJWJbxB6kOcNyOApvGPPeIx4gec4wUTul8cdie5E35j/iNZesQtilszhGfSs2s+j9Nkqkk0cfdCQGoWXCmy5ENe71fmjCzW7oNqZxUoCmcQECbCCaJDGa7NFix9d9yGeFHNSNduL0FwNDc4p8kfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+TSM3tYZif/qzmj60F+nUo1Br1BD5fdIGVLPMR0vN0=; b=lHsy8Mw87lg/b4MtGR9VlazEAhLx4rt+68iQAlx86lN8m10ploGWMxbtQR49ugVVltB3wKT9LD5CgT2fUE3xK5pOeIbM5Ukz60Ydq6xnGK5YnOvDQh94SKDdXmZYnOjt4KJqNKTWa2+s2OM61LapJCsMU6UCKyMIeZE7JKfMZNC4tsgY2qZ7PiyOp5vqwHXITw8YEN/xfCFoumBLMAIAMSh3SOvL49pmfuYbhF1/SRpbom2zQXfhk3FYwOOtJI47opm2nR/GgJe+x0Jr7nsJPSYzfeJX9Y+/ajURTlCnfm1oiL9pxsxvrh8i/6Bes3plL5K56RQgTs0o+i46vhFM3w== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 08/12] hw/arm/aspeed_ast27x0: Use a table for unimplemented devices for SSP/TSP Thread-Topic: [PATCH v2 08/12] hw/arm/aspeed_ast27x0: Use a table for unimplemented devices for SSP/TSP Thread-Index: AQHdWhUwzzP2nqa+w024lSzGfjpCMQ== Date: Mon, 12 Oct 2026 06:44:55 +0000 Message-ID: <20261012064445.2571633-9-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 539e56ff-0599-4e0d-c5c4-08df282c535d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009221227099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: uKOqJ0Poq1m/7ml16ZAhN9pjAvUnEzq7gHaCQU5GYYrgm4EIta+5vS1jSldoaxjMFwSOOKHxcIbMhrJOri06Ik5pgS/G1ao0csgVHxoEk/eSs25kDc9PPPfGpxMwDpGPMqyu2wIt3RyvUZUtNScBoFoCNrV+uMWySOdnRPZHxBZk7CD5AcAQhIkmvYuldmfWsRdK6lIj/eso4iEdYGcNWxDlyFmm3I1HFCnha007Dx7WN9SrlqHnYsvtziAF8wYAncFz7QWt1fIYLivcV8aIEgAIQAUnjTfp4PW9xiYOWgScyAJKQkG90TKo9f8HJu9uYHaVqcePZQPWnRMdbZNJwHCOO/Qqcj3d6sLkvSIiepxjsqnmtaSUDsrzMlNYX7xwJ4iX2w2XV9nKdw3qs/s6L4CeT6CsvZ9HvsD+GvFO8xJKECUjXimv5symiJ7VUXteOm/AIL177gfAyOm6MezZSh0FbtCWrbiyv5ORWI/n+RmjAF/9vDvVZE7UO95cxKdtbimE1z/zl4C466zCMkzV/geNfVZGHlD/Rm+xEuBBJ+eoKGuRe2EkTID4UZ/9MlMpkW449WSmQ0hIQDvOAeJBRxoLG1fB0w+QNHfSAt9Ut+wQQviZTXttkll2HUhyL7DD8v6SzPFLyxbQvn70UO3zFg/wiUVvymGnbi7QtLPhjWAYpB5iFx8szK9LBKA4RKm+jSaIXMCVp5JPfO7+j8naE2shQjGbQ0N75DsmQzLlnmeT5PUESXzO/QB0zu6ovQgn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009221227099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?xqW1ZUYu9k7j9jAZiD1qsA7fx6Ux0IzMX8N+YsfG8CPEhb7WUhTFTPyQ6M?= =?iso-8859-1?Q?7odmYotymDcj+NyV7yRpmdxcZnnv0cjSTYuUM8Zm9+RWGnsyL+mTX3rSx4?= =?iso-8859-1?Q?wDSL3LctTy71hxgyXCn0PdXKkmVXAaB6+3nyf9W8GfP/HN/FJ3vNzxwL5y?= =?iso-8859-1?Q?1UNFDkySFUJe+v6YGNfacMzWpmAGkhsHv/N9QSvSSKH0Ez3XPF9LaXr001?= =?iso-8859-1?Q?jH2EILoQlo9CEE6JV0JBIffVNM6B/YofeF3NGZYuKwLMLVvm1fHLaHSOrl?= =?iso-8859-1?Q?e+b2qV052HzihW0LMZjP7gKgyCkWxwKSNyOtX+A4yNIrp/5uTYoaHDGNzv?= =?iso-8859-1?Q?1AX/lGyWJAG9u8ttW4tVnUFpBhJXp/9X3dZgkJFTcdEZhQG+giNJUGAPM4?= =?iso-8859-1?Q?7SOU7MwbFNjCqLy80P23gR/kwX0PmnncU5rQgPe+OjWX+YgYk1RnoSLoc+?= =?iso-8859-1?Q?gWpvqxGoL7MIDHavOSVm7hE6pYg0D5O5lMH+zzKxfJsXE4vsHao75NDdsj?= =?iso-8859-1?Q?xbZ89wTjVxuS1cv+PUcxqyxkJt2XhDDg9rJbsok6Kutn06CrEhGysDmzRA?= =?iso-8859-1?Q?0XSZsnigH2CsDa1bEwa52xxTFsMz2HnOYtgPYyxpzoKsJOGH7PzgVLLv8a?= =?iso-8859-1?Q?rzPKfskw5o9iRVxZmpdiCx+Z9hNOBVgreLa5C9Gu+vu3/l2dZcodkQ9He6?= =?iso-8859-1?Q?lslCW/MUb++StsOsN19/upAz69idYQRNQZ0Nk7q6arByMrXJPR45ObBmlc?= =?iso-8859-1?Q?1y9VVoUIN3R8/yJRpmGScGBGEfHhtwWfl6ce/TOdF3T4Lj23encUJmGBoQ?= =?iso-8859-1?Q?7TaKHCEhi8SyLFU4ojxZEZbCaN+QwlGTqg/B8/eFH9uTEQn5UKuCN7ZC8k?= =?iso-8859-1?Q?3Mu3YYD8mhYrpJNLkqaPni6ybkOb5S59SNsr3GeOlqlWwNDnfATIfjkSQ3?= =?iso-8859-1?Q?vUxd6IKZmJfrwC+nhwUQo7tRqqAwE0wEezhNnfL+6tW6IZc2axT7OE+zGX?= =?iso-8859-1?Q?BEY/eQgzZyz+qZqMvU1Nea4XMyZv9HnXpZtdjea4QEtZqKP6ZjUenH3NeS?= =?iso-8859-1?Q?nfOKzvtMuMBSLZhqRMEHrFEk7BmTnrj58lZayxL3Y22bnP7v7movruMjC4?= =?iso-8859-1?Q?AoMQ9XNfzoFjSl7O2vZfHBkRRFKIOrKkBl1RThhPDlm8UujtlUCRIfefE5?= =?iso-8859-1?Q?Da1VYTCB5cxSz+Hqpt+7yEnCOf/WBKDpoe7YxYFeDx1N/7UyZg7NupztgS?= =?iso-8859-1?Q?6wu+u0Ejctb6KaN0xU4VNSV1Ju9/GC1GS7PdTMnZ+q4EPN9URxWk/Qn4FN?= =?iso-8859-1?Q?q8R3b5PcnGHd6yfE1lV0vsgC30IwPBmK3Qzs1ga2sAKBr0eTKHtgd14opi?= =?iso-8859-1?Q?B92n1e1sG9nRUs6EGOdg1ytwjLz96SuMVxh005yxEiUJkaMQHmUfvDIAxR?= =?iso-8859-1?Q?lGCwq+G14KJrhqbSbwxOcdAMkwSTzD+1Vr9MtVNH8DWhR4uQ/3732P+0nS?= =?iso-8859-1?Q?yDls+qQ4Quaulr0yMjEywOQQxq92WzgWbsKljsMTLmJgK8NaisbYkcM++c?= =?iso-8859-1?Q?z2azivQ6zv0XVt5J0zg/oVzPQ0dcbS7iX1w6Kp5dNLmBWGC1sZnFGoS9jA?= =?iso-8859-1?Q?VC+hjsUQeYunro0BakPSvAWkIp+uLNZMI7BFK01vTIUI69UEQxr3nreHGU?= =?iso-8859-1?Q?rSY64WsDLGGF29XrfX1r9EaP3y/fulsTlVvbJl1XlpTSnA/dYbYpVQ48kw?= =?iso-8859-1?Q?OUJmLdSUqilM5eOYnTBf/hxzz+ZYxQD9N5y34LkearD5c98mv642ZHNftx?= =?iso-8859-1?Q?yi/HDEhfSA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: mnQpO+rl4sX1VARYEExYujnICFdP65rhInhltsCuNU8PuD5Ggi5zYl6do0aeBpSCvaOH7/mLY9U3H47iz5CVBrE7gsBeWGdvJYsPzqnqJtBDi2/I8wDOK4XixcBl5xldDEUBatmtLNeWyZIqGq0L7idxvB1T8PPRhJ0qXujoT6LauVTrudzWwAKWv1tUImf1d02X3TP24D8odxl3IWva9DDY0wZxkG45QKxs1Dl4cgnF9TKxHTJYwe8q9tSvJUWVqrDnfvnTzYgIXkIdnRbavcnOBKM/gTllRCw2EZmcw1HUBWfAOa7miH9p5kFqNB2yhfUD9Fdcopq+InMTK1L2dw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 539e56ff-0599-4e0d-c5c4-08df282c535d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:55.1912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BBYfevEJyeV2rNzFdPnp/Vy+Cf2hqDmVkzafnD3oSNjwkyKCc+si5qKI8/OrOOhEaWVH1IjEHaDvszp2moeSR7eEmWC2pMwAaKofZD82o2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787587512158500 Content-Type: text/plain; charset="utf-8" Before this change, each unimplemented device needed its own field in the coprocessor state. This made the code hard to maintain. Add an unimp_devs table in AspeedCoprocessorClass to describe the unimplemented devices, and use create_unimplemented_devices() to create and map them. This makes the code easier to maintain and read. Convert AST2700 SSP and TSP to use them. This also fixes a type mismatch. SSP and TSP used the "timerctrl" field (AspeedTimerCtrlState) to create an unimplemented device. It is not used for that anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_coprocessor.h | 1 + hw/arm/aspeed_ast27x0-ssp.c | 44 +++++++++-------------------- hw/arm/aspeed_ast27x0-tsp.c | 44 +++++++++-------------------- 3 files changed, 27 insertions(+), 62 deletions(-) diff --git a/include/hw/arm/aspeed_coprocessor.h b/include/hw/arm/aspeed_co= processor.h index acb8b06457..39209d2579 100644 --- a/include/hw/arm/aspeed_coprocessor.h +++ b/include/hw/arm/aspeed_coprocessor.h @@ -37,6 +37,7 @@ struct AspeedCoprocessorClass { /** valid_cpu_types: NULL terminated array of a single CPU type. */ const char * const *valid_cpu_types; const hwaddr *memmap; + const UnimplementedDeviceConfig *unimp_devs; const int *irqmap; }; =20 diff --git a/hw/arm/aspeed_ast27x0-ssp.c b/hw/arm/aspeed_ast27x0-ssp.c index e03653086c..0238dc3672 100644 --- a/hw/arm/aspeed_ast27x0-ssp.c +++ b/hw/arm/aspeed_ast27x0-ssp.c @@ -101,6 +101,16 @@ static struct nvic_intc_irq_info ast2700_ssp_intcmap[]= =3D { {169, 1, 9, NULL}, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast27x0ssp_unimp_devs[] = =3D { + { "timerctrl", "aspeed.timerctrl", 0x72C10000, 0x200, -1000 }, + { "ipc0", "aspeed.ipc0", 0x72C1C000, 0x1000, -1000 }, + { "ipc1", "aspeed.ipc1", 0x74C39000, 0x1000, -1000 }, + { "pric0", "aspeed.pric0", 0x72140000, 0x1000, -1000 }, + { "pric1", "aspeed.pric1", 0x74100000, 0x1000, -1000 }, + { "otp", "aspeed.otp", 0x74C07000, 0x800, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast27x0ssp_get_irq(AspeedCoprocessorState *s, int dev) { @@ -136,19 +146,6 @@ static void aspeed_soc_ast27x0ssp_init(Object *obj) TYPE_ASPEED_2700SSP_INTC); object_initialize_child(obj, "intc1", &a->intc[1], TYPE_ASPEED_2700SSP_INTCIO); - - object_initialize_child(obj, "timerctrl", &s->timerctrl, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "ipc0", &a->ipc[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "ipc1", &a->ipc[1], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "pric0", &a->pric[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "pric1", &a->pric[1], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "otp", &a->otp, - TYPE_UNIMPLEMENTED_DEVICE); } =20 static void aspeed_soc_ast27x0ssp_realize(DeviceState *dev_soc, Error **er= rp) @@ -283,24 +280,8 @@ static void aspeed_soc_ast27x0ssp_realize(DeviceState = *dev_soc, Error **errp) memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_FMC], &a->fmc_alias); =20 - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->timerctrl), - "aspeed.timerctrl", - sc->memmap[ASPEED_DEV_TIMER1], 0x200); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->ipc[0]), - "aspeed.ipc0", - sc->memmap[ASPEED_DEV_IPC0], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->ipc[1]), - "aspeed.ipc1", - sc->memmap[ASPEED_DEV_IPC1], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->pric[0]), - "aspeed.pric0", - sc->memmap[ASPEED_DEV_PRIC0], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->pric[1]), - "aspeed.pric1", - sc->memmap[ASPEED_DEV_PRIC1], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->otp), - "aspeed.otp", - sc->memmap[ASPEED_DEV_OTP], 0x800); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); } =20 static const Property aspeed_27x0_coprocessor_properties[] =3D { @@ -330,6 +311,7 @@ static void aspeed_soc_ast27x0ssp_class_init(ObjectClas= s *klass, sc->valid_cpu_types =3D valid_cpu_types; sc->irqmap =3D aspeed_soc_ast27x0ssp_irqmap; sc->memmap =3D aspeed_soc_ast27x0ssp_memmap; + sc->unimp_devs =3D aspeed_soc_ast27x0ssp_unimp_devs; } =20 static const TypeInfo aspeed_soc_ast27x0ssp_types[] =3D { diff --git a/hw/arm/aspeed_ast27x0-tsp.c b/hw/arm/aspeed_ast27x0-tsp.c index 39ba062a20..7f057ff135 100644 --- a/hw/arm/aspeed_ast27x0-tsp.c +++ b/hw/arm/aspeed_ast27x0-tsp.c @@ -101,6 +101,16 @@ static struct nvic_intc_irq_info ast2700_tsp_intcmap[]= =3D { {169, 1, 9, NULL}, }; =20 +static const UnimplementedDeviceConfig aspeed_soc_ast27x0tsp_unimp_devs[] = =3D { + { "timerctrl", "aspeed.timerctrl", 0x72C10000, 0x200, -1000 }, + { "ipc0", "aspeed.ipc0", 0x72C1C000, 0x1000, -1000 }, + { "ipc1", "aspeed.ipc1", 0x74C39000, 0x1000, -1000 }, + { "pric0", "aspeed.pric0", 0x72140000, 0x1000, -1000 }, + { "pric1", "aspeed.pric1", 0x74100000, 0x1000, -1000 }, + { "otp", "aspeed.otp", 0x74C07000, 0x800, -1000 }, + { } +}; + static qemu_irq aspeed_soc_ast27x0tsp_get_irq(AspeedCoprocessorState *s, int dev) { @@ -136,19 +146,6 @@ static void aspeed_soc_ast27x0tsp_init(Object *obj) TYPE_ASPEED_2700TSP_INTC); object_initialize_child(obj, "intc1", &a->intc[1], TYPE_ASPEED_2700TSP_INTCIO); - - object_initialize_child(obj, "timerctrl", &s->timerctrl, - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "ipc0", &a->ipc[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "ipc1", &a->ipc[1], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "pric0", &a->pric[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "pric1", &a->pric[1], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "otp", &a->otp, - TYPE_UNIMPLEMENTED_DEVICE); } =20 static void aspeed_soc_ast27x0tsp_realize(DeviceState *dev_soc, Error **er= rp) @@ -283,24 +280,8 @@ static void aspeed_soc_ast27x0tsp_realize(DeviceState = *dev_soc, Error **errp) memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_FMC], &a->fmc_alias); =20 - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->timerctrl), - "aspeed.timerctrl", - sc->memmap[ASPEED_DEV_TIMER1], 0x200); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->ipc[0]), - "aspeed.ipc0", - sc->memmap[ASPEED_DEV_IPC0], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->ipc[1]), - "aspeed.ipc1", - sc->memmap[ASPEED_DEV_IPC1], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->pric[0]), - "aspeed.pric0", - sc->memmap[ASPEED_DEV_PRIC0], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->pric[1]), - "aspeed.pric1", - sc->memmap[ASPEED_DEV_PRIC1], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&a->otp), - "aspeed.otp", - sc->memmap[ASPEED_DEV_OTP], 0x800); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), s->memory, sc->unimp_devs); } =20 static const Property aspeed_27x0_coprocessor_properties[] =3D { @@ -330,6 +311,7 @@ static void aspeed_soc_ast27x0tsp_class_init(ObjectClas= s *klass, sc->valid_cpu_types =3D valid_cpu_types; sc->irqmap =3D aspeed_soc_ast27x0tsp_irqmap; sc->memmap =3D aspeed_soc_ast27x0tsp_memmap; + sc->unimp_devs =3D aspeed_soc_ast27x0tsp_unimp_devs; } =20 static const TypeInfo aspeed_soc_ast27x0tsp_types[] =3D { --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787631; cv=pass; d=zohomail.com; s=zohoarc; b=c9J4k7f8xGXK2KEt40I549FcsFrjtoVs+hDwueX5/s07dhEphsz9RzGkJZ+l3e+kPc4XMKy2pu7MAugDIAxSllf+CD8iTjwRbLXHyFe641t31Rka9KJRJeLGe85N/RX96CZ2lamn8/0IpupBa4keFFQcYN5EpnlBzIbvNQsr/DY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787631; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8R6QC7rZsp+5qW6HMI+M+bud2W5oZ8xLIISlTMJd2g4=; b=YFUlRpDK4zSIxfn+BwLvqHb10sTbtQEu67nPo0Ex0jmoQi5TStYSGa9Jh0tYC6KKCHRT7O+CwR3ZcRDaA2Uc0XemXdp9Bkv+WKuoK3qNPoOfkTVYH6ioYXA3uxuFbplrjxTWC9ceO4oiaCN5szjo3gtnHK78nHduSLbns72NMSo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787631515380.5352706563625; Sun, 11 Oct 2026 23:47:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mh-0001r6-27; Mon, 12 Oct 2026 02:45:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9ma-0001oX-IH; Mon, 12 Oct 2026 02:45:12 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mZ-0006Ms-48; Mon, 12 Oct 2026 02:45:12 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:56 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zGW5dCWVGn0PM5cgtbIr9+1NpAyoD7KJntYOREJA4Fx0ENuX81WcsIDIkdhljd9v/U2FmVxh50vTW5sE/q6PVfaqrNszaGb0bgoGG53ucHu1+PiDgK/gMnXW2eS2jQC5IKikCIjidRqfQjeD1Mf9fTFz+3VUFUG4mP2ulEu1yPCna0rZW2+eTfCMGvCJxuK5Y0s8xTnqdyBjYATsJJMbPI/s08QETgqVqHuQYVALq6uB6CC5rZiRAHEsRrq46i1EhsvkvpKUoDxUgNXy8BMTz7914YvTF3XMZfBRAo89siDTK7T1WfQ6hZQOfgwC2vbZUyJbvA4Za7HH+sx6bBnqRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8R6QC7rZsp+5qW6HMI+M+bud2W5oZ8xLIISlTMJd2g4=; b=WQStc66MDTFo4ibDNfAlqgeX1dL1X2SYK+LcJEW09h04ZsCV6IMF1IG8VG33XDDXoj5rpZZ7Tu9m+2WoPrhp8sL7pnObwgUSffOTRlaVrDPY68cXYJVnWAF2wz7JPOUyiMSfuhtMtLk3M343lxmGkhgYdxrEOA50+zfJS9pmZKSLy9k3KKSvl0Tl4fCWJDyr+WgP2HPoA78+hfFJPKS1OBWH9xdvJWc6wZu5NozdQrZiC0mmnIrjZ/qopsx1S/8soV9KAypbE69Wy3nXgultjcak8FQRXH9kOwqWjP9WuRJitYin8n5dEDMhTbvDV+wFH67nEVnWD3mmWC0RS1dUzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R6QC7rZsp+5qW6HMI+M+bud2W5oZ8xLIISlTMJd2g4=; b=ORaChRf1TJFk14xF/gP1vFfi4y/B/Y3JTz2j6z14MzccVfhRurHi6SbEZp58nMb0glt7YMKeotp2/QWlzTxW+GoxtoDJmjhQOwJuNhxdOVWaWwGNt9Fdg/UJe71f1hMhhEKFWy7KuDhcnggfLIrmIlnMg3iab9W3hemQBV/O8W+PUIYqvljhHS7TkDG0xcbMrxOvF+Ye51l4OUzoPiC0wgcRpOejy6/H/7ikrUv5or8CpD9dylQLYuwPvy2HyKM1H3B6jL2Gx3pMLXZsO/AmNrbuTlmMQDZuNeebyDiDNf7D8cplMMwRJBqWnY6d1QraB4d2iNDWcORXhQXFoqqp+Q== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 09/12] hw/arm/aspeed_coprocessor: Remove unused unimplemented device fields Thread-Topic: [PATCH v2 09/12] hw/arm/aspeed_coprocessor: Remove unused unimplemented device fields Thread-Index: AQHdWhUxLzQZ4Bp4iEa6br/nliVo8A== Date: Mon, 12 Oct 2026 06:44:56 +0000 Message-ID: <20261012064445.2571633-10-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 5bac63a9-9f01-486e-b3a5-08df282c53fa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|7416014|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: 9I67EqqLPOMbZStMV/km0ZRwqG+DL6t6kVi8G4+GCRvYdlOs+1YDS7Rvs0xvo9bWlvd6VnkCxVw6y+g2LO4gR4GPkYjXlFPihJGTQwaeOc4gA5h5ODpqtxY2/c52Hh6KoxbQObsyXeq6sDIKgHBGJgTnljKB6FZH1FjsAo3uDRL6jlnDcR87X9DpCowjvJkwP+Xjsj+dqRpXoNSrdTG/EvRJUnTE9YTHB0wjbfM+k5GjBt2zemnyHFbNwoQIXkIY6dMvcN7u1bcZpO6U+Bb3I+Tyk2hiNeKGuAWBuIB3yP6bU2GMDJpsiSgmXI1Oa/0i0vbD3bOuZGIyFzEp3fRH7bAIbN4iDhUIfj5qr0CV9kDCqh0Aeqos2ehG4ws5yWUoM1SczIuienHI/g02HRGESpmKyKT4OHE0mTUEtpXlp0vTnU+6WTbDkkDy4j+XloIzTWf1V98G41pNpB4Ml1sjeGs8Fj3xReA7kuwv+Nu+JfNx3G0EDlYEhBmWI6eEatrljrqttjjEC1cx3gzayZJ8R/nz//gaarbU0J/Lm9sW4Q/azUWn6/PGrlFsB7Oe7/+tJ3IVbaZqSPtK2PEdkSUTxx12q/Dvk+JqLJjZMyw7J6yGFcDJc3ax1XcxZ1Q2kZdp5tdsWtfV6fcdvmcXY/aZJhtp9AIfBYTmSmXDKazocIpSKJ418mDET5a5ffPOrXeXuMFLKHve44qGvdGjC+FYoHK+LuAMziugUclmWuppyB5Xlw/vbN7ZvznXbbce63mJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(7416014)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HxkUu0Vk8g+hrQkF0Znkt223Al4J9xG6rBIGrH3+Rq3K6BzmslBZEm2hV+?= =?iso-8859-1?Q?sJetWFmJoInd8kSC1hFkGbscqt6EAULCCEyyqNF3qZHTOdA8vqndN18A7x?= =?iso-8859-1?Q?CX2ANJql0wapkfk2KM9BpFWToKOpnJ3yl7x1fJZwS8i1uoYPC7xozA2pdN?= =?iso-8859-1?Q?YLJlTdhEchICfhOpVtfLhVmuPdpCoSuBb6Ns2rosL2FoNfsdfV2p5q0s7B?= =?iso-8859-1?Q?LaommIN/nfDnjSHZRH0nDVhkw4w36BYthO6+ZJFS+1bgdHI28SF+mDR6lG?= =?iso-8859-1?Q?7QZQd5u4AXcrxi4oyeraEG/cpBmj7XSijmeqLmNs7x4jwzEFsiUQ3rQLY7?= =?iso-8859-1?Q?M1zRe9tHn93g5D6oN3zpCqDQTKtli3rSrnPiOreINFhkZQ77WTwyLoFt1m?= =?iso-8859-1?Q?030syV9VgQJb9dsxgXeO+w76sxMG7fGx9okH1TNqjMTe/oCLY/uy305THD?= =?iso-8859-1?Q?AjZ5UlfOppWrLnyzKfo/X5zHekeJHYAQbE3cunDrr36xDCq5EfcmdjHakN?= =?iso-8859-1?Q?znqgitt45uoLms49ZDpyAF+UFwwB87O8hZ7qDO4Ne2WJT7aaHHTKh7HRkO?= =?iso-8859-1?Q?X8a4fZNFJVJ6hyrqKwDPoW8YiWSTWM+rtuFjLIM469moH4vhVO3V/K4wYK?= =?iso-8859-1?Q?Ov6JTu7GVmT6GxGIz9fou1qsFEig2cSnATgIkvBSVQrvzx9V/PPDn6J94y?= =?iso-8859-1?Q?m5QJhObEXx1YLT5da39tObV7rvhtqNc/pOgPFhHmOd7/Cews+jRkSlKe14?= =?iso-8859-1?Q?m5r7bFmkqlcMKCyxh5BBNEBttvaBUVoqdc4ql5RgLb0zFTMx2oif5Dcsuy?= =?iso-8859-1?Q?k2xq1AftPOnj5OuQ3ocJ0gjZxxUq65eCThSyeJyH+YzjS4X+bWLSivZNFv?= =?iso-8859-1?Q?FdQc6iA9zYc2eQA9ltl6cz/fvpSjD68z+vvbAO4Z6FHz+kTJ1294ATt+ux?= =?iso-8859-1?Q?y+MO0sVHQOemSlMLPRUjxrPdsk4QA97z0YQ8dRWb7q4HBG5mL+X7wtS/SU?= =?iso-8859-1?Q?vj4FMVuheKCZ9sIKZt2DG/+jNomtL4dC8iDW6YNoJ8lUF50yeOoPTzyUkP?= =?iso-8859-1?Q?mXxITlAlHyME1IIL+SnWlyfU0NK4Xr8qG6LNwOwWJs9lZSrMTOX19GSWYJ?= =?iso-8859-1?Q?I1k2yJzBJ+owwaF3QUcrE/W5OcwVKVtgp8LTAc3qBs++bDb9+dLS/28ke+?= =?iso-8859-1?Q?nQu+rWfy2Liroj18IzR5d+VqJewPPixdMuQi4MYKpZ3eVZYtJ1SqTxE2YS?= =?iso-8859-1?Q?DL0f1thpAdmhUctfzTQMAhkk581FtKZ7AmYndmq0/pzaAjFF5/yruJKt56?= =?iso-8859-1?Q?/bwfYxLjHhC6DIkGMxkPqeXeJ0KODdsLYHakvyDJV6ZUeOx8yX+H7OJ0sA?= =?iso-8859-1?Q?DTD1sRTDYvNqZ0UbbSUDJId0BJHk3swhxofwqQGO7uvZM10L8gF34+oeEK?= =?iso-8859-1?Q?KbFTUKNar/fGMQtBuQQSj/R7JV7UqlP/zJ4HWzeGv8tcF4B/VMjwpE0k2C?= =?iso-8859-1?Q?Jd9z2w0QYptu41ZxzjjYCIQR0Ck+VXsHLV7ZOtMoCkd10myrLE0gvrjkWP?= =?iso-8859-1?Q?o0tWqsUVRgLm81T8jURN56qQG85xsF52SXXa6xM96m3HI4kxECVBD4mz1H?= =?iso-8859-1?Q?OJpaBcwLzlxFrg83tKeO/P+MuKM/REOQFQubk8B2nwro6ds7rakXdbfV+q?= =?iso-8859-1?Q?BcP9G38ycH3s5I+Tm4/e9vjmG1UZs0MD6+XM0eFIJGR+DYRYyax10qovI3?= =?iso-8859-1?Q?uAlZMLlbpTzF8ARnizY14tSaZi0tMzl6UyPsfP6K4hHF6DDXLKUdhJCSis?= =?iso-8859-1?Q?KZ9uIjBWVA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: PpkTxpXK+XIqbToh/bB8Mmii4Vr8zS+xzroK8oyyXAnaf1/s3g6KdHfmkE5DQA2gT5ezRipxFRIKnRQdw93nR+qW9avGa6KjPCSNzkcq5ieWfEjTtg/Qba/E1IDF8HSog5Q5A8Bv33cS76vU94z9+T1aFCeLe9FhaOnEZ2E31IYVMfmOJTFeo9fCZMf83oGP7FIwZ7vceQzDULGHtUD02ltfaLF1Ye8hgZLHi890vwOq1EIxfAa2nK1utSou1x6TsC5ZEEeefu+ZSBORcQO+UrW5YF69NyRX5uUX/oMFAd8dIiZkpIeNp1gXUgFVJIbsN199d18I96u6o69VWn53gA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bac63a9-9f01-486e-b3a5-08df282c53fa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:56.2289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: obKANugpCua9HSsTl5czfCLZVlw9c2AoJFVYw38pPzKSWRlbNcPL1UMU+Vx1J6pFSS/U8UQ8o7Yy7xejzBnv/CV8sQV7+y25qgki6bapPCw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787632249158500 Content-Type: text/plain; charset="utf-8" AST2700 SSP and TSP now use the unimp_devs table and create_unimplemented_devices() for their unimplemented devices. Remove the old "ipc", "pric" and "otp" fields in Aspeed27x0CoprocessorState and the "timerctrl" field in AspeedCoprocessorState, which are not used anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_coprocessor.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/hw/arm/aspeed_coprocessor.h b/include/hw/arm/aspeed_co= processor.h index 39209d2579..b0d72f9163 100644 --- a/include/hw/arm/aspeed_coprocessor.h +++ b/include/hw/arm/aspeed_coprocessor.h @@ -22,7 +22,6 @@ struct AspeedCoprocessorState { MemoryRegion uart_alias; Clock *sysclk; =20 - AspeedTimerCtrlState timerctrl; SerialMM *uart; int uart_dev; }; @@ -44,9 +43,6 @@ struct AspeedCoprocessorClass { struct Aspeed27x0CoprocessorState { AspeedCoprocessorState parent; AspeedINTCState intc[2]; - UnimplementedDeviceState ipc[2]; - UnimplementedDeviceState pric[2]; - UnimplementedDeviceState otp; =20 ARMv7MState armv7m; =20 --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787622; cv=pass; d=zohomail.com; s=zohoarc; b=XoREQtkVYMsfYrr2fktaURFbpMXQ+PdgAAiaifd/corhdAvu71bXGHrfm2WRcG1Um/ZhRw46F8YYSBjhV6RwcOU4BT9QXPNkQqoG/8Wt0lP5bFltxgQAlLraB6cmdZgJD5tQzlu5I9VenrJwLBsTErz8s2o72dJPJMMiWYXEQUI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787622; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xYdPpEIboSJtD7Zj2dweGki/BSXxXo4tASm78nIqRiQ=; b=Ii5pdNi6J/+jHL9QpCLh9q8vPQMt6Qj29QI16NnlZnen73Ma/3OQOPxGowR/hPn/r9aJJlSHaXqL7K1/gWQ6aG6tFN0gpL3PI4yltOFLMWpRXl+oqDml2bTFSFDgI/RFKrYiZ2poqPFF+yAotAzMIaaFK0vUbV4RTw+i562OnUc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787622414649.6968122141415; Sun, 11 Oct 2026 23:47:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mg-0001qz-4b; Mon, 12 Oct 2026 02:45:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mb-0001ot-G3; Mon, 12 Oct 2026 02:45:13 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mZ-0006MT-Sm; Mon, 12 Oct 2026 02:45:13 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:57 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vGd8JfRStsl3H0yHKzfQdi4fZ/6eTxzTDYPJmmNLJxIIUM62O5csgUlh2PS5yZUXYHv6XHjLgmdTo9wfVCWk9udatZI0i6Cf6+3P4C+Ou3hBcOqTUh0S8Ohiguwg6prMLApDV3mT2dN7BYLjTVoFpLvrUMeab/blBbQNvFWPVd+xV4MC8KnuzQ71FH0lBetUJIuz5iYhz4wB3iD1dJhujsjzIyfbJw3Xktxc1ezBmJDtNNKNSp+jtm8JhnWUqeo8eaPBk8GZImzCQ2E0Rr8jLZPR5KB00YzfVn6GfnbmyE1Mn9/+jU5pQRIqaVjfJTwLZunCOduxWI8SyuN9OIeDAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYdPpEIboSJtD7Zj2dweGki/BSXxXo4tASm78nIqRiQ=; b=Wx9pn7yXWcsUXqVM8YINqB1qIh8NUCK+iruRHAefk62/b0+j8phsyimxMtjZCeh8gkNGaK001dBCQ0jO/eAbNh+FkUTXJZnrDrVarRRRs11gOQKNPXf16N3oje+zwTsa6LCRAZ+NbOGDP0hQ73KpEfVRKEu3rUVIQKFNL/l6IUwgkQpoMlI360FJbXjw6e92H1UI3EKuToqZyldWVIquJARgNuWsTE8Muq6Ume/m1nNXX3cgPTcAxm49Wz7FpWdX8FjNToanhDgfFrc/K+RapCOG7ulQFPo/Gp5AWD29KmGQV15TXEj20n6xrmWAxCSsehF1GLB1aiAra26RKuBTYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYdPpEIboSJtD7Zj2dweGki/BSXxXo4tASm78nIqRiQ=; b=UI46IS6PHTEi4bHwTod4Yjr519zfLU0Mkv0UrwUNG48yHTJrVHgtE5GWKuJSgtK4F1dpfXoz+Ntz9P8sdWColf9DN36mAsphauH6kOKNA2JjhZ4avysnbdAKz6AllknpZfNdL8q+61t4+TDJ0srVtETNGHU/J74BO4b3ZcyeYLR7K1PvQkDpucyYzU0GKA7Hf5isYLZiGDxYFGrqrtQczUvxtMIUnsoCHSkGxbJCxAl8s24D8CDrALcsj9Cy0X3b/LSzikLxz3CLV3LNgrZ/fn2Y1Yi4O25mToGN+GEXUckzOeOxQUaKg4L1S/yokL9ZaniLPo9ik8A2vzG7wtqvDg== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 10/12] hw/arm/aspeed_ast1700: Use a table for unimplemented devices Thread-Topic: [PATCH v2 10/12] hw/arm/aspeed_ast1700: Use a table for unimplemented devices Thread-Index: AQHdWhUyUF75Wg8dDUy4uRschzSKlA== Date: Mon, 12 Oct 2026 06:44:57 +0000 Message-ID: <20261012064445.2571633-11-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: ce988bc1-be9b-489f-273a-08df282c54b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|9063799003|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: F3mBOEZ/w0rmxWwN13JYjZHznP28mTXazsyHlvoEBT/0pzVFH/z0E9S/9w/RRepQELwXkQpyTn5Kor/i9Zt9Rd2Kk4gRFs0Y0gXgm/d6fmp3FV9sdcxTF60tREr1mbW3JT7e+B9Y1s520Sqh4STyRW8L+vfDKvrErUtrOyAa8eoA6JpoX4OKD0J+SkUCg3qTkCEgxP90TWPRfjNZiHnSA946PmJouo19VOcf2niCxA4z5WCXFDMTYtnlp/J5uFPBFlPuo3tjY9EQ11po0NKdcAgtvRd8KmSgmnmzv5i4nwM7jZLpFsbvkVdvchaGB7nT8BnbPs5vgWRAATRBWnOpYrf2aEL6ZwRfVeBILPBsotw0Cd5Y1Y2cGVIqWnbPgO3KS1jDZUutSfqV3GliFVGurO53a2aNe4ddjw4Em333XC6KVjvZoj3Y/WIbDSnOtXX5Pp2TQFvI+g/Kw8IH0ZoyPqSPa870y8+K4q1BF+ZdAjDyiVR1uUMV8hC5oMV6gnNa6cXv6ZSxHCb14KLTelqa4TM4d4Z1GADUtyROxb4pR04+GyTqp7nrlRtd/HpDHxkzXO+0J6rcmYeuEinx6jiAFWL3jzoXCBH5x0Cke1wFE7lwP1kHWz62pxUah1YYhUU6viSK5mlInlZqfcbvXmnboVJM0c1VmpwH+tRR74GyKYgB5/zjfnw1VeVbMTEjK9mxNq2kBRchXa2jhnRoc3s8f3ypTml48Uq5WOQm2pc8DOLCjHYVRe+zXEvLUZDXmsjr x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(9063799003)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?RWKNOUEptthqKDTPgLCKrHLLwkw8gYsITIwuaxuBui1KZZoY8F/HtfXlB4?= =?iso-8859-1?Q?NNYqCC8OAvp0rHkseVZMZQYoKZhWE6gwKGhVaBrVq8OKXNu/6I9vJNYpWx?= =?iso-8859-1?Q?sfKJdwdqFMQvtDhEfe8IlQHzflGVM2vfTuhOe9uMMK41IPz5nBXMXfaC9g?= =?iso-8859-1?Q?B4XWrxAmCs2H2nDdX6As/fIpRG5oXkB5OfM5SBiIsGWIfSkt2lI9iU2vyA?= =?iso-8859-1?Q?JFxWT/zfxMdCXRys9rbx2lv/cKV62l1SZsJOo+KmtAUUSMIr9UtQr/bxq8?= =?iso-8859-1?Q?C47iTT0Kc4TTeH3ekGYfPolrdLP5mC+TIyIcoddsXpMH1LKCY73Yd/b9Ag?= =?iso-8859-1?Q?ofGSJyM/u3DhspDcc8MGOP6c/Kn2sxv3Fp94anT/e09SrPmia/bh/qfp2I?= =?iso-8859-1?Q?k1ATOa31YMKbTl0lA40YhoL7+VC6UnCTQqWX+vMKFzjRP8lfeHr4rjGxoB?= =?iso-8859-1?Q?MmNTLmWuXEl5MycSOcACEZIXw57EjgKq07J2ZoUl4KOERtQUx0mkSEPgmt?= =?iso-8859-1?Q?mGWrP1b0eO8o9f1caBrbEsNrdydu7PXZCpTRiUwp7blL5LpvgW1VWR2b5w?= =?iso-8859-1?Q?ZFY18txJY+N10/kUmkZ5nsiSOJd+/ihsMppU/r74FOMHirrzcgO5/4RgD5?= =?iso-8859-1?Q?K2aVgcSRU2+ew3QtnZqxbbzpIOYQofGV6WDKV/cbWuozS484EYCD3hQp+e?= =?iso-8859-1?Q?QDT+ugsxpgtr1id1NiYgu+pjJvfEX/twtRRbWbml2QFPXgLK3h+0yg58oO?= =?iso-8859-1?Q?BpIYKMTQmaga45CYwHGjxlsQ0oiQ2/gSUQpTRoGiCwSPgz4bS8ZXTUi/2h?= =?iso-8859-1?Q?J4ttz6KVz3fIk+y9yuzSqw0TmnAFhUVU7ThL3uXZaYDxLqQFpZy5XmNrug?= =?iso-8859-1?Q?i0Cc7s++6lpnBDuHGBNCrTlH96iN+Txg1+BXhbyBCTiW6mje2qt/LnqwNM?= =?iso-8859-1?Q?7nw16rXntdwKRUdLdzhtl9vqR9NA+Yab6+F12NQo21SXW0XthfFriZFPjE?= =?iso-8859-1?Q?qNsZZc7rs68Bj31rwj4S//HmRvuSHuyYSh93riQO3hi0If1GV2MlwGj+IH?= =?iso-8859-1?Q?o391r8Kcyg/DCLbP3u6xvCY6z/59HUllf7w1zJHraXi1/0uiTVkZSF9ncG?= =?iso-8859-1?Q?Njy/LaeNDfnwwXshdMKuWRp1h0eZnZsCQou3lMACjBrxp7K1AZaehlSmaI?= =?iso-8859-1?Q?UypXEr7Z6gnnShm6yQpmDGVJuh7TU4w5YgnZZzr6TdV+2/q5/MO3mfYwHF?= =?iso-8859-1?Q?1oCC/xOoobbtdUlFXX5CTSMgAK4mvPMIVmQ2INfycK15FKkTzNRHM5koK9?= =?iso-8859-1?Q?92gGmCkYGfwaS+18k3o8FhK7qSnOCc3RmhY+zVwpkM62o+UF6AeKrKZWd7?= =?iso-8859-1?Q?AaswloRzkhPRg+dO9EMJkcvBMl4iD+RtcGkrJF/KOCxqv+sjtzail+SO2Q?= =?iso-8859-1?Q?rY48qOeayYyR0dt/bV4adW/pMDxghCO74mx2XuaW/K0jK13G/AEWOqUsti?= =?iso-8859-1?Q?ZKz+GQVHWuUVee3aXdUEzpbsQnD5VaMPpQtk8NSMF5IzmUrBoCk0WLgF08?= =?iso-8859-1?Q?XknN3prlL67aMN25fZrAPtVV1seZ2db+480HuQc7j4KCBq3M2bLc62jMAp?= =?iso-8859-1?Q?CG5tXZATMzU9kMhH6d6J/8zY9hnkzwXmdUNTTK3kXx0qodmXo2/p/hp+3s?= =?iso-8859-1?Q?WSmPtkq01tw+8/dF6WICCZn1cmv+P+e/3JTIhD6ZKigZXDcrGbsRnQZ4JZ?= =?iso-8859-1?Q?rhHuHVIfaardr1PTf62rbb8yK0ESmEXfxBjkESwJJSZHVSMT2TdnEMhWqu?= =?iso-8859-1?Q?q6P+det7lQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: waomHp0bbmDkjSBA6TjjufeYM0aPuMRf8KY3qv9d7x9iRnHG7leDND+YfqhA57rHNML7+yPuEA7CjuS1y3odeP5RYducu0GMH/oIAV/ioBVxDtKcOYY3CSTQVM6c9Ww2woR54JqNMYLyv/sqRJ2eiHMwiSY9rOhfr23Ns8hzmGNh5HUaD5B/Q/JHDZlzw9/sID1ePCUi4sOW75n83AkekU+T/At7vbXJu/vySUgpd7OXMngQC0dtXZjNqDS8UMP/58NzSLObUjWZEhpKXyj8fSr7Ci7t3WmGcV0d03mh9gYhFYiVssyG4z4epLuvAdQbMGJuHaVh/GP8TOZWVydO/w== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce988bc1-be9b-489f-273a-08df282c54b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:57.4056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iBbdcZvkyg67OeQ+2wxMOV8sjNP407fks3E32Xbh/lzpVSMTDRQnHVBU3sjTk/K7Tj9G22/y2cpLHximWC6/tI5fvC/7oOZ4/SjLX1860yA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787624203158500 Content-Type: text/plain; charset="utf-8" Before this change, the I3C unimplemented device of AST1700 needed its own field in AspeedAST1700SoCState and was created and mapped with open-coded calls. Describe it in a table and use create_unimplemented_devices() to create and map it in the AST1700 memory region. This makes the code easier to maintain and read. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_ast1700.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 5af5da5b8a..e5d5bf4056 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -15,7 +15,6 @@ =20 #define AST2700_SOC_LTPI_SIZE 0x01000000 #define AST1700_SOC_SRAM_SIZE 0x00040000 -#define AST1700_SOC_I3C_SIZE 0x00010000 =20 enum { ASPEED_AST1700_DEV_SPI0, @@ -51,6 +50,11 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, }; =20 +static const UnimplementedDeviceConfig aspeed_ast1700_unimp_devs[] =3D { + { "ioexp-i3c", "ioexp-i3c", 0x00C20000, 0x00010000, -1000 }, + { } +}; + static void aspeed_ast1700_realize(DeviceState *dev, Error **errp) { AspeedAST1700SoCState *s =3D ASPEED_AST1700(dev); @@ -181,14 +185,9 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->wdt[i]),= 0)); } =20 - /* I3C */ - qdev_prop_set_string(DEVICE(&s->i3c), "name", "ioexp-i3c"); - qdev_prop_set_uint64(DEVICE(&s->i3c), "size", AST1700_SOC_I3C_SIZE); - sysbus_realize(SYS_BUS_DEVICE(&s->i3c), errp); - memory_region_add_subregion_overlap(&s->iomem, - aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_I3C], - sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->i3c), 0), - -1000); + /* Unimplemented devices */ + create_unimplemented_devices(OBJECT(s), &s->iomem, + aspeed_ast1700_unimp_devs); } =20 static void aspeed_ast1700_instance_init(Object *obj) @@ -238,10 +237,6 @@ static void aspeed_ast1700_instance_init(Object *obj) &s->wdt[i], "aspeed.wdt-ast2700"); } =20 - /* I3C */ - object_initialize_child(obj, "ioexp-i3c", &s->i3c, - TYPE_UNIMPLEMENTED_DEVICE); - return; } =20 --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787631; cv=pass; d=zohomail.com; s=zohoarc; b=BzdRdrLVRHslIQhgCWxBZQFyrt6f+BYBzKKTx9FeCacxqCQbFM7vmrbdMufuF4rf3MrEPIPecnDP91dih90uu9N1f4WM/47BOof3ckosQCAwqNwAQlPVqk1XlqLaYFzyPvL/MqTdC4ueXR5PAN8I44PrWCERLjsfflHMiNWFWio= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787631; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=smeNMQ3+Or9a+GPIwQu7lRYbrnPnzjwRKoH0n2KDERw=; b=a/Bp7Q7YELHXTVeGwuDU5nxybbVq5dLmMi/eAJ9iocqKf4xQPOyQ7PQHmcurFfcW65Y/wibNjzdBZjhoqeID2t0+IYp2NHO2QxUw0QGW2dTCvetChqbwkv96Psqi0XUln1wEFtZerFay0VEbQ2iMz6jTvu/gVhGcfcJ1Ezhw2Ws= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 179178763128134.61868435213171; Sun, 11 Oct 2026 23:47:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mh-0001rD-Fi; Mon, 12 Oct 2026 02:45:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9md-0001pn-1P; Mon, 12 Oct 2026 02:45:15 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mb-0006Ms-Gc; Mon, 12 Oct 2026 02:45:14 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:58 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EI0dI2na2avLHBTlOuvpTjRgypdtNf7KO9IznjUGJAwYQQZh1agqNmaq0op4YH5VUulTgV5DUQCHBQIP5ojdV/oRsCVHAuhi9+r4iXU6DfynG4RYwg48PKSpQCSfZOcNQf1YfAvRsImUPyFPLJ0yqppYOCNW/l9HjkuXJKWCui/1hcWaImuGJUH5P4jySeZrvRoC4LjTYENbYMuahODzAF9z4iU5+wB1cOruFaieOBV8/dJO62JvMYUE7yqzCl7cKhJEGwezjq2gCggy7r149znam+kASc70nkq+N6LJjLv2W5Cwuz0JbP025z3Wr10lYbA+/Z/VwWUnafljEJn66w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=smeNMQ3+Or9a+GPIwQu7lRYbrnPnzjwRKoH0n2KDERw=; b=C/cnwV4/QCPERPNyXcuBK7hvaoYBhEuNQ15613ZxVRfdWQhnS96KnxSoUYziWdZPBkSiRAjbHN1gwafnMWIIpipL76JQrFO9FW/UULQnsgU1hQ7x9fERSnsJJWMyW7GrtKMA6yWTAi+qlop8eLIEyrw0AAXfYxpJQesj1cCkpzMD+2cX0HLnbOyAFhFCXxosXHwBXqZ9Sm4+v7+yTpGvVuBac5097jehUKyFf3HpchVks7De87R9Cfdz6AQ/Inw+V2u+ixZT6IxIrBgj+lf/nuyKfEO5C6NZlTlRCr/gSfe/6S+v5Jzb9CWZ7kIxY4gvO9v5XmSCMdyzGSOLfrIwhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=smeNMQ3+Or9a+GPIwQu7lRYbrnPnzjwRKoH0n2KDERw=; b=QUCVxfnFh1hEjskL8RUn4f6MMQm//yjv+yirfS5hNHSX3MSsfvnddGB21jPpjeN5+Xzv6rutcx34bdmyk6V9mW0hm3Tx1lzDo/DiI0ZYG8OuGDjmMIj65p3ITddQiZklK1YiVSnbgEmb+NiGC5kfHChGoDNlRIhdlYMCaoe+hyzXu6N4OuWEVwGwbR3jQFjH32C19IWA1Q5ex+aFwO2ExtdD1C3NdHezWiK/BdEtDUdWWgs90NSbxbpq7TkcARxYHtQEOTRghUS0FMfwelnJMCOaBM8krcW1PY5n2bDbBEzEshW8xQ7vXd/a5xGvVSLV6PuY96XTVhUjlOGqssH0Kg== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 11/12] hw/arm/aspeed_ast1700: Remove unused unimplemented device field Thread-Topic: [PATCH v2 11/12] hw/arm/aspeed_ast1700: Remove unused unimplemented device field Thread-Index: AQHdWhUyH7u+tI9C602apCCBPvLLaQ== Date: Mon, 12 Oct 2026 06:44:58 +0000 Message-ID: <20261012064445.2571633-12-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: f8a642a8-5f10-4b60-102a-08df282c5560 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|7416014|10067099003|261009220027099003|261009223327099003|261009221227099003|261009221727099003|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: xNf0YZIq7jz6rQ8sghD9q4K4OyukjLrxUhoCrkgclKtiJk1XNBrGyf8Ntlxac1TloRep5TPsNRZJUXjgvSREbA2o0jMPlVpLFFBCYYLt0j3grZ1ZRp2+AI2Vhw7eP58hd1obyNU9zfLD/hXo8SqY7VsYi/o8Tje/hH1jUqFxDXxmGEwXbZkTbHHsrkAZ+R6Rc2h82qzpnXD3sOGdCt2DuKIGPJUcvvEk3QlMIN3RpTi+Rjq1P1pgUdxXTkrOqJ+hLdT4Xsz9pMsv0bACCsQHQxERBUqzLoyatCKf5fkIp1RBhFqDkbc5F5jkyKEbbH4wJOivSNH1EVY9HSdj/Cdrl4JzXcVtGiB0dhFYFOiFhmXByKZmnKow8ssjxqx4wC9Q1kTirVKDSFh7nXEqvShnwUuZ26srE0/48gOT0qqzhTiqOzU6nd1tvZPDMvoYQXmj01ZrIyHDz1l/Uml2h+KJljl9ZHwc8gfl6zhakoEmDfIskWivd8bH7YRSuhFeZl/oTaDS/0IVgQBW9DVPqPoETstvpKHtrNfFp9uT2OrC1onn3wQdK4VTgrXogzpre2BgClIdqcoH7S/WlWZKWVG2ZDwqbgYcz3GUF7EmNC1nh+7VpaTDsnkSxXGTTMnHjhoJgT+WJaXJxN6kP9abMi3HNq+G50X6hwjDXp2hU+DoBTt92Iyn3UsT4TT09wquVTLEuUN7XHAa/t5mUfRS684UsC6iyLrKq0a8dEdSF9rlAQ4IueUEVv1AF91abKwHPJUY x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(7416014)(10067099003)(261009220027099003)(261009223327099003)(261009221227099003)(261009221727099003)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?TMGrBNxzgO1cdjsyyvk88NEsVTp44YjqYHVjb73vDfzxcnsdfuON3qWtqR?= =?iso-8859-1?Q?lv0YngXIVKkaBIXRFSdB58rmRDPfDJ44DzS3RfWb8KdXrJJrBKtmzdtC49?= =?iso-8859-1?Q?kiX+0WfuHiRWm3hVxxXYhf7JM8k5p+VWoJKMmUck6ckldwu25awTLz50IU?= =?iso-8859-1?Q?fRIbIunJuBa8ryrgXhWqL25Kfjn2s2Dm38csTaU9vxgrqvxgCf/8uEuM7P?= =?iso-8859-1?Q?eFvatMihDP2uQlJVTqLtJk3JivvUXY6nIkOYGGNmQvpYpaw2q5ricXlw6F?= =?iso-8859-1?Q?MuZE5n3zS3JzDmrEzQV0Y1kVJ0STizlySBYMaAUgUqVdnYU5/VQe/1Q6V3?= =?iso-8859-1?Q?HDZO8Pg/f6n5HdiIzHW9E2Q8FQ/8DRzHr16UPgEap4gxshl41YQUqYPxKn?= =?iso-8859-1?Q?pkFxbDID0Pi3sp6jvrm8ez4F9GvJS2eJt1V9SOnKlrCKiGSnXYtcqdvrOE?= =?iso-8859-1?Q?MhUTx/ajzMdK2LPYosbUxKsM+t1ujHCW8Id+vtuuob4/CXUy7Hz6fXNsVP?= =?iso-8859-1?Q?1i5U2CDBp33Hnj+hKprNYnzXIwS2WxfRd2xjYoN1ayxfOsNYTXXpBnol8z?= =?iso-8859-1?Q?Tt/TH5b9ib7S4mWowSwil97pZagSSHdQnOwqY+LeYkvWuknSvc1BXqkwQr?= =?iso-8859-1?Q?Wyq7NeYMWNzJZh4kC3lUF/2aurSHmYAtp1C4i0yf7yr4OgqyY9RKFZT2Mv?= =?iso-8859-1?Q?whMVUZCzhlf5OShk3RvbwOvfrYdCUIYItnJymy/O2d8ZxSSFgb0eIyZYTM?= =?iso-8859-1?Q?gwqdC6cw7EnC1fOW7H8ITJjmxGQDYHn5MEhRr+1yt39BwavRS9kkS1kIzn?= =?iso-8859-1?Q?CnIV76OMA+KAyHcOrfUzfcnaTy12QiDeMzECF2rnexdTSAZzV85EBtLDB8?= =?iso-8859-1?Q?8ONDW4fCTvE6Tl8hC30T3VE0bI7+nYX9+4chedCyW+fdgSmhC0rTpwLg5K?= =?iso-8859-1?Q?DLMK7CsJwO8GWWeDbWKhiy/edXFdnxfeJEyA7HLqUQnxnKWR0s6zeIeo7K?= =?iso-8859-1?Q?sUc93B0F4/eAeXqJ47V4Bl3n6un8av3bwbmq0uXHlV2I8fLwQs/hqDdvjK?= =?iso-8859-1?Q?5nhZ6ZU7Sr1qff+st8zv/VMnTm4euiNXo9VSa1ns9ecASFPeoqKOCUSExa?= =?iso-8859-1?Q?cD8R3nUSlrpCr4xkzwWviAPKD9wtHnMl/0DYiC64hfEEErViz3TH9+B2r1?= =?iso-8859-1?Q?0XQP7hELcn1mUA4Qw7mjvqw1CrMSkMh9vKxQzmUnDFynRvkuVRTjBaiYrs?= =?iso-8859-1?Q?CKfcaOKHPKednUNXPU21Lcle0FR+jCqhLGGjr2HeLFIAjPCAafIY82YKhB?= =?iso-8859-1?Q?HIJfjajSiWFDixsKwXVXu53L1/3cwlHaXf5eI45pVB/N4q3syhbnl2mnCU?= =?iso-8859-1?Q?sLdbw9EcSnkVeAftcocjTNfaOq19upzshUPArTSlL8Ft/pPjwZGIJXr+O/?= =?iso-8859-1?Q?eGMqIQp5KvisSMg/r9R+efeUKQvoQ/TXlhQKSlzdf2G4/Csl1OP/DxzACs?= =?iso-8859-1?Q?Q+vkYShTqcfogJg9VSa7uTV7cBY081WqPa2wkiWxQHlpzvzGxo48sSwU1+?= =?iso-8859-1?Q?rkTqcDX+UGh95OiouPDGbilz+W2NK/Ih3UvlqI29JSd07RzAvHG0z4XOKK?= =?iso-8859-1?Q?uHOfqShfXXhvVoMgvibpvJDteDSGFgoczSk4doqE9VOKaYXmGYYf2/gNLR?= =?iso-8859-1?Q?sfypCen++k7qenix1XaMzhdP/ckgjQ/8Fh684Xy0Yy3Qfh42WKJRA5ZQ4I?= =?iso-8859-1?Q?aEnvXpeDJ78vlNrEsHkrhlyfX+nQpUnKUQPCjQsfZyuasX711Cv04aPhsb?= =?iso-8859-1?Q?ty5gHzetKA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: blMuz229iy3ySJz1RWDCQz+n6zvmeuurMgqXen/Yuwvl9B8WWM5quYIMWtmL3twOZSJCfZfBFmLFx2d0D0xYyuVYE0U3kDSOkbv6168i2O1FzGC9p7b2cEKq4SDFmTpKjde/m+R0cugzisocm577C+WWcH3GFFMDtI55dz4a7Q41b1lNZjOWB8kDQM+iEJAC8o/KcYYmeRsMSaWlEfrzmZdKZDwbF4/FMI//Qls2ZFOYFIfcu3agYFc+y7IJkjh9YGYHmcInzEXT/PKQ/+7NvQI+iwGWKzwZk7qwCVzRu6PluRISrbfN7gwvy43cP7PyIZcW4ZhXV2dZRyCJNTK8+g== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8a642a8-5f10-4b60-102a-08df282c5560 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:58.5857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kvrV+7VbDZREzehjUh8QPxD5Z8rOFupJXriBPaAiYgTqZflYvfbot4z5/o9fVQBVyrQCFuposqXz5PZMWgaQBnH6NCpMzTanOqa8vPeA8Ag= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787632243158500 Content-Type: text/plain; charset="utf-8" AST1700 now uses create_unimplemented_devices() for its unimplemented devices. Remove the old "i3c" field in AspeedAST1700SoCState, which is not used anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_ast1700.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 39c5977cf1..d30483c88a 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -47,8 +47,6 @@ struct AspeedAST1700SoCState { AspeedI2CState i2c; AspeedPWMState pwm; AspeedWDTState wdt[AST1700_WDT_NUM]; - - UnimplementedDeviceState i3c; }; =20 #endif /* ASPEED_AST1700_H */ --=20 2.53.0 From nobody Thu Oct 22 19:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1791787620; cv=pass; d=zohomail.com; s=zohoarc; b=GdWLbRo3iTMP6XCl+Sbi2RKfYzJ0yvm3vTN9ZbwLfJMAuKeCl7OIjshA7sonadsnaAjOcnr9OUMKgR0JHf/Fi6WsvCPiVmTH7R6q/2Fdb5YDZ3sSgsujNC9dPJnT7q50pfvJzA/E8mmM7az/CMDGLO8TBKdNdv0eb1bknQEUMSM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791787620; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UzQyBL4XUqek9PUaHpyjjkSQ8pg1ifHETTw0gMLZDww=; b=GwnhjSjo2GqF26hFduR9sKbm7Xzw+Htd6CRYnCkJM5wzEI1xFhwXYhwrErbD4OepvqyblScUKcD8BGk0V8wZkPKC1nyxLFXSOeBaToFNxwv4hIViZKCm8eAQS+jp+WDRAr9U1NCpa5HwdWZCrg2umucWHtt0bhfbLBdUuES+Nkg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791787620513793.5606867490061; Sun, 11 Oct 2026 23:47:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xG9mi-0001rp-S3; Mon, 12 Oct 2026 02:45:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9md-0001py-NS; Mon, 12 Oct 2026 02:45:17 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xG9mc-0006MT-8l; Mon, 12 Oct 2026 02:45:15 -0400 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com (2603:1096:101:253::10) by SI6PR06MB7244.apcprd06.prod.outlook.com (2603:1096:4:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.21; Mon, 12 Oct 2026 06:44:59 +0000 Received: from SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6]) by SEZPR06MB7362.apcprd06.prod.outlook.com ([fe80::cd2d:35d2:a702:1de6%4]) with mapi id 15.21.0496.020; Mon, 12 Oct 2026 06:44:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tUKzq2eIgrrCIp+ooZMGLIY6tD7XxvieB/s9bHe8aEYWeaZfeKqP+BCZvA9CK/eS1ePfInoLZCul97pWfQiHAxETisF3UNvG6+W3OWYgPWItL9Tcd6ZuHusq8IVmsODtCw7nEsaNrTsHXn3WckeTAXUzmdyhZ6pq/uX5on6kZf0ItBWl8sEfRpR/sCC2jLj8H8Ho+rXKc2AZ+dOVd+6PEPdDHJrPWx2WHiueTIYnT9nR4gFvldI6bgJ1hGrRYzriRzRieFnTsouR6/lVsXeJpLp3267w5t5fBphvTUG+ywovzUoqUlQ5G3Wd7VJqvtUTeDmBPTDfGi+JC92yNXzlrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UzQyBL4XUqek9PUaHpyjjkSQ8pg1ifHETTw0gMLZDww=; b=EQheixOTPaZGZQ8wIz0diq50a4yVoRv3LHHlhL5QkWSgR1OByGHEG2k+xTq05jxdByjnMfhXziteSVIcTp26oWFu1rzCEXfisTg51bZyLafDvsB4uM/hlQk6cTLDecwC8Rvij5AjdnU21udaj/CTH4LH9FEYPf48MosHc5vnOCi4sBhkvJcPuTp+E0AHrmKQ8S7K9OTkj0SbD9EJEWonS4+VLwHHmE1RN8Xrimne0uUT7r8xIPGxaTbfA33r/8noH08glVuU7zCCHTiL8E1mYE5mJC3t/jbbC7Ax92cdE8IF382uHqnsQarrDMGI0H1CYvyKWS23xgdhgXoyEFmWJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UzQyBL4XUqek9PUaHpyjjkSQ8pg1ifHETTw0gMLZDww=; b=WHwj5WUXT7hBuKGHZaDdyqETm8+9LxLxhDELk+ACI+BAdBsy1XkPGYtf2RxCQPjcc+B5zVwQHTI30Y1Az8rQb5D4mkCLyF2WZovQx0KN2Wgp+RPicPHp09XVvNH0eWuFSN2Wu9ABQUDWbBKLME0eRzJ7lBb1gXjbxzFn5QJFas7PyiRfVSjjK5JTM+a0+p/d+VdoWJx32u37vjXs4udJe5iEy9BAIAN7i4qnemXiIxm14HUCM1xbb8JqbajfNCvj4B02nuaHcu+0bPkLYhtMn+Z/XFx5sj6rivXJPjgr7XexZc+4xNt869vOoinmGSoxGc55F/qKMR/hhiROcLLUIA== From: Jamin Lin To: "philmd@oss.qualcomm.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Ani Sinha , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 12/12] hw/arm/aspeed: Remove unused aspeed_mmio_map_unimplemented() Thread-Topic: [PATCH v2 12/12] hw/arm/aspeed: Remove unused aspeed_mmio_map_unimplemented() Thread-Index: AQHdWhUzLnHsNSb//0KXkMXYajKXNQ== Date: Mon, 12 Oct 2026 06:44:59 +0000 Message-ID: <20261012064445.2571633-13-jamin_lin@aspeedtech.com> References: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> In-Reply-To: <20261012064445.2571633-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR06MB7362:EE_|SI6PR06MB7244:EE_ x-ms-office365-filtering-correlation-id: 761cd9f8-cd6c-4e5f-cfa3-08df282c5623 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|10067099003|3023799007|261009223027099003|38070700021|921020|22082099003|18002099003|56012099006; x-microsoft-antispam-message-info: 5jc7jueGJf3gmeZ09iXnNcb7rJ6B/6xhmXSvbqcj34oRs+ZFWtHQ1aa6Jk9Ys58mcBVyDzmVrZsS72Cae0teF1lsIJJGuSteipgRrpkyQXfCRsp8L3pQN8V0ZnW/mXONAfB6hfm1MDC0AKnhRrlQouLpasxGfTRPRvPcv5UJOxulcZrmIrNgaKjT4GBBqIHTm934lo6gGYB/+N8MsbS86CbCr98MzFB5vn51Bz6aPUBXyS6pFU5+NcjWwleF37VODw3poVx8/Pkha5JeFQaHUnT/OLZAWkot00KMkmKvJpD4pPc+LzkP052ZRmZcAo2NSztEPpqlWaLcwxhwxriXpvk9PMXYWB8ioXvDFCXQ+NfW9o5EaDRe9tWY5UcRyp5u1ENuI+iaw0r9XaR+HHDBPb2UxXtfA87VFxqOEB2S4Kd0tJpy6yoDUWXYXLr+mpn7l0f2iEbmi4PH7OWZ5PG1n9s2RP8wl3206i2Vf+oCx6YtcGBHl1UwVxdU2oUCkdhXlCVsUnzL2g9558iL8j7diLepWP6AFTnLALIAxm9Ah8CcghrObQwrTU5b7o2kOYsikccJwiJCB/EY9eltziIyLt55qc0jR8F1jjwRgyd8meVVBwE8+MWHiFi+qujsBKZKeBL6MpriEzPCTvujGFzT1UlzGFXLMZCo54SY41eir7BxDXsBSfuRDkxzAXQLdakzBV0u+UenxkPpQw8FjR+CBAIMPy1IJ938AzkHcQuLAggbEAYFPuqcmleODUiZR8hi x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB7362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(10067099003)(3023799007)(261009223027099003)(38070700021)(921020)(22082099003)(18002099003)(56012099006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5GaEjMRhTOmNW5uJyBZy4o5g7VXF12AoO2S74Hl5yXESPXPlOw6Gai/4gJ?= =?iso-8859-1?Q?j7LJ2ESUaE8I5DNjrL+krMBhCBfVtWAeu5zx92s1GddfhKovk51OPCcwNf?= =?iso-8859-1?Q?lyi/ttW8UVQ+lnYKkt4Zxwl59+KaBGabbFFg0EJfEK/Rt6Oq6qBgXiKk4D?= =?iso-8859-1?Q?k6fHTxoNr1f3Xadz1v9YUxvaTZ6X6dpk7mEKc+XvMvvhRbfBtyek+UEY9q?= =?iso-8859-1?Q?OIzhBmkkDfE66e96T3iH3CJd1InVPXaN4koyQ6RVZX1bIDXkI29CUP+Ni4?= =?iso-8859-1?Q?yDliSbYOfClss/rfF524ruhvZ9KZqNhCslIQ5C1542kUIdaNwoLUNOL8b1?= =?iso-8859-1?Q?r4Te4b56TY3hpDDIhp75Z3TFpV4IEkLhAbiGN30z1MsUFrbFjCzlUkXmA2?= =?iso-8859-1?Q?peqaT4ksVi7KgdyiUzVyKJyum3WiZSu+l1pf1ri1o/MyXWNsJ0FFDYBfqM?= =?iso-8859-1?Q?8rMm/jfl/gCyzWUTlV7LR1Scik+bYxE4axG8cnKNiQcM1btJRTrts8JGQu?= =?iso-8859-1?Q?s7vVvWckiXCPLheHjHpeOHWsBO2O5AhUZTKVKDN+sT89gYb9SREomW/S6w?= =?iso-8859-1?Q?CHKkgglKxR/lDSxBbPkeKorPaHokMfDJu3TBu7b0kU/0fCupXUZMSQ0rRB?= =?iso-8859-1?Q?MS0yUsyJBukeOflDoAgrV+acGppy3XgwGm0LbIILR4frLbZf0Ht5ClqSpf?= =?iso-8859-1?Q?vGDgQm4nzm3vxwSU7ThNzJn3AHQq2RfLFqpu1iYAmG3/ZLPTQGijSfjb/v?= =?iso-8859-1?Q?ZLraw0Zs11SkHTu49HPrxdm7hpZVD0XKDIIwQKnn/rsy0v3Aqp1sCXhuLb?= =?iso-8859-1?Q?gCjMq6HSQNqb/OxQrse4nQ7pkY97tRWecNdlek0l9oTT628f4kVdO1uxAh?= =?iso-8859-1?Q?4g2vQH9LXos5AXlbvlVreMWdFoXr9ykZRenxbmQHX+HQeEzTUgF5QzLlae?= =?iso-8859-1?Q?KRg6CkV2vyMWXf/hYIMuRO1yeHz0Sgzmsx0K/12f/zaUGCm7Ov/De++WQr?= =?iso-8859-1?Q?R0Y2eRpSoM0hvdbuzs9XLN9YKtpC+PUxYa/aT+iafNdQz9UXEIQRMTfKQa?= =?iso-8859-1?Q?Y1b6JLfhOgeQBE/n/FRzJev1gsqK4k2tQr523ojRuKhIk/foNHoCynGbXy?= =?iso-8859-1?Q?zSkBi47yxGgqinkTIGYV+OV6KTi/MwcEkHeeHY1Cnjf/vk9M7tsQuLjDg4?= =?iso-8859-1?Q?uztn9vOwRpjLK3uIEPuUawgFbM1dhq479AWxGAGQYGv3Th/wHQoAI01YbZ?= =?iso-8859-1?Q?a0pzSIoOvsQ3dDElZLog0g8R1LzwYn6FmUazijMySiAuIcmFy8M733Uh8a?= =?iso-8859-1?Q?717jUx2KN2L5BLo8PVtpulYgiT0FezBbtltC3obWSK/1pRiKCvmsccwMpy?= =?iso-8859-1?Q?oKqKaUwJx08N7aK/cAnfI/appGzrovc39dIlE6FjE1IDFoIksm5kB9GB7B?= =?iso-8859-1?Q?FnMuC52scdAdjvIYN6StufQ+wx1X1p3htkTQK3Y2iYpEeDYuXRrw1XKm6u?= =?iso-8859-1?Q?nMXiBE2Av8piu4OU57eebXODxEAnwq97DakdtWkYFLq/NzsWfTBirt/ClM?= =?iso-8859-1?Q?9NaFhahjSOBZpytzHOKaOTdnmzdro/oAXXXrxzfRDH1sEtgyV3COBmvfLZ?= =?iso-8859-1?Q?ES4yTt5KMJfY9V4iZXdHsvV7GwKhnoqkW8Jd7pwQaLUmXTveHssap6sYQq?= =?iso-8859-1?Q?4S7d7m/SchzqcpChMHoJG3NyIWKJvdg0DZD3bvBYyxP8RMko9sZzxKkLIW?= =?iso-8859-1?Q?08bPqPKZVo1sPIX6S9bqMYGu0FPvOE7iz6WY3l/foTGci4tZeZFHuFz+MJ?= =?iso-8859-1?Q?Ek0jrl1X4Q=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Ree+VfThIUT5w51DrZDZ+vWMxhlPlwGebJmEWlni+qWITppnB/qON29/MiDjJcF/QUEBP1mmTm+Km4yOKCtBLbpS6h9eDJzdHOmaRZUqwrGAFVhMARWjKtvH7UHNRXU0Rhht7jM651nh7zjBK2eDur1OcWK+bghZ3kqBxgYcXJl/MTdamNS9eRgRP+I4+1DDiLk22e/IMpcbNftnwdzha1jkKMgCPpGeslLkRvH6qS2+QRtvDuHdkYCZT+/dsz0Rs6mM0MEK8fF08BfomJS8w3UCkehOIyEeVYKmWc07iKxJCz092OHkVauqRGI0fB3PTvEHcuZog3uInKX2kM97Cg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB7362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 761cd9f8-cd6c-4e5f-cfa3-08df282c5623 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2026 06:44:59.7342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a5I/fBFOje2H/woRBOXSmqF9iQrCoqio4tv82s7pMneTY/zLSxfONXhdoxbYoSIPf0T6lBZItgBm8yfWy03ciWTsrrVY5Uwj6XAxbXkMlYI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI6PR06MB7244 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1791787622055158500 Content-Type: text/plain; charset="utf-8" All Aspeed SoCs now use create_unimplemented_devices() to create and map their unimplemented devices. Remove aspeed_mmio_map_unimplemented(), which is not used anymore. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/aspeed_soc.h | 3 --- hw/arm/aspeed_soc_common.c | 11 ----------- 2 files changed, 14 deletions(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 4ef1014ad0..fd860ef9ae 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -307,9 +307,6 @@ void aspeed_soc_uart_set_chr(SerialMM *uart, int dev, i= nt uarts_base, bool aspeed_soc_dram_init(AspeedSoCState *s, Error **errp); void aspeed_mmio_map(MemoryRegion *memory, SysBusDevice *dev, int n, hwaddr addr); -void aspeed_mmio_map_unimplemented(MemoryRegion *memory, SysBusDevice *dev, - const char *name, hwaddr addr, - uint64_t size); void aspeed_board_init_flashes(AspeedSMCState *s, const char *flashtype, unsigned int count, int unit0); void aspeed_write_boot_rom(BlockBackend *blk, hwaddr addr, size_t rom_size, diff --git a/hw/arm/aspeed_soc_common.c b/hw/arm/aspeed_soc_common.c index fd08793575..54a128c965 100644 --- a/hw/arm/aspeed_soc_common.c +++ b/hw/arm/aspeed_soc_common.c @@ -104,17 +104,6 @@ void aspeed_mmio_map(MemoryRegion *memory, SysBusDevic= e *dev, int n, memory_region_add_subregion(memory, addr, sysbus_mmio_get_region(dev, = n)); } =20 -void aspeed_mmio_map_unimplemented(MemoryRegion *memory, SysBusDevice *dev, - const char *name, hwaddr addr, uint64_t= size) -{ - qdev_prop_set_string(DEVICE(dev), "name", name); - qdev_prop_set_uint64(DEVICE(dev), "size", size); - sysbus_realize(dev, &error_abort); - - memory_region_add_subregion_overlap(memory, addr, - sysbus_mmio_get_region(dev, 0), -1= 000); -} - void aspeed_board_init_flashes(AspeedSMCState *s, const char *flashtype, unsigned int count, int unit0) { --=20 2.53.0