On 9/18/2026 1:22 PM, Tushar Dave wrote:
>
>
> On 9/18/2026 8:24 AM, Gerd Hoffmann wrote:
>> Hi,
>>
>>> The series was tested together with the QEMU companion patches on the
>>> AArch64 virt machine across a range of PCIe topologies: emulated devices,
>>> VFIO passthrough devices, PCIe switches, single and multiple fixed-BAR
>>> endpoints under a shared root port, and fixed BARs behind nested bridges.
>>
>> Given this is active for both aarch64 and x86_64: Any testing with OVMF
>> on x86_64?
>
> Gerd,
>
> Thank you for the review.
>
> Yes — tested on x86_64 OVMF (OvmfPkgX64, q35). There's no fixed-BAR
> placement to actually exercise on x86 since nothing on the QEMU side
> populates the fw_cfg blob there, so this was really a check that the
> fixed-BAR addition to IncompatiblePciDeviceSupportDxe is a correct no-op
> when that blob is absent. And it is — existing behavior is unchanged,
> without any regressions.
>
>>
>> Overall this looks good to me. edk2 has switched to github PRs, so
>> please open a PR there. edk2 has a policy that patches should not touch
>> multiple packages, so patch #2 should be split into two for ArmVirtPkg
>> and OvmfPkg.
>
> Sure, I'll open a GitHub PR for this series and split patch #2 into
> ArmVirtPkg and OvmfPkg patches.
PR submitted https://github.com/tianocore/edk2/pull/13183
Thanks.
-Tushar
>
>>
>> take care,
>> Gerd
>
> Thanks.
> -Tushar