Misc patches for 2026-09-09

[PULL 00/12] Misc patches for 2026-09-09

Paolo Bonzini posted 12 patches 2 weeks, 3 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260909155624.1082893-1-pbonzini@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>, Chao Liu <chao.liu@processmission.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>

docs/devel/conflict-resolution.rst |  7 +++---
docs/devel/index.rst               |  4 ++--
target/i386/tcg/fpu_helper.c       | 34 +++++++++++++++++++++++------
target/i386/tcg/decode-new.c.inc   |  2 +-
.claude/.gitignore                 |  2 ++
.claude/rules/agents-md.md         |  1 +
.gemini/settings.json              |  5 +++++
AGENTS.md                          | 40 ++++++++++++++++++++++++++++++++++
Cargo.toml                         |  1 +
rust/bindings/chardev-sys/lib.rs   |  1 +
rust/bindings/hwcore-sys/lib.rs    |  1 +
rust/bindings/migration-sys/lib.rs |  1 +
rust/bindings/qom-sys/lib.rs       |  1 +
rust/bindings/system-sys/lib.rs    |  1 +
rust/bindings/util-sys/lib.rs      |  1 +
rust/qemu-macros/src/lib.rs        |  2 +-
scripts/checkpatch.pl              | 44 ++++++++++++++++++++++++++++++++++++++
17 files changed, 134 insertions(+), 14 deletions(-)
create mode 100644 .claude/.gitignore
create mode 100644 .claude/rules/agents-md.md
create mode 100644 .gemini/settings.json
create mode 100644 AGENTS.md

Expand all Fold all

[PULL 00/12] Misc patches for 2026-09-09

Posted by Paolo Bonzini 2 weeks, 3 days ago

The following changes since commit d2843fbf80260e4346c856819e8cea11768c9d0e:

  Merge tag 'pull-riscv-to-apply-20260904' of https://github.com/alistair23/qemu into staging (2026-09-04 09:43:27 +0100)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 0937f8a26c159d710ac6a122cc99f9661e739950:

  rust: bindings: disable more clippy warnings (2026-09-08 19:36:25 +0200)

----------------------------------------------------------------
* AGENTS.md: basic bare minimal guide
* target/i386: TCG fixes
* scripts/checkpatch: warn on duplicate trailers, self-review, crediting AI
* docs: link to website for IRC and mailing list
* rust: qemu-macros: remove redundant clone()
* rust: qemu-macros: silence more warnings for bindgen crates

----------------------------------------------------------------
Alex Bennée (1):
      AGENTS.md: basic bare minimal guide

Andrey Polivoda (1):
      target/i386: Mark MOVNTI as not valid with prefixes 0x66, 0xF2, 0xF3

Marc-André Lureau (1):
      scripts/checkpatch: warn on duplicate trailers and self-review

Paolo Bonzini (4):
      docs: link to website for IRC and mailing list
      checkpatch: reject trailers that credit an AI agent
      rust: qemu-macros: remove redundant clone()
      rust: bindings: disable more clippy warnings

Simon Scherer (5):
      target/i386: Fix FXCH to unconditionally clear C1
      target/i386: clear C1 for all x87 compare instructions
      target/i386: Update FPU tag word for FXTRACT's old ST(0)
      target/i386: Update FPU tag word for FSTP
      target/i386: Update FPU tag word for FXCH

 docs/devel/conflict-resolution.rst |  7 +++---
 docs/devel/index.rst               |  4 ++--
 target/i386/tcg/fpu_helper.c       | 34 +++++++++++++++++++++++------
 target/i386/tcg/decode-new.c.inc   |  2 +-
 .claude/.gitignore                 |  2 ++
 .claude/rules/agents-md.md         |  1 +
 .gemini/settings.json              |  5 +++++
 AGENTS.md                          | 40 ++++++++++++++++++++++++++++++++++
 Cargo.toml                         |  1 +
 rust/bindings/chardev-sys/lib.rs   |  1 +
 rust/bindings/hwcore-sys/lib.rs    |  1 +
 rust/bindings/migration-sys/lib.rs |  1 +
 rust/bindings/qom-sys/lib.rs       |  1 +
 rust/bindings/system-sys/lib.rs    |  1 +
 rust/bindings/util-sys/lib.rs      |  1 +
 rust/qemu-macros/src/lib.rs        |  2 +-
 scripts/checkpatch.pl              | 44 ++++++++++++++++++++++++++++++++++++++
 17 files changed, 134 insertions(+), 14 deletions(-)
 create mode 100644 .claude/.gitignore
 create mode 100644 .claude/rules/agents-md.md
 create mode 100644 .gemini/settings.json
 create mode 100644 AGENTS.md
-- 
2.55.0

Re: [PULL 00/12] Misc patches for 2026-09-09

Posted by Michael Tokarev 2 weeks, 2 days ago

On 9/9/26 18:56, Paolo Bonzini wrote:
...> Andrey Polivoda (1):
>        target/i386: Mark MOVNTI as not valid with prefixes 0x66, 0xF2, 0xF3

> Simon Scherer (5):
>        target/i386: Fix FXCH to unconditionally clear C1
>        target/i386: clear C1 for all x87 compare instructions
>        target/i386: Update FPU tag word for FXTRACT's old ST(0)
>        target/i386: Update FPU tag word for FSTP
>        target/i386: Update FPU tag word for FXCH

Actually, it looks like this whole lot should be picked up for qemu stable,
is it not?

Thanks,

/mjt

Re: [PULL 00/12] Misc patches for 2026-09-09

Posted by Simon Scherer 2 weeks, 1 day ago

Mostly yes, but one caveat on "target/i386: clear C1 for all x87 compare
instructions": part of that commit is wrong.

The FCOM/FCOMP/FCOMPP/FUCOM/FUCOMP/FUCOMPP/FICOM/FICOMP part is correct and
hardware-verified. The FCOMI/FCOMIP/FUCOMI/FUCOMIP part is not: the SDM lists
"C1 Set to 0" for those, but real x86-64 hardware leaves C1 unchanged. I
caught this after v2 was posted and sent a v3 dropping these changes
[https://patchew.org/QEMU/20260902135705.261863-1-scherer.simon89@gmail.com/],
but
v2 was the version applied.

I'm sending a follow-up fix on top of master now that reverts just the
fcomi/fucomi changes.

Simon

On Thu, Sep 10, 2026 at 8:02 PM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> On 9/9/26 18:56, Paolo Bonzini wrote:
> ...> Andrey Polivoda (1):
> >        target/i386: Mark MOVNTI as not valid with prefixes 0x66, 0xF2, 0xF3
>
> > Simon Scherer (5):
> >        target/i386: Fix FXCH to unconditionally clear C1
> >        target/i386: clear C1 for all x87 compare instructions
> >        target/i386: Update FPU tag word for FXTRACT's old ST(0)
> >        target/i386: Update FPU tag word for FSTP
> >        target/i386: Update FPU tag word for FXCH
>
> Actually, it looks like this whole lot should be picked up for qemu stable,
> is it not?
>
> Thanks,
>
> /mjt

Re: [PULL 00/12] Misc patches for 2026-09-09

Posted by Michael Tokarev 2 weeks, 1 day ago

On 9/11/26 13:42, Simon Scherer wrote:
> Mostly yes, but one caveat on "target/i386: clear C1 for all x87 compare
> instructions": part of that commit is wrong.
> 
> The FCOM/FCOMP/FCOMPP/FUCOM/FUCOMP/FUCOMPP/FICOM/FICOMP part is correct and
> hardware-verified. The FCOMI/FCOMIP/FUCOMI/FUCOMIP part is not: the SDM lists
> "C1 Set to 0" for those, but real x86-64 hardware leaves C1 unchanged. I
> caught this after v2 was posted and sent a v3 dropping these changes
> [https://patchew.org/QEMU/20260902135705.261863-1-scherer.simon89@gmail.com/],
> but
> v2 was the version applied.
> 
> I'm sending a follow-up fix on top of master now that reverts just the
> fcomi/fucomi changes.

Thank you for the explanation.  I'll wait for the follow-up patch here.

/mjt

Re: [PULL 00/12] Misc patches for 2026-09-09

Posted by Peter Maydell 2 weeks, 2 days ago

On Wed, 9 Sept 2026 at 16:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit d2843fbf80260e4346c856819e8cea11768c9d0e:
>
>   Merge tag 'pull-riscv-to-apply-20260904' of https://github.com/alistair23/qemu into staging (2026-09-04 09:43:27 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 0937f8a26c159d710ac6a122cc99f9661e739950:
>
>   rust: bindings: disable more clippy warnings (2026-09-08 19:36:25 +0200)
>
> ----------------------------------------------------------------
> * AGENTS.md: basic bare minimal guide
> * target/i386: TCG fixes
> * scripts/checkpatch: warn on duplicate trailers, self-review, crediting AI
> * docs: link to website for IRC and mailing list
> * rust: qemu-macros: remove redundant clone()
> * rust: qemu-macros: silence more warnings for bindgen crates
>



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.2
for any user-visible changes.

-- PMM