[v4] the org.qemu.Display1.UIInfo interface design

[PATCH RFC v4 0/1] the org.qemu.Display1.UIInfo interface design

Chengyang Zhu posted 1 patch 3 weeks, 6 days ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260830054641.45437-1-colazcyg@gmail.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>

ui/dbus-console.c    | 106 +++++++++++++++++++++++++++++++++++++++++++
ui/dbus-display1.xml |  50 ++++++++++++++++++++
2 files changed, 156 insertions(+)

Expand all Fold all

[PATCH RFC v4 0/1] the org.qemu.Display1.UIInfo interface design

Posted by Chengyang Zhu 3 weeks, 6 days ago

Currently, the `SetUIInfo` method cannot set a refresh rate.
Simply adding a refresh_rate argument would break the method signature.

This patch adds the UIInfo interface containing
  * property `Supported` indicating whether console UI info is supported.
  * the method `Apply` taking a dictionary as input.
  * the method `Get` returning the current UI info as a dictionary.

Changes since v3:
  * switched back to the dictionary approach.

This patch needs further discussion on:
  * Updated/Changed signal as mentioned before in the v3 email thread.
  * necessary test suite to prevent dictionary schema deviating from QemuUIInfo.

Test results:
  * qemu:qtest-x86_64/dbus-display-test passed
  * qemu:qtest-x86_64/dbus-vmstate-test passed
  * qemu:qtest-x86_64/dbus-vnc-test SKIP
  * manually created a virtual machine
    and successfully set its refresh rate and resolution via `Apply`

Chengyang Zhu (1):
  ui/dbus: add org.qemu.Display1.UIInfo interface

 ui/dbus-console.c    | 106 +++++++++++++++++++++++++++++++++++++++++++
 ui/dbus-display1.xml |  50 ++++++++++++++++++++
 2 files changed, 156 insertions(+)

-- 
2.55.0