From nobody Sat Sep 26 22:16:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1788068849; cv=none; d=zohomail.com; s=zohoarc; b=HxE7pTTMYoCTwlw0ikjtsPHpF5JzVnqi6Z2/VugMkcvZTZFqj1M/Negw8jI/Etfm92/G7IOAA8xPAy9lkwc1HWV1iYiKnuyA9parA4At8aEBYn1+qs7uOpaExiGCG2lM7cBdZ6XPulM1H3zJAHJ3MRHtVElHPaeiFBYYsKYKYco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788068849; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sCLqvCcl/TsgvcW8ZflsErBGVRq5eKuTAYlxhpxwCPc=; b=FEVEvrjzAjXy6JWaqRdv3sCjKMKFxuzwSKxLh7jtGPSLMBMil+Qb4L1DhSfv2zuIvKmyL+5nbXb98Ns8EbkQHTg2dVNQPMovPgKb7d2p82QeVuRgn61eyFDoB4Sym6/uiq6gpCIqBB2Ho8mXNUA2VXDGJXPfirs94cxWWKoSZpI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178806884980914.788364828434851; Sat, 29 Aug 2026 22:47:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x0YNi-0005Bd-Vx; Sun, 30 Aug 2026 01:47:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x0YNb-0005BG-ON for qemu-devel@nongnu.org; Sun, 30 Aug 2026 01:46:56 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x0YNZ-0001Ri-MA for qemu-devel@nongnu.org; Sun, 30 Aug 2026 01:46:55 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-cc1bcdb3c4cso1693918a12.2 for ; Sat, 29 Aug 2026 22:46:53 -0700 (PDT) Received: from colazcyASUSlaptop.localdomain ([2a09:bac5:636f:183c::26a:c4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3286fa5517fsm22878963eec.31.2026.08.29.22.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2026 22:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788068812; x=1788673612; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sCLqvCcl/TsgvcW8ZflsErBGVRq5eKuTAYlxhpxwCPc=; b=JaOtxbnk3ogIenZ4UhBGbiHDW6Y8uivxv/tT6kKDFZWXGqX7nTMqn043ELd3l9eovt NvzH9/KSU4zsjepLQHvAFNXWrDUo02elzG/fm1IYD5ktgbVTJgEpbtbBqfMPXnScHpmB hOiqWZeq08G7X95WWEPsv+CkfrYYiAXrtDbkcVTR/CkHcS+W8q4PmAd/0kkxMrbsP1M1 spXU25oFcy9479qrL5beXeUWz844n1vQGNd6b+VSzP0mRp70TBxPHu4MFKMyWkrWGJ92 jJiIZZBPepvxrVtFj21BS3R170NpMxxi1/ziBn4QUyzRhidh3ptWU2+h5ItlQechuz3W o9Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788068812; x=1788673612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sCLqvCcl/TsgvcW8ZflsErBGVRq5eKuTAYlxhpxwCPc=; b=BUm0OV06jGnML9SIkQdNTJGI8sCd/CPbsPzpybfPPWzFNGzV1mU2GHW1bZ0M18/pcr yBvYEbMtHdwOfLJjzBfNcxLJgbqu1uwY2oXx6gJJmx1rfLHLuYgaUwhUjzaDkecmQYVs MVq6bxCtxwuQU5wptbJo1Y87QTJe46zDO2S4drNDXzELPLCObTjE2hsI5hxd8pgw05B5 okLFwAULMCs2MLMpDXLhHaImANUEYaTvvH/VxvJNis2Z1M21gIRAwhzHcQvgnRjfnf/9 IUDLlB2FBg2pb7i1mo7nb1IILQd61Bt5gMCkH/jhpM7hdGUuQbUxdSZu65+YsnbpB0iW kDKw== X-Gm-Message-State: AFuF++l0mXjM7KUnQsiNis7/yuvjD50OWhyYqhtw0+CZIIQxWPmWVE7E 5HiinTOV4L0qXR5bZZNGB3YNwV71c3bSYGJYIU1tubReq7n1l2Geiw1Q7ZIy8py5v7TunA== X-Gm-Gg: AR+sD100KZu2Ft2kwpIuTTkOMx//k2kqHQVACETacIIbEnzUx7OHiNWQtsjcIOcVv7G q1Wmwbcx/lojFPNLqVym/bJLzbOMQTCb2GBWKplbXrsRzTjuaJwXjfimqqokJWQb0Q+dJnVAPLV F2UEzlxEwPsgyRYjQS8GvFdSbn8SZEseKLhPqx658S4Zs/M4WaP8JMQRb0LtzRUJZHPhEuUzOdO 21zf9NHUFsCsZkbmN41Y/vXR0XeZy/cqW9HXGDajujAohY/IO2ej3CAcSOUJO1mlHZbTmv9loiJ wlchSC3PBbOJGHLR+Jua91frAq5gjUCV+RPT1kGHUklWDhdpE5LRza8dsdnFl1YDmdaRpR6Er31 Hvfnz+JfLH/NWfk8SyPcgu+KD/rFZHSnQDxPxO9umyAlQvm0Wt45bCBc+2L5Wp92loRccR723LJ +e5WWDKkiap5YTqGSEaupuf/COVegdZN2xdTJngiXnfVSDR8geiteIXHFef9M9Qai5mAd3Dw== X-Received: by 2002:a05:6300:49:b0:3d3:adbf:7782 with SMTP id adf61e73a8af0-3d3adbf816dmr15668004637.23.1788068811842; Sat, 29 Aug 2026 22:46:51 -0700 (PDT) From: Chengyang Zhu To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, Chengyang Zhu Subject: [PATCH RFC v4 1/1] ui/dbus: add org.qemu.Display1.UIInfo interface Date: Sun, 30 Aug 2026 13:46:41 +0800 Message-ID: <20260830054641.45437-2-colazcyg@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260830054641.45437-1-colazcyg@gmail.com> References: <20260830054641.45437-1-colazcyg@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=colazcyg@gmail.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1788068853195158500 Content-Type: text/plain; charset="utf-8" Currently, the SetUIInfo method cannot set a refresh rate. Simply adding a refresh_rate argument would break the method signature. This patch adds the UIInfo interface containing * property `Supported` indicating whether console UI info is supported. * the method `Apply` taking a dictionary as input. * the method `Get` returning the current UI info as a dictionary. Signed-off-by: Chengyang Zhu --- ui/dbus-console.c | 106 +++++++++++++++++++++++++++++++++++++++++++ ui/dbus-display1.xml | 50 ++++++++++++++++++++ 2 files changed, 156 insertions(+) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index e1ac06814b..947c3b3a54 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -55,6 +55,8 @@ struct _DBusDisplayConsole { guint last_x; guint last_y; Notifier mouse_mode_notifier; + + QemuDBusDisplay1UIInfo *iface_ui_info; }; =20 G_DEFINE_TYPE(DBusDisplayConsole, @@ -155,6 +157,7 @@ dbus_display_console_dispose(GObject *object) qemu_input_led_notifier_remove(&ddc->led_notifier); qemu_console_unregister_listener(&ddc->dcl); qemu_remove_mouse_mode_change_notifier(&ddc->mouse_mode_notifier); + g_clear_object(&ddc->iface_ui_info); g_clear_object(&ddc->iface_touch); g_clear_object(&ddc->iface_mouse); g_clear_object(&ddc->iface_kbd); @@ -528,6 +531,98 @@ dbus_mouse_mode_change(Notifier *notify, void *data) dbus_mouse_update_is_absolute(ddc); } =20 +static gboolean +dbus_ui_info_get(DBusDisplayConsole *ddc, + GDBusMethodInvocation *invocation) +{ + QemuUIInfo ui_info; + GVariantDict dict; + + if (!qemu_console_ui_info_supported(ddc->dcl.con)) { + g_dbus_method_invocation_return_error(invocation, + DBUS_DISPLAY_ERROR, + DBUS_DISPLAY_ERROR_UNSUPPORT= ED, + "UIInfo is not supported"); + return DBUS_METHOD_INVOCATION_HANDLED; + } + + ui_info =3D *qemu_console_get_ui_info(ddc->dcl.con); + g_variant_dict_init(&dict, NULL); + + g_variant_dict_insert(&dict, "width_mm", "q", ui_info.width_mm); + g_variant_dict_insert(&dict, "height_mm", "q", ui_info.height_mm); + g_variant_dict_insert(&dict, "xoff", "i", ui_info.xoff); + g_variant_dict_insert(&dict, "yoff", "i", ui_info.yoff); + g_variant_dict_insert(&dict, "width", "u", ui_info.width); + g_variant_dict_insert(&dict, "height", "u", ui_info.height); + g_variant_dict_insert(&dict, "refresh_rate", "u", ui_info.refresh_rate= ); + + qemu_dbus_display1_uiinfo_complete_get(ddc->iface_ui_info, invocation, + g_variant_dict_end(&dict)); + + return DBUS_METHOD_INVOCATION_HANDLED; +} + +static bool +dbus_ui_info_apply_lookup(GDBusMethodInvocation *invocation, + GVariantDict *dict, + const gchar *key, + const gchar *fmt_str, + void *res) +{ + if (g_variant_dict_contains(dict, key) && + !g_variant_dict_lookup(dict, key, fmt_str, res)) { + g_dbus_method_invocation_return_error(invocation, + DBUS_DISPLAY_ERROR, + DBUS_DISPLAY_ERROR_INVALID, + "%s must have D-Bus signatur= e %s", + key, fmt_str); + return false; + } + return true; +} + +static gboolean +dbus_ui_info_apply(DBusDisplayConsole *ddc, + GDBusMethodInvocation *invocation, + GVariant *arg_ui_info) +{ + QemuUIInfo ui_info; + g_auto(GVariantDict) dict =3D G_VARIANT_DICT_INIT(arg_ui_info); + + if (!qemu_console_ui_info_supported(ddc->dcl.con)) { + g_dbus_method_invocation_return_error(invocation, + DBUS_DISPLAY_ERROR, + DBUS_DISPLAY_ERROR_UNSUPPORT= ED, + "UIInfo is not supported"); + return DBUS_METHOD_INVOCATION_HANDLED; + } + + ui_info =3D *qemu_console_get_ui_info(ddc->dcl.con); + + if (!dbus_ui_info_apply_lookup(invocation, &dict, "width_mm", "q", + &ui_info.width_mm) || + !dbus_ui_info_apply_lookup(invocation, &dict, "height_mm", "q", + &ui_info.height_mm) || + !dbus_ui_info_apply_lookup(invocation, &dict, "xoff", "i", + &ui_info.xoff) || + !dbus_ui_info_apply_lookup(invocation, &dict, "yoff", "i", + &ui_info.yoff) || + !dbus_ui_info_apply_lookup(invocation, &dict, "width", "u", + &ui_info.width) || + !dbus_ui_info_apply_lookup(invocation, &dict, "height", "u", + &ui_info.height) || + !dbus_ui_info_apply_lookup(invocation, &dict, "refresh_rate", "u", + &ui_info.refresh_rate)) { + return DBUS_METHOD_INVOCATION_HANDLED; + } + + qemu_console_set_ui_info(ddc->dcl.con, &ui_info, false); + qemu_dbus_display1_uiinfo_complete_apply(ddc->iface_ui_info, invocatio= n); + + return DBUS_METHOD_INVOCATION_HANDLED; +} + int dbus_display_console_get_index(DBusDisplayConsole *ddc) { return qemu_console_get_index(ddc->dcl.con); @@ -550,6 +645,7 @@ dbus_display_console_new(DBusDisplay *display, QemuCons= ole *con) "org.qemu.Display1.Keyboard", "org.qemu.Display1.Mouse", "org.qemu.Display1.MultiTouch", + "org.qemu.Display1.UIInfo", NULL }; =20 @@ -626,5 +722,15 @@ dbus_display_console_new(DBusDisplay *display, QemuCon= sole *con) qemu_add_mouse_mode_change_notifier(&ddc->mouse_mode_notifier); dbus_mouse_update_is_absolute(ddc); =20 + ddc->iface_ui_info =3D qemu_dbus_display1_uiinfo_skeleton_new(); + qemu_dbus_display1_uiinfo_set_supported(ddc->iface_ui_info, + qemu_console_ui_info_supported(ddc->dcl.con)); + g_object_connect(ddc->iface_ui_info, + "swapped-signal::handle-get", dbus_ui_info_get, ddc, + "swapped-signal::handle-apply", dbus_ui_info_apply, ddc, + NULL); + g_dbus_object_skeleton_add_interface(G_DBUS_OBJECT_SKELETON(ddc), + G_DBUS_INTERFACE_SKELETON(ddc->iface_ui_info)); + return ddc; } diff --git a/ui/dbus-display1.xml b/ui/dbus-display1.xml index d96bae2ed6..26483edc37 100644 --- a/ui/dbus-display1.xml +++ b/ui/dbus-display1.xml @@ -1159,4 +1159,54 @@ --> + + + + + + + + + + + + + + + + --=20 2.55.0