[v3] the org.qemu.Display1.UIInfo interface design

[PATCH RFC v3 0/1] the org.qemu.Display1.UIInfo interface design

Chengyang Zhu posted 1 patch 1 month, 1 week ago

Diff against v2 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260818134543.654949-1-colazcyg@gmail.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>

There is a newer version of this series

ui/dbus-console.c    | 71 ++++++++++++++++++++++++++++++++++++++
ui/dbus-display1.xml | 81 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 152 insertions(+)

Expand all Fold all

[PATCH RFC v3 0/1] the org.qemu.Display1.UIInfo interface design

Posted by Chengyang Zhu 1 month, 1 week ago

Currently, the `SetUIInfo` method cannot set a refresh rate.
Simply adding a refresh_rate argument would break the method signature.

This RFC adds the `UIInfo` interface containing
  * properties as staged display settings.
  * property `Supported` indicating whether console UI info is supported.
  * the method `Apply` applying staged settings.
  * the method `Reload` reloading settings from the console.

Changes since v2:
  * added a read-only bool property "Supported" on the interface.
  * switched to typesafe getter & setter.
  * documented each property/method individually.

Test results:
  * qemu:qtest-x86_64/dbus-display-test passed
  * qemu:qtest-x86_64/dbus-vmstate-test passed
  * qemu:qtest-x86_64/dbus-vnc-test SKIP
  * manually created a virtual machine
    and successfully set its refresh rate and resolution via `UIInfo`
  * sphinxdocs build passed

Chengyang Zhu (1):
  ui/dbus: add org.qemu.Display1.UIInfo interface

 ui/dbus-console.c    | 71 ++++++++++++++++++++++++++++++++++++++
 ui/dbus-display1.xml | 81 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 152 insertions(+)

-- 
2.55.0