Supercedes: tencent_E2269E77D2CCF40AAE3E69F67780397B0A0A@qq.com
("[RFC PATCH 11.0 0/2] tcg/mips64: Fix shifts and unaligned loads - [DORA-B]")

Hi Quentin, thanks for these.  Note that I cannot even compile test
mips64 anymore because Debian buster was the last os release, and
buster has package versions too old for qemu.

I've fixed up the html damage from your mailer, reviewed the changes,
and have changed the second patch to fix the address inside the called
function.  If one wanted to backport the fix all the way to qemu v8,
one would have to apply your patch in two locations for mips32.

Michael, the first patch applies cleanly from stable-10.1, and the
second applies from stable-10.0.


r~


Quintin Kong (2):
  tcg/mips64: Fix variable shift operand order
  tcg/mips64: Preserve the base of unaligned loads

 tcg/mips/tcg-target.c.inc | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

-- 
2.43.0

Hi Richard,


Thanks very much for clearing up the HTML damage from my mailer and for the review.
I agree that fixing the address inside the called function could be better.
Thanks again, and thanks Michael for taking these onto stable-10.0/10.1.


Best,
Quintin


         原始邮件
         
       
发件人：Richard Henderson <richard.henderson@linaro.org&gt;
发件时间：2026年7月29日 18:27
收件人：qemu-devel <qemu-devel@nongnu.org&gt;
抄送：mjt <mjt@tls.msk.ru&gt;, 2358543632 <2358543632@qq.com&gt;, quintin.kong <quintin.kong@qq.com&gt;
主题：[PATCH 0/2] tcg/mips stable patches



       Supercedes:&nbsp;tencent_E2269E77D2CCF40AAE3E69F67780397B0A0A@qq.com
("[RFC&nbsp;PATCH&nbsp;11.0&nbsp;0/2]&nbsp;tcg/mips64:&nbsp;Fix&nbsp;shifts&nbsp;and&nbsp;unaligned&nbsp;loads&nbsp;-&nbsp;[DORA-B]")

Hi&nbsp;Quentin,&nbsp;thanks&nbsp;for&nbsp;these.&nbsp;&nbsp;Note&nbsp;that&nbsp;I&nbsp;cannot&nbsp;even&nbsp;compile&nbsp;test
mips64&nbsp;anymore&nbsp;because&nbsp;Debian&nbsp;buster&nbsp;was&nbsp;the&nbsp;last&nbsp;os&nbsp;release,&nbsp;and
buster&nbsp;has&nbsp;package&nbsp;versions&nbsp;too&nbsp;old&nbsp;for&nbsp;qemu.

I've&nbsp;fixed&nbsp;up&nbsp;the&nbsp;html&nbsp;damage&nbsp;from&nbsp;your&nbsp;mailer,&nbsp;reviewed&nbsp;the&nbsp;changes,
and&nbsp;have&nbsp;changed&nbsp;the&nbsp;second&nbsp;patch&nbsp;to&nbsp;fix&nbsp;the&nbsp;address&nbsp;inside&nbsp;the&nbsp;called
function.&nbsp;&nbsp;If&nbsp;one&nbsp;wanted&nbsp;to&nbsp;backport&nbsp;the&nbsp;fix&nbsp;all&nbsp;the&nbsp;way&nbsp;to&nbsp;qemu&nbsp;v8,
one&nbsp;would&nbsp;have&nbsp;to&nbsp;apply&nbsp;your&nbsp;patch&nbsp;in&nbsp;two&nbsp;locations&nbsp;for&nbsp;mips32.

Michael,&nbsp;the&nbsp;first&nbsp;patch&nbsp;applies&nbsp;cleanly&nbsp;from&nbsp;stable-10.1,&nbsp;and&nbsp;the
second&nbsp;applies&nbsp;from&nbsp;stable-10.0.


r~


Quintin&nbsp;Kong&nbsp;(2):
&nbsp;&nbsp;tcg/mips64:&nbsp;Fix&nbsp;variable&nbsp;shift&nbsp;operand&nbsp;order
&nbsp;&nbsp;tcg/mips64:&nbsp;Preserve&nbsp;the&nbsp;base&nbsp;of&nbsp;unaligned&nbsp;loads

&nbsp;tcg/mips/tcg-target.c.inc&nbsp;|&nbsp;22&nbsp;+++++++++++++++-------
&nbsp;1&nbsp;file&nbsp;changed,&nbsp;15&nbsp;insertions(+),&nbsp;7&nbsp;deletions(-)

--&nbsp;
2.43.0