net: only advertise passt in netdev help when CONFIG_PASST

[PATCH] net: only advertise passt in netdev help when CONFIG_PASST

Posted by Rohitashv Kumar 1 week, 5 days ago

From: Rohitashv Kumar <roohiit@amazon.de>

show_netdevs() lists each conditionally-compiled netdev backend behind
its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for
"l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was
added unconditionally, so "-netdev help" advertises passt even in
builds configured with --disable-passt. Trying to use it then fails
with "Parameter 'type' does not accept value 'passt'", since the QAPI
NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'.

Guard the help entry with CONFIG_PASST so the advertised backends match
those actually compiled into the binary.

Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>
---
 net/net.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/net.c b/net/net.c
index 2892f17..5c39f8e 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1385,7 +1385,9 @@ void show_netdevs(void)
         "dgram",
         "hubport",
         "tap",
+#ifdef CONFIG_PASST
         "passt",
+#endif
 #ifdef CONFIG_SLIRP
         "user",
 #endif
-- 
2.50.1

Re: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST

Posted by Michael Tokarev 1 week ago

On 7/13/26 22:45, Rohitashv Kumar wrote:
> From: Rohitashv Kumar <roohiit@amazon.de>
> 
> show_netdevs() lists each conditionally-compiled netdev backend behind
> its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for
> "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was
> added unconditionally, so "-netdev help" advertises passt even in
> builds configured with --disable-passt. Trying to use it then fails
> with "Parameter 'type' does not accept value 'passt'", since the QAPI
> NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'.
> 
> Guard the help entry with CONFIG_PASST so the advertised backends match
> those actually compiled into the binary.
> 
> Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>

I'm picking this trival fix  up for qemu-stable - let's stop confusing people :)

Thanks,

/mjt

Re: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST

Posted by Puranjay Mohan 1 week, 4 days ago

On Mon, Jul 13, 2026 at 07:45:11PM +0000, Rohitashv Kumar wrote:
> From: Rohitashv Kumar <roohiit@amazon.de>
>
> show_netdevs() lists each conditionally-compiled netdev backend behind
> its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for
> "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was
> added unconditionally, so "-netdev help" advertises passt even in
> builds configured with --disable-passt. Trying to use it then fails
> with "Parameter 'type' does not accept value 'passt'", since the QAPI
> NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'.
>
> Guard the help entry with CONFIG_PASST so the advertised backends match
> those actually compiled into the binary.
>
> Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>

Reviewed-by: Puranjay Mohan <puranjay@kernel.org>

Thanks,
Puranjay

Re: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST

Posted by Philippe Mathieu-Daudé 1 week, 4 days ago

On 13/7/26 21:45, Rohitashv Kumar wrote:
> From: Rohitashv Kumar <roohiit@amazon.de>
> 
> show_netdevs() lists each conditionally-compiled netdev backend behind
> its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for
> "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was
> added unconditionally, so "-netdev help" advertises passt even in
> builds configured with --disable-passt. Trying to use it then fails
> with "Parameter 'type' does not accept value 'passt'", since the QAPI
> NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'.
> 
> Guard the help entry with CONFIG_PASST so the advertised backends match
> those actually compiled into the binary.
> 
> Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>
> ---
>   net/net.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>