From nobody Sat Jul 25 20:49:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783974785; cv=none; d=zohomail.com; s=zohoarc; b=fGtR6qRIrIKmOUggKbbZn8dtFmu2vY1fqB0zMw6LLdlbv9Aw6j5noozkr7oHGyj8lkOMcs0n6ufHv2dg0rG5+oBi61BXgcpVtfj6oh/I8yWhMAsCkLxd8pjDl7M+UKCn9XoHz9WtBrZqIOWGw7h+KZFipGwgILwR4nC9VrQAiXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783974785; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nIKPn37ekPjotsQBGbChfqYBuVfdRftV02OfijT9yAY=; b=Y9Ng2+5U6rrcCZ6UrETLn2ods8D+2B/0F58IS04WNv3yFtHa/DNxOO4vrY+yyn7HFokaajgbfyNUUu8ZOGfbbUFEotHYGvK8xIljK+EBp5nqAlCcV6t7HZIc9UcBEAw8XyaPRJ8NXIaGeujSQiRWE+VzbuQo2sqPHUpxyOKau3A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783974785948257.745442119396; Mon, 13 Jul 2026 13:33:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjNKR-0007kB-GX; Mon, 13 Jul 2026 16:32:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjMal-0000Ou-KC for qemu-devel@nongnu.org; Mon, 13 Jul 2026 15:45:31 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wjMaf-0003TM-63 for qemu-devel@nongnu.org; Mon, 13 Jul 2026 15:45:22 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-47f3e6cc44aso1337155f8f.3 for ; Mon, 13 Jul 2026 12:45:17 -0700 (PDT) Received: from ip-172-31-13-20.eu-central-1.compute.internal (ec2-18-198-207-175.eu-central-1.compute.amazonaws.com. [18.198.207.175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464a96fdsm2052990f8f.24.2026.07.13.12.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 12:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783971917; x=1784576717; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=nIKPn37ekPjotsQBGbChfqYBuVfdRftV02OfijT9yAY=; b=WxSZ0+NFHwvt8iO4O3Ijw6i53vwikihmuF0oyGqa1Gtu+L311orQ+CaUDgTh4cm0MS mhNj1Vly6twdrgOtxVAAZ/SpGtqR4uMF5eomYkolKCtSpoHGGXZVmFHkVuLC78X1A4JV QVIUa9OrNyh26lGnHOtUAunfV+v27PPYT1iMFx2+5m8baHqsRaTuHRbdrE5Yg66f2Hx9 Ux5o/zidyIbrN4JCga3saiRXaAmMVgGdHRG5tm2GhxlclxLy7hsL2lFxUl1ccZx//j6Q jpo3igw1jiFhuoEpm0suv7nolWp0XGQZQSfhaMPiOpEWPGPEoNOgbQkOK0PnWoRZTHKf uFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971917; x=1784576717; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nIKPn37ekPjotsQBGbChfqYBuVfdRftV02OfijT9yAY=; b=Vi8lBvtOP6voxiJ63ENMmUZMy7ClNHHBhsTO8Jb/Fk3l4RBEFo7UTB2UjPF9ccsJTL r/rdtXuJ6ih0wuwUw6r+ctbJwt69q6ThSsdU3YRH9zEeS6A34FwGso7eRJNhlJ2iXqOn A2RH/r8y+ndxaYy1ZqBcH3C+ujNkpJxQNdCpM9OTPNT2ta1X237anR8kvPUpiRIINA2b oMRweKw6SWMi5CQBhS/9VNV4HIoLj/jmnHYCTN6Xh0wPiaSiLi1VAVpjN/1RHwdCoxrF sETbgdEml8qP//K4FtmxPbXkHNaBKbVc0TnbAs8wD+1nnPcrPkqiYczPGCpG0oCfP0BO WuCA== X-Gm-Message-State: AOJu0YxW/YAyWnXCmEQ+566EgCSaj6KUtorLQ34638ea53Kdmeb52OIm 6hI4ydhhXfsk7AXWGtpCX/GB1ZkhSkueyrzXC5iWJNWH9IEMHFRfV8bLFvKYAXbfPgs= X-Gm-Gg: AfdE7cn1W+WoBGpETl9Rd9Sl0TQfjCCrVtIdOnMliBHcu6BT6cNYxw5M95yVZeq65kQ CXV6XHcsSYvm1KpjUadHGA+DK8BLa4GnpJ2yyt1dzFQ5W3jNul/r5OHoJVkK9/WuF3M/b+E5pxP McHU0LMJnXncT/Y38I+krvh0BbbDDmhQUVD9AS1PLzNGYYuyQnja2Eclsh7IdIi7+OV40dncShO 82AEdewS+iWkWK1ZsUYweSHwM389oUOqs8AuSJx0fI8R5m4ava7cQTdbhEwhO2HNO1Iyg5vkVxu GYG6fUjiRDCLWE1a0g5VNYQU+4iFVJ0UTy2yEIX53lvju5cSropBLS18qyiHeZ+LbUKjA6b0nPG P48kEeaXuapj+c+smHuD3W73g5cfkRUurfw5UOt4gAgAPijBPi9mZImOCRdDFCSdLbmO+pLX/tY sPydIrUKBkd4OVyrTMQ0KKHOLLIYP3mCPK1I6e6iU6AffwXVpyBhooevRSsw5rSOidinQE1ces6 VIa4xcarLFhn2k/TdxAKTIemJsU/0iwTrzv3IkgTlk/xHxUCBIlWIiosPUFqQ== X-Received: by 2002:a05:6000:4906:b0:47d:f02a:99c8 with SMTP id ffacd0b85a97d-47f2dc9bdd2mr10999394f8f.23.1783971916429; Mon, 13 Jul 2026 12:45:16 -0700 (PDT) From: Rohitashv Kumar To: qemu-devel@nongnu.org Cc: Jason Wang , Rohitashv Kumar Subject: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST Date: Mon, 13 Jul 2026 19:45:11 +0000 Message-ID: <20260713194511.1058450-1-rohit.kuma1313@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=rohit.kuma1313@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 13 Jul 2026 16:32:38 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783974787661158500 Content-Type: text/plain; charset="utf-8" From: Rohitashv Kumar show_netdevs() lists each conditionally-compiled netdev backend behind its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was added unconditionally, so "-netdev help" advertises passt even in builds configured with --disable-passt. Trying to use it then fails with "Parameter 'type' does not accept value 'passt'", since the QAPI NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'. Guard the help entry with CONFIG_PASST so the advertised backends match those actually compiled into the binary. Signed-off-by: Rohitashv Kumar Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Puranjay Mohan --- net/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/net.c b/net/net.c index 2892f17..5c39f8e 100644 --- a/net/net.c +++ b/net/net.c @@ -1385,7 +1385,9 @@ void show_netdevs(void) "dgram", "hubport", "tap", +#ifdef CONFIG_PASST "passt", +#endif #ifdef CONFIG_SLIRP "user", #endif --=20 2.50.1