[PATCH 00/33] accel: Unassorted cleanups around debugging

Philippe Mathieu-Daudé posted 33 patches 3 weeks, 4 days ago
Failed in applying to current master (apply log)
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@mailo.com>, Roman Bolshakov <rbolshakov@ddn.com>, Phil Dennis-Jordan <phil@philjordan.eu>, Magnus Kulke <magnuskulke@linux.microsoft.com>, Wei Liu <wei.liu@kernel.org>, "Doru Blânzeanu" <dblanzeanu@linux.microsoft.com>, Pedro Barbuda <pbarbuda@microsoft.com>, Mohamed Mediouni <mohamed@unpredictable.fr>, "Alex Bennée" <alex.bennee@linaro.org>, Zhao Liu <zhao1.liu@intel.com>, Laurent Vivier <laurent@vivier.eu>, Helge Deller <deller@gmx.de>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, Alexander Graf <agraf@csgraf.de>, Peter Maydell <peter.maydell@linaro.org>, Marcelo Tosatti <mtosatti@redhat.com>, Song Gao <gaosong@loongson.cn>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>
There is a newer version of this series
accel/kvm/kvm-cpus.h               | 12 +++--
accel/tcg/system-page-protection.h | 17 +++++++
gdbstub/internals.h                | 10 ++--
include/accel/accel-cpu-ops.h      | 10 ++--
include/accel/accel-ops.h          |  4 +-
include/accel/tcg/cpu-ops.h        | 12 +++--
include/exec/breakpoint.h          | 26 ++++++----
include/exec/cputlb.h              |  8 +--
include/exec/watchpoint.h          | 20 ++++++--
include/gdbstub/enums.h            | 12 +++--
include/hw/core/cpu.h              | 42 ++++++++--------
include/qemu/accel.h               | 10 ++--
include/system/hvf_int.h           | 11 ++--
include/system/kvm.h               |  9 ++--
include/system/kvm_int.h           |  2 +
include/system/mshv_int.h          |  1 -
include/system/whpx-all.h          |  4 +-
target/arm/internals.h             |  6 ++-
accel/accel-common.c               | 22 ++++++--
accel/hvf/hvf-accel-ops.c          | 23 ++++-----
accel/hvf/hvf-all.c                |  9 ++--
accel/kvm/kvm-accel-ops.c          |  7 ++-
accel/kvm/kvm-all.c                | 55 +++++++++++---------
accel/mshv/mshv-all.c              | 18 +++----
accel/tcg/cpu-exec-common.c        |  2 +-
accel/tcg/cpu-exec.c               | 12 ++---
accel/tcg/cputlb.c                 | 15 +++---
accel/tcg/tb-maint.c               |  1 +
accel/tcg/tcg-accel-ops-rr.c       |  2 +-
accel/tcg/tcg-accel-ops.c          | 31 ++++++------
accel/tcg/tcg-all.c                | 16 ++++--
accel/tcg/translate-all.c          |  3 +-
accel/tcg/user-exec-stub.c         | 11 ++--
accel/tcg/watchpoint.c             |  9 ++--
accel/whpx/whpx-accel-ops.c        |  7 ---
accel/whpx/whpx-common.c           |  1 +
cpu-common.c                       |  8 +--
cpu-target.c                       | 10 ++--
gdbstub/gdbstub.c                  | 11 ++--
gdbstub/system.c                   | 39 ++++++--------
gdbstub/user.c                     | 20 ++------
linux-user/riscv/cpu_loop.c        |  2 +-
linux-user/s390x/cpu_loop.c        |  2 +-
stubs/replay-mode.c                |  2 +-
system/cpus.c                      |  2 +-
system/watchpoint.c                |  8 +--
target/arm/hvf/hvf.c               | 24 +++++----
target/arm/hyp_gdbstub.c           |  9 ++--
target/arm/kvm.c                   | 14 +++---
target/arm/tcg/debug.c             | 81 +++++++++++++++---------------
target/arm/tcg/mte_helper.c        |  3 +-
target/arm/whpx/whpx-all.c         |  2 +-
target/i386/hvf/hvf.c              | 10 ++--
target/i386/kvm/kvm.c              | 15 +++---
target/i386/machine.c              |  1 -
target/i386/mshv/mshv-cpu.c        |  6 +--
target/i386/whpx/whpx-all.c        |  8 +--
target/loongarch/kvm/kvm.c         | 10 ++--
target/microblaze/translate.c      |  2 +-
target/ppc/cpu.c                   |  4 +-
target/ppc/kvm.c                   | 20 +++++---
target/ppc/translate.c             | 16 +++---
target/riscv/cpu_helper.c          |  2 +-
target/riscv/debug.c               | 12 ++---
target/riscv/kvm/kvm-cpu.c         |  8 +--
target/s390x/kvm/kvm.c             | 11 ++--
target/s390x/tcg/debug.c           |  3 +-
target/xtensa/dbg_helper.c         |  2 +-
target/xtensa/helper.c             | 36 ++++++-------
trace-events                       |  2 +-
70 files changed, 477 insertions(+), 388 deletions(-)
create mode 100644 accel/tcg/system-page-protection.h
[PATCH 00/33] accel: Unassorted cleanups around debugging
Posted by Philippe Mathieu-Daudé 3 weeks, 4 days ago
Refreshing the `split-accel' preparatory work; this series follows
"accel: Preparatory cleanups for split-accel" from last year:
https://lore.kernel.org/qemu-devel/20250703173248.44995-1-philmd@linaro.org/

Nothing really noteworthy here, generic code refactoring with the
objective to strengthen the various APIs, introducing few enums or
headers.

Philippe Mathieu-Daudé (33):
  cpu: Constify CPUState::cc (cached CPUClass pointer)
  target/i386: Remove duplicate tlb_flush() call in cpu_post_load()
  accel/tcg: Restrict tlb_protect/unprotect_code() to TCG
  accel/hvf: Remove left-over comment
  accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
  gdbstub: Add trace event for STEP packet handler
  gdbstub: Only return E22 when reverse GDB is not supported
  accel/kvm: Always define AccelOpsClass::supports_guest_debug
  accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG
  accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config()
  gdbstub: Store @can_reverse in GDBState
  gdbstub: Make default replay_mode value explicit in stubs
  accel: Have get_gdbstub_config() return @can_reverse value
  accel: Move supports_guest_debug() declaration to AccelClass
  accel/kvm: Hold have_guest_supported in KVMState
  accel/kvm: Hold gdbstub_sstep_flags in KVMState
  cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h'
  cpu: Define BreakpointFlags type
  accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints
  gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode
  gdbstub: Reduce @type variable scope
  gdbstub: Introduce GdbBreakpointType enumerator
  accel: Use GdbBreakpointType enum
  target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint()
  target/arm: Factor arm_check_watchpoint_hit() out
  target/xtensa: Move watchpoints handling to check_hw_watchpoints()
  target/ppc: Ensure TCG is used in ppc_update_daw()
  accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers
  cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h'
  cpu: Better name cpu_single_step() trace event
  cpu: Introduce cpu_single_stepping() helper
  cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
  cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping()

 accel/kvm/kvm-cpus.h               | 12 +++--
 accel/tcg/system-page-protection.h | 17 +++++++
 gdbstub/internals.h                | 10 ++--
 include/accel/accel-cpu-ops.h      | 10 ++--
 include/accel/accel-ops.h          |  4 +-
 include/accel/tcg/cpu-ops.h        | 12 +++--
 include/exec/breakpoint.h          | 26 ++++++----
 include/exec/cputlb.h              |  8 +--
 include/exec/watchpoint.h          | 20 ++++++--
 include/gdbstub/enums.h            | 12 +++--
 include/hw/core/cpu.h              | 42 ++++++++--------
 include/qemu/accel.h               | 10 ++--
 include/system/hvf_int.h           | 11 ++--
 include/system/kvm.h               |  9 ++--
 include/system/kvm_int.h           |  2 +
 include/system/mshv_int.h          |  1 -
 include/system/whpx-all.h          |  4 +-
 target/arm/internals.h             |  6 ++-
 accel/accel-common.c               | 22 ++++++--
 accel/hvf/hvf-accel-ops.c          | 23 ++++-----
 accel/hvf/hvf-all.c                |  9 ++--
 accel/kvm/kvm-accel-ops.c          |  7 ++-
 accel/kvm/kvm-all.c                | 55 +++++++++++---------
 accel/mshv/mshv-all.c              | 18 +++----
 accel/tcg/cpu-exec-common.c        |  2 +-
 accel/tcg/cpu-exec.c               | 12 ++---
 accel/tcg/cputlb.c                 | 15 +++---
 accel/tcg/tb-maint.c               |  1 +
 accel/tcg/tcg-accel-ops-rr.c       |  2 +-
 accel/tcg/tcg-accel-ops.c          | 31 ++++++------
 accel/tcg/tcg-all.c                | 16 ++++--
 accel/tcg/translate-all.c          |  3 +-
 accel/tcg/user-exec-stub.c         | 11 ++--
 accel/tcg/watchpoint.c             |  9 ++--
 accel/whpx/whpx-accel-ops.c        |  7 ---
 accel/whpx/whpx-common.c           |  1 +
 cpu-common.c                       |  8 +--
 cpu-target.c                       | 10 ++--
 gdbstub/gdbstub.c                  | 11 ++--
 gdbstub/system.c                   | 39 ++++++--------
 gdbstub/user.c                     | 20 ++------
 linux-user/riscv/cpu_loop.c        |  2 +-
 linux-user/s390x/cpu_loop.c        |  2 +-
 stubs/replay-mode.c                |  2 +-
 system/cpus.c                      |  2 +-
 system/watchpoint.c                |  8 +--
 target/arm/hvf/hvf.c               | 24 +++++----
 target/arm/hyp_gdbstub.c           |  9 ++--
 target/arm/kvm.c                   | 14 +++---
 target/arm/tcg/debug.c             | 81 +++++++++++++++---------------
 target/arm/tcg/mte_helper.c        |  3 +-
 target/arm/whpx/whpx-all.c         |  2 +-
 target/i386/hvf/hvf.c              | 10 ++--
 target/i386/kvm/kvm.c              | 15 +++---
 target/i386/machine.c              |  1 -
 target/i386/mshv/mshv-cpu.c        |  6 +--
 target/i386/whpx/whpx-all.c        |  8 +--
 target/loongarch/kvm/kvm.c         | 10 ++--
 target/microblaze/translate.c      |  2 +-
 target/ppc/cpu.c                   |  4 +-
 target/ppc/kvm.c                   | 20 +++++---
 target/ppc/translate.c             | 16 +++---
 target/riscv/cpu_helper.c          |  2 +-
 target/riscv/debug.c               | 12 ++---
 target/riscv/kvm/kvm-cpu.c         |  8 +--
 target/s390x/kvm/kvm.c             | 11 ++--
 target/s390x/tcg/debug.c           |  3 +-
 target/xtensa/dbg_helper.c         |  2 +-
 target/xtensa/helper.c             | 36 ++++++-------
 trace-events                       |  2 +-
 70 files changed, 477 insertions(+), 388 deletions(-)
 create mode 100644 accel/tcg/system-page-protection.h

-- 
2.53.0