From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857001; cv=none; d=zohomail.com; s=zohoarc; b=m8yYLdHKn5O1FttWYgmzQst0Cq61boysfPLEdhH0/BY8whAKcRB3VuGn5ILAUMdrpSM8Je0OiUU/KjBrryBpX0C0XorruR+9LMKIr+Kmkn4hKhxAUHYWlrTafvFRQDayTg/WZUNI4b1CLKTmG4PH2rJzXQvTCivN5uVjYP95aUg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857001; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BV3Qij8EC8HKpY66szPIpqeKiHQzHVd80VSFDRIdzxo=; b=FbrZgavpjDTdHilEhnsJCObcPmPDqrm7vKTfsCBjAnuppH20iHzI4p2/ldMRNHz5DNwIG72bVCrR1FwdSJ6T1KSio4HcfkOCZrngp7SIBuxNHthIvy+FAsjU59E3E31cqpEdSTg+EcXBiUXKHUwv0hTMIobNCHLL1h8O2UjthxI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857001247728.5965068987388; Tue, 30 Jun 2026 15:03:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegXh-0002t5-7c; Tue, 30 Jun 2026 18:02:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegW5-0002So-Qa for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:20 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegW2-0003WU-5O for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:16 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDalA2948483 for ; Tue, 30 Jun 2026 22:01:12 GMT Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4kgw0pqb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:12 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9692ca167ddso1086277241.2 for ; Tue, 30 Jun 2026 15:01:12 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636cf1asm12147563f8f.18.2026.06.30.15.01.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BV3Qij8EC8HKpY66szPIpqeKiHQzHVd80VSFDRIdzxo=; b=T8uWZARW3jkobYyv 86/iBQ5uoy1qy8t27DC5NJ2v95Jau/msqwekOfbnCtFjWduUrUiTovAt1rSoWDeZ y6/oWLx4f6H++Qr/KNAqNOcoMeKEjwVXT689L87djojfZm6YQXSXpylcUVFOLAEg y0xb7EQNVa0RiXnG4g/E+IkYfii4pD6XgvsnCl7yn9LFFxG8eGtIJ4s+o2M0pcIS Wz6N+UNbjL4JvrD1vDNyr4yHlXWafQM+XB1aI3KZhBiyb/+ymE8UkDr0OKHzkEFT EKeR/sRks5yJGxOBfk8qrJ6g2P9l+Nt5lGiRd7W3VhTowH8ODRQn3breIv1AYK6z qF7OAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856872; x=1783461672; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BV3Qij8EC8HKpY66szPIpqeKiHQzHVd80VSFDRIdzxo=; b=SZC8koXhRxO4L0LLkm5DvRZOP5Q07h9AQgSvSgqELRvNyo6IWnC8MnOvLHpRCIZcS3 iyEw2RZI7lYECot8hrcM/UlS6Q/JCJN1CMwAI+3AmIasUbhkmB2ql1LZBOjv1iVUwARR EPXFJI0DBcXtYumMY6TS6aPeW179GjMeoEXHpaWtlRqYS0qPBFywL7KEw6F88hW6nKve +1FrwCZ1kPKSafCY+rYbQ/vMZirfSGm5HzSlIHOOevKA4197oY4AbpP4g9n/BPW49n3g nBL3qfz3iPkAc0+yoEVbwbcLXjEIh9i44qPe0rLnCe9q3ThA8CeMaRf7HHB8fzuWEyQ+ Nwzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856872; x=1783461672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BV3Qij8EC8HKpY66szPIpqeKiHQzHVd80VSFDRIdzxo=; b=YexoX88SpcHuIPoQhS8fO0gzZRi6lc7Mt1XXNu/VhTErjBtX0eECHUHfdrKnoCH79M U3ygA3TXwPojUUp4zNX7QlA8V4zVcv63iEPi9LYKVYSLuClcqliRevmwdxnDzW2j7/OQ 0L2puoCdqj/Uma0dB4dilNII4jSYIqe3mNNbJf/lDuNf3RjYhl92hy3M161N58AwQx88 +bnS7p/qpsWJIE8wNmhoMbnxNdHQoDNwrokrZltlYFSjBGaP9JmDt3Ua8l/mOARAdMRM iPTBXsSMZsBXg79E2NmSqvJx1ikzBEf7RWD1S7SyNqx4LDKZqsiIkDPruFGwE/mC/kLN +aGw== X-Gm-Message-State: AOJu0YzacrDpA3dD7FYBNFX0MbVYzMsDOr0RKTyUinfab4k68Teh9Csk adTt0Nsw35YuKslGwCbCQkgsMUJwQvyRXyt8gnVyKOfMtGBpS3uITKaCW5VgwtmuFC0l36Xfvxn I+V+CkH6PeFiqlzjfJCV4eVCAdLegDACEVz2qzA0zsXyqI1N9a8r/acXyJDALW3AFDw== X-Gm-Gg: AfdE7cli/RdqXjBMOZNtdvwaipm+IV7HEPyG3/ZHRdlaXbPwgxOEpFhajdWSFEMvLA6 1ADOrD5iSxYs+ZB5C03ViqdbShHFT37lEmeahnkA39rsqjWcACIm6M7hQkZb9lFxVehM2SALEqn B+xNZ76x+a6BNc2t5cwdd8dGRlaeBESNmSC6NRIbX10auLqfqQeOsAUFkZiNITjBezRySSc1Z1w 2GmUqpJsz0ps/iMlov4mqd+2/PFByVdrwzRXse+u3kM9MlkvNCAzi3/MOEDmyj4X2bRmCv0S4Yd aBPx2OXpBHVxi7jzf7g8Kb9xy159dIQtjj1nIiJPt9QQssUO4uJqbQv/OZAzGIb3utdpdi30IyO Kf0Ty4WNxn5m3yrxCvNQMFsLpxdK/0bOA8IUloWDcaqDxkd13j+t4U3CbAjMyOpatlBc3 X-Received: by 2002:a05:6102:644b:b0:6d4:ba3e:bf97 with SMTP id ada2fe7eead31-73a35ff40b8mr2328058137.4.1782856871556; Tue, 30 Jun 2026 15:01:11 -0700 (PDT) X-Received: by 2002:a05:6102:644b:b0:6d4:ba3e:bf97 with SMTP id ada2fe7eead31-73a35ff40b8mr2327993137.4.1782856870920; Tue, 30 Jun 2026 15:01:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 01/33] cpu: Constify CPUState::cc (cached CPUClass pointer) Date: Wed, 1 Jul 2026 00:00:28 +0200 Message-ID: <20260630220100.1289-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Co2PtH4D c=1 sm=1 tr=0 ts=6a443ca8 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=O_p9N0DIn41U_kaacwQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: jGeWFDtRW5Xdnyj-Lbws5_f02n-M6l8J X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXz9lQ1Uxre5mc /LrKJEQW2DARF9Qx2rpiTTgCEXwTpHJ62ONfNR4T0OM/LfPEmw8aKZsRZeBx3oyIpk3JiM964kd 8KXqDdyJ+XtWXx8YCzCChqlpocKkyIE= X-Proofpoint-GUID: jGeWFDtRW5Xdnyj-Lbws5_f02n-M6l8J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXzXzprp0LMju+ 1jWKz8QJ2uZMAwqq/4sOuMKSVi5qyvgLMVU2Ezyqr/WJkdoR3PvCEEkoTKbL90aJ1oQIAV/MJmD dboSSrVTCd4eKlIWlumZKmqshz/ffdkWlwEDXYjqCD0XwJSDAB08MvBgKycgpWU4H/PXQ4LU1bD kfvswHgFohlsUjKI/cbWYFvbk3mO/ClWFYWtzqxKxyo4hLhGwHL7m6lScE0lDaxEN70snE5JeDY 4yKltoWYfPDwIexZtRq0b+sCQttbX0nNrY+hNKrLevWeMRkUcW07QTvit0RNXgu5pfpIh4Ws7fe 5tAsSME+s0qbV0snIouXOYFJurjTsi3aApMjrqJnvOP0Mc2SLDYBFBtXRUfO5Ld2NjrcRZdrnRZ 0WoOXX5lj5XiJQ/ZUI1ZE5QKclMQlOGg8bxsb7BdVu8RhzbwOnulck0x/hdYvbfvKQIwPGUvuOO g15nAoew+E6wmBqebrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857001987158500 Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Chao Liu Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 59d601465b4..60a23d6f38b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -480,7 +480,7 @@ struct CPUState { /*< private >*/ DeviceState parent_obj; /* cache to avoid expensive CPU_GET_CLASS */ - CPUClass *cc; + const CPUClass *cc; /*< public >*/ =20 int nr_threads; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 9c754b03656..d7f91dce9db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; const TCGCPUOps *tcg_ops =3D cc->tcg_ops; =20 if (tcg_ops->synchronize_from_tb) { diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 3f1a3a28438..328d96aba30 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retad= dr) void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) { TranslationBlock *tb; - CPUClass *cc; + const CPUClass *cc =3D cpu->cc; uint32_t n; =20 tb =3D tcg_tb_lookup(retaddr); @@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) * to account for the re-execution of the branch. */ n =3D 1; - cc =3D cpu->cc; if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch(cpu, tb)) { cpu->neg.icount_decr.u16.low++; diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c3c944e965b..26366acb674 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int bas= e_reg, =20 static const char *gdb_get_core_xml_file(CPUState *cpu) { - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; =20 /* * The CPU class can provide the XML filename via a method, --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857118; cv=none; d=zohomail.com; s=zohoarc; b=RBF/AlwffUc00V4W6d+EyIkzfIZRukiHdvntjzurnDItXZCspUm9UY6rJpyx9NuLLJpjnSSpBkALfzxELCGQsF16m2Jh5BLSuIML/9Z3lcTTXr6e/NE5fNlkTq3TcN+A5D+Qz3bswufqsjah28xyiVWq9TOxTt1dw/tRGd/d1hU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857118; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xxo4rncdHVOGViF+d02fuLUfZcQgG/AAcgr6n4Dh5Qs=; b=muqJD4mUEsy+d/bZqoWK9vw07uZ3azCjU5Xyhk2uVTor3LtFdsqvNuNrIC2+k/8D6pP8oELjwPYLSFPQ/+wIaerEWsLOmvR7yaOgxPhI5rw2IBM5BZygAn6VDb17rOLQFUj3wAmIbtX4oTAEQOVXIi4JlYKuMeb1U4f2cQdMVFg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857118774388.7759727586671; Tue, 30 Jun 2026 15:05:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegXm-000355-EB; Tue, 30 Jun 2026 18:03:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWC-0002Tl-Vu for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:28 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWA-0003YX-Iz for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:24 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJE2Nw2838807 for ; Tue, 30 Jun 2026 22:01:21 GMT Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4hbd1f71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:21 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9692aed16feso4226045241.3 for ; Tue, 30 Jun 2026 15:01:20 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bfe7427dsm4110515e9.2.2026.06.30.15.01.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xxo4rncdHVOGViF+d02fuLUfZcQgG/AAcgr6n4Dh5Qs=; b=av6QHs47UIiuVOtP GEZUlrxV6YgEIah7rjCGb8l7tjoMx5TtIy4suGCX9v8YDQJC4OMab1Ay/aoev4PM fmAAP+4uD7yU7oCpaTi01OZlNhBhovIkqvtbMC0WE3PRZXgBlKZudTAHrRIlVP4G dzmd0PFsMtI14aB0Q4lS0EACI4UzyYlrCZ/k2nTTyfYw9OVTjI1WDQBIFYkrDm6J q07nNJnDpvqHCWnoBJ7tyd0koWc+Ss17gk2zPWEvQ3rY1DSPiKXbOHJ+/I1llfr9 +E5rHG/GOY2kU61h28XokSW4mVXXWn5ScK6iwUo7mridoTOXw58OPlQhOaxeNP6l cwV39g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856880; x=1783461680; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xxo4rncdHVOGViF+d02fuLUfZcQgG/AAcgr6n4Dh5Qs=; b=BUj/23QXdbk0DQqkSbFC4rGS8gcjTBqP5GnSPSuCnIcYnm3f4uLzDoDY491384VpHJ 4unxR4jwj0aDm9qoqGBJEer31khQYVwGlFy0PTc2iPX1xBIb4I6OcEvHWvXYri055WoB mN7uPjVMDAyS8qOsATCjIWKRWfD/DZ9EUIs+yYiqnpr1ipIucmPGrLFVsC6diu1+UuO0 mm2vTUS9u7oHA5ZOiLCLdVZ31uTVs4G2CSZKLCiaqYXMDsbrdyeRRp23UL4ZMeHRKiat pG/NdEpaneHx19D60Xny4r+nChu75i+g5LrbYT65D+k/0BWwRjtWrC6IvL/Z4pcdeuxM ji7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856880; x=1783461680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xxo4rncdHVOGViF+d02fuLUfZcQgG/AAcgr6n4Dh5Qs=; b=SBpwQtXwvVmJR1QKMRto2fOXwA6beSkS5aKTIKsffGr9vF0tJpHeV5DdA+fGn3i3d9 +Cb+eylhl2Y1tWd4sF5CIkBZIYeAx7JZ4BlMJDu98uWDL1+TM5Ivfk3GhyCeBSSvzz8h 8TMPioERo0LEbBXBXJeQgB/YkO3kAo5nRwAq0gEvgNW3KZJ1GO3MMuKHXIzoFzqRCuZh jgiWPWTapPnB/vGEFHPz3kvcua9mxsHCOfX9UW2uhBsXqEtSTjFiojUWBCKyNPxmUnHd LDPUAtZjTMZ7a2qzeNY+j8QkWwGsLc6SoLviE54uuzapZax+yTQ7LHdNfp08CfS2iy55 Ns9A== X-Gm-Message-State: AOJu0YyDFhfiBz1AsqBIOS42iFhqMXnzAaO2E/tNz1ZABSZPgZaKF8V5 1HRAvMfg9ugidofZObB0IrvoVhRxzzmhmM3/DkkaaJPdxjRAuGVIQJO27k+IssW+SF2ogI6bCHi 6EjAmHvktlKP8OGsm8AXnyacwINtfTYLasGJu+dGCHK55oGt5UHKU9mF4SpDJGS9b4w== X-Gm-Gg: AfdE7clOzSF4OMAVPVQAc+4uSw+/ytX1pxXvz6wnu0wvZtMT3D6ovFhCgE0qEpao9ZB 7+YPsWzS9Snr5MkiGK0COdX9csCbfh/j56e0PHUs/2Ph9vEeLIzJ0v9c3LoOHzhtbVG9nt289oW 2lYxLO2hG1SBxgC4AMPrILHv4n7b1txYT8EyPWDbQsOdvgXDOMW6319+dUbGfkFrBKkAV8Y4dm6 1vb/wnY7KCp10UX2S2ihE5/i8rP3AZzZJ4dUC6g4LsobNd1w98grdambxQEwutD9ZSZXn4jvpeH twwhu1aGceRQ0iG8wPEtcVfYb1fCycjHi9Np8Dc64L1VZIIovMLFtFUOj+o0aAeDWYCoOARVQIX U0USMbhhWaNxE/XtWToKsiMIb2hCEmH5j34Y6OHswTl5C/dLnr3JTkOWW0oKcQjcI56Hk X-Received: by 2002:a05:6102:c4c:b0:729:cc7c:7de2 with SMTP id ada2fe7eead31-73a369f3636mr2630899137.10.1782856879875; Tue, 30 Jun 2026 15:01:19 -0700 (PDT) X-Received: by 2002:a05:6102:c4c:b0:729:cc7c:7de2 with SMTP id ada2fe7eead31-73a369f3636mr2630838137.10.1782856879323; Tue, 30 Jun 2026 15:01:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 02/33] target/i386: Remove duplicate tlb_flush() call in cpu_post_load() Date: Wed, 1 Jul 2026 00:00:29 +0200 Message-ID: <20260630220100.1289-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX4aLpOx7K1uv6 OZnuiEaKuohhnkQlISPUVVGg8efi/kyP+MFNEXLNa1F5NPEg6tsLpBXcP/b11i1qtwkVRNWsRwa t5LSFoQF1WVNaab6NJYWZMzGcj4ZlTo= X-Authority-Analysis: v=2.4 cv=MpJiLWae c=1 sm=1 tr=0 ts=6a443cb1 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=yCXKn3YvPAIAJG_6uuMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: BxqWax-2sfbhE1bdxHo3Pt1Ykaq2tgZK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXwGlkH5VFX8Xv CH/3WhdbriyJ5TgrnboX7YkMbvpb8j3kRSCDupITM+1NaxG5KLwkydPl/SOduRsEbfwjWq/gV7K sPgR0Y5rl7r8Ht4AJsJDrsmDTBcNb7tRbjsohoaup9PTznsZygY2ZI/nxQKJONQwz+bBeQS8SGe 7KOI3YIYWQazXt2xVO8H7B592ctJiyyuGLSV3pxPQPLTjvzIJmgVSuc6aIf3x+IjXHQmu1jFXNT PaEZbySKwESVKmnePC7GgP9v+Ijc1oCCW43B5GSsaVMfZwKDelSCKTzKg/OKzQmLc6cgYaShm92 R68ns9qzJ2xooyGni90W84S7DGIZ+GqJBenhUpmdPwHhkUdIM5sbcZObiWGhaXTl5SQiLUqssyh GZgHMzHmWuvKfr/Sfygyr2HgL5Ybqj9x4CT06Mhga/4lsG/4dMcMF4+AvNgXy6dcSuGpLAaa6N3 uOSKqMypM9Qxp6C5xlA== X-Proofpoint-GUID: BxqWax-2sfbhE1bdxHo3Pt1Ykaq2tgZK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857120461158500 Common vCPU cpu_post_load() handler calls tlb_flush() since commit 9656f324d25 ("Move interrupt_request and user_mode_only to common cpu state..."), no need to call it twice. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Chao Liu Reviewed-by: Richard Henderson --- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 1f5c517e562..df0e0c178e4 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7] =3D dr7 & ~(DR7_GLOBAL_BP_MASK | DR7_LOCAL_BP_MASK); cpu_x86_update_dr7(env, dr7); } - tlb_flush(cs); return 0; } =20 --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857055; cv=none; d=zohomail.com; s=zohoarc; b=CHhBzPX9FXP+kMKqfhRiNFcHs692BtFniUCOhHLchr9uxtU5U0W8RlC0W/QFHSLg4X5yb8h5SCEsTPeAbyh843alxO0+z1OjQnQgmevqPXh24f/2e4pvs1pP9b1ZDdorpu04W74nbzUkZ88UFjb+lDXF1LVaAcbkjK1InY2QUX8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857055; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PozYVmyS+sQUTBp7M+ZfA7G6EVpxfWO8Hrg4LZ11D3s=; b=Mhaui3SA63n3+YyyTJuK4qjmJklUbgSCav2MXmX0RuhziAo6kCNRoDnd9KYDnSE83EyOjpcdIgvowr/OLT/1ViJdAu/nWMLNa+pYpRdUtkpEwd1Ltc1WNJLE8oUcQpSB1rMyzg10btTKWhTm1UU+cI4zjLJlwUL7pFzW1HLD5Tc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857055743285.0407933372546; Tue, 30 Jun 2026 15:04:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegY7-0003Tv-0S; Tue, 30 Jun 2026 18:03:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWM-0002Wk-CF for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:37 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWK-0003d9-DM for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:34 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDdih2948564 for ; Tue, 30 Jun 2026 22:01:30 GMT Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4kgw0ps9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:29 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-737d352d3b0so3299816137.1 for ; Tue, 30 Jun 2026 15:01:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756797a8besm11884706f8f.35.2026.06.30.15.01.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PozYVmyS+sQUTBp7M+ZfA7G6EVpxfWO8Hrg4LZ11D3s=; b=gc7l7wipIMAai75X HkbsO20y1N/qW9uQm0fPX7KnfK7+9K4oOE/nMeSthPw9I9YHiWPfDS47K9h/aVN+ EBOrRtN0+euVZlwego8uigeNQQYZLWnEzlyuBcaq3F6B6usTzhak7OS5gjrvyvlF +2UGDTAhxS0RdgmqVH+0DKeUswWpFLcpHp+GhrbjY9i5wXdpNz/hvLpGIl1WfSDR 2diBuEqXtKoKPD8FRJp3N0eOmNWHuwuSRx/WawK6Iww1ZTLUd968iZTOmwcJ36t6 l6wAIB7kSzhZw1QJv3B/YGCulJ43dsht6Ck1m7P2Uvw4d3uu6TPFrJE1FCvk52VI rk5NMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856889; x=1783461689; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PozYVmyS+sQUTBp7M+ZfA7G6EVpxfWO8Hrg4LZ11D3s=; b=GWnXGRGBGCcd0GupbosRkvmCopKOKqCGpHbTrj6yHU8MX9rcYpJqlRmvSGCDX8t9p+ /F5j3xWL285qrPCQmofwXA9iqLNn3mIG/nfWyuAdQTwspTEFcC9SWeXMW5Xet2Rr13NV +Q8NTc7qDImSVmoD44u3xKZpXViirXY2Q76x5uhd2/jQi++KlqrhO5eAwgvf32p8aawv +qASPZtfaIe5AcMgYuYa7zuzplClOpXkH/74qjgTeW2NGxiKR5bweHy2HomypOj+xOxZ 8LkBtJ+6/keiaNjSRHp854CdudM7UEX4KuGopDlQPWgQONl7fN335lLpwDK1/XbDuy1z CfCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856889; x=1783461689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PozYVmyS+sQUTBp7M+ZfA7G6EVpxfWO8Hrg4LZ11D3s=; b=nS1WH0XOEZg6m/zhvEwAtTVlfcmM+tKd7JNiL2GOBSe50PKU8Av4IlLpDCo3mO242A SiUcf9uifRlYxQA0U+eIzPejkmfHIDT/eJC9bQm2b4E7lJLT7fqPXTBpxvIVsp+6Ax+4 mh82fcwwI0/d35zpB0u34k7NwBoRI8m0K9H4GpbGixmHdhuA7b83nwIFMXGmeh6LzbqC 331qBvUXP6Qga9AwYiXDEUovI16K72N/Lh/IA2onhGNFdyk6eJ3mFf769RzfB/wc9pi7 tl4fOv/P4AIiC2fZyDJMgfhzCowkTch2vC6i5AFPzSGVSKHBF1uzM0KleSj6sOgdjum5 /9zA== X-Gm-Message-State: AOJu0Ywz6Kby/LldSrRV8ZkQg96yh+tK+h7uc4t+sbI12YBcBJb0rxLY FwToS3TeYA6La+LNeogVwkBWd7wx3hH2cHKr40rI123uIGANdR5g8MfvJDa13OS6qsNlhBf4adQ Zo2WcZJjtSvexeCQ0ZRiqeGjCen6GJxvlmfHPGrLadnpHJfzuQXnBQ8Lf/EPsh4kavg== X-Gm-Gg: AfdE7cl4x4IkpS96KmumJlWiUvrbdbHFfT9wWZ3PBchDKdJixM6ry8N1pAEI8OnQLTN 09ANUc0Ii/lU6A6a4HC8wZuKYdCCPFsal/nOEcfFLF969HHVdSNbk9Z1Anm0bjNwYrDwH8hzDPF 06Ig1cGhcWm5LLMXJDTl0rTYwpnD4aJ3sXf0+wRIPAZGoMan8jYx1p+Wb9AvbL8wceVbpVp1kce vGGDl14WytfNaQ634XgKbq3SFtSMZZaCnJCmxLVMpnnJqR4CVKjQHxbQIcmpgHIwlm9Q41Vm8Fq hPNYSHfcBGhV1Prc3K/y+gB68wrTgEW3LUz1NQqWU37SXJGuOEL1UvdeY52b26Gxvi2IVIOYJy3 CeDOKOvlpZftfLwMNiEE6D0LYCiAZsuUIASMfVnQW+LrHYa/lMwLR7XzqyYcyfvF5Qx3K X-Received: by 2002:a05:6102:5805:b0:738:472f:2ca9 with SMTP id ada2fe7eead31-73a369ec1bcmr2811977137.7.1782856888533; Tue, 30 Jun 2026 15:01:28 -0700 (PDT) X-Received: by 2002:a05:6102:5805:b0:738:472f:2ca9 with SMTP id ada2fe7eead31-73a369ec1bcmr2811776137.7.1782856886629; Tue, 30 Jun 2026 15:01:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 03/33] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG Date: Wed, 1 Jul 2026 00:00:30 +0200 Message-ID: <20260630220100.1289-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Co2PtH4D c=1 sm=1 tr=0 ts=6a443cb9 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=MO-ljkwS13Xngjg1mVIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-ORIG-GUID: YMVkDWfjaiBMTKbQIkwZ5oznq6rb3cCd X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX6YQz/yUk3lGf 9jyFVTAii6PjSPcnLBzlcS/IN09VVD8hyQB1TcEBLW9sE4BlZz2kZc7hZ7hqhgVJWRAHhR4qMLj piNRAfMIUYgH8ij0DN3rhOZ2CWA6T8M= X-Proofpoint-GUID: YMVkDWfjaiBMTKbQIkwZ5oznq6rb3cCd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX2NwgmepoK20Y 7D/fw+2WjPH4E0ZdF6nYjyp8515SYwO1bLaus6Zroba6M0I2dAoGADo1T0LWiy8EOU112qVW2lU It8dfMaqQHM3TGW73dmRMvG0KZ2E9NpH5MnGr8M+fDdaTK+wb744wuEknumJe6gMydX7eROyrFC 3rQOajyUnn2qLtO+NlZjxYF5KkyHyNGrwA9hSxTnsN3V2SakhlvZsJqxy+eSwFPdL4ST2Ya8bd5 3vbOeG5ADJIGG+kSi6hxDLvLWWKOFwV66duQMdhunWw3XGPZEqjUHJNoRI2Yvy8cQhUKGBKo9wL JqYrls6/RiiigHZd5r+7R7RVcLHVYylKCUTrXzrh9u8gWe94V5qQAsLS9tWqDHs+mYuPiE/wdmA 2sOLCcUNUStCBzNVHNmxhUrVObaloTzdA2duYvdRKwmdYq+pySwJd82t+QGzOvk78XcZszqPmJD w7IwdWny7qbHbm19+kQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857056111158500 Both tlb_protect() and tlb_unprotect_code() are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Chao Liu Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.h diff --git a/accel/tcg/system-page-protection.h b/accel/tcg/system-page-pro= tection.h new file mode 100644 index 00000000000..52896c6d24a --- /dev/null +++ b/accel/tcg/system-page-protection.h @@ -0,0 +1,17 @@ +/* + * QEMU page protection (system emulation) + * + * Copyright (c) 2003 Fabrice Bellard + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code(ram_addr_t ram_addr); +void tlb_unprotect_code(ram_addr_t ram_addr); + +#endif + diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h index 3a9603a6965..f7f7020382d 100644 --- a/include/exec/cputlb.h +++ b/include/exec/cputlb.h @@ -24,14 +24,10 @@ #include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) -void tlb_protect_code(ram_addr_t ram_addr); -void tlb_unprotect_code(ram_addr_t ram_addr); -#endif =20 #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" + void tlb_reset_dirty(CPUState *cpu, uintptr_t start, uintptr_t length); void tlb_reset_dirty_range_all(ram_addr_t start, ram_addr_t length); #endif diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6e66f3c6e93..7f7c208ba12 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1,5 +1,5 @@ /* - * Common CPU TLB handling + * Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@ #include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index c33dbf65e7f..4313864d2c5 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -38,6 +38,7 @@ #include "user/page-protection.h" #define runstate_is_running() true #else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h" --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857116; cv=none; d=zohomail.com; s=zohoarc; b=bVwnuIjTqpBCuXbvCv/nx/XOWc9PVbJGC4Yz/1uckprdfwDmGOb8lkc/WMp7kcqDtJJYAEX9nJQuQ4Xmmky7oDqFQ5Ag/01Q/Bb28uztwPXFCLazjpLg2swI91uCT3TvAtXa3+1eI4RullsVlXMyGS78ROkscHdkZw7B8FH639U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857116; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W8kslJw3ZUnEngHyQr3H2ja6FRUQWfjp/nGbHX5sZaM=; b=A0d3Cp+WrC3yE5g7b3ufHNabovfsl3o+Ti7BOaCkLGg8m7WlWA5UuZbhOTlCtT1PNBtSCyG9g8uy7q6LHRRBul/M0oDv6OiOQ7QsW020SLUy4vJSCvI9jYceiblAdNYTNAmvoZSjbqGHMgsfULF4eB7kiEjiuhJaUihYl04Anp4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285711680025.13555599457186; Tue, 30 Jun 2026 15:05:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegXm-00036A-Jl; Tue, 30 Jun 2026 18:03:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWS-0002XZ-5I for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:52 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWQ-0003fh-CT for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:39 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDav32873364 for ; Tue, 30 Jun 2026 22:01:37 GMT Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4k3sgtu2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:36 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-73a1de16ea7so960493137.1 for ; Tue, 30 Jun 2026 15:01:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475671d0403sm11709605f8f.29.2026.06.30.15.01.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W8kslJw3ZUnEngHyQr3H2ja6FRUQWfjp/nGbHX5sZaM=; b=ISMYjUBDIyv3ZiCd mZVDXkR8aph0SQfjJg4bhXmMGlQIEJSJnyGdL9ImMJivSjxgfVsNn1B3cNqElhm6 +Vahp472nEaXEVpANnx8DI0FgVWYGR4frxgpKBm1n9YakDcbcKpJRuHmvs27EyOZ tClGcpdD6nqRdxN0Dny14DmpLHHNkDPav4TtT5gRyW3hjgyafPWTKj0uWJsCAf5p XTFtru8ANEAYA0YrQCfx0eIYVUC2KbvRaz1ifnMML7BtFdgwuojpPznzDpo3fRSp 7T0e8MGl9UMXuaezmrheSKBjmcrCP1E7VTbFuG9SsPpHVqdmegNCYRBwIZmifoVS vJKoGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856896; x=1783461696; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W8kslJw3ZUnEngHyQr3H2ja6FRUQWfjp/nGbHX5sZaM=; b=O6+7zM2uTw4oStFy0VlJ4U1gj6NSyFnf6KnjGXUJDfc3F7fduxQupRo6aGWvmC2MPH /Cp8/XBRgB18gwqZuQP4umQu2e3ubtKVmX4BLTRefsoSy7JIPXJlRi9GgdP7xNblmJsM 2L0zniuUlIjmLZGimsvxncIm6g4TeQ9pIbl3OLplKgLdXZUo+iPU4jhD/A9QrDK8LOqg 63qOeskTYNzFNEVCPXujUXx8YFsY/jQyXJd/ppNaVEdPPHV4yNSOFj4jsq7kLoPNkpMM Yyw4wP8z3avU31nMwLA1hVTA1+gD0OXqwsmC0FYEMfMJRcqvfI3TsMvv64scqSYGML8L 7tFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856896; x=1783461696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W8kslJw3ZUnEngHyQr3H2ja6FRUQWfjp/nGbHX5sZaM=; b=e6+lm6EOo4DAoPtcoCqAbJj5aqEWqd6sotJA6L87CqfiJnefSLfZiCccYkHDsVGaJ7 za3RaYOtOLH5aRPmUnTr+rH6jd1FodSRKNyt0lSf3hvBw8e9sNMPAgfq5sm9XYFC7iEA QBdOdqiY+Rzr+i32pHzrdKSJfn04jdrHsVNKMHNNxytOT2645zVRblfFqyzvSNqyHLYG qApDH599bo+VkKpl/9p0EeS2yx4UMLnMozXJnSzDHVrR45iA3Pppa+lGM2ycfdpHWTrg LPyjA++qyZh1o/8svKQJZBcpsycE14w3gS3/uk0T7rPM+8RVE9DgIEE8Epoym3PwgvBa BxRA== X-Gm-Message-State: AOJu0Yw04XTdXaindisLb3IsHALkxlriJY9e1SjraHGH9BdpYNwhymVN WukIXZvHv6h3wd7qkqkssgnngYdoE9gS4oLvf6Qx3obIjOOnbDtcGmffefN+2DR7R1BWf3zZvL0 pzeeWpwWXY9Mue018xMGU0ip8u2gwWj/QMmjDds5G2B7QrumQq/WcV1Hu+AwAE06Dig== X-Gm-Gg: AfdE7cl9ITkIjk+MV1wPC1a5T+QSTDSp9bLLCtYYyB46OwQmt0caNLRn76gG2/V6Qjz TV82Xl1toN9O3mz5cby8ztE2Lu/4lXa4G9TGeMWRnKeNdczPac9Vix68ZXg4liS8pofs8xK6Lud MuzSuiMxG995DMdXfx2hmJhAeMYa6mbjfYHQvI75ai70qAkPMX1BxIaxAbxU4DtfhezxkkxHwZ3 oT4hu6pkc9DgZNyAOsQ4mxfCMMvkTrCuyKGSQWPrdkN/5BewS1OlXMv1quTj9T0jkIOaWZe/5QS ndJHhGJ1yzdLpEJ4ix0K7fl6CePUkekoGejzvOw2XE5HJ6XELJdYlmo1z5BbYT9vmCsRiUjuVlX bd64hy601O4Sfwh4IqbsglwPhVQbkyJLVT41wmD0ZMeLBmhnVjKIAXwEmdmPnC2zf/cxV X-Received: by 2002:a05:6102:5a90:b0:737:b102:c1b4 with SMTP id ada2fe7eead31-73bd357de61mr1268346137.7.1782856895735; Tue, 30 Jun 2026 15:01:35 -0700 (PDT) X-Received: by 2002:a05:6102:5a90:b0:737:b102:c1b4 with SMTP id ada2fe7eead31-73bd357de61mr1268278137.7.1782856895307; Tue, 30 Jun 2026 15:01:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 04/33] accel/hvf: Remove left-over comment Date: Wed, 1 Jul 2026 00:00:31 +0200 Message-ID: <20260630220100.1289-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: P-nQq9adHRCu9D_-OlMaERxi4pYE7L7y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX1sXVS3vRx2X4 IM1JLeIiR1XHsnXDDuxuJR2/Y58h3ZNN0T3eK/IOsQZDIklsnCf3/5mavEOIxdT/TFRS4Us73tH hqSZ44j2uHwqH4570b6g4rUaVbYvovToVXA6uT4O2tME7eVeQaM+5PamFuGM5uxgQNkLyL+N3hc pIo0+Qb12MMU3hNbN4MmNbK1hxbR7arlVCzF0Znfq2jaENS2NOj7kYLfiPw5FejW4jzKFWfwjvr DgZlp+EN54wolr60OCuqqhlUYPVKpP4WwiZ++GylxpZ1GvudL3Q/y2w5xmdwGmhIGMmmkd8FFWD 52g+UuVfUbuesLuKCCtUP7GRfHtiRd381pzqRfTJn5bcd9WkDfivMP4YsriywXwzMIywH9NaBN3 Vl3kONmbP1SEifpC8RlkF5KZwSPrHCdUmMdRVwrMkLPbVmPED0sD6KdF0NG4ka5VJ8Ee+2pBxV4 1fNmNv3CC6aL4BTKIxA== X-Proofpoint-ORIG-GUID: P-nQq9adHRCu9D_-OlMaERxi4pYE7L7y X-Authority-Analysis: v=2.4 cv=Ff4HAp+6 c=1 sm=1 tr=0 ts=6a443cc0 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=UxKr3doQCuer3U7Pa8UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXw8hbwpH6eqqq nxak95O54PVjT1O0tXOmOA7lX+4MuvsGErQz4X5u09FYiJUTZhDvLLm2QQL8+xwLaMkqDnB++TO D+5K58Un+1TTgiRf841e0bE9PWVbpUs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857118469158500 Missed in commit 6bf331164c5 ("accel/hvf: Drop hvf_slot and hvf_find_overlap_slot"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b74a5779c3d..dd2b45b7cb5 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -62,8 +62,6 @@ =20 HVFState *hvf_state; =20 -/* Memory slots */ - static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { if (!cpu->vcpu_dirty) { --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857024; cv=none; d=zohomail.com; s=zohoarc; b=GTWQwAmSR9vw+3UV6diC7c9HM+y7cPmlv+I5/WPNYNBjgPqH8CGnbDpoKtSto0uDHh7OE7KqNPInF6YvsXmN/C+yZhSlDAnM0cg9jXPyyDC85mZ/sfUCbADC8y1aR9/lSBSR50ceTm+IM/HQNWvHqeT9ZT5N8UYeGsr+yQRYgyk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857024; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=z+xL8MKC11RapxyAXs8PHasCSN7xyle5CPBeAQ7XaVc=; b=PV92PwrSS0EX/x/C3y3T/1MWL5S4GmMXKTvOB+3Mwx3R8UzEEiWA6evbrHoARolc5Wia9tt/lq5GkasCYh/4SBS9RsAX39s818io94RrNmtCv0BMDDK2+BPPVxiTVQhtd0TbZWhDLgrc+cbATJCjMp3/l8WrxQdWpsaVPu/em88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857024412252.05353033762856; Tue, 30 Jun 2026 15:03:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYD-0003oT-Ch; Tue, 30 Jun 2026 18:03:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWf-0002ZB-38 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWX-0003hJ-Gv for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:47 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDc9l2959972 for ; Tue, 30 Jun 2026 22:01:44 GMT Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j9113n2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:43 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5bbd01d56ecso2064118e0c.3 for ; Tue, 30 Jun 2026 15:01:43 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475641e4618sm11302940f8f.9.2026.06.30.15.01.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z+xL8MKC11RapxyAXs8PHasCSN7xyle5CPBeAQ7XaVc=; b=LdH3R2n+uqp1aojd zK7nv3xMfiBbpfcq6YnS729RcOtuUtOJCgsCuF64d7fJRqrsnNXkHjRI+7KqyC5P 6IeEJmOu0B1UobQSo2ms5pLNsWI16DSJFPnedgpmNOAB8MAwE04C9fxdTgLGloOu qB2RupybpHBAEQ9qf2SriNTWCiumoZIm8y49xmIrUW/WdHmcWpguaAeBNMtss/85 ZlIZCOdIj3hD8C5qzy6nGNXB/eI2Hj8DB+1VN0j09ddubqcws4lZYpws6Q2FFts7 OL6HD35WZ0a1vZoWAhyNo8knO23Mp/qfzGG8YNI3KHo+mKQsffRcjrWONj7zcML6 /6TO3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856903; x=1783461703; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z+xL8MKC11RapxyAXs8PHasCSN7xyle5CPBeAQ7XaVc=; b=KtKGMtCK9UGqkyyN+GAUFdyCJdecKZINek/vztCB5W7adrha60q9E7TR9vFMXyXONn zdY76ykBTIWUTz9Zd2z0Jt3sIBHYL+0M6oA6kHWsCYp0hKzWwFDAMmNUzTYaSSiekN5c NeIH3JnCtSMpsSKWPJRrCoJ9rowt7ip2wyeMklm6sawN3NzTmQJ/wh7Ct1Y4JQpLTxxi 104j+F5kpYi/5ZZ7lAQgDDtCQnnmMop2C5NJzsSwhwfYgRFRpylz8kQtHVHYkRK1sZ0/ VjL4Xcv1pJ4jDl6iLs3iUgq8StC31X2+qMdhhjhuyruGOjdESZDAxBE1JS8ezCKzI3w3 Cexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856903; x=1783461703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z+xL8MKC11RapxyAXs8PHasCSN7xyle5CPBeAQ7XaVc=; b=VPTZ0E+h9QZcodu52Hulp+5F6ENHp5TP1gBLvkVxu/eclmsQha2y7P1brzP0PNX1Sa yNvlt7fivhFVcnbJEEzUXTqnrBqTkJ7+yD5jYZluAqRuzr1PAoo+Oi4kgjfpgK+5foAN 986kb6xpquvuDLpRGxPBLxIphzezglxuXtvJa0wRKAS2kHUFsDN7OYpgZu1j+5MdYIQd gNa0ZnBoEZULAnwslRDFCMVDcmy5kQGTC+bveONS15H+DQeIMNJ9iAfY18M9QptAlJjh 5DMUKfxzWUWrxVouEblu9a/LM6icrBIiyX8b+HxVMKz0fTlxNkKMAwq9vujkQjkhwFNw J+Vw== X-Gm-Message-State: AOJu0YxcRkajf+mughJMW1DzcavYIVvQgx662x5xX4HPOiPAaa6EMUE/ d0mQzbjnMf9+xn+95uo18pHK+mf8ZI9dQtfmycBim7TfDqtTSipr2wgEdbCS9ncPbJS324cg2TT OTaz+4Uv1QjgXhGf7PQICYPVKLYgrNBxLVsJwktCEFt9qa9UGXhjNjhlTnkhx6P6dlQ== X-Gm-Gg: AfdE7clIUeyZ+JGTFzmrcf4jGYIc2ED62CgGsUcbbfe5ud3zx3LacYrGID/f+Zn1bvU XwfZr3PhAw2b2iAsKZTtnVc43plxK3iOSUUrUA3jdclY9X0dcPMn6DATS1R5rrjwy7WDFuE3Plg /V5aP3SS3OMCnqfh2HtHOhb+GEzJI8AI5t7b1b4DMqNkfK3WYcWcfkf3lX78FqaLpPB+kZC5sb5 lh2EEyr2uZGe6JFCwFKYPId646QNsubTUYqadIcxXg/hvxDHPnDgSNavN94EQpdPK2q/YzXxQIj 0XknyJu+fB9QaShend4KvxzREBHC7jZa1H1AJaoUBQxTTIZeRo07Wsz4T4irCeuE3vWtrcZCZau 4XFYUNjgBdWFXFBFvxfgmxsdkJLRDex5eqAvY4rVVojLmEA2g5gXjaKLT6mfa1hSRMCe5 X-Received: by 2002:a05:6102:cca:b0:728:53be:7c87 with SMTP id ada2fe7eead31-73a365e95d4mr2746745137.7.1782856902978; Tue, 30 Jun 2026 15:01:42 -0700 (PDT) X-Received: by 2002:a05:6102:cca:b0:728:53be:7c87 with SMTP id ada2fe7eead31-73a365e95d4mr2746658137.7.1782856902490; Tue, 30 Jun 2026 15:01:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 05/33] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Wed, 1 Jul 2026 00:00:32 +0200 Message-ID: <20260630220100.1289-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: LhW03g8OaB7lCIMxTNar22XBON7riU_o X-Authority-Analysis: v=2.4 cv=ftfsol4f c=1 sm=1 tr=0 ts=6a443cc8 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=3ch_I0QHNd5-WzArR2wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-GUID: LhW03g8OaB7lCIMxTNar22XBON7riU_o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXztqgoAoueHoI PBRvAqcByWnXsK5HVhPUdPkmAaoZ99GHuNNmRQOSC+g7NjAFr/m5rJfJk+zbfMV8nzMCjRBox0p 9BMyhpMHVqjqcUkHgaFVRGetHzWg41k93jkW8GU+bKnDrxhV2gqyDD8rrHCha0i1F3FGemTdV0m 4BKBqRzPbhQ/H6LF/z6P5MdKHQqR/QvFmLOPcGf1XX7vyLHy9rrcoRj0w2/bS21Zoucc5NFT4Ma aBN1hv+WSnClGlz3N9yr6Z1recC2U69YUxLhfaVhzi7GTRv0sGv9frkUAxqB82bf5Z/auXv4kcS GntGvCsI7kNjIJS06dwlHuoJiwMYKIc2a6Thnni467T+QUgbsCFy3sjSBxe+xcpIbv8t20uhKGU wotLiBZdUPaLHPUrCM/JLueS/HnR6mNe8ktPAY49qVjX/oZhDP7OYnP7NTS4rcZZIhWyR/pj4tg tL6mOGAu0bPEyzVJTuw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX1GO+fSnjyHt/ hDtYVgWRVj0yjVjgQRkn314wdBlUrxUdEq0hH+XUH7ROnSEUikOwl+br4XFnqEVbDzbS0RXkhMg v41wlkVnvY3Q/uStO3/phPdFJHpREVw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857025805158500 No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits 6f13a0ada01..36ab216b81d). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Tested-by: Magnus Kulke --- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h index ba3073888ac..b91c4d661a3 100644 --- a/include/system/mshv_int.h +++ b/include/system/mshv_int.h @@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs { =20 struct AccelCPUState { int cpufd; - bool dirty; MshvHvCallArgs hvcall_args; }; =20 diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 9452504ac28..1959baf6672 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) } =20 mshv_arch_init_vcpu(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; =20 return 0; } @@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu) cpu_exec_start(cpu); =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret =3D mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s", @@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =3D -1; break; } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 ret =3D mshv_run_vcpu(mshv_state->vm, cpu, &mshv_msg, &exit_reason= ); @@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState = *cpu, abort(); } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void mshv_cpu_synchronize_post_init(CPUState *cpu) @@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState = *cpu) cpu_dump_state(cpu, stderr, CPU_DUMP_CODE); vm_stop(RUN_STATE_INTERNAL_ERROR); } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_mshv_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu) @@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *c= pu) =20 static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { int ret =3D mshv_arch_load_vcpu_state(cpu); if (ret < 0) { error_report("Failed to load registers for vcpu %d", @@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, ru= n_on_cpu_data arg) vm_stop(RUN_STATE_INTERNAL_ERROR); } =20 - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 static void mshv_cpu_synchronize(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_mshv_cpu_synchronize, RUN_ON_CPU_NULL); } } diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 126ca40b481..1c433c408c8 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *da= ta, uintptr_t size, return ret; } =20 -static int handle_pio_non_str(const CPUState *cpu, +static int handle_pio_non_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) { size_t len =3D info->access_info.access_size; @@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu, return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } @@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_po= rt_intercept_message *info) return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857081; cv=none; d=zohomail.com; s=zohoarc; b=R0fjn7vS4c8n7d1heLhWrT/zroersNSophIF9WZTec8+60obV32Dwsqj0ZH3eSlCwaf0FSY8v1Jy8UoyJGxIO4UDwSWn56EawJ4prW6/s/fMHwkEwVzeBTh7ye+BXYx4E324u3hBJCX4D82l15ZAnkxUIA90lQErtCBkRrJ8EhM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857081; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O+CJQ2WaPj1ekIqswOivVJT69nveLqslyZ7evlwq6PE=; b=d/cZmE/W04nCGZ5up/RYRc3iazcWfik/m+pQqgS26nBGB4AoW3+h2T3SWrc0vVB0XJpfOO1FLQ6kWe4GOoA6XXZfUGJut0RWsjgdo4dHvg2OEok+QYU9xd9BiNaMQ/hQNH966prnIzT1fV/bza+dR6SGiNGZsdk2F2Ksc7Q9uAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857081503501.107222074294; Tue, 30 Jun 2026 15:04:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegY8-0003de-NS; Tue, 30 Jun 2026 18:03:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWl-0002dA-Pp for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:04 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWh-0003iL-8o for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:01:58 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDYOU2942530 for ; Tue, 30 Jun 2026 22:01:52 GMT Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j99h41r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:51 +0000 (GMT) Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-6a177de7766so9787eaf.1 for ; Tue, 30 Jun 2026 15:01:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef183e7sm17134445e9.2.2026.06.30.15.01.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O+CJQ2WaPj1ekIqswOivVJT69nveLqslyZ7evlwq6PE=; b=ZqoFldRRRtiRog25 wipxUrFJMzQXSRnkCZcUO9rpFgssPMsV6TD3u0E51YISjYFeIulK80r7FwQG13Eg mwfVP0nlgRC7md7IgNwRUmou3erAKyvII3k/yUPKFth5mYijU1Jo2K2FxGhhAFPu LxQJK5IyxvBzEZkGh5sSe0+Cfv42kuhjoEHViDljskCbaf27t8e1rMr8C0EccSoF sbNgppZ+Yumo9lrzV9wIPvh2WUFi4CdLpOkKs54A8EEhxkMphH6NDVeqXAVOc+JP zWvR7zHstf7F4z2Wm+XWqJgbXfiJlRIFVURtXO5MZ2Nz2Topf9Hs3W/iyhwn1DEM 9ANM9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856911; x=1783461711; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O+CJQ2WaPj1ekIqswOivVJT69nveLqslyZ7evlwq6PE=; b=EHalOfYlJ6qh/7N2R7s9XUF33+M7cCtr70f8QTrmD5jIPqPb/6PSkAqvTbCmzJv841 nihZM1cvHwlefgUlKoxGJd4df1ddgJl4igNC9CibCkNF210ni5VoXL08TDpRcjIGReKI jkKJhj6eWpvy5AWlbM92JDMlcBjoNqszwYgSOJkm+gs22L0SYDy9YPoH+A2lKY4bVvgu eG9ZoPtYtQTF2Oq4f1mR7vpyBUo5cypAUMl6zPHi6G8tau15bt6Y3AMyeWJw6NFWPRBE cGODxTdR5j1mdXme3PM7HfV3URGUQ+aqlcQc8NNXvkn46X8BY10VxBTIwDEuLF4MoO3r uhpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856911; x=1783461711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O+CJQ2WaPj1ekIqswOivVJT69nveLqslyZ7evlwq6PE=; b=JSZph0yNb6yrE9HQEKBE7tPA5S+YSLWu85D7f7PeG0wpI0vX6fmRPQJakkGyZRTcQD VY88AFwjQP/sMk6zQT+UbLfUFVWtk1PF7tYPx+nTp62Ze/miGGqyd0aTwo2bQyXjNsiu p1MzO1SdURiM0wLIwICFmcberCkvW6QiaPRZjL+nWU6iyHUpGbYkDo9KrkD0DGUeqHdY ewLNH5Gtlu0eoOhdZ50XkNEyyzto6DOngk4BS0BZswAcjFC7Lv1TCGGYheuhXZX10sJa Qi+u2yEN3kshqIk88H29wKLhJRLVU94sssKZ4z4+WfWlU30H8LUpSblPJ/hHME6pSw7p CySQ== X-Gm-Message-State: AOJu0Yzhl6XWeuXaeGdZjsYTIPMAVJnA5f01/FV/3N+vdlIQUlRKL2BM 6uXjI42OmTJQaQkB4TuPSWUEiQliSD65PQEldeBTdfi0te79dr2nu1tgIIBs7hqj8qEfT2NspOn Pnog3oWK3iw+0zIiDtIypXZVt6phPt/KqHRu9GocqrNlsJGrh5pXaGsnrvj3rlie60w== X-Gm-Gg: AfdE7cmiy9Ve+ov239VaHuacqDXDtui/nVw/XZiayV5rW5eHoMF5RbdnUPjsQPxHUtR s/FPf0+QZ+jxmftIvJJD4yQHYK0XIAG+A5R+cO6xFlkCAJ494+Azl6K4pZAo4co2b36ZLC7XEmC oOPIOCXK9DXNzjeeoMA+aU4KpjBtLr4x0UcJWOS6EzGXgMiwOpZWFaVmt64/Blw5OKImWLckNze hNVuAGZGGsM3ZxQYpvzTbZiOuyLJDcfv/SwW481at/uFADPgjziAqRZFIWWCINaRlNX3mmEr8iS LvyQZTU3Pjdr74az1z8+lpvvHuOSyN6v7S54rts+49H64hLXe0XZ9zf55AH4bqdjiPxdlIeMGJ5 veHc0aYcwrTRirgVwc5Uyso7+ecDH0wlcJk4TkhA3tGEhxmM1yeOsrgjL8eHdvJWm+K6t X-Received: by 2002:a05:6820:8107:b0:6a0:e230:61c5 with SMTP id 006d021491bc7-6a196b35eb7mr1622722eaf.2.1782856910317; Tue, 30 Jun 2026 15:01:50 -0700 (PDT) X-Received: by 2002:a05:6820:8107:b0:6a0:e230:61c5 with SMTP id 006d021491bc7-6a196b35eb7mr1622688eaf.2.1782856909916; Tue, 30 Jun 2026 15:01:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 06/33] gdbstub: Add trace event for STEP packet handler Date: Wed, 1 Jul 2026 00:00:33 +0200 Message-ID: <20260630220100.1289-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX36v/W9eDlryF pYbAlbwWq89ZZCmYXtdSX0T3DKwTKFpX3mnLA+4KZr/ja0R67NBi5k9Z+uBjmeafkZSxOvuuHlV lDjxuGwAtoTiLtzJg45A0+z6NbutT7Q= X-Proofpoint-ORIG-GUID: Lmn6cUWa7CGUMKXuFWBa_g09s2unZFCy X-Proofpoint-GUID: Lmn6cUWa7CGUMKXuFWBa_g09s2unZFCy X-Authority-Analysis: v=2.4 cv=bNcm5v+Z c=1 sm=1 tr=0 ts=6a443ccf cx=c_pps a=wURt19dY5n+H4uQbQt9s7g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=TahVrclb075nq1LRks4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-UhsvdU3ccFDOXFxFb4l:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX49+WAbyfXTt8 mSDV+FK6WJsCCSgRSMH6mdW3Adih9Usa+52TIPCfPa+0ywpnaSUY+fdtulTeNIUPN4V7W/N/KYa u9BToyRZsb15betb+hJGiOKr27vN3QdEuS5YzNPXAdsi3mcj7G3jISf3lwqMpfRcDNkd5FetE7t 8CIwhATnC1ozA8fR7XPiDosjkKucO1QC4RUTmzmkjsekW66PtVghzjeiDtaiYlW3p7qxkAX6W0m h5d5KgNLFSSFg67XF1hhgs7UXGbclnUwjF8YdNdJd/3vY3w5dnwc78itChelt5DNss+MAa9ZcW7 rk6EoLKTm+GUKmBo24FoeTox3j1WbxnQ+cirDbTDZtRr9ubHH721IgzfW0LRoPM3RLjsNc/4X3t azc/OmhXe2w+MgrK1ecXMTMnVjDiqKcgY7CGIs5o8j2tsOcFYjxtmqV7swsItzMPCV7Th1F/Ima eMLs95vvlQN9gGGyCig== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857082188158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alex Benn=C3=A9e Reviewed-by: Daniel Henrique Barboza --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 26366acb674..246e7746300 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ct= x) gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 + trace_gdbstub_op_stepping(gdbserver_state.c_cpu->cpu_index); cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); gdb_continue(); } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857229; cv=none; d=zohomail.com; s=zohoarc; b=lttbn63JDY0XFqe9l2rtVZplPoy4N0RsSP6Kg4uGfvvtzHhriekv20GMVRpqzl/HtWf+d6H4GsiQLBn7AM4ecFR7tm037toiCNgsme2W3KFG5dQdDlhQvQw89C46uPsx+roYPHpjZ/4Q58+SdbPqxusGdO+z8YAfliLwXUOkOkQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857229; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4oVqV4TVjvIqWPN1HoisnzLzhW+GkrfDL0s26Pl3fow=; b=bT7mMj4zkIuiM6Ot/kYRJS7Ex9y/cWQ0KTv9E3qgzLM49s0LU8l53EFpfILLca7eG7TkSGcdeLntLYPKlc9WScZLbVdebdUnpaKH7K4gHgZJO5ExuBZFDxKnnuLckbzQjoG0+q47B+0CmFMRnUIEAXbKGk6M2Sz4vRX5tjMXdoA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857229416163.07618120947643; Tue, 30 Jun 2026 15:07:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYN-00040T-0R; Tue, 30 Jun 2026 18:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWp-0002fq-Dy for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:08 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWm-0003kP-HO for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:02 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDlZo2937268 for ; Tue, 30 Jun 2026 22:01:59 GMT Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a3u1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:01:59 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5954c5fbcc7so4604346e0c.0 for ; Tue, 30 Jun 2026 15:01:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47567a6f0ddsm10608340f8f.37.2026.06.30.15.01.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4oVqV4TVjvIqWPN1HoisnzLzhW+GkrfDL0s26Pl3fow=; b=Oz8t/yI2yqoaGjO7 tRtKCLjtBaAaXNMmHiTgJg1fNFB+1Nzg0aZy7xJ6Umre0vAUz9gX95vL8OOlHAtQ QOX3ToaYI5MZR/DAUMeNEIu7IZvvDsUvynKJB38Lx62g5sgBR5wblvEZ6k4Cr5Uq bWcMEf/r3MV2wLceRT8nOsDufUfDwJYvF4yFJAQf+sSfsWyKESSLnkrbMfygX1O5 9bH2e0QkcfaIljjubrDZ6vjBcDXiQqtz6duhRmQKK8x1XUlaA17eC7MfqV3OddIL Oqs1IWuRne+5nNzoKSZSTfPSTIyF74eRZ+xxd3e9L9NmGJFy4r1TTqU8FTQiBoP1 NRUkMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856919; x=1783461719; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4oVqV4TVjvIqWPN1HoisnzLzhW+GkrfDL0s26Pl3fow=; b=KW2jPhpULAUeU9aTqioePDwP9XCHIuYWrPJG120lj9nATE8xGldZN2iw9Eqz9QRDXX qwOHHDu+LOOFiYoF/nnlGacyj/QJrEErkno7hoj6T+5P/TEAdv0q74KKaS3I8dA1wIio ULRTVrc9GuQ14sF9oeMnVnctTfygnWX6u8KDg0/TXMW499L0DT1w+aTFxlUZ1urj7rz8 y8tSpms29c0nezSz+Hp5YHPZ+a7Ab6UbRd5z+zR1OLjpPcSbEbAFO/RfRquPksx7TOER zK5bsHbcqbM9X0bQjU96xKLOc1aQ35jPeMDTtFsdAHeyQz/iRaCdbhBcUiwnGXd4TW0M tyMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856919; x=1783461719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4oVqV4TVjvIqWPN1HoisnzLzhW+GkrfDL0s26Pl3fow=; b=NfYJZ+G00dFnlsT6fd1eWItr9OhAl5q4+XXruMs6OvHkqRyosLdZG6xu8EDXL3XXUg nKjUyjLhpjQB5e/qsps06VSfG+JyaFM5KS4uYLOlMI40LRVD7dP3l+VsGRU2uv3JEg2z a93oGrUrktGEdiyFeQwY/8MIZyl6zfuJwWQTewhANDqLZ9HOGYr2AT7Dce07AfKTj0CB wEC7Yk4MMXJnWLmjGvQGzj4HHwsVUkecTnvTYNFN9wFcbWH1/X+30Jz0yL/WC2roJAOh ukxe0jTFyaRg16A1/gWG/42BIXz6WeGs/Xm7FL0LFeEjMHGaRBteKcpScYIWbM13XyeK qO0w== X-Gm-Message-State: AOJu0YxU9d03esp72YTI6z69kdXuhI4Hx7ytdT+CZFVmm1R7+6E6LSTL ThCMtDtE98PhtDVxJzqQxaGQe7cN9FSiRxT9cSUyRVgtc3w4BtPflvS6hL8yigccovY+HAWvfxY oSAs8XDDfigfTeUJv4/RFsxOxYehSlgFDGcv7est7deeP2aFLo5i4G7jbeIGcj/m+qg== X-Gm-Gg: AfdE7cldqTldQc3op5LTKQ4bX3Z4avv5dhc/bKZKS3YfzOjIZ0SOHM9kB2TkTNYsHjD KVHn/DDAoQJcA1XkIZLdFO4UvKlO7BA/O0TloIK708PcQ6oecN36GP9SISkEt2DqMf+fJ4jB75p JiRhFNlZjHnDhvPXFlC7Jhif4Xo9a4/OKhVVeGj6KUOurwQSdM2Sj8v0AHaew7NwCsgPSkbLvFx aavFSZsPXG4yzWINXHyq72e+P++zCfbowmPcaLgXkNZow36aI0ffMjfjNWhM3LWulUyaffiNRMS k5zFwxfwDLJyP2N/2yaeLS9gVY5PQNQgsOEAoTTVLv3kE+rxO2IpN0IH5+lVX2o0gSttGB4+OGj HpWHHSEd/N15Kd7k/33r9hNOLRjAF5/ghMGp2eWqIyM8jZb93k5tN2EcELZ25l9pJrzqY X-Received: by 2002:a05:6123:2e6:b0:576:c4b:460a with SMTP id 71dfb90a1353d-5bdbed438b2mr2731093e0c.8.1782856918105; Tue, 30 Jun 2026 15:01:58 -0700 (PDT) X-Received: by 2002:a05:6123:2e6:b0:576:c4b:460a with SMTP id 71dfb90a1353d-5bdbed438b2mr2730896e0c.8.1782856917293; Tue, 30 Jun 2026 15:01:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 07/33] gdbstub: Only return E22 when reverse GDB is not supported Date: Wed, 1 Jul 2026 00:00:34 +0200 Message-ID: <20260630220100.1289-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX/3iRDqRvvBxk OTQKKNpz1daZDxQ5VUy1K5HniELS/F4cgU7YrZZotLzIfm1xtUXO1HdHcGQde/aX4OrS/0ivHrL ZKlXc7gpAM1J1M1kWVf2Jb7gbS9QGJG5rEkLogF4UCNHCXq+2hH9k7S174c7d0mH/MXcjcMI/+E 7Z6QfYB2II6KoidUI4mDqeVAIEKKe7kpyxMwGXjTnIdchHCKyBcCc2KQuK/sL+qr6cgxeFhBep4 wQuNoCidLDhUpAspeIH0vHp2MdvMpYhlZQIEtGbF5LPXl0U5vtT407O9CtIbd+izj3Ejuk2UdW9 74GDtOlqYCzsz1cvzM/F1rbR+4kLvKXdRXXEXAIQbqzXdi3V85PFWbNyohnZy2ub1EjYnvEmwNN ZXlRjwLPW89vtQaPhAOFfFKjMcj6T2z+/QrnhVEOtz1Gr3xDTkrRDIYyk6ZZA83Y/WQhFA9tI+h 2dyWZH3StuPa8JpX3eg== X-Proofpoint-GUID: XbQ_7IuYWhjGDpWc1bYIRWzBBJL-mK6B X-Proofpoint-ORIG-GUID: XbQ_7IuYWhjGDpWc1bYIRWzBBJL-mK6B X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443cd7 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=0n23ylXGgdPVI_k3iFEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXy5709awRtoO4 mnQd9xc3vek2s58CxXopwFeX617hMUDbhOtMkv7eJJTg6SOzTKtLbF98UhbVH9mTmSDPNsFCUBR KVupBMLIOEhAjSgPU4YdKMu9DlZDzBs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857230951158500 No need to keep processing the arguments when we know reverse debugging is not available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Daniel Henrique Barboza --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 246e7746300..f54415a9db7 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *use= r_ctx) { if (!gdb_can_reverse()) { gdb_put_packet("E22"); + return; } if (params->len =3D=3D 1) { switch (gdb_get_cmd_param(params, 0)->opcode) { --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857049; cv=none; d=zohomail.com; s=zohoarc; b=Sbbz/uWyju9I8QO7fDJl+9G8SMJD7jEOgkTgiqYQhnyCPtPGfpe18qpMJTHPSY6zaqUfG08/OUsCrMXa3mC1gTQrU9d9j+x98/bkAHsj7xKq2SyF+IM739GcQe13df1do022GTZG/6y7AgCLprunkvl/av0f6mt5goxyLarPYiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857049; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TDGo5gmxoqPrcD+LvxaIY2NJFAfGqwPOje2LgjJRDmI=; b=Fl4oJ/Ac4HdGIykJ69EJBdZg9apQuMK8u7saraHMcIRs4cafS7IZyWRwQwJfuNIjzIYdZaaTlJYWnU3YQhGWZmyDNXpPC6L6vajt0HKTdZYE1I/LnOF674wnHjo4VbXAEYVoM8/62EG52Q9tOz95tgXJ4y9aScAthiMqVpqGiDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857049299967.0250085058192; Tue, 30 Jun 2026 15:04:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegY7-0003Tu-0a; Tue, 30 Jun 2026 18:03:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWw-0002gk-7e for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:14 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegWu-0003mQ-Hl for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:09 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDW6o2942512 for ; Tue, 30 Jun 2026 22:02:07 GMT Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j99h42s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:06 +0000 (GMT) Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-486055c1c6fso38920b6e.1 for ; Tue, 30 Jun 2026 15:02:06 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2bc5sm25317705e9.5.2026.06.30.15.02.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TDGo5gmxoqPrcD+LvxaIY2NJFAfGqwPOje2LgjJRDmI=; b=p7ORiCTClpu620TN LMuRPjNAukUmjbgKVRK6K3PbYccUiNl0he/QD3zeTMuEtJUySjzDD/8EV7+le+x8 94dOBxF5xQFJf4aMlgOIKL9KvMY8D0R3ziBMoEpsnbro9fk31goNq1NcqZ3q7wFx BIQQr+5Wtj/JnVkwr6SyCQfy0OVN5VJ/RvBJqK6dzNJFHYbXs8chVrSmMy/LZv8c LGT5VXeyJOJB6MOW0l5Pnc+0vpY07oNF7/vtmZs5RYVIRF+TnsM7pKb7ATwioNGi BxbeotabQLTY1L38lEnSFFWj1DuEhlwHsuViWP8jMHnijAdPkHmKat1SjiCGyEsA xhyf6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856926; x=1783461726; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TDGo5gmxoqPrcD+LvxaIY2NJFAfGqwPOje2LgjJRDmI=; b=kUKqN2EBuZ6VN4FAN0odTzIHDLf7Qhqpuhe/EyS6K4DGkKWpf25UcczQ7hO9QTgmq/ IyLKbfP9esxboD7Dj3wm8Jtnef54nNRwviJx7xpUxtJGEJhvrUqPg6hSuR/n3NTDAR2W j1hF4e5qFwsJyNwoYyCvH/XnpcCspWgSt6+rGT0up5bwCksBnBYRgTOclCOTi1j8xlT7 wOafItjTyRcdJdAdSdyz40bVnlfW2axlAbYKY0uqBCl/gdi83PVVIvyRQ9zk1LzdNekP iGE7DX0nN4AMyhiQyLWAKIBFrwAgXfg/l7BtU+Xlqol63faQjYFGeoX7BKo4oSooHmCR XaFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856926; x=1783461726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TDGo5gmxoqPrcD+LvxaIY2NJFAfGqwPOje2LgjJRDmI=; b=VJp6ykQiuQzHsFvcylQsIl/sSbrZHMJP7DVidLXtNnG0gW3jBHjCjn+N+z3b1lKDDR ehch1QUIAD2yAN3Ujpirfk2Z0Gy0BbVVYBTJxiLFMr5ne8QNQ9R0amAIWWsmMw2jpUzH FpzCDrx5qU3B3GVRzqu0RF1R5cM0sA2yq+UEdlVIPE7jb2/B/dQJWM6WQnH44FTSLXVl VAvudC3bajlK0MuE3f9aHsbAD4xxI++KGOO/cX1HIn+2/6AQhogDB3ZSCcQyqwShOQua uSYCP1eCPqs1uxYvN+u3xtpSonjjaAgalZ7Ko0/xfVVrPzqodEZIUNnRwkdcaDadFc9P zCuw== X-Gm-Message-State: AOJu0YxkCW/wQV2z88x3efe8gH9kiin42CqlXkKgEr5K3sLblxxpolq9 R3X1D0YiYIlZu5Wnt9UWnjzgSa8Q4L5EXRqdM5IVROmAAXsKyJP3ERThJruUp5H4rBEmkds21pd wK5Jy1ksY1zPcHaZpLgMJKvWwUBN3I5lznXi0oAhIdBKU+kQikp7wu8ISNCPW1c27sw== X-Gm-Gg: AfdE7clxHssGoL7Wviml17EwYOxUV3ksokE78wvo8+lRWBsIlyvRJ+3RCpdASLgQTu8 lvEBE6G3a6QSsaj6XgYiIf2EPOWE0UQ+tfv2i14UvtTF1YWf7WzILZOkHhIfFYCsKsCWXZGO4f2 5CehFKau27Fm8Nv0W6Xza6NDs9nj4RFm9dsh7yj1iGFSp/w0wZhrjJItVpa6qkG3i+yzM4cw/mT 6b95Zl4QAjx4SwwNIpvUsvoNEPmdjniVGqjjGm/qBrNHtWYAwEyuc5RtZTG+lj+Sfw8v8EeeTUv IEoZEFOsiVMNeXn1a2i5Cw1e4FWJdRZ5Q6W+zJMsfu3ss8AuQNDxkCcRnjos0EjAcyYJRfU6M27 9EjzfKOdx30FWS5FyMOXJLzXBZ3YWZM8jPrBRwj1vijpEdeHoonkRfHgckFCwdl8Poiif X-Received: by 2002:a05:6808:4fd2:b0:48a:a666:e735 with SMTP id 5614622812f47-495eae3b8dbmr4806518b6e.16.1782856925333; Tue, 30 Jun 2026 15:02:05 -0700 (PDT) X-Received: by 2002:a05:6808:4fd2:b0:48a:a666:e735 with SMTP id 5614622812f47-495eae3b8dbmr4806466b6e.16.1782856924654; Tue, 30 Jun 2026 15:02:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 08/33] accel/kvm: Always define AccelOpsClass::supports_guest_debug Date: Wed, 1 Jul 2026 00:00:35 +0200 Message-ID: <20260630220100.1289-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX3AScE8v4KGpd uj/PLyM0iWFjFoTZG5EHUyH/thjg6GrSiNar4+yiewHEfnpcbQZkPJPJyNRRQ1piUnvzl7TD3go hGg0N7IzvtTFoWn7UlQi0qcynSeIMUs= X-Proofpoint-ORIG-GUID: yJ4b-sQRLu9KsYjNESKNcdNYCw2d7EsJ X-Proofpoint-GUID: yJ4b-sQRLu9KsYjNESKNcdNYCw2d7EsJ X-Authority-Analysis: v=2.4 cv=bNcm5v+Z c=1 sm=1 tr=0 ts=6a443cde cx=c_pps a=yymyAM/LQ7lj/HqAiIiKTw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=9RVOebA3_GiVrJoGtMwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=efpaJB4zofY2dbm2aIRb:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX9y1RIgg7C3VD dhTHC6XUGbKMWpQpI68EqqOL8ErSfFBisjYPRM7iWpIEPaxqpkcB6BMa9UmISC1PxRLpeqGNm2u 5gVyBSE28otp2EJafODXSQwM06GzuIYS7QVGnL3YVwZDERy4bfSdD2gKCVTgL798MzVfKFONOzj IoiyaBd3UwgEGQ6qrx4OICQyfMmiUEU/Q1bmRjxE8RLpbcff/siQKC5ANIp3ZCqbX4gZKmaEa15 iUM9muaZORkBUXiiWCmtQxqeZAUE97bw+WgayX23EQxDzEa61txX4wqIe+PfYXsfRE4sba0m4So ymrXr7BPGQQW19P2IC68CeMr80H/miutxnXJgIUZlrfQ+1X6aJPRxqziUg/lJ2Ij23+w7m0KZns RF/taCRP55Eb7ihFyCWv9FH/yOk/w6Hw1jqpHpFGvpYnVENnKZL5ydOCKL6U7pLMq9yPfRudZqn NtdutPyzb/HMc7BTNzw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857050008158500 Whether TARGET_KVM_HAVE_GUEST_DEBUG is defined or not, kvm_supports_guest_debug() still exists and can be called. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6d9140e549f..d7967bc922f 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 + ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->supports_guest_debug =3D kvm_supports_guest_debug; ops->insert_breakpoint =3D kvm_insert_breakpoint; ops->remove_breakpoint =3D kvm_remove_breakpoint; ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857058; cv=none; d=zohomail.com; s=zohoarc; b=kfizSwO+M0T7swJZGMBaqUFtQ+h3rWsEK+yBwwdJOQWAeBvC/H8Eknqcuwt2c5XbAUcPLK268+/Rm27SnWcnsG6AhDDI9e+EUc8FiG9Y1G0Z6aFoCcsTOkRht15hMz4agr5ExixsjtSH2rNbLZbfrsze1H5nsvM3qZUjhlhO1+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DJMmr3+XwLt3KJsVQCfjGWMC+Pwyxb4MVSeXPY0Lok0=; b=DvQDe5gWutTMRjI78YiaFuIaMII051+ZMo7yNf9YCNERJKxV4RZc+/VBWCG3AbTH18KF6urSYzYpEL/TnnwV4A1D46MaSx9pqEopx44XCUGepFZDPdaoDR0sWx2oMVdQUIosCIWv3YkX3hG2RpNwJBW58EeJPEoj5laxY1UpYbE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857058623956.3367811081301; Tue, 30 Jun 2026 15:04:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegXm-00034g-1l; Tue, 30 Jun 2026 18:03:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegX5-0002ia-I4 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:29 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegX0-0003rt-U9 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:17 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDaRv2881438 for ; Tue, 30 Jun 2026 22:02:13 GMT Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jtqgx46-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:13 +0000 (GMT) Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-4893fc86bebso80971b6e.0 for ; Tue, 30 Jun 2026 15:02:13 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636cf1asm12156232f8f.18.2026.06.30.15.02.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DJMmr3+XwLt3KJsVQCfjGWMC+Pwyxb4MVSeXPY0Lok0=; b=Ji7C1Cg9PvkhjV+d /HJaQ2oV+8K9Yae9jl4D7kKbbdH8tN9Pi9s1/aJ10F0GbV88zvoXkrp24/tGNa7/ nPZCQWfnrtzJiRC34sSLvBUv1GnmdXzudBo8kHPrwBRrTtA17po4vXwYCJdRycJ9 ZxFogcblDHuB5MNq6HhoaoVVY6Pt4kIumPDlIy+LHOfLy6aoE/kBmnzRD5mkpp+S o8xkGkQDlGmIAVIQEbDS/Y0GMEbA9D2v4aHjl4FQTzVsQRByUFuPrRktHYrRg3ot 47Rs6Mxg6zMmBAKX1ppP06dmFSIAazUrn2DLkW+OzQXseqWu8d6nfZjkvifby+SY 0J26yA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856933; x=1783461733; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DJMmr3+XwLt3KJsVQCfjGWMC+Pwyxb4MVSeXPY0Lok0=; b=aAo3dtshOrjTdCCWaFQ/VLXVnaEZTVjF36XUHBHPNUvU1gbcmavm3mqV1/qUi6lb8+ DvBBHjVBPhQSgH2noLcifms3+YO82PyyoV5JK0fe7/2z0HwPGku0eW15d6Fa8QsauPh6 MOELETzACZUTMMWUS8Loex2o+Vy9IWX1fET7EooQEdoVrWeVKc4QzkqMgBM4L6JhbG4t y4mTvV59YFVrcZprR5wKyCEIe9s7qz44DZ8uuf4pKZBxDxCZxZVe1ara0i3MDwmYwBsh 1KDxleWVGtL0xUWAmq9XJbpy9dVOnPlWenCt58Zr4oRhpASOX1c0c7X+j2YKpnNqO7Ib lB9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856933; x=1783461733; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DJMmr3+XwLt3KJsVQCfjGWMC+Pwyxb4MVSeXPY0Lok0=; b=TooMoipjrFcC8dXnTFtiH3U3Wwb61XVHQuRv1YQQHvOISfscm49P5cZUDYi1YcGiR4 2uCawgekDxx8j5WNZ+NRQBARvPcZH5s9Ibzqx4Q1ItWUYnrodvVMlkyWqqEdmuzylPmM uNwcKyWA5Cc0renhxR9Qz7Uny0T5l3W4bQQzcwENMmrN05pgpAw0YS0abUI/3vvj8sWL yUYjcIOLinIkZZFkoIov/TeXtn1vN0MIJCscchGigrExCNLRb8YZ0y8XygZVeb3/WZNs 4Y1oOtxS4hOAPLLWkvbt+bvFlSgWIKtVLEGQyNnfdDXmqktR3CetGLUcZ4YnzOA68wdq PgBA== X-Gm-Message-State: AOJu0YxysfNLnn78i4qgdnbU5ISNX3DFW+i8StC7RvhTbcJUQLx2B7J2 Lt/iJ+wmj+qAVW5Wkh/bl8cWWYXa8wdQ8VQTdt/mlbGIOyESFHSGAI/XEQU0wPBkpf92bq84oK0 oY5vAtwHtZcsag9/yAl/O6WU2aO3UqeEEfdtVVtFQf+V+zA/h0cUfCXcZb5E5o6iU2w== X-Gm-Gg: AfdE7cnmtYZrQwB7C0mTvT7JGNxYbmSahHlvGULHnjQPHmsWZVuFRZ4wHiOEXLBQgDX oI6ftByt877sg6Kgz4v/ZcRqLfvi0rC721Wkscam8Yu21tN6XVUcRYu3oBeRPvk1qCWbmX1aFV/ snYiUI9LMcK1NonAHEcPN5/wgArfevyz4au2P5ILdYjKE3UI29uBJH2dIMERTGvO3kYvlWRk0Oi fPDY/KQzKkwFc+bYHjVl1aVm/AFqFMTcNDG/ywcK+4ZzLa6DpCrnLGlpM1bKngmtsV8vOLq2NuV bMSMpJJkfoLRrUnuMYH8mrQWK1Edbse2Jc7vvSocb4sgPgOA43YnLNvK8e98LTxSvGu/S7gJ8zM 2y4KmMhKLX2Ida6ihaIWtqaEIL4XhmR0Wi9Ge8YEWEjuFJSfJr6t4dOhMnN5lRioIyG2l X-Received: by 2002:a05:6808:5186:b0:485:41fc:71e1 with SMTP id 5614622812f47-495eaf32892mr4357633b6e.21.1782856932690; Tue, 30 Jun 2026 15:02:12 -0700 (PDT) X-Received: by 2002:a05:6808:5186:b0:485:41fc:71e1 with SMTP id 5614622812f47-495eaf32892mr4357591b6e.21.1782856932204; Tue, 30 Jun 2026 15:02:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 09/33] accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG Date: Wed, 1 Jul 2026 00:00:36 +0200 Message-ID: <20260630220100.1289-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: sxt2erI9WPdB0xYHQROUcB0MSy-D0zer X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX/pYT9f35M2aJ wD5WlCKhkvSpjvD+IpyTn4CC5m7/XmpeeA3YVfe2biHV0Il/HEtv62b3WfdbDD0TcujGhTKLSx/ pJMfzHzgZS/pYp9rW60tdrpO84cLsMFWwgKKJ+uY9Cqb6WUIAtolgMEkJG0Z+Xa0HPBRIOS0pv4 FVG/6FW2zFLjyl6oGo/NwsJ1zff5mnb/YxH+8wY4HiO2XNNmzyOOIa4ea4ac/TY/Nhr0uztEWGh gWaYoUQejMjrNaxW0eZ22uYze/UrbqlfDXOMgjuWskkk6zy0cB764tVqfSM/NtGHqTHYC2Vtx4X GYOF5kLJ9Fuy+R8AyivYBCB1fTu0ERLjYqabkmxRnCqn3xvTr5a1IEJYxq9yqlY6R1JMDm9uP3B WOfSvupPw7ChYiTQsxfex4sa+pu5ybztw3gnzsNw5kxsCmTi3v2pluT7UP2yv18YZWvz97OmU6Y VpynkHSU5OsxJxCB4dA== X-Proofpoint-GUID: sxt2erI9WPdB0xYHQROUcB0MSy-D0zer X-Authority-Analysis: v=2.4 cv=LIZWhpW9 c=1 sm=1 tr=0 ts=6a443ce5 cx=c_pps a=yymyAM/LQ7lj/HqAiIiKTw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Fjv_wwvgkwid0SI5BdUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=efpaJB4zofY2dbm2aIRb:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX9+o83KGnEJjq +Ovw7RLYXh4puXSyxcjXDPJqwxa+EDq+x7Mbn42sjfJbBtvL3NJBy+BmrTqpZ4fATadHWD+SJLU 8bcLJzileka/ItlezJEBkGxmsjqzRyY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857060134158500 Simplify #ifdef'ry using TARGET_KVM_HAVE_GUEST_DEBUG in kvm_init(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-all.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 5d55cb45cf7..6cd5f95d06e 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3037,24 +3037,23 @@ static int kvm_init(AccelState *as, MachineState *m= s) kvm_vm_attributes_allowed =3D (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 + kvm_sstep_flags =3D 0; + #ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); -#endif =20 - kvm_sstep_flags =3D 0; if (kvm_has_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 -#if defined TARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { kvm_sstep_flags |=3D SSTEP_NOIRQ; } -#endif } +#endif =20 kvm_state =3D s; =20 --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857040; cv=none; d=zohomail.com; s=zohoarc; b=dweRIdqKZnNZg4IwjR6EjO+XMUqWxdn72rxKW1GD+s0A0r899/URBM+fwYlLyPiO6380R1jIFW8tgBiV0g+A3Vd6JY3FnzNopjptUHg0tPBSSzrhDO9YNzlIaCm/SB+SUIg6b1qT5DS2Vdx3DwCk47WgVNV2by+mly5GOZSZRO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857040; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PZLbCHHJVVo9tzbQGh7Lv3WnuDKgE812wa9Iighf7Qc=; b=Lme0is+seilDNx4ri1nyAdT9V5ZWL+pbL10KSvogMWGJIfOCtLy/KuPu/FsRJD64YzapkiS6WX9WFy6L24BI7pXp7DEI4i6fZqYOvQbTASH+XtX8mfgFqLQlchU+8qTFJ2beZ3ZYESAsxv6ew/j2WBXmNLaBTrTgojPxYwwtKfE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857040572113.78485473775777; Tue, 30 Jun 2026 15:04:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYb-0004OO-2J; Tue, 30 Jun 2026 18:03:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXA-0002j8-Lw for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:31 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegX8-0003st-Kt for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:24 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDsS72959924 for ; Tue, 30 Jun 2026 22:02:21 GMT Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jkt8y2d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:20 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-966a617821aso2572847241.3 for ; Tue, 30 Jun 2026 15:02:20 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4c7f2csm28217525e9.3.2026.06.30.15.02.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PZLbCHHJVVo9tzbQGh7Lv3WnuDKgE812wa9Iighf7Qc=; b=EHHy+u15n0P5zT8G drKLL5EcfyJD3AKrfYnoFbXhoraORYBpNMk+zBxjNi0bXULo1ZRpx/4BcKkGWHx2 Rvcilh1/tDaEaTps1KGdCQoXLBKKpfSB6uOrcKFRFdvPRtGNI3aC2zS1+zteertt 4O57OyrFcFzN+T7l4C2G1P8bgj6OBjHZgPTPaDELJNDRv6IAfxm3+LeXHyZS//7g 1Qk/NvJ230zkFrAElhXr5JMW0AFaRVsGfbdtymA2N4NMkn/mcCPiAo4knZFGjbBb 6Lpuc/QIup1iBggZvJk78QUTkw12LG6fhrVVZadMwZtMeMnZ2k3usap4ch7WV7fz kIdnuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856940; x=1783461740; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PZLbCHHJVVo9tzbQGh7Lv3WnuDKgE812wa9Iighf7Qc=; b=K3Rgjo/dQsuwaz/xG/CO1QgVG1zeSo7tZb7GzFjuohhKr8YLQYaEySHOXl7qrqxaYG BFD63/A9FnExeplfH05Bd78GtBUiIkl9zOpMpxvzPmbxNVd1Szq6kZpz9YP+fzRzssAb u9xW48lcXmhMhzbQjk19bdVpFImec8VLPIp1ubCiT0BrsfUm18YNZLr4bZO/mGBJ/b5I /DXmdUygJBqIFnlF5bJB8z2Lx9eF2UW9TK7uboJplh+cdE1IOG1JkyucDrCgXfY6EZFV wEgf3iWRJEio6FyAtIkqdUL9V2FubJ9XXZz/a7ge6WAcVxM6pSGiCdZLg+elYHrV0GGq /LWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856940; x=1783461740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PZLbCHHJVVo9tzbQGh7Lv3WnuDKgE812wa9Iighf7Qc=; b=KsQLYr3nuY30ZtXhC+BaOniKvyIGcuDyHXHLbeXvqmt8fC8HkJRknDphjsKmoN/p1P e0YVTlZ99By2ekke+rKlUqXXEo14zMQRTeY7CK9IscfHxuF0aNEI4LHlEOu/F0jDYttN lhe1MI41hWQ+u0+PDPPAOY3uUcZLG6k7Z2JT7XvBIE7dZ2MggkDnUreDmlHaJvJpkqwY bLrZRb+bg/l/Tu4Bzr4K6m6zT4kF31XD8rzohmJ37tD2ln6tcbmHm1RLQnjiw9x1Y2AV cYwbTLQ8MW263W1g0iFNTBPDHiepldjRpIdMQgrnLB1xeZdNvsutWHcUxWekY0O1xnI9 6JoA== X-Gm-Message-State: AOJu0Yx8WJrToDtP7TE1HgvcErdCpSbb6KSx6PWpttCwy/vgieYAU8R+ uvykECfzc3lpNT1edi9t03CgtnhyQT7JSt1FB5/MkGRjPyzHmEQA/65QjvDcRyYEH0IYFFX0+gj 8fdkfd3W9vXbhn+ThuJ5Cf2G+BH6HeZGqEGrxR6RdhjEfYTQpVvs332C9PSRywMVlWg== X-Gm-Gg: AfdE7ckadnUqITSQ9iqmtjjp6D2hXixd8NRx4YSgSrBRW5TDCf+fZ005YKX0wo3GKSv rMeD63FQLxGTCyQfQJjzjdJ4bn0khRENu7Ia+x5jlCksYQby+U4AXO9FbarGguO9KghmQfmr1uk U8ysMYkCpAYIIlsVU+wALLGuYMbvAcuvw5mJOA0adawh487I7t+T38IuDQJSBX2lGnbRwdDQsTI 4n3Ba+oR8rnmPK9rvD5xxzlH243s/IDbv3OJsvhnvSmFT1ZannpPG514Rl3IBacsk+eGfjy41eQ Bug1zRI2Cb25V3ObvTGC8vrRb+DjBmifdmUheiqIhEqqtS4EzwI3sNYhaokuO87XPWhgXUJmsnq +8XVDFemOuy74mzvZMKfZYbCohFpVxMoD2GXq0NoYxz9WkwI1XT6A8qLmVe7NHuAog791 X-Received: by 2002:a05:6102:5804:b0:739:97bf:9189 with SMTP id ada2fe7eead31-73a38840eb0mr2316434137.19.1782856940105; Tue, 30 Jun 2026 15:02:20 -0700 (PDT) X-Received: by 2002:a05:6102:5804:b0:739:97bf:9189 with SMTP id ada2fe7eead31-73a38840eb0mr2316356137.19.1782856939454; Tue, 30 Jun 2026 15:02:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 10/33] accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config() Date: Wed, 1 Jul 2026 00:00:37 +0200 Message-ID: <20260630220100.1289-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX88VV6h9K04PH D+HC6Gc+eN1buLn/ryuuFEX3zqli6ACiB92aKs4iZwuH81Pm6bYeR22g37jPZ3JrLNGeWeiSpGN QGxnaFfBkZbrBeqEAEvPg95G5OPp+7g= X-Proofpoint-GUID: 127xc8LsUR_7dmg-ghpRFF8ifHQHI2on X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX/Hhgw7vb+sET zRpPk3myXurSAdnzXXT51xjdgR6znVT/dW1Iv8OIW8IzMSABNaRfVyB7+TInXDOkzUmFoajCCAF VNPrAACfeLSuR7ex6AjVEjn5gZZi8nGW0lAfC9Sv+lrM8rAfkA/insp0hMGm2uFFZX0BWVhvW+Q uBrh+YZDN8FowVpNksP02BmkqL27+azSzZakRs5jahQa4vlbrqBKyOV7HoEaA/ziHR7SvpzxFna HwPkIXYPhjdqf6Ca8zIWUrRzlrOk9UpCljrsi/EIvJcCB4I9DbQthtVMuAHoNRPOj9oDmk+Qgvk xmTLi/nin6INGqlh/vOUn40+PiDNrdoV606ieYvVM5LOyQIq25zOvD3JunLAiAty8ZFodKCxomX 24YUaROGAinsqBc6nOs7zFjzQAWnfouop/WjxkXXXgUMh49iY5CG17dQYFgbNOSxstWKSh8whq+ CQjZvuL3MZe6GzdC55Q== X-Authority-Analysis: v=2.4 cv=R+wz39RX c=1 sm=1 tr=0 ts=6a443cec cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=PyuShGlAArM5Lf9eh-UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: 127xc8LsUR_7dmg-ghpRFF8ifHQHI2on X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857042013158500 In order to have accelerator return multiple gdbstub parameters, pass @supported_sstep_flags as argument instead of returning it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/accel/accel-ops.h | 2 +- include/qemu/accel.h | 7 ++++--- accel/accel-common.c | 9 +++++---- accel/hvf/hvf-all.c | 6 +++--- accel/kvm/kvm-all.c | 12 +++++++----- accel/tcg/tcg-all.c | 8 ++++---- gdbstub/gdbstub.c | 2 +- 7 files changed, 25 insertions(+), 21 deletions(-) diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index f46492e3fe1..1bc359ff3e5 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -37,7 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size); =20 /* gdbstub related hooks */ - int (*gdbstub_supported_sstep_flags)(AccelState *as); + void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags); =20 bool *allowed; /* diff --git a/include/qemu/accel.h b/include/qemu/accel.h index d3638c7bfda..92f9c538f31 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -74,11 +74,12 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **er= rp); void accel_cpu_common_unrealize(CPUState *cpu); =20 /** - * accel_supported_gdbstub_sstep_flags: + * accel_get_gdbstub_config: + * @supported_sstep_flags: pointer to store the single step modes in * - * Returns the supported single step modes for the configured + * Set the supported single step modes for the configured * accelerator. */ -int accel_supported_gdbstub_sstep_flags(void); +void accel_get_gdbstub_config(int *supported_sstep_flags); =20 #endif /* QEMU_ACCEL_H */ diff --git a/accel/accel-common.c b/accel/accel-common.c index 62590a7d9a6..526ab2a0cfb 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,14 +113,15 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 -int accel_supported_gdbstub_sstep_flags(void) +void accel_get_gdbstub_config(int *supported_sstep_flags) { AccelState *accel =3D current_accel(); AccelClass *acc =3D ACCEL_GET_CLASS(accel); - if (acc->gdbstub_supported_sstep_flags) { - return acc->gdbstub_supported_sstep_flags(accel); + if (acc->get_gdbstub_config) { + acc->get_gdbstub_config(accel, supported_sstep_flags); + } else { + *supported_sstep_flags =3D 0; } - return 0; } =20 static const TypeInfo accel_types[] =3D { diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 21b9b71a6df..284ce8ebff1 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -228,9 +228,9 @@ static int hvf_accel_init(AccelState *as, MachineState = *ms) return hvf_arch_init(); } =20 -static int hvf_gdbstub_sstep_flags(AccelState *as) +static void hvf_gdbstub_config(AccelState *as, int *supported_sstep_flags) { - return SSTEP_ENABLE | SSTEP_NOIRQ; + *supported_sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ; } =20 static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, @@ -278,7 +278,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) ac->name =3D "HVF"; ac->init_machine =3D hvf_accel_init; ac->allowed =3D &hvf_allowed; - ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; + ac->get_gdbstub_config =3D hvf_gdbstub_config; hvf_kernel_irqchip_override =3D false; hvf_kernel_irqchip =3D false; object_class_property_add(oc, "kernel-irqchip", "on|off|split", diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 6cd5f95d06e..72d6eb464db 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -4281,14 +4281,16 @@ static void kvm_accel_instance_init(Object *obj) } =20 /** - * kvm_gdbstub_sstep_flags(): + * kvm_gdbstub_config(): * - * Returns: SSTEP_* flags that KVM supports for guest debug. The + * Set SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static int kvm_gdbstub_sstep_flags(AccelState *as) +static void kvm_gdbstub_config(AccelState *as, int *supported_sstep_flags) { - return kvm_sstep_flags; + KVMState *s =3D KVM_STATE(as); + + *supported_sstep_flags =3D s->gdbstub_sstep_flags; } =20 static void kvm_accel_class_init(ObjectClass *oc, const void *data) @@ -4299,7 +4301,7 @@ static void kvm_accel_class_init(ObjectClass *oc, con= st void *data) ac->rebuild_guest =3D kvm_reset_vmfd; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; - ac->gdbstub_supported_sstep_flags =3D kvm_gdbstub_sstep_flags; + ac->get_gdbstub_config =3D kvm_gdbstub_config; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip, diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 8eb4a6b89e8..89f7e025021 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -242,7 +242,7 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool v= alue, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static int tcg_gdbstub_supported_sstep_flags(AccelState *as) +static void tcg_gdbstub_config(AccelState *as, int *supported_sstep_flags) { /* * In replay mode all events will come from the log and can't be @@ -251,9 +251,9 @@ static int tcg_gdbstub_supported_sstep_flags(AccelState= *as) * them occurring every time we single step. */ if (replay_mode !=3D REPLAY_MODE_NONE) { - return SSTEP_ENABLE; + *supported_sstep_flags =3D SSTEP_ENABLE; } else { - return SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTIMER; + *supported_sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTI= MER; } } =20 @@ -266,7 +266,7 @@ static void tcg_accel_class_init(ObjectClass *oc, const= void *data) ac->cpu_common_unrealize =3D tcg_exec_unrealizefn; ac->get_stats =3D tcg_get_stats; ac->allowed =3D &tcg_allowed; - ac->gdbstub_supported_sstep_flags =3D tcg_gdbstub_supported_sstep_flag= s; + ac->get_gdbstub_config =3D tcg_gdbstub_config; =20 object_class_property_add_str(oc, "thread", tcg_get_thread, diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index f54415a9db7..1e0a6638bff 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =3D accel_supported_gdbstub_sste= p_flags(); + accel_get_gdbstub_config(&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857021; cv=none; d=zohomail.com; s=zohoarc; b=GlU2ElR1Du8OxEb//UFLLVFoM+rMSTi3U6q97Hg1qDoOhRqInAsKqxRgccFlRVWeJcqB1y1xFQP3dkcHpRGJTAa41BMiwg1wI0EI9LaC2dkEDFP6dX9PGaI4oIU0FnlBkZY4hbtaukdvqwPiLsO9ibTqz3WvtRevLKPREMxPzoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857021; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uDWJymj80vwbof4Tx7YxMX1WHF7pu8qLq5dCap8A0DE=; b=Q2k8/Lgdeqthtltn/DzR4t5Se7eoH9TAHSP07C+PZ9MWFfmXOksw7MfUqgtbS9EMqcAtVUa9M38jJZygIEdClGGH6PtL+HJEmjd1APXFu//lZHDMETzJVf2zRdrwF4f7R+5a+TaszlLLZ+iloJs2GD8GsHZ1RGw0+UgP/wRNOrM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857021945419.21294441829843; Tue, 30 Jun 2026 15:03:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYK-0003xN-GB; Tue, 30 Jun 2026 18:03:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXT-0002oM-6m for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:45 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXQ-0003u5-Tn for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:42 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDkar2947120 for ; Tue, 30 Jun 2026 22:02:29 GMT Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4avpucn1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:28 +0000 (GMT) Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-69e89d83663so4263eaf.2 for ; Tue, 30 Jun 2026 15:02:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4fef11sm22819365e9.15.2026.06.30.15.02.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uDWJymj80vwbof4Tx7YxMX1WHF7pu8qLq5dCap8A0DE=; b=eKFHOdDm+pbFEUBn vL2oFerUct2J6oXbbALBkKQP9T99oBjrYY90s2M5wf908NJkqpecAXZB0hi0XsiE CoyCYpTotrTeSk7HIxWdExFcjNHp7gycXYNCf+qQF/bZ3+JhOSSaT6uyKwzhTsK9 C6rs+YPWi2ZaF7oL9egYwdFvxV98QBWqID0fLRgkkn/CLdWNuxE4ojYc0zX1ZSl2 SEweC+mnXdAZp8DneXtG8hA0wQdsfYSTZhhZHsYP5doLgbrzjQSoFRAylJ4VAk1s xyhVSTQgm1C3JS3zN7cxvgAtNuVgZdrn8g6SFTwj8G8K7E8R5/HCRNq6p5xzMEKX bgjmLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856948; x=1783461748; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uDWJymj80vwbof4Tx7YxMX1WHF7pu8qLq5dCap8A0DE=; b=SL5dNMHZnhx8ZtwZ1DVn46C7ibgWz5LRWo19YzTnVJYnT/PGsFtNxNXB3rJQjkiC+E IDi3z4q8uAYjhaAmHLS46u0nhyVeu/z7Jak9G0R2fat5JMR/pQH5QoIuzt097WR3UdsJ JNvaLZtmqGs5990GkyajY5Ybmk6F3rBUb7+DjxjWwsGR39wcfOGzj7+bEZRfNvD+A/Sk QZQcmSGuMetVldE9PErawM4IZiia9z8rfp+Pw94Gf1BLKqifoWzkXR0o6lqVLY8WSclO 7O5F6TtcnQl+GtJ1VADO3P2tpsbQ7L7nnGU5rVuXvhX6A3ab5QEP4Wcj6lUivJhxl+Xz Z77w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856948; x=1783461748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uDWJymj80vwbof4Tx7YxMX1WHF7pu8qLq5dCap8A0DE=; b=NCXSaFGPbAHAPl3r81esFMXH+mdYGFw+cMH/Uj0fsGfbzZayvYHOKWhzknP8u0ZTiK T3AJQDrbVyivtfb5v1X2YeGtAWL0sAfXJju2tubKws399gQyvAugk4eL0N7vGUTgJ+G1 iSnS39qZTTBBQtVMBxECCtdfQl3cwFMAd4t4EwSFy/yFhGcMUF2YZmay5LI8S2DUgOYv 3DeY78QhQuumfPapzmed+qWevqoTfcYCS/gN7WcanPyowrs9qFWMRQ0kBMYxwGRuOKhU JZAoiU67uqobxr9Efe4h5NCqIsTdUQRVaWXU3I8ZbXPv6iEGHDmoACkLzqklzyfw2RE5 OtEg== X-Gm-Message-State: AOJu0YwRUW1zVN3e+FBvwcVNrsXBRk88mt/evevMlw6W/DlqXUc70V15 UNRNbYCSX4d+1YANFeC2m8lz10FxPfTqgJtMTRwkfnlmKvPirXb2w0288ZDS4YUW7lNCs6kughj CVvljVSDQF0gsSAV1xmQcnN5b/JaAB9bob89NaYspWPzNNyJs+NSVgL9C96V8xyTakA== X-Gm-Gg: AfdE7ckU1skRAiYFSget1mt4wZlYe3ldnemUBfX//Uk8hek48fMFY/jTwwKoDimdxhm MH1536p9ojlAhM5cgmmxRgE60hYV7U4TOocaky3BxIMKGbXZz5aqkk/qwPH2cpZG75Sji17JaL0 m348niZCtB7ne8q8RweMDQZ6AKvcaLsqtPyAPtOxHxxC2VAFUSVbtlKPOgtUsv5eljlcoN7eDnp ECbuJYlPHsYnxhPzE/XiqvaL7TCiPqvMh9HE0MXsqYVjwK/MPZVg7/IPFhZ5xrtzjhm3CAHvtkX SCu3y6uiB4wG/MkVNfj7ITOnlOFwdaqbxGwxRB53LsA2Weou473CGTP+kDewWESagYh5igRaGGl 2ByCQpDEuWMh6HUQrqeW/ubnGukXENwtfRxKxJash/xndbQUTBOIWX8v/DZiDzyJWCs9J X-Received: by 2002:a05:6820:16a5:b0:6a0:e37e:4614 with SMTP id 006d021491bc7-6a196c50f99mr1515169eaf.40.1782856948206; Tue, 30 Jun 2026 15:02:28 -0700 (PDT) X-Received: by 2002:a05:6820:16a5:b0:6a0:e37e:4614 with SMTP id 006d021491bc7-6a196c50f99mr1515148eaf.40.1782856947732; Tue, 30 Jun 2026 15:02:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 11/33] gdbstub: Store @can_reverse in GDBState Date: Wed, 1 Jul 2026 00:00:38 +0200 Message-ID: <20260630220100.1289-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: kMZILRAVCaLgp4P6JLyfxqgtZuALnMpT X-Authority-Analysis: v=2.4 cv=KqJ9H2WN c=1 sm=1 tr=0 ts=6a443cf4 cx=c_pps a=wURt19dY5n+H4uQbQt9s7g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=XnORNqxp5neGsmUcoQsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-UhsvdU3ccFDOXFxFb4l:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX6/W9w2y/Iu35 jZJFMstVE5VnlfgXkL5B8J80vp81sdIfwr+PMgzQ6CG/AAt0uw2Mut4Uu3gENqfN6F7cB63QYD1 xBvvd7IcckjU6/+UBmC2aCowKL+MyjRGE43im869e7U0KlVlniYU+wGezuV2wSyQpBRfA+gl0oC ixgAsA5e93inWe6zcT+ZP85HwxDT3AxWH3T3eEGF6XO2E7YaW9CGLeZd1r9GlQbIG7fEwbDeQ9E sozOBl45K0lGFMlwhnFFNQ5KHGuSnf+ff5VvRvJB4jvxV3jTPJ7YBZROnUqYU90IOTF3uddUvDm 2g2bGv4AGAUZMGnWPBwsIi12sfOtLU/6JSpd4KKc9CG6jJsvnyFaEyjnCBp6NKwq0lI7whdUzDd 64eICCMiJhPRRp0q+I17Vm6VU815t8Kw0WxeWsrtjYRwMuARmccppxhCnPH5TC1z8yqKSQJQ7Rt KAIIjTNts/CIhAl+e0g== X-Proofpoint-ORIG-GUID: kMZILRAVCaLgp4P6JLyfxqgtZuALnMpT X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXybhgTGCavndE MwvP5F1kq6VYfyBuq14DjSaz42cih5Zbg8dUxMbF7u6d360xSPEHqQg+FFwzd2XSLEugMA8FJ2u l30GDaw5wLZPzg/gx5M+okpVzcILZ3I= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857024116158500 Call gdb_can_reverse() once in gdb_init_gdbserver_state() and store the result in GDBState. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- gdbstub/internals.h | 1 + gdbstub/gdbstub.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 9b25bf58b8e..9a1b8d9dd8a 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -85,6 +85,7 @@ typedef struct GDBState { GByteArray *mem_buf; int sstep_flags; int supported_sstep_flags; + bool can_reverse; /* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself. diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 1e0a6638bff..0037704d522 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -75,6 +75,7 @@ void gdb_init_gdbserver_state(void) accel_get_gdbstub_config(&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; + gdbserver_state.can_reverse =3D gdb_can_reverse(); } =20 /* writes 2*len+1 bytes in buf */ @@ -1376,7 +1377,7 @@ static void handle_step(GArray *params, void *user_ct= x) =20 static void handle_backward(GArray *params, void *user_ctx) { - if (!gdb_can_reverse()) { + if (!gdbserver_state.can_reverse) { gdb_put_packet("E22"); return; } @@ -1684,7 +1685,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); } =20 - if (gdb_can_reverse()) { + if (gdbserver_state.can_reverse) { g_string_append(gdbserver_state.str_buf, ";ReverseStep+;ReverseContinue+"); } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857119; cv=none; d=zohomail.com; s=zohoarc; b=SvrEWlJ/EktH70jQ1Je9w9Pua+Y+fL7j9YHhaEQBkrHW3rKKX1NVAmWmazpxuayf9U9ghPVUF65RkwEz2dVJvNe0JVkUwZ/mIPe4vB4d+RXDsm8n2Hhdt/jl0wkggfy8k11tMXnhZHyaf05lbNnIjvIz4KQcrP5zYjwlI2eyRMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857119; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xl6Yv6lxkZ3eY3NoScDQIgt89IBP8oIZC7MwT2nJFyg=; b=ImsnIVtfde7PIraq5SK0AZvzj051Xa0hBS5Tfd0PtNhKmgHGFlD+FnrIbDXJBDe8KJN0ZD29oR1sTRGQJLcQhYecK8XjyXzJnV0X34/g/T+HPAqXPpErAEo/F4r+dZa3wqnjbbNKttFm0J4F/NLcb1BCSM6RSMQEI81B0VoEtrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857119008847.0717911333304; Tue, 30 Jun 2026 15:05:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegZl-0005m2-8m; Tue, 30 Jun 2026 18:05:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXd-0002v4-0Z for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:55 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXb-0003ut-H3 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:52 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDguO2920150 for ; Tue, 30 Jun 2026 22:02:36 GMT Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8ue8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:36 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9692731af28so1829175241.3 for ; Tue, 30 Jun 2026 15:02:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2bc5sm25355745e9.5.2026.06.30.15.02.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xl6Yv6lxkZ3eY3NoScDQIgt89IBP8oIZC7MwT2nJFyg=; b=CpZD0+92OR5VAu7m zyysf+XiOdoGEZKwoXjdOBl4nuxnxCUMWULglr2CwSygrv8PdTJBUKxVshhGWRqM eHQ/WgDrz+1t1XJMqFzG5sxmxtpToX1tyY+5+8o3vIqAKMJZ8fvPujUnUb5pKgoZ fPq825cpnFPeJveZ1+KsXp8G56tV+DelNokv98SzpbImnxLVg88BFrbgB9QIObSL QYDHhZIyRHfc6m4UYaQRrG0om4SNjhScH0Nfd/zUlU5S600PEg/wnYuMSG1htbE3 2DIH5wJYEVXY6xmRW7KclKweT72o59lMQQG892Y20cDn4jn3EfHV76Gy/OyyV1eF HHdLEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856956; x=1783461756; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xl6Yv6lxkZ3eY3NoScDQIgt89IBP8oIZC7MwT2nJFyg=; b=L4APdCv69RYepFdGlWW03iLqqxBtrQr/uNWeMxSVKjkmDjvtREI87AJUoECkkC8mRV 4RUjJq8mUxk7MSSii5Ii8mIB4JpXBDIXvs15kr7DiYCLCUwQI2swUlUdqakibhi1JvSQ KSad4K6D5inWoDjo1ySa9P/oC8FclJQkauP5Z4FF2bZbIOMwvXpkeaWJ0w5ux64Wr+vI AE3jpOwisItBZm5tzHOW+50qr9eZ37dqYHwnBf3glYYd/DhbEE9TXwxhpjhqWLCCvW4z rM4Tq0n77u63mTQH1cIXgXDTqGHIxqfQMePsjFS0gZ+pDgfR9RPr8VxvNap917Wb26Iy e4/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856956; x=1783461756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xl6Yv6lxkZ3eY3NoScDQIgt89IBP8oIZC7MwT2nJFyg=; b=m5/n9CyqtEppckQRYcg6CTaqULkfCOyfXUEe00RoDVCFmtMV3RSA/A4INytpuSDuzl QFQW/D1cMMvud1omhh7jpf3PAQwaGJ3FzQ5i1ZJgtXJAylBiYRXPg/Rajum+viq7sPZo 8USJrG+32WISJLrK/RUicuqmC/utpjT7I9xNltPMM7fQOtx8nxWCPgS2DT3FDf2gW1D4 KAbwXSnuUQQAKBtKeAqSKB0H4xVSCA8zCvBDxi/xcCVL5Wb2NaWnr3Tl9Ff6ZbGewNFM /hNFKvsD3H4mVujNlWqvqncJVkcupXMPHFhaZirOWCJPc0bGMj6s6ee6nP+fwtx77Erz qFqw== X-Gm-Message-State: AOJu0YyUFZkqQOIxluaZXv6ng1AXa7LSyEwuCV8KRqbXRc22dq6YbRtc Znt5y4CgdtLvF+f0DSbW4p+bKDTLFG5iWhzzc9GXXm0ptA+JLyIRrHd6H9LqnoC26NMLCWIm4fg mS4zA/UIii80r4Tq/hx76e/kIAOzAD1/2f6Xby+Kf0TzByIfYwVJsCVyi1/5qKBrMPA== X-Gm-Gg: AfdE7cmp6WX4m17+Ry4ASVE8zf4Qd/n/FipYV3TbgDNXtkM4KzeTG7QhKQfNJ03il+T EilNfM9S5B5VlS3l9rli0fiFAeC+5duMQEDk76I36CYskx2uApNU5tc4rRWyyys43JoplzruGxO o67mCl0iSxD4zY9OuX60ZkXu+oC/rJjJOQMNrF8LK1iJbzjKiKF9yiFUxTZr4G49xpdYmSQDDL/ Nw2uJe7GZUwoL3DuI8MCpgRADUtGTYYsSiMEMJVhsgDHVqicxE0ztzV8b+85ecHIl96hCYnpUpb 9AV+I8g8J/Hrm9jdSirNXa9n+oMH8FnwlI1MJkcwO8RxhnOx/s795QvSFAfDkWZF4PWwiHSkY+0 a0M2KQqq3TCorWETwWDuunMwDgy7d62S+o3NkFNC57nLku7vX5VFamd4Ne36cIDSQzyiT X-Received: by 2002:a05:6102:5805:b0:738:be73:55e0 with SMTP id ada2fe7eead31-73a366f6f09mr2355953137.12.1782856955681; Tue, 30 Jun 2026 15:02:35 -0700 (PDT) X-Received: by 2002:a05:6102:5805:b0:738:be73:55e0 with SMTP id ada2fe7eead31-73a366f6f09mr2355905137.12.1782856955182; Tue, 30 Jun 2026 15:02:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 12/33] gdbstub: Make default replay_mode value explicit in stubs Date: Wed, 1 Jul 2026 00:00:39 +0200 Message-ID: <20260630220100.1289-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 9pOyqXTVNvP4WVF7IeUsSCPaDAEV0NnA X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX0krJBgOGiK/F S98jlQgoYs9eVGJE5oUhszUrcMYPBrczNvvkjTO9VzaeFdgHTuYOExFJ4wM19CrTZpahGB/xw0s r6RAVg8gyMWA/dofiXj/U0kudVLiQyw= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443cfc cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=K_Z9TnmIjj84_yaIjkMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: 9pOyqXTVNvP4WVF7IeUsSCPaDAEV0NnA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX6Cg5LAUPlrzi rYgG5Jtpq0pKd9u8NDj7NtgjRaX6lsSgfkEUgjj1KaVyXGEsXqzA3vs3a9cIrHfp89qEYXr7E1n vwXF4JZzEJntdA5EB0z5Y5aAvKHU1XzfgsCSMbEXELEE7rhMeQKQh8+E92WTlvbmvnf8XsZvJyH X467s1d9ovZPRaVSfOD87+UEqXH4XKTT+KK1IqPAYoJbkfOzAf+hwjwbqJeVD19vfmZv6gv1BGX pLTEWp995TJmSKsXRp9Ka4M5J9UdOgilVk9vD84nrJlncQdMw4G4+zbKpLUAfFMgZcXaOy4e3F5 jumPeicmxmwsraePZFjFHQX7UdCS8lNiGThTGqU/4CfasjRWmr09n6N8VnIWG+e1vmdPdds2OVi cuNPzVUiWSoBwBfNLp1WWyFxTpzVQ9xLWqOjYVovP00XwTZIHp3UU8Q6YeU3Oluqb02sgSW2kce tY6JeB5ECCALFy+qcoQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857120472158500 Make explicit @replay_mode is stubbed as REPLAY_MODE_NONE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/replay-mode.c b/stubs/replay-mode.c index 439d97e4a87..5bc8f7d6589 100644 --- a/stubs/replay-mode.c +++ b/stubs/replay-mode.c @@ -1,4 +1,4 @@ #include "qemu/osdep.h" #include "system/replay.h" =20 -ReplayMode replay_mode; +ReplayMode replay_mode =3D REPLAY_MODE_NONE; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857072; cv=none; d=zohomail.com; s=zohoarc; b=nHvVhAb7IXm9ZEbPqTNEr78u0IrZgQ9z6JJqxqbegRQRZefbesZtKwIhCC+NosBOjKpWdsKx4SQROlkzpzOtOt26HjM6oLDxf3EVE1/AAqNrAY9eYLHBl/ugMnpY1e5hjCiVu+jgB626Y46pp5d0NYGwi2QhvM7O7Jz7R+AIy4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857072; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2B+Rc9UR1tQQKp1qAJSR+ZDe9AelYqZi3TA+CLAH77Y=; b=M5FlxzQRs3NK4HtJXvYisk5f3SwZquUMy5/RLv4FXvxJkbCX2Xl7JQBjoQW86jCi2DS54cPywJpfuIolLCRJB8ARAYC0NAYwvkH8Ppvj3xq4/kKKd/Y1V74AQXbdDQJqz86dRKyJxtCp6m3fzeZ1bX49klbofWyiATxd1ptb3Tg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285707206681.93427762063095; Tue, 30 Jun 2026 15:04:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYO-00047z-4U; Tue, 30 Jun 2026 18:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXi-0002yA-7b for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:59 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXf-0003we-EV for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:02:57 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDj062959559 for ; Tue, 30 Jun 2026 22:02:44 GMT Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jkt8y3k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:43 +0000 (GMT) Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-495f94eac1eso59547b6e.2 for ; Tue, 30 Jun 2026 15:02:43 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47563d194b0sm11859962f8f.1.2026.06.30.15.02.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2B+Rc9UR1tQQKp1qAJSR+ZDe9AelYqZi3TA+CLAH77Y=; b=ZyURHLKYgpbCxyEG n43EpB58fbYAgJa3Mswx259er0K+rjKsnxefV1xxI5MeHkU94stqsS/X3hL1BDaq PZ2VWNkj9uwZrT3rbrAkrLcsm6Exx2HadWzNs5TTcO6Ad6jo5kEFHg+DORAztc89 MDabq6SShqAfskzUW+cCuehzNaLYLuOzJM5xy0XM7rQmCWbZxc9gAdTtQRJjH4pD G5x1qtBRzXGjYfsuEMFKkIRz5nsrQbcSvLKL8PWSQzEsStop9NNDmptljhNc7Dr3 f43ajYGoTDCM244enPtAayASBaCyfJ2yfQ0ETHyPcB53ZZC8sam1jjytxMAkvnOj IntEZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856963; x=1783461763; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2B+Rc9UR1tQQKp1qAJSR+ZDe9AelYqZi3TA+CLAH77Y=; b=E/1WVFjGeE25IKeymayobV2RsVgJ8ovtC7IAB0pU0kjDQYEieUpsfKRiIZejFfMO9+ YjVWsNM172UerDW3IM4WgV79hCCrdPBNNB//I9z1zfqMFzoIqaJr3oKWjsVKlXaUi082 tXa5W9SPFUkGkuvxPwzJq+MSbfScGUzYPMK716CbHkMU05JLKa5NXqvZe7J0VZd7qFWh fWW66I+3tz4B61LLQCt914IdNrYjSJY0KhrJB97Ogbw/ZtTNBJ/v6Cw33R5OgYDMWhp1 WSQ538bM4Xcdh/k6k+Lg08THUPK/pMu4m16k9Z1dJbDzgADHfUgzWEipYmxrX7PhNWl7 U9Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856963; x=1783461763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2B+Rc9UR1tQQKp1qAJSR+ZDe9AelYqZi3TA+CLAH77Y=; b=K7J0H+WWtRedRn4USh2qIEC3lv5MjZDY4WBJUn/Awel4+aCs8kn5g4qVO6MTm0PudE itBxk9fRS0e5PBBZtZ6mCPVbXiS6hVMNBKG5xxn2jdW6ipSvN7bsGuTAoRkjvjBIgAHo iBHGKzJ7zPkFRqdhp6bicZk+Yvx6svNoOENFlRhAsAS4RyC/scsdUagNYdnAEPv1Va9G Vyun3yN75TCKyu4Y3U4xFGVDi8n0z6gWOo0cAdM043yncFfezbNIL6cbiZ7yzZhPA6kx NNY+73ieWuCpr2sc9IxxXA4vlGjDV6uCUKXh2GgeQIlcHPTYx27m3i39oK4XBSrB9K4L GO0A== X-Gm-Message-State: AOJu0YxoCrcsERPIW/gNPFCUc+G6jp0F3Z7KKZgjiC9uJ/KTgunqZwIx 0CE2ThML/8UUt5w40OZyeQQnhK4cwBoC73112PWZPvb75Sn3nRz4fV9sRkALb7/++rR5MmOzdiA wi7hkmmRfpYhnM56HKH/vA4KXNWY0tcKVuQaFpN8/lHzJleC2zd76JtfoH/z5Iy2VMA== X-Gm-Gg: AfdE7clSNUl7ZuyIELnS1Q04mF9EhPts98h3vLeiVlQD9Jb3UgXhcv0GzUl6foZlNLz w/1qYNTIPKNco4NwjOQ4LNP81dW2IeycbvTm1ID9DqLaSmAFvMD1udre7hs3UMVyxpG8HCs8hng lmKxam29cUF4gpw8SbVIon6hl3PgAPaZX0neX6AO8BdPNbiJG3D04xAnJQxQ2CiUqD0zjug7982 M4x/jxYn5ylv/4mCLX8gKINjBDQ+GFRxPxWT+vf2kFmiCDNIoTtMTspTAqp/W3eS/EjR7tF7yCq eHjlkhARli1bU3/Iyr2rnT9PcLP/hq18UfwjulbUTjt1JREwr47u9xPrSLEdltcdDbBhBCcHwnq 9s40PRX8cZnGym+U5BXLLQLw/zKZyFeGO4qg3WGD+UoyJeJkyl6KuaZZbzKsdwXGhXyhP X-Received: by 2002:a05:6808:1821:b0:492:7abc:4244 with SMTP id 5614622812f47-495eadaf2a2mr5364080b6e.14.1782856963118; Tue, 30 Jun 2026 15:02:43 -0700 (PDT) X-Received: by 2002:a05:6808:1821:b0:492:7abc:4244 with SMTP id 5614622812f47-495eadaf2a2mr5364027b6e.14.1782856962634; Tue, 30 Jun 2026 15:02:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 13/33] accel: Have get_gdbstub_config() return @can_reverse value Date: Wed, 1 Jul 2026 00:00:40 +0200 Message-ID: <20260630220100.1289-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfXybY1veROyTso +17w0ncX9mtNlLJju/qdotpOsXIPgAcmLjg0dAVs0RDE2WD++DIgkP1SQjBLJzjdR0smera0i/Q r3kKXO187CFbYuXpISEoZf0eBksCzOA= X-Proofpoint-GUID: gY04QJYiRPY6ghXPhSifC_moil8WjHaG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX8WDro4W3cSI1 oHqIy90imp/B4fBAuDnCLHQeTOFrIZDZ9uoNcJ5EPt33gl1JlXJbd1hLaeOxeCnYAynu3v4Xr9c TbL80EsZ6bDv24IF308j7sQ+8Pv0pbvwUiK4Zxi7gg8JmXZZhJOrkhVVd17L0cMFI4jeU6H2Djy TZrKFSXTmqVbSS6/fJ/jYGNnTdYO5sWOs2BoyKRDcCon/nUTgBX7KOKCFGeR66SmLUChIrVmmXO u5GNF7nSnXvO+tRDFU2+cejmkNEYj/2iyyirW0R6jxAJ80rUR/nGKmk0sAxpvWUMlipTVZh1Bwb dN4raVFdzLnERpVdsYE92D+pW4YEBzttmvnxHWVGK8vkVVPHU/i+wloJm20ectiTlkTM3rw/tWb P2h1pcgRiAe0tJI2XN/OBXPlycUkk9cVb7xUG+k8hVJAw1rvMwYSSv8BSQMYCx6rSudDcg4hPU9 n0oyvqKQmcipRBa+0gw== X-Authority-Analysis: v=2.4 cv=R+wz39RX c=1 sm=1 tr=0 ts=6a443d03 cx=c_pps a=yymyAM/LQ7lj/HqAiIiKTw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=B3UIE0ElhL7aPqeKxCkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=efpaJB4zofY2dbm2aIRb:22 X-Proofpoint-ORIG-GUID: gY04QJYiRPY6ghXPhSifC_moil8WjHaG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857074253158500 Have accelerators set @can_reverse in their get_gdbstub_config() handler. Remove gdb_can_reverse() as now unused. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub/internals.h | 1 - include/accel/accel-ops.h | 3 ++- include/qemu/accel.h | 5 +++-- accel/accel-common.c | 5 +++-- accel/hvf/hvf-all.c | 4 +++- accel/kvm/kvm-all.c | 4 +++- accel/tcg/tcg-all.c | 4 +++- gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 5 ----- gdbstub/user.c | 6 ------ 10 files changed, 19 insertions(+), 22 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 9a1b8d9dd8a..dbd6d11eb8c 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -154,7 +154,6 @@ CPUState *gdb_first_attached_cpu(void); void gdb_append_thread_id(CPUState *cpu, GString *buf); int gdb_get_cpu_index(CPUState *cpu); unsigned int gdb_get_max_cpus(void); /* both */ -bool gdb_can_reverse(void); /* system emulation, stub for user */ int gdb_target_sigtrap(void); /* user */ =20 void gdb_create_default_process(GDBState *s); diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index 1bc359ff3e5..07241f799a8 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -37,7 +37,8 @@ struct AccelClass { hwaddr start_addr, hwaddr size); =20 /* gdbstub related hooks */ - void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags); + void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags, + bool *can_reverse); =20 bool *allowed; /* diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 92f9c538f31..e740939908a 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -76,10 +76,11 @@ void accel_cpu_common_unrealize(CPUState *cpu); /** * accel_get_gdbstub_config: * @supported_sstep_flags: pointer to store the single step modes in + * @can_reverse: pointer to store whether reverse mode is supported * - * Set the supported single step modes for the configured + * Set the supported single step and reverse modes for the configured * accelerator. */ -void accel_get_gdbstub_config(int *supported_sstep_flags); +void accel_get_gdbstub_config(int *supported_sstep_flags, bool *can_revers= e); =20 #endif /* QEMU_ACCEL_H */ diff --git a/accel/accel-common.c b/accel/accel-common.c index 526ab2a0cfb..41f98937426 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,14 +113,15 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 -void accel_get_gdbstub_config(int *supported_sstep_flags) +void accel_get_gdbstub_config(int *supported_sstep_flags, bool *can_revers= e) { AccelState *accel =3D current_accel(); AccelClass *acc =3D ACCEL_GET_CLASS(accel); if (acc->get_gdbstub_config) { - acc->get_gdbstub_config(accel, supported_sstep_flags); + acc->get_gdbstub_config(accel, supported_sstep_flags, can_reverse); } else { *supported_sstep_flags =3D 0; + *can_reverse =3D false; } } =20 diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 284ce8ebff1..49014de26d1 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -228,9 +228,11 @@ static int hvf_accel_init(AccelState *as, MachineState= *ms) return hvf_arch_init(); } =20 -static void hvf_gdbstub_config(AccelState *as, int *supported_sstep_flags) +static void hvf_gdbstub_config(AccelState *as, int *supported_sstep_flags, + bool *can_reverse) { *supported_sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ; + *can_reverse =3D false; } =20 static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 72d6eb464db..0019a092d69 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -4286,11 +4286,13 @@ static void kvm_accel_instance_init(Object *obj) * Set SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static void kvm_gdbstub_config(AccelState *as, int *supported_sstep_flags) +static void kvm_gdbstub_config(AccelState *as, int *supported_sstep_flags, + bool *can_reverse) { KVMState *s =3D KVM_STATE(as); =20 *supported_sstep_flags =3D s->gdbstub_sstep_flags; + *can_reverse =3D false; } =20 static void kvm_accel_class_init(ObjectClass *oc, const void *data) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 89f7e025021..2d2aab80d17 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -242,7 +242,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool v= alue, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static void tcg_gdbstub_config(AccelState *as, int *supported_sstep_flags) +static void tcg_gdbstub_config(AccelState *as, int *supported_sstep_flags, + bool *can_reverse) { /* * In replay mode all events will come from the log and can't be @@ -255,6 +256,7 @@ static void tcg_gdbstub_config(AccelState *as, int *sup= ported_sstep_flags) } else { *supported_sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTI= MER; } + *can_reverse =3D replay_mode =3D=3D REPLAY_MODE_PLAY; } =20 static void tcg_accel_class_init(ObjectClass *oc, const void *data) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 0037704d522..0a691c95880 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,10 +72,10 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - accel_get_gdbstub_config(&gdbserver_state.supported_sstep_flags); + accel_get_gdbstub_config(&gdbserver_state.supported_sstep_flags, + &gdbserver_state.can_reverse); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; - gdbserver_state.can_reverse =3D gdb_can_reverse(); } =20 /* writes 2*len+1 bytes in buf */ diff --git a/gdbstub/system.c b/gdbstub/system.c index 2063b63b2f8..1421645c6e5 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -477,11 +477,6 @@ unsigned int gdb_get_max_cpus(void) return ms->smp.max_cpus; } =20 -bool gdb_can_reverse(void) -{ - return replay_mode =3D=3D REPLAY_MODE_PLAY; -} - /* * Softmmu specific command helpers */ diff --git a/gdbstub/user.c b/gdbstub/user.c index 97eb13e796a..2cc851691f7 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -786,12 +786,6 @@ unsigned int gdb_get_max_cpus(void) return max_cpus; } =20 -/* replay not supported for user-mode */ -bool gdb_can_reverse(void) -{ - return false; -} - /* * Break/Watch point helpers */ --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857158; cv=none; d=zohomail.com; s=zohoarc; b=QPBg+EnIFnCCQwuN93E38iyFMQ85qikLP+98RmDMkzORIUQHCnROUyEIZ+wSQNlv1EGTbKDyGX1CrGs7LA6p0PeFxUDvanJgZeq37mxOEas4noRqhIi4fCb7FnhyHfYNHR57DTcT+q8jYi1FH5oiV+ptJ9UWTHVTBAsSUncDtM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857158; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PU2nAJTGYp6CGHXCfxh2HO5DrIysP1r8Qcr5JVkdKOY=; b=nKQOOQmBr1C+Yjsp4XJbU30twGjMx6AUJBHp9geH9levn7t1loVdIdlxAgiQU7aKjEUOXCoipwcGDlJ7aAVnw9XSEq8VeK8W8EABMZcN+c1kh6jwXaJXlEK8jT7tfw5t0kmtMeL0utFXBGw5i+2de6DGhtzX7bvXjMmCckShuH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17828571587061012.2359448472911; Tue, 30 Jun 2026 15:05:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegZq-00064a-W9; Tue, 30 Jun 2026 18:05:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXu-0003KZ-Ut for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXm-0003yI-FZ for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:05 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDkDV2959586 for ; Tue, 30 Jun 2026 22:02:51 GMT Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jkt8y3v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:51 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-48952d1c293so58343b6e.3 for ; Tue, 30 Jun 2026 15:02:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475643cd64bsm11901398f8f.14.2026.06.30.15.02.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PU2nAJTGYp6CGHXCfxh2HO5DrIysP1r8Qcr5JVkdKOY=; b=S/90EKuSHhMWD2NH z5SGwKOAUnbbQm9et2IXJKoJAIxD1Hz2EsRzDswfMX32q75IstPQkPXEtAnL4g2+ K8KqhHc2kA3y/gvs/xEf/QCciUfvVqo4DTRVHngGZCKWyuzO8vb8smB+F50Nz2hW w58OjEVlWmIGvjDNCPDUJ1K/R8bH6h2AMWOCPHamt2rkvKZ9I3GDSWqWYLPdUFcM 33FAU9yHUez02LAA1Ybc5ZcwlWrXVi3w4DT6k8C3lLY50uK6H0u0izKVqWgFeEH+ 28/3i7qThZcLBNjyYpEKzwNTv5+GgHTQ6ZLqDptlhChYI7Qi8f1syPsSjnl8MfqM bI/sqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856970; x=1783461770; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PU2nAJTGYp6CGHXCfxh2HO5DrIysP1r8Qcr5JVkdKOY=; b=iPA9JJ3vOgUsj9ZGTHv5DzHy/It9G0TKoRyVulzFTl+yef1R5yWbJkp8ThcYObTn5B 6vmA9FcdtrtKZcrJTzsPemCLfEQnmj63sm0aEm1IzISmp8zMRXOE+iuSSzEw+pdFMveH v3eYv9GcnI1e7g5yiEYEYzy3rzyMA2JBP/cUjOvzm2wcysEWw69mAn7gU2/W0WqYVMpn fuaoENLDeDJULLg+UGwxBjav4AhxbFcwVsfzFZw5AIPFVstLA6abjQpBugUD06NfMMDC d+R9tHrs3dAeXjIlmc+5RhQjyt52dmQ+N6LHZQ1aCGPVHC2RuI3xyJBW7tlCJfFclacQ dovA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856970; x=1783461770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PU2nAJTGYp6CGHXCfxh2HO5DrIysP1r8Qcr5JVkdKOY=; b=fdRXeJpntg0P87ItXOC8orFjD0KkppF0VqZURPbI1kQCKXFWRivjOZrTlW4jRfqY/l KNI0ZFBHzfJ00iDS3q5yT6SobXsh2LCMc1zNNv3VM0jNGdN1jVep2MonqtgotaUp7IsF n9oPifLvnEAbaL72lfrUM7o1lw+Op09+Di7GKiJs1W4mq+LI05VcCiBJxJkxnB2gN9iX tr3qwXUt6oNBw0N3rJedEHe/PBMXVbT/zd6GonJgpy8bz4vA2Ctucb1HdMgjzYamSg0M 2ZB9UlEWFFFYxgjC7VpzvzfD8nLb3MCeNxn9fhaR6N2PBWFTiWzdyZO4N5k/C2K6dGet 2MBg== X-Gm-Message-State: AOJu0YyyEb7QplDIBum9uWnVqqHFRyoW0AZFxa8BNa8MpMaoI1j3O7qU icN1k3TgIaYvyXWpluvbV8rbyrX5kn6pfCV5M1Vziv0q/s/cB0O72Mr7KpvmCqrsgmjCkB1diJA 0rDKh6ltLZxJ66rdQPPSxq3Mqohic9R8SHDvTNgU2mz4IhZudr7yaNzF4Y4ZVZfVYHA== X-Gm-Gg: AfdE7cl6OkfXo2qR/OqGhEqbBX+4Uee+0EvYnYqsEwWns2Nvu6sDgrZ65RyADHnvt8w Yd67io6YS2A0sqIOG9g1e0NUk+tItHKk1zWzQxRdt53qvoWu3x2rZevAZ0obB10cr2RVbXHrNEG 2ZglOGwXBgNw5Jdfjnh1mgMkBPcDNhcQ2u2Uz5Nj9S+EczItXMScEp2F+cXBSz+Nz6UZjH+Vkkw DUIj1Om8cY5fwQ1LQM0Oc0OsQAPW20+DCx7wERvBR7YysHeK15CqD7P2JVTjLsRKCuzx3wld0rh dSchQJyzFXbIukoQn3I172CiJaOnuIZTnOMynhhMhWrJUnUloSFow6daUFxznj8A9IfL6dltT4X 27lHjkhHlDVkSsUuH9euP0bVG4tCmd2qN2Kto8zzCJAthUYgbp6LiNeVUvPXhXJQewz+K X-Received: by 2002:a05:6808:4fcd:b0:495:fd95:5fa9 with SMTP id 5614622812f47-495fd956143mr1605809b6e.33.1782856970448; Tue, 30 Jun 2026 15:02:50 -0700 (PDT) X-Received: by 2002:a05:6808:4fcd:b0:495:fd95:5fa9 with SMTP id 5614622812f47-495fd956143mr1605788b6e.33.1782856969959; Tue, 30 Jun 2026 15:02:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 14/33] accel: Move supports_guest_debug() declaration to AccelClass Date: Wed, 1 Jul 2026 00:00:41 +0200 Message-ID: <20260630220100.1289-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX+iru4sEw/s26 7gw97iNMuOUDqDG88f/JYjdSmpTclINQwYMhXTKv49GNHy8Lqajk2E0mcxRnzz+3xV0f3xfpcH1 vIunTjNpY7niavV2a/Opcpwmw3qfgYk= X-Proofpoint-GUID: kRaf-C9bOhJm4npmLeBw3NQz0QHH3_YY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNCBTYWx0ZWRfX3OoF+hZJkeZM lErf+9VIgUimFHtNS+fvFUOZVGamTJT6Plrpir3/1S3X+gt09131DiTLSJgSj6CtX/UEuGRR8Wg l94jqkn68/hOMd6D4f2tMXq6IoaAkdU+P120BTPGMfr5GYuSEP+yHBFvPD8xhwQXtolkPewBLUe p6OsS7tiSKVEguKAxcCo37BQ11YWHMQpnM7nc9vB7E5KwnkVGhX00wzy9IdE6mLDGSOyjUQnjtp i52GjeWkuM9j7a4NSKtajKyL5WUN5JlSZHxwgwtFWdskbaKqBWX1+9u2sr83BBifjsVXKbg6AjH ECsJ3dPgbSzmZ9RZq1ybHSwDhzI8vQzhDrEtbFYi5wcoa+fQ5yemZoClS8JovS/WYRakhXz8lzV HMrydTRgmfH5oKyMmw0UL/fdM64Cx7TSUNyMp46K8ULwiOizTUBOQlAOGFf1y1gkwbID+/G1gdU fYpY4tyWRgwRZQJXrng== X-Authority-Analysis: v=2.4 cv=R+wz39RX c=1 sm=1 tr=0 ts=6a443d0b cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=d9gndd0ExkgcL6hwJkoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pF_qn-MSjDawc0seGVz6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: kRaf-C9bOhJm4npmLeBw3NQz0QHH3_YY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300214 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857160743158500 From: Philippe Mathieu-Daud=C3=A9 AccelOpsClass is for methods dealing with vCPUs. When only dealing with AccelState, AccelClass is sufficient. In order to have AccelClass methods instrospect their state, we need to pass AccelState by argument. Restrict kvm_supports_guest_debug() scope. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-cpus.h | 1 - gdbstub/internals.h | 1 - include/accel/accel-cpu-ops.h | 1 - include/accel/accel-ops.h | 1 + include/qemu/accel.h | 2 ++ include/system/hvf_int.h | 2 +- include/system/whpx-all.h | 4 +--- accel/accel-common.c | 12 ++++++++++++ accel/hvf/hvf-accel-ops.c | 1 - accel/hvf/hvf-all.c | 1 + accel/kvm/kvm-accel-ops.c | 1 - accel/kvm/kvm-all.c | 3 ++- accel/tcg/tcg-accel-ops.c | 6 ------ accel/tcg/tcg-all.c | 6 ++++++ accel/whpx/whpx-accel-ops.c | 7 ------- accel/whpx/whpx-common.c | 1 + gdbstub/system.c | 12 ++---------- gdbstub/user.c | 6 ------ target/arm/hvf/hvf.c | 2 +- target/arm/whpx/whpx-all.c | 2 +- target/i386/hvf/hvf.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- 22 files changed, 33 insertions(+), 43 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 688511151c8..3185659562d 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -16,7 +16,6 @@ void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -bool kvm_supports_guest_debug(void); int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); void kvm_remove_all_breakpoints(CPUState *cpu); diff --git a/gdbstub/internals.h b/gdbstub/internals.h index dbd6d11eb8c..dbae07d2577 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -217,7 +217,6 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -bool gdb_supports_guest_debug(void); int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index 9c07a903ea0..b23a0606c7e 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -84,7 +84,6 @@ struct AccelOpsClass { int64_t (*get_elapsed_ticks)(void); =20 /* gdbstub hooks */ - bool (*supports_guest_debug)(void); int (*update_guest_debug)(CPUState *cpu); int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index 07241f799a8..e961f37cd61 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -37,6 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size); =20 /* gdbstub related hooks */ + bool (*supports_guest_debug)(AccelState *as); void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags, bool *can_reverse); =20 diff --git a/include/qemu/accel.h b/include/qemu/accel.h index e740939908a..c520feaa38d 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -73,6 +73,8 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **errp= ); */ void accel_cpu_common_unrealize(CPUState *cpu); =20 +bool accel_supports_guest_debug(void); + /** * accel_get_gdbstub_config: * @supported_sstep_flags: pointer to store the single step modes in diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 58fb865ebae..ca0d4034e0f 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -107,7 +107,7 @@ int hvf_update_guest_debug(CPUState *cpu); /* * Return whether the guest supports debugging. */ -bool hvf_arch_supports_guest_debug(void); +bool hvf_arch_supports_guest_debug(AccelState *as); =20 bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp); uint32_t hvf_arch_get_default_ipa_bit_size(void); diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..1b4389c052c 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -9,6 +9,7 @@ int whpx_vcpu_run(CPUState *cpu); void whpx_get_registers(CPUState *cpu, WHPXStateLevel level); void whpx_set_registers(CPUState *cpu, WHPXStateLevel level); int whpx_accel_init(AccelState *as, MachineState *ms); +bool whpx_arch_supports_guest_debug(AccelState *as); void whpx_cpu_instance_init(CPUState *cs); HRESULT whpx_set_exception_exit_bitmap(UINT64 exceptions); void whpx_apply_breakpoints( @@ -22,7 +23,4 @@ void whpx_translate_cpu_breakpoints( void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 -/* called by whpx-accel-ops */ -bool whpx_arch_supports_guest_debug(void); - #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index 41f98937426..db27f96c916 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,6 +113,18 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 +bool accel_supports_guest_debug(void) +{ + AccelState *accel =3D current_accel(); + AccelClass *acc =3D ACCEL_GET_CLASS(accel); + + if (acc->supports_guest_debug) { + return acc->supports_guest_debug(accel); + } + return false; +} + + void accel_get_gdbstub_config(int *supported_sstep_flags, bool *can_revers= e) { AccelState *accel =3D current_accel(); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index dd2b45b7cb5..ecc0cd1b558 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -369,7 +369,6 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->remove_breakpoint =3D hvf_remove_breakpoint; ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; ops->update_guest_debug =3D hvf_update_guest_debug; - ops->supports_guest_debug =3D hvf_arch_supports_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; }; diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 49014de26d1..8ca6d9f5d32 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -280,6 +280,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) ac->name =3D "HVF"; ac->init_machine =3D hvf_accel_init; ac->allowed =3D &hvf_allowed; + ac->supports_guest_debug =3D hvf_arch_supports_guest_debug; ac->get_gdbstub_config =3D hvf_gdbstub_config; hvf_kernel_irqchip_override =3D false; hvf_kernel_irqchip =3D false; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index d7967bc922f..45330327909 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,7 +105,6 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 - ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; ops->insert_breakpoint =3D kvm_insert_breakpoint; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 0019a092d69..1231c010fce 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3833,7 +3833,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) return data.err; } =20 -bool kvm_supports_guest_debug(void) +static bool kvm_supports_guest_debug(AccelState *as) { /* probed during kvm_init() */ return kvm_has_guest_debug; @@ -4303,6 +4303,7 @@ static void kvm_accel_class_init(ObjectClass *oc, con= st void *data) ac->rebuild_guest =3D kvm_reset_vmfd; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; + ac->supports_guest_debug =3D kvm_supports_guest_debug; ac->get_gdbstub_config =3D kvm_gdbstub_config; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c179cd4adeb..927af6c1db0 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -109,11 +109,6 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } } =20 -static bool tcg_supports_guest_debug(void) -{ - return true; -} - /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) { @@ -221,7 +216,6 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->supports_guest_debug =3D tcg_supports_guest_debug; ops->insert_breakpoint =3D tcg_insert_breakpoint; ops->remove_breakpoint =3D tcg_remove_breakpoint; ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 2d2aab80d17..19d776faf27 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -242,6 +242,11 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool = value, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 +static bool tcg_supports_guest_debug(AccelState *as) +{ + return true; +} + static void tcg_gdbstub_config(AccelState *as, int *supported_sstep_flags, bool *can_reverse) { @@ -268,6 +273,7 @@ static void tcg_accel_class_init(ObjectClass *oc, const= void *data) ac->cpu_common_unrealize =3D tcg_exec_unrealizefn; ac->get_stats =3D tcg_get_stats; ac->allowed =3D &tcg_allowed; + ac->supports_guest_debug =3D tcg_supports_guest_debug; ac->get_gdbstub_config =3D tcg_gdbstub_config; =20 object_class_property_add_str(oc, "thread", diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c index b8f41544cbe..f38bd850ce3 100644 --- a/accel/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -82,12 +82,6 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu) return !whpx_irqchip_in_kernel(); } =20 -static bool whpx_supports_guest_debug(void) -{ - return whpx_arch_supports_guest_debug(); -} - - static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); @@ -96,7 +90,6 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; ops->handle_interrupt =3D generic_handle_interrupt; - ops->supports_guest_debug =3D whpx_supports_guest_debug; =20 ops->synchronize_post_reset =3D whpx_cpu_synchronize_post_reset; ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 247e12db812..db1d9d43744 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; + ac->supports_guest_debug =3D whpx_arch_supports_guest_debug; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/gdbstub/system.c b/gdbstub/system.c index 1421645c6e5..414aef431ec 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/error-report.h" +#include "qemu/accel.h" #include "qemu/cutils.h" #include "exec/gdbstub.h" #include "gdbstub/syscalls.h" @@ -343,7 +344,7 @@ bool gdbserver_start(const char *device, Error **errp) return false; } =20 - if (!gdb_supports_guest_debug()) { + if (!accel_supports_guest_debug()) { error_setg(errp, "gdbstub: current accelerator doesn't " "support guest debugging"); return false; @@ -622,15 +623,6 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) -{ - const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->supports_guest_debug) { - return ops->supports_guest_debug(); - } - return false; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/gdbstub/user.c b/gdbstub/user.c index 2cc851691f7..299388b9f71 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -790,12 +790,6 @@ unsigned int gdb_get_max_cpus(void) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) -{ - /* user-mode =3D=3D TCG =3D=3D supported */ - return true; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { CPUState *cpu; diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 8b902c68829..f76bd7bf55d 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2901,7 +2901,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) hvf_arch_set_traps(cpu); } =20 -bool hvf_arch_supports_guest_debug(void) +bool hvf_arch_supports_guest_debug(AccelState *as) { return true; } diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..ec65e332f9c 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,7 +295,7 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -bool whpx_arch_supports_guest_debug(void)=20 +bool whpx_arch_supports_guest_debug(AccelState *as) { return false; } diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 2d1a943b96c..bb8a070903c 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1067,7 +1067,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) { } =20 -bool hvf_arch_supports_guest_debug(void) +bool hvf_arch_supports_guest_debug(AccelState *as) { return false; } diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index e626acef2f0..95705522e04 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,7 +1853,7 @@ void whpx_apply_breakpoints( } } =20 -bool whpx_arch_supports_guest_debug(void)=20 +bool whpx_arch_supports_guest_debug(AccelState *as) { return true; } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857188; cv=none; d=zohomail.com; s=zohoarc; b=mGWO2YKj5URmNoEmr8JFifkUL219/Th4h42oi3NF8lkuNrUZDKvidK2wrS81lPx1hkaPanWvVZNHh2g6pyrv+Dd+IibmnwxY5PJFF3f2La4HW/PDq9JixcyU4pfPvgEv559OXIWvOPAGD2OfZVtfMmEmb+f5AckzPoPsAplitrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857188; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZHA9oyIZ+nrX6vsb6ZZDJzajrIq4tDDe95w5tKqJuSM=; b=SUtC2okJ0ntul9UFSq78kRIHVcu79G+1uAVck40stw5p7eyjlaWhK6/QZwv3t+wiGzwRRivl9+LBlkGb/qiSn+6ggi2UXzBqSlKNGawYqDpfBylA/8IoM3EPDi4nlGnv39COTI9JYAjmym357SUa7ptQDHC0KHxzc4UvkAVl5Pc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857188052800.4703904852776; Tue, 30 Jun 2026 15:06:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegZN-0005Ia-Ex; Tue, 30 Jun 2026 18:04:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXw-0003Lj-QR for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegXt-0003zq-EY for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:11 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDeLX2920093 for ; Tue, 30 Jun 2026 22:02:58 GMT Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8uf6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:02:58 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5bd4b488c10so5719033e0c.1 for ; Tue, 30 Jun 2026 15:02:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4540aesm26070855e9.0.2026.06.30.15.02.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZHA9oyIZ+nrX6vsb6ZZDJzajrIq4tDDe95w5tKqJuSM=; b=ZtghZkHqiS57XdSL GFtMjk1ZsYt3+Cd0r/tZEdCXGkbZlK9SoA45cjQFbVEMhiDiRzR3efRt4C/kcIib Lw3VEQSQG8Cfhknt7Ro6Or5Vzwz4CcEsv3xlp591lYJM/Q3zbIGXu24r4MP/6xb2 blDR0QKLP1FtdFaToecrYkAA20wcWYNK9fCMXkXLv5XK+aSElUIBO+uYEicXoIjS E/VidzuOLwgQPTdWso4Upmtz/hczHE5jkgnMeoADBL6E82nIRbcDDmQtrXV+XDP0 mCr0stSbm8/ayAZnVq1T2Wo2PNxTUyuY8+zimYqiKt7ubJNJRGczRDtZOIrBBwm4 MjCcgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856978; x=1783461778; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZHA9oyIZ+nrX6vsb6ZZDJzajrIq4tDDe95w5tKqJuSM=; b=DkEl/qgnRH978kkBsJEQPVFArNRJgKJkpVavN74bP4Ui+D4MI9VOo54IRxt0RF8Y/Y XxB1lQNBzKJNXjq4s2g6DKViEur3ciowWfFO5o7dyjSpMjCDn+dfTQxm2hgMKwI30+vF f9fY2vadoJ6EARbiosMCzTaabNS0DNYi6O5hlB0gqafiyaImEW+SNpRych6MTi2MIS8e i2wPKlllML49Yg+jXFlWc6plv1hOvGiQr5lJD26+hJsYo3stsWCURMqT6aQLZ434+uMe Pud3zAHIjGYAikDcQX4ZSq9zdc16j1wiuhz+ytigbSL4/LWAtnq8o3aHAujVCE/cuQ1i iT1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856978; x=1783461778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZHA9oyIZ+nrX6vsb6ZZDJzajrIq4tDDe95w5tKqJuSM=; b=JUfrlVKlmuMwUlT3Exzs94Ew/og3ipnCtSP++NRxvqG5xeE/chZSklouZMKX60fiWM hrr2Uo6YuqzXRkGMAFgKlxfLir4LQB1iuxLM3s8nYW9XwhpyKEZcyeuOlGI0uTxoGh4O XVXoieukV3C5X0gp/UQ4tZ4vLytFcLuNlC0yqkdRpJVICb31MfOW01p5+h2xeUVKjsEt zZVSjp1X+BwYREw8hLpW047Ry3v1wLtz9v5AD16II93oai7tfff2HV5K78MInC7IVakq YcZkPe58FJBg+AxGMc/WO7lWk8u8KoMVeXPtukWRg7OQ/c4hlCp9GrGEmHr8GUd6hBmc 2i3g== X-Gm-Message-State: AOJu0YxGh5tyvsGQ1ZMHuTHDsMzyZli5p7Pk46oSUG5gy8jY7qM3gVxK pa8I3czF9L9uYKMdm+RyTs821GdHYvmSzvs1/DZ+ZCWil8vKIE8MZ89R8PKrAfoJjXf9bdKOhru 5+aZVI2kh/mtx130IbKDx1aMKl0jcTCT6AMs3JwqRFchA6U/iK/l8XA102/Y44041fQ== X-Gm-Gg: AfdE7ck/38OntDNW2C/AC5VIXBysccbB1Aurcdx98aHjJF3YCfNpChbum8u/om7DVYe PFIyKw85JO9shwPnO1YGKWKg5iGxcFCZuZuDdr5oOiztGHMRdDvQHfaAcauTbEkpqGJofUWaZ1Y gj3CfZDhDLkVM/QoID9fpiVUGX+VhalD28oI8y1r0DIOSjVlJoYxdnWRdJ7esLI/XeXBXkRJ/+B 4CoPq1xVQkqCt3RJst9KGDN4Hw7E0CnBVTJkupBdzuZbg9Wl8dIeS2oyev/Gq1FAbwC75rCwZpK fV58yWHHKdJZPeDak7s3RqW9SD3CuSYscUhBKrN/7Nrta4Szi9M4dCagS71vOhcKZa3nyY4YH8E njQvPHl5LCs0P6yyc9qskv6JxXYiFhQ7ADAn8Fg828uWfMyEhlYrO3AK6NMQeFS6/Eez5 X-Received: by 2002:a05:6122:4582:b0:5bd:bcb1:453b with SMTP id 71dfb90a1353d-5bdbed729bamr2483861e0c.10.1782856977724; Tue, 30 Jun 2026 15:02:57 -0700 (PDT) X-Received: by 2002:a05:6122:4582:b0:5bd:bcb1:453b with SMTP id 71dfb90a1353d-5bdbed729bamr2483813e0c.10.1782856977284; Tue, 30 Jun 2026 15:02:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 15/33] accel/kvm: Hold have_guest_supported in KVMState Date: Wed, 1 Jul 2026 00:00:42 +0200 Message-ID: <20260630220100.1289-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: EgtqZDDQq9mmCOvsAnF1Axtq8TwpVSb6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX+QuoB9hWCpuO 471pSKiA3aRrx3u3qoErznsPOpuN4QtjccdZaRQNH/U5mt1N7T50cquqdIZwnkeMvTvWxQKmnYM 7tpeu82RKIQHtdqEXp904d/Luq3dH+A= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d12 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=O5kNlQXW-qQlE3Y8R88A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: EgtqZDDQq9mmCOvsAnF1Axtq8TwpVSb6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX7EgVTOzMKzM4 74QIIveT6qwPMH1UH+7N6trZ1RMNghhXW1NWJb8TD6lW6i1WH0OY2Gy7Dw6Be8DzK0KCahD3TMg XEc+4W9DFXZvFKTE+xZ/YvxfckNc89DXp0I98NWwapMmGZNdKM3xoe19+vcNVPcl+jpC1er9Ham 1T/62U6QyVJ1VFoHAnkh7YTgUQTNartOmy0jJBfIqMNCwsGO5s3UhUiqn6JK8dWbig5w2Z/YVBp VOivNaqBFyOA9HuCptGRx6N+khxAmNYiLDqwJonoheOaxpP16p7Fp13FTL/1mvWFIlDxig2x2L9 02q9l+Wz2iHV7KpLoPHntCLWNHhl+SUyEBW3ICdvUZCkScmCXsgtUxYM/XlwjInCZwo4MToHBfE 3I5UTUdsi8FUBd7Zh/wXWtoVj7jJq8HNElo8u1H6z/Gxz1B2gF6wUegPpFe35AqWSct4kg6Zhcg KyUX9tyRjpu4knMl1OA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857188752158500 Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 0876aac938d..49e90cc0235 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -113,6 +113,7 @@ struct KVMState struct kvm_coalesced_mmio_ring *coalesced_mmio_ring; bool coalesced_flush_in_progress; int vcpu_events; + bool have_guest_supported; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; #endif diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 1231c010fce..80d8ef1a974 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug; static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; @@ -3040,10 +3039,10 @@ static int kvm_init(AccelState *as, MachineState *m= s) kvm_sstep_flags =3D 0; =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug =3D + s->have_guest_supported =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 - if (kvm_has_guest_debug) { + if (s->have_guest_supported) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3835,8 +3834,9 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) =20 static bool kvm_supports_guest_debug(AccelState *as) { + KVMState *s =3D KVM_STATE(as); /* probed during kvm_init() */ - return kvm_has_guest_debug; + return s->have_guest_supported; } =20 int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857154; cv=none; d=zohomail.com; s=zohoarc; b=Ia3jKu3wRQ4X5XbMj187NGFGE1R10eITJXIAWJEcieasJTgZKy1paPWweZh7DxQRz4vIr0nwllVIVzR+H+iZW7xdDSpAOh3M73p6BGpHzqKzQZObPM5FyKGruMuSuDwZyo0BsVCTrh+zxEmuL7LCiJbjL/5lBywkDOX3gJWkL2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857154; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V0S5PYbuGLEoeTum/9hNHbmqOND4X4rpTeIikmvtXeY=; b=b8dIXCljOVb7586kFvxOCsDlKr7ROm7PYfwMsNZ004hRzDZM/+DmO5x1a+B/ZxQnoHAqcPeFcE34YN5RoboHiEGatChrOtO3y9R1NVNjuVpdjDLLQRVjQHy4z9HvqFOw8ARamPNu+6CqRzi2vWq3eGl3heuiP2wm6VE8xMY8do0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857154440401.18610425457246; Tue, 30 Jun 2026 15:05:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegaC-0007Rj-UL; Tue, 30 Jun 2026 18:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegY7-0003Y9-BC for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:23 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegY4-00045W-Gj for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:23 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDdmK2920073 for ; Tue, 30 Jun 2026 22:03:05 GMT Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8ufm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:05 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5bd797e447cso5841455e0c.2 for ; Tue, 30 Jun 2026 15:03:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4c7f90sm24212925e9.2.2026.06.30.15.03.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V0S5PYbuGLEoeTum/9hNHbmqOND4X4rpTeIikmvtXeY=; b=Fi9G2opCj14StcVv fHGtxanLPSvMP9t+qVIjDSpr/kCZq16BwgDKmj7JU0WuD+ern+v3fbbNgwhRo4xV WwHzf6MJAq0rlbs+6j6A+x90fhrFvh6jVkphXpxXvh2AAMsdaElY0LDpigYaVAzz EQ5qbM7TBeqCSdNkKivyqK7dd70olJaBRlf9MbJCVjKXjz2CYqUUz0UDQeVIzXWO 5Fjp/fyhM+tfn8QsSMg8scws1yA+K7LF8ijBHD4UNat8Kb9MsaUHmxUHNex9sbeA n28PEWkhgP0MTw3wYRbWZQfv/YjV3RbIlPEchMQABKlmtsBupYThZsiImawCp2Dc PV+IEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856985; x=1783461785; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V0S5PYbuGLEoeTum/9hNHbmqOND4X4rpTeIikmvtXeY=; b=CNEuo3dtMmJptHvBwawmndMarMHEo304OB9N8Mu7rTiXeAQPnJ6jUPQZ9lv2HnQgod Lhrw6ejkpuiYfNQ9yEqHYo0XffrhwL7vUd5MirHTBSyoD21TxuFaSMnf8euE1NPIIDbB F81dK0e4goHjSnnttsuwb/B3o3tAWDVxupF0hko/EHh4Q4y4qZPWwbUOPKYHIJT1JoNB pYmco//FpG+1IlbcpeIkuePqR+VlP8yUK6aDIwuaZRhKYTonpJcAQHAQ2cwIPQ5TvdVD a+GGAIBqPU2kAnl1TSN1N2yzaoIjmj5r/yNbZSx5rwRzea064Mi62SLz/B7bD8Sjy7JU cSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856985; x=1783461785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V0S5PYbuGLEoeTum/9hNHbmqOND4X4rpTeIikmvtXeY=; b=gUb7GEGhDQSZGrHa/v660WmY1bWtDujDD/jKY9gD4J48Jv6LQM6scllpTRGgIgzU92 xHi0rnyuqdIXZfaX5HQs3hnB2qa6xTV8BJRVTvx9mFZkhzggTt39REV7GA3TEQNCZsKv kr8ud7iQF68VBDaMiH5kwbB9G5KkZiQnoZt1vQttJ8AtNNWOT3VCjCUNHn5xq0ojwHW6 jUTkCEscUCsBpMyP+Vh7sn6gZfRJQ0A6GmyZSebY8TlnJDUuBYDs3RNPNiSYT1rzqdad /5XTDF0gn6rD3V++Kx7fhkeGyO+Mks3D+eYcfquJ+zQhSmkIpZ59teKwbJi5pFYvKT2t YKqQ== X-Gm-Message-State: AOJu0YwiA5o+ny6BFGhpYPSOrrghDNyx/ScKBa4SyL9xqCxAW7HVD9ao /yp+lHsn7FweMur8zitaeKYc0XrekOWgiL7FWxDXr2vL6q1Wt61hpLHnFZ5UT8wG1Syv2YlsyLN Yr3xEV2D48WfN9f03av73UMx5Gox6IsM5Bi25kCz9e+w9l//50e/xg1wG0tXgdSJfrw== X-Gm-Gg: AfdE7cnhb8BAZPEv+gXVbg6NOUQQz922RKnAJubUbuZbQMAMqI/lIvSCZS5sQt+C/xP z12tT6DJxIr2fygxOmFR48/2lzlxKlns3DA0hlg24RDn3MjQkFKAgoaPkBb6vVLkgVDevi3SC+E 2K7ndPssaUrA994Fkh+BTlUHi317hR0/sLLXzPZzSPo9AN67iEGgCwFWGByLYK44fFBwBM/ra1V +MLjrmQBiDA6U57kcfDrYPvUcfTi611KYP86b10lTPCTh00EzD28Ky3Xc+32lVeKAJ7VIEjlxoJ EMWrFcUOovyCDEs3VZZtara8kgvXB542s68g77pl6wArage3Bv1y8XBd2coOlMqZT+j2LrDzfF2 L3fT5jBugMBB9ws37HKXyX6a491ZIS8DNaFXjSiYY+5rLbhbn5Mvm5ujcC/1xn0SHcOAt X-Received: by 2002:a05:6122:6161:b0:59e:f727:4bb4 with SMTP id 71dfb90a1353d-5bdbebd1b66mr2662310e0c.1.1782856985080; Tue, 30 Jun 2026 15:03:05 -0700 (PDT) X-Received: by 2002:a05:6122:6161:b0:59e:f727:4bb4 with SMTP id 71dfb90a1353d-5bdbebd1b66mr2662274e0c.1.1782856984628; Tue, 30 Jun 2026 15:03:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 16/33] accel/kvm: Hold gdbstub_sstep_flags in KVMState Date: Wed, 1 Jul 2026 00:00:43 +0200 Message-ID: <20260630220100.1289-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: U2CHxaVRZNvulAL3N4dEBvuG8cofMbw- X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX7GSm/+lQaQBP aS8N1e0WEC0SZe7KtXmWJEEnZavBzQv47JrfVUS1HEM6FUFSfLTophSAtR9Rw+rZVquEI4J4o1L 7dmc/LBrDl1fdMn1Pdncgxer/Lockns= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d19 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=SyX2bNzGUzkgapdpcZcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-GUID: U2CHxaVRZNvulAL3N4dEBvuG8cofMbw- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX0pkVD9WXC4da 1hponIkLB5Jj90/cFYYlGYNb566z5tGb65XnANZwFy3+Bc0HdsBxapWHgZfexYRzuTzqI87yu5O Cke2xpg7ZgpnARfYKwRQVbg+uPs/lY4AB+xZs4raZPbijZx62rqHSkufANfFFnM+V8mNKMiXjSi 4aWlO0Gqq9VmhKqZbZh5r+qOmj7jDzsTTcbKu/eHze1n3UgzGauNWX4dQctxBZEt/BAGCAJ9IAq fswqnCgfHESiPLHOLs2tJ2rkwN18YQD+nAc46Xbt8z5m3PTrG2NIOW7aOBh7JS5JXh6y6Vh/yiT M+Q6SbPRGLmY5XE2RZkLZ3lJCVPGim0fWKSC4euoHkwGHD7m9rlpLvlaJ3SvzHQGW5beVyxCva0 1n2FgKc9mGsCe8z2CKYo5KInhorS1u1eZmNCIVo/JQj3+kbxglIkGtB9LkDzD/Gvvkx2cx3c4lo GVsVNgSVLU5fpyM5neQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857156752158500 Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 49e90cc0235..062759eaa01 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -114,6 +114,7 @@ struct KVMState bool coalesced_flush_in_progress; int vcpu_events; bool have_guest_supported; + int gdbstub_sstep_flags; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; #endif diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 80d8ef1a974..76c9ae6d4d4 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; static bool kvm_guest_memfd_supported; @@ -3036,20 +3035,20 @@ static int kvm_init(AccelState *as, MachineState *m= s) kvm_vm_attributes_allowed =3D (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 - kvm_sstep_flags =3D 0; + s->gdbstub_sstep_flags =3D 0; =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG s->have_guest_supported =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 if (s->have_guest_supported) { - kvm_sstep_flags =3D SSTEP_ENABLE; + s->gdbstub_sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { - kvm_sstep_flags |=3D SSTEP_NOIRQ; + s->gdbstub_sstep_flags |=3D SSTEP_NOIRQ; } } #endif --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857171; cv=none; d=zohomail.com; s=zohoarc; b=jgeXrisO5dydAqxzk1EPQRl/ZMQnJpoGnVdAbPYmPeWomUWVjYcaSb+6gJbhqho/8vcka8twJWnFc+51YzvW4PJ5da0XbgsJBU93Aau1gDPFx4yz57Xryqe6iHs9JxCTUwQc50C7MDou5OGfJc2T/iez8trnA16A6V24S23uhG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857171; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OijKqTgpoJMIkQ3TU8uTMw7WZJkBtSN0JpdlSaU0fwI=; b=epngs12jvFMnr7K/cVHHFNKuim1uMWH69iCKitiLxdil3Ouose00GbcMOoYmssbS9g77EeIcdGTzckaSXSkMFqBCJ4QKOM5KA8xbFEWQYbEOM98E/RMl3pGNjY51I5prL/hhgFIvUFPfHn3if86UjTGEFLoJvgZTIuFRUGtBxyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857171250642.084565522163; Tue, 30 Jun 2026 15:06:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegaS-0007vx-8O; Tue, 30 Jun 2026 18:05:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYB-0003lz-Bb for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegY9-00047Z-Fy for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:27 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDmIW2937296 for ; Tue, 30 Jun 2026 22:03:13 GMT Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a3yf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:12 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5bdaa7039d7so3329651e0c.1 for ; Tue, 30 Jun 2026 15:03:12 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2a9fsm27705845e9.6.2026.06.30.15.03.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OijKqTgpoJMIkQ3TU8uTMw7WZJkBtSN0JpdlSaU0fwI=; b=ERGTrbzsPGCWmfb7 0DaqqX14r+StzVohOz/hrmRcIvIW2UTFCWeUte+fppRIEJX0SShgCFao5LQKl/28 GT+qOJj2rveXwWnymgDhIXPKViz8rI7Cc65SRnpFTebPxUfTooEE9W61xqkfsjjw 40XLMDKS8EJDX7QJZFikfxYFtRAK7TTktIKUTVIa+HC6c5sgSHtrXKhjwH2CmTj2 QzHKUWVJMeSGlREtwCMHJcQ9LOSCVqp8225CCU59derRBO2YMDX7c+QMRI0hGpcy kz5w0doKcHWnxhSDT8w2qWP5MmZXY4XmnLvySS5wZDfVg2S3RzzSCoGyzl/s4y3n lOL4NQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782856992; x=1783461792; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OijKqTgpoJMIkQ3TU8uTMw7WZJkBtSN0JpdlSaU0fwI=; b=P4X4SyC0tIO9WdKWtBPwXQLxYv5qBClRyY4Z0m1cqhBpZO/vJcHjqgUZZoSted34iq JB2pkuUc//5YDQUjNCUChO59QMhZNaw3gy0AB4o0oRlbRj6KArJy1DO2hVE3XqrWDB0G KyPhvIC1nPjV98C0gPtQZCbnG4557IK0caK8T0YzbMe6FvzL8V8IPTr8dmeeAfSDno0v usYgdL+l2rXhlvZq9GjChej8E43gnIfCIykN4rYqt1BM+ykZeDxUHQZedE9rMnL8B208 Gsafc6srLnbJzdWM3M1LQF6QP2lCffGWpkeGNKSUF0yD32XgHXobMM0rkLZkiSVVBvte 8PFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782856992; x=1783461792; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OijKqTgpoJMIkQ3TU8uTMw7WZJkBtSN0JpdlSaU0fwI=; b=l9bASzv9qA3qW6yu9kclohzluQyYeH89Pc0GUCH9V58qd93gLwO0r2xAsNbVzhAuSK k9W33DSyMpdYVf9ewrM9hgT3ytI74mykxJhi+muAZJT/o7/N4SCqg44IBWWhrg9JgdJf Ar+1oSlHjb/QxeJr738Kzjrgofrupfy0akOk4wnfRv9tXzAKj1cRHrohmlXW77lQwLnp mtWP1w14erhG1e62RPVBj6K8XVmJpezJGUAjlWvu4J3pu1/qeDt8yKluQ51JnmxDRYjd BWtuPyo+H3RDWL48o49XEgJJLLD6mzqAaOCT/8MG7V/gB/GehA88N6f5f5Ci69n5Mkxl 0Ttw== X-Gm-Message-State: AOJu0YxVybVVXnXlYosMVTmfYSHn+0KEM3jilr0KrPt+mTjEE+9cpYYa aSHbrBcpufAOiqLPuHsKyayrmSUd/RTyr+W2UatysTme9cLxsF8iO5M8AqdQfwV8AOePSNkqxSS 682Z5vt+FEnnj75eNewTTYD6/HYDxkz0WlCR9GsMj09nCGxlnS9N5f+RhtUrvrJoVXw== X-Gm-Gg: AfdE7clo/EEriMfctEo0pDh0rAS4fWPVUHyAroYj4qvw+qPjHhe22aepd7/1j+PfBoA sN/pPj71Zx3vPvt0AAIzqNbbqOn3ZqD/MzO5I2+oZRckXT5OKy3cE5o0mi/ypjlCCUZ8TKbvqsM F6G0IgnD6dm9OUIF+voKZ9lPBGpyF0pp/KoKdk+XtJ14u1ylso9lOPxZtFGLYeCtecj9r/8yBF3 zLI2lytbi0aJS0FUOHuJMDbOwHdoprry9xACVetuqiqF3kFE7ml54R+Sw55UxwFeDdVDgRXiQbI z0tW18NI+OJibO/3t6yHNDO9XF6dGaS5nJk8D9dXQwtIRU0H0ruFVKZ16JhZr2u3Nt4oYqap2+g dMNr8HdVphEmEoRp/kaHl5DhhaANv7WxVHU9UZv1V3tjb/EIjlGVTQQO0muE/jv2v3eCB X-Received: by 2002:a05:6102:b13:b0:726:717a:696f with SMTP id ada2fe7eead31-73a38838216mr2991097137.25.1782856992390; Tue, 30 Jun 2026 15:03:12 -0700 (PDT) X-Received: by 2002:a05:6102:b13:b0:726:717a:696f with SMTP id ada2fe7eead31-73a38838216mr2991078137.25.1782856991924; Tue, 30 Jun 2026 15:03:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 17/33] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h' Date: Wed, 1 Jul 2026 00:00:44 +0200 Message-ID: <20260630220100.1289-18-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX9e8bZwNg7i8i dAYUXu+MpL9wClgV8NXLlYNJySjCJAUJoBVhQkt8wRXLdavuQvEYNcxFPsLXAmURDSgapeLm9oP 4g9DKLJwWekCTYkPs4Q46lxxWsJlS5LgVC50Ismv5DhUcR1nJttyKKjVk+L/IfQydToKSBopmU8 M2lQD7gRaRhby+8GV0C+uZpVKcniDWbo834qD3OEvDPg8R/9CBqTcZgkPYhLrUhDWo6KJPR/bBw yVA2pcoX3Z4rbQOuiZHlmHpJ7t/7d2fUQqhH8rinq3YoUz51SPeJL4Wo/5SML+vBJPHYayqvEZh 3dXqzgB/XcGByrcRBoQWSkPPh42s7FL5XXkiuny/kAs3uVt7uVgaRTeNXe2OSi4wlmhIWUG6iGD /xEC2eRwZGkGOC/KKr/X4koFBGXUaoxo/poZeVLn9Z0NyiePdGjU3GF2iuuGhl6LNspAbDgmb99 SYV7dX8gn3ByBeNrDVg== X-Proofpoint-GUID: eqD6KSeT_debOF5WKO3tFL91oAeQQ2K_ X-Proofpoint-ORIG-GUID: eqD6KSeT_debOF5WKO3tFL91oAeQQ2K_ X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443d20 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=yZPQLu4l72ctXTxYlJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX4v40on3shDQB srccBte7FAKw1cn/Qcq8WoYKj9WQSbibtD3C6fTDLuYYZuYGAIBQt5RNlQB9WZhgjlrbaiDaJwd wU5UqMe88hzHr5jt/IhTHZX/Ylz9lPk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857172647158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 95f0482e6d0..cc6fedd09fe 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,20 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 60a23d6f38b..b1df615792a 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) - int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857218; cv=none; d=zohomail.com; s=zohoarc; b=JsmrWvXS11aH4xhKqfqi/8i9PeuvZTQurrvaF+m4sbpSK+Ku7UCO2l3vOotkpYXVnXomaBdMkQWH/VVD93n+dOntKnQyQyT8N/yNBShHRQoFNFvxfpwRmNlOCuWetUOh0dNk6NhBuUtwLWaD+LCPS7CTjAJssykH97Nx4YPqXlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857218; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UJD193JYH6eXtqUqouyKXBBMb0BtiuibbtpVZ823ZUI=; b=nYdd40CqtrAZyA+iMSPCB1vKvVV1EPv9+8wtWd3Ms5wv4hSz7OvA/OOxBO1tu4XUCWwiLexPCGnCSKRxey/ZpXpQkJfd4TTVVtU1F8zpilKrHgNIUHFmMaALXGdUUnNO4H8Kmxt0FMBssnfgd6xgpahCG05GhX0e/euY1JAAsrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285721822191.85316048576647; Tue, 30 Jun 2026 15:06:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegab-0000XD-MW; Tue, 30 Jun 2026 18:05:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYI-0003wq-TO for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:35 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYG-00048z-E7 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:34 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDmgx2947194 for ; Tue, 30 Jun 2026 22:03:21 GMT Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4avpucqm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:21 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-967552ac7f3so1197314241.1 for ; Tue, 30 Jun 2026 15:03:21 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47563d195b3sm11829212f8f.8.2026.06.30.15.03.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UJD193JYH6eXtqUqouyKXBBMb0BtiuibbtpVZ823ZUI=; b=PdYZTKIV6w/qRj81 +Ucson9cd6ztToJkQKS/vekMVn+/o9/Vp01QJRUw2wYvSfq39GkvZSd+8ypgKy7w OofZZgtXO0/+KSHPWum3Rr2gOeh0n1IQsbNQ7v5tTGJexUAZk4why5VsBj2WmkIa I9U/wN+wBCGiHeKoLm1SC96eBR5Ow4tHHwx8/e6pbGR8OPhF3B+0s6pw7swe9/MQ zQEHTrvca7YvuHlQFAb9m+kLrmcP8U8yo8WpFpODm4IYcnMmNEXpVi7UU913mGpN UME+xqtQnyW+woEcWVehFHVuOACQdjkxG6s88wPBcYeRD3sMStEzJbjW4pGq327N gSl4XA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857001; x=1783461801; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UJD193JYH6eXtqUqouyKXBBMb0BtiuibbtpVZ823ZUI=; b=OlFutwtCuBKBThVVbtycpCG0TmvXqzHLw7qIr7HGju9UcK9BduvvTG9QFDWnIW8tlV QMl/0KevM4BwCpEI6vZaQjpLWlZHJx5qVW9zJAGIi/+SBrfFE3MMTwsSZBw5lW6GFUUF 39NG0ea+okIv6Cb0JHTKwMooPC/oCgOsfINFs4Y6aWqvKCUE3ZwdBk6jreKghRK9Ki+U EIpBuF6kbpLxQKbE7nz1V7OlnYXChRTJMs4TkgMh1Sl6inUJ7TQFrfURNU3PciSDfEtO XBHC07BUt1+uvR1p4/igPqHoOIS8fS8bYQNI2lAihagITFyZ1I9KftxFQoPuK1JSPPZG yn+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857001; x=1783461801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UJD193JYH6eXtqUqouyKXBBMb0BtiuibbtpVZ823ZUI=; b=tJv7VHk9wT4aMuN1ySQ207ObaY4JXHuzwPfzgDxOM1YQk/MNqwMbcQAtbQmAFZ1Kpq pGxStLjhrKQxcwPIz1B+aKyIX61U0v8MXhoCW9wjCzvZ2Vf4uGZ4PltDs2RziiA6gch4 /QK+219eRhferJdw6SEz4897c4RtiqOc80298qYrZOZ3m/Waxx9CNoaxQiuI7Aja6Jci tPK2RYnn8f0q8kBxfcq7UGkEx8zNgeK3oKFFt/5c4DDKxICXTYB5wQJyf4ELJ53axlpL aMPDIThEqjGqE/RBay9J0egW7DY11lKuvKST2QK6hu395k7VPI7vKOmrOsnK+zzPBkib fwtQ== X-Gm-Message-State: AOJu0YxSi3yAgjZSVIXETZqI6bMekuTi6EVj4BHAYflwEoVVAg3QGh2x LMtFZeDRQinVgL1Rm3IkVmHDT04FlZoLBMDUMXHxQzr9GGb85NGvcBj6spHf7v3Xt32W2/kQ5ok 3bOJuWp5UX7ZJreMoodp3c3+xo/0ra1VHryXtrYr9rVhedtO/ikjCnBvpuRcD5hWl2Q== X-Gm-Gg: AfdE7clCntgHb7mkBWk751GV0qOwrczepb8Dt4fUE+7ebTLhoW6jY/MSIyif2blVC9x f6i8Jr3+J+eSk4dJTC579w73DnjKXqZzTA4yCGQnY4iczvEZ3ZKaZybt7EIpY4gdCDeHagexAwl q42tHTfY6B9QOxDOZw2zWG2/Kmd5lr0Slw0LZ2hJNr2sZ058wn2t0hvnDP0BpUmXG3/sovYJvM+ 4RnuYNbshSX7JUOtl+t4H0JiiI/SdI2vVDs4RmOGg4sM/GFDK3e90wYjkEypQf4ClFxQ9gGnIEc OJCSz5TS/Wg0r98Q56BtbiVa/A2AIdeTafd4xuWmEQBbBYT0iK4J6/bL48bbUvM8T/pfdc5hi8u PDX1v4hHO/PQ6UyTvpK9WZ8ifUZpy8vZDNpghy+vxHjMpVlbUQOuJX3vcJ/dvFjgVcoIA X-Received: by 2002:a05:6102:6c93:b0:73a:9949:df89 with SMTP id ada2fe7eead31-73a9949dffbmr1304532137.24.1782857000433; Tue, 30 Jun 2026 15:03:20 -0700 (PDT) X-Received: by 2002:a05:6102:6c93:b0:73a:9949:df89 with SMTP id ada2fe7eead31-73a9949dffbmr1304470137.24.1782856999320; Tue, 30 Jun 2026 15:03:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 18/33] cpu: Define BreakpointFlags type Date: Wed, 1 Jul 2026 00:00:45 +0200 Message-ID: <20260630220100.1289-19-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: QiSmAq70T1yMtOS8_FZepbsl3YN6LcLP X-Authority-Analysis: v=2.4 cv=KqJ9H2WN c=1 sm=1 tr=0 ts=6a443d29 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=9jKa8Ys6bur2UUCdWgEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX5+1g5YFndfJl uNmOqu637dQ590Lf+8IWf4xi7Rm4Ll5shaKhGaww46JJyKQW4xX/AqFqb48SxKnBfUrS/GEKB7r 8LL+7USWuJ117vmjU0Hc1SCEQP+DWmyKrtPx7h7/WZ+Fsf20mgd0gNa/JQCTXs7Ar/QoVOlZjrf GOw/Z07LizDpk9qCyQZ7dVkII8yeA/HTKxj9HO8oF3D2DcXYaX9s7c43oGfQ41qvV0aUVdfZIRa 49B228kNkCJv2RW7PmflhETpIIic/3/rs3rWhDHIZ0FquaJPD/9Tz45bKUlALyNby/FuVLRZj2u x3A+u5AdMPQzqTqylmSFMObRRwedaTf7KnXNfGichfq63/JP/U+EkKPOJwsB9Dd2Ta9Cgl48sNG UPXoSLs4ULH2ZGdsPhcYWiH1Vva8ANAtcqDzA3Lq2eyJft5TaiPfy2yeTdMVvRiBpwtwpIxMyx+ MLTQAovqTzQGY2iZWOg== X-Proofpoint-ORIG-GUID: QiSmAq70T1yMtOS8_FZepbsl3YN6LcLP X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXwJiTlfnyq5+P UwZN3UHFoF3Djf4gQjHS8lThfMsSTgzJyrFGL7/q+V4OdgiF/46330ydXfYy8NKNHBpNqlNWShU X266Q//kawmfoqiaLh2WzQUnxs7sc0M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857219025158500 Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 3 ++- include/exec/watchpoint.h | 8 +++++--- include/hw/core/cpu.h | 11 ++++++----- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 11 ++++++----- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 8 ++++---- system/watchpoint.c | 8 ++++---- target/arm/tcg/debug.c | 4 ++-- target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 65 insertions(+), 54 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 710da12b828..f64d94b2b50 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -298,7 +298,8 @@ struct TCGCPUOps { * specified by @flags. Exit via exception with a hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra); + MemTxAttrs attrs, BreakpointFlags flags, + uintptr_t ra); =20 /** * cpu_watchpoint_address_matches: @@ -309,7 +310,8 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, va= ddr len, * Return the watchpoint flags that apply to [addr, addr+len). * If no watchpoint is registered for the range, the result is 0. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len); +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len); =20 /* * Common pointer_wrap implementations. diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index cc6fedd09fe..0c3cc0c8ff3 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,7 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +typedef int BreakpointFlags; /* Breakpoint/watchpoint flags */ #define BP_MEM_READ 0x01 #define BP_MEM_WRITE 0x02 @@ -28,7 +29,7 @@ =20 typedef struct CPUBreakpoint { vaddr pc; - int flags; /* BP_* */ + BreakpointFlags flags; QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; =20 diff --git a/include/exec/watchpoint.h b/include/exec/watchpoint.h index c4d069425ba..ba148eff3d1 100644 --- a/include/exec/watchpoint.h +++ b/include/exec/watchpoint.h @@ -8,11 +8,13 @@ #ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H =20 +#include "exec/breakpoint.h" + int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint); + BreakpointFlags flags, CPUWatchpoint **watchpoin= t); int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags); + vaddr len, BreakpointFlags flags); void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *watchpoint= ); -void cpu_watchpoint_remove_all(CPUState *cpu, int mask); +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags); =20 #endif /* EXEC_WATCHPOINT_H */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index b1df615792a..bea8e509a19 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,20 +1138,21 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); -void cpu_breakpoint_remove_all(CPUState *cpu, int mask); +void cpu_breakpoint_remove_all(CPUState *cpu, BreakpointFlags flags); =20 /* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) +static inline bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, + BreakpointFlags flags) { CPUBreakpoint *bp; =20 if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { - if (bp->pc =3D=3D pc && (bp->flags & mask)) { + if (bp->pc =3D=3D pc && (bp->flags & flags)) { return true; } } diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 7f7c208ba12..e2911e3aac6 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1033,7 +1033,8 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx, CPUTLBEntry *te, tn; hwaddr iotlb, xlat, sz, paddr_page; vaddr addr_page; - int asidx, wp_flags, prot; + int asidx, prot; + BreakpointFlags wp_flags; bool is_ram, is_romd; =20 assert_cpu_is_self(cpu); @@ -1499,8 +1500,8 @@ void *probe_access(CPUArchState *env, vaddr addr, int= size, if (unlikely(flags & (TLB_NOTDIRTY | TLB_WATCHPOINT))) { /* Handle watchpoints. */ if (flags & TLB_WATCHPOINT) { - int wp_access =3D (access_type =3D=3D MMU_DATA_STORE - ? BP_MEM_WRITE : BP_MEM_READ); + BreakpointFlags wp_access =3D (access_type =3D=3D MMU_DATA_STO= RE + ? BP_MEM_WRITE : BP_MEM_READ); cpu_check_watchpoint(env_cpu(env), addr, size, full->attrs, wp_access, retaddr); } @@ -1702,7 +1703,8 @@ static void mmu_watch_or_dirty(CPUState *cpu, MMULook= upPageData *data, =20 /* On watchpoint hit, this will longjmp out. */ if (flags & TLB_WATCHPOINT) { - int wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_WRITE : BP_M= EM_READ; + BreakpointFlags wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_= WRITE + : BP_MEM_READ; cpu_check_watchpoint(cpu, addr, size, full->attrs, wp, ra); flags &=3D ~TLB_WATCHPOINT; } @@ -1885,7 +1887,7 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr a= ddr, MemOpIdx oi, } =20 if (unlikely(tlb_addr & TLB_WATCHPOINT)) { - int wp_flags =3D 0; + BreakpointFlags wp_flags =3D 0; =20 if (full->slow_flags[MMU_DATA_STORE] & TLB_WATCHPOINT) { wp_flags |=3D BP_MEM_WRITE; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 927af6c1db0..26d34c72d9a 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,20 +110,20 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) { - static const int xlat[] =3D { + static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, [GDB_WATCHPOINT_READ] =3D BP_GDB | BP_MEM_READ, [GDB_WATCHPOINT_ACCESS] =3D BP_GDB | BP_MEM_ACCESS, }; =20 - int cputype =3D xlat[gdbtype]; + BreakpointFlags cpuflags =3D xlat[gdbtype]; =20 if (cpu->cc->gdb_stop_before_watchpoint) { - cputype |=3D BP_STOP_BEFORE_ACCESS; + cpuflags |=3D BP_STOP_BEFORE_ACCESS; } - return cputype; + return cpuflags; } =20 static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) diff --git a/accel/tcg/user-exec-stub.c b/accel/tcg/user-exec-stub.c index 28286e11a60..7b6c25c4738 100644 --- a/accel/tcg/user-exec-stub.c +++ b/accel/tcg/user-exec-stub.c @@ -22,13 +22,13 @@ void cpu_exec_reset_hold(CPUState *cpu) } =20 int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { return -ENOSYS; } =20 int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags) + vaddr len, BreakpointFlags flags) { return -ENOSYS; } @@ -37,17 +37,18 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWat= chpoint *wp) { } =20 -void cpu_watchpoint_remove_all(CPUState *cpu, int mask) +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { } =20 -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { return 0; } =20 void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs atr, int fl, uintptr_t ra) + MemTxAttrs atr, BreakpointFlags flags, uintptr_t= ra) { } =20 diff --git a/accel/tcg/watchpoint.c b/accel/tcg/watchpoint.c index c75ed278459..5ea66e9763a 100644 --- a/accel/tcg/watchpoint.c +++ b/accel/tcg/watchpoint.c @@ -52,10 +52,11 @@ static inline bool watchpoint_address_matches(CPUWatchp= oint *wp, } =20 /* Return flags for watchpoints that match addr + prot. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { CPUWatchpoint *wp; - int ret =3D 0; + BreakpointFlags ret =3D 0; =20 QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { if (watchpoint_address_matches(wp, addr, len)) { @@ -67,7 +68,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr a= ddr, vaddr len) =20 /* Generate a debug exception if a watchpoint has been hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra) + MemTxAttrs attrs, BreakpointFlags flags, uintptr= _t ra) { CPUWatchpoint *wp; =20 @@ -91,7 +92,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vadd= r len, =20 assert((flags & ~BP_MEM_ACCESS) =3D=3D 0); QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { - int hit_flags =3D wp->flags & flags; + BreakpointFlags hit_flags =3D wp->flags & flags; =20 if (hit_flags && watchpoint_address_matches(wp, addr, len)) { if (replay_running_debug()) { diff --git a/cpu-common.c b/cpu-common.c index 988d057d844..5afae9c1899 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -389,7 +389,7 @@ void process_queued_cpu_work(CPUState *cpu) } =20 /* Add a breakpoint. */ -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint) { CPUBreakpoint *bp; @@ -419,7 +419,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int = flags, } =20 /* Remove a specific breakpoint. */ -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags) +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags) { CPUBreakpoint *bp; =20 @@ -446,12 +446,12 @@ void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUB= reakpoint *bp) } =20 /* Remove all matching breakpoints. */ -void cpu_breakpoint_remove_all(CPUState *cpu, int mask) +void cpu_breakpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { CPUBreakpoint *bp, *next; =20 QTAILQ_FOREACH_SAFE(bp, &cpu->breakpoints, entry, next) { - if (bp->flags & mask) { + if (bp->flags & flags) { cpu_breakpoint_remove_by_ref(cpu, bp); } } diff --git a/system/watchpoint.c b/system/watchpoint.c index 21d0bb36cae..f96aa24210f 100644 --- a/system/watchpoint.c +++ b/system/watchpoint.c @@ -26,7 +26,7 @@ =20 /* Add a watchpoint. */ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { CPUWatchpoint *wp; vaddr in_page; @@ -65,7 +65,7 @@ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vadd= r len, =20 /* Remove a specific watchpoint. */ int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, vaddr len, - int flags) + BreakpointFlags flags) { CPUWatchpoint *wp; =20 @@ -90,12 +90,12 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWat= chpoint *watchpoint) } =20 /* Remove all matching watchpoints. */ -void cpu_watchpoint_remove_all(CPUState *cpu, int mask) +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { CPUWatchpoint *wp, *next; =20 QTAILQ_FOREACH_SAFE(wp, &cpu->watchpoints, entry, next) { - if (wp->flags & mask) { + if (wp->flags & flags) { cpu_watchpoint_remove_by_ref(cpu, wp); } } diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 07a52643e71..11043ecd589 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -550,7 +550,7 @@ void hw_watchpoint_update(ARMCPU *cpu, int n) vaddr wvr =3D env->cp15.dbgwvr[n]; uint64_t wcr =3D env->cp15.dbgwcr[n]; int mask; - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; =20 if (env->cpu_watchpoint[n]) { cpu_watchpoint_remove_by_ref(CPU(cpu), env->cpu_watchpoint[n]); @@ -656,7 +656,7 @@ void hw_breakpoint_update(ARMCPU *cpu, int n) uint64_t bcr =3D env->cp15.dbgbcr[n]; vaddr addr; int bt; - int flags =3D BP_CPU; + BreakpointFlags flags =3D BP_CPU; =20 if (env->cpu_breakpoint[n]) { cpu_breakpoint_remove_by_ref(CPU(cpu), env->cpu_breakpoint[n]); diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index dca4ef5a942..17f920b3f35 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -190,7 +190,8 @@ uint8_t *allocation_tag_mem_probe(CPUARMState *env, int= ptr_mmu_idx, =20 /* Any debug exception has priority over a tag check exception. */ if (!probe && unlikely(flags & TLB_WATCHPOINT)) { - int wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_READ : BP_MEM_= WRITE; + BreakpointFlags wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_RE= AD + : BP_MEM_WRITE; assert(ra !=3D 0); cpu_check_watchpoint(env_cpu(env), ptr, ptr_size, attrs, wp, ra); } diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 41edb18643d..913920d55b8 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -145,7 +145,7 @@ void ppc_update_daw(CPUPPCState *env, int rid) bool sv =3D extract32(dawrx, PPC_BIT_NR(62), 1); bool pr =3D extract32(dawrx, PPC_BIT_NR(62), 1); vaddr len; - int flags; + BreakpointFlags flags; =20 if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index b94c2997a07..2a3711fb1df 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1429,7 +1429,7 @@ static int find_hw_breakpoint(target_ulong addr, int = type) return -1; } =20 -static int find_hw_watchpoint(target_ulong addr, int *flag) +static int find_hw_watchpoint(target_ulong addr, BreakpointFlags *flag) { int n; =20 @@ -1575,7 +1575,6 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, { int handle =3D DEBUG_RETURN_GUEST; int n; - int flag =3D 0; =20 if (nb_hw_breakpoint + nb_hw_watchpoint > 0) { if (arch_info->status & KVMPPC_DEBUG_BREAKPOINT) { @@ -1585,6 +1584,8 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, } } else if (arch_info->status & (KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE)) { + BreakpointFlags flag =3D 0; + n =3D find_hw_watchpoint(arch_info->address, &flag); if (n >=3D 0) { handle =3D DEBUG_RETURN_GDB; diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 59edcdd3704..8b9d4bc1f4d 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -1992,7 +1992,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, } else if (probe) { return false; } else { - int wp_access =3D 0; + BreakpointFlags wp_access =3D 0; =20 if (access_type =3D=3D MMU_DATA_LOAD) { wp_access |=3D BP_MEM_READ; diff --git a/target/riscv/debug.c b/target/riscv/debug.c index 30d39ee5cd0..3046cc896a8 100644 --- a/target/riscv/debug.c +++ b/target/riscv/debug.c @@ -479,7 +479,7 @@ static void type2_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type2_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size, def_size; =20 if (!enabled) { @@ -604,7 +604,7 @@ static void type6_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type6_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size; =20 if (!enabled) { @@ -992,12 +992,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, C= PUWatchpoint *wp) CPURISCVState *env =3D &cpu->env; target_ulong ctrl; target_ulong addr; - int trigger_type; - int flags; - int i; =20 - for (i =3D 0; i < RV_MAX_TRIGGERS; i++) { - trigger_type =3D get_trigger_type(env, i); + for (int i =3D 0; i < RV_MAX_TRIGGERS; i++) { + int trigger_type =3D get_trigger_type(env, i); + BreakpointFlags flags; =20 if (!trigger_common_match(env, trigger_type, i)) { continue; diff --git a/target/s390x/tcg/debug.c b/target/s390x/tcg/debug.c index 99140b1ac9a..d10e9ed8922 100644 --- a/target/s390x/tcg/debug.c +++ b/target/s390x/tcg/debug.c @@ -14,7 +14,8 @@ =20 void s390_cpu_recompute_watchpoints(CPUState *cs) { - const int wp_flags =3D BP_CPU | BP_MEM_WRITE | BP_STOP_BEFORE_ACCESS; + const BreakpointFlags wp_flags =3D BP_CPU | BP_MEM_WRITE + | BP_STOP_BEFORE_ACCESS; CPUS390XState *env =3D cpu_env(cs); =20 /* We are called when the watchpoints have changed. First diff --git a/target/xtensa/dbg_helper.c b/target/xtensa/dbg_helper.c index 3b91f7c38ac..990012f60e6 100644 --- a/target/xtensa/dbg_helper.c +++ b/target/xtensa/dbg_helper.c @@ -85,7 +85,7 @@ static void set_dbreak(CPUXtensaState *env, unsigned i, u= int32_t dbreaka, uint32_t dbreakc) { CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t mask =3D dbreakc | ~DBREAKC_MASK; =20 if (env->cpu_watchpoint[i]) { --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857090; cv=none; d=zohomail.com; s=zohoarc; b=kcBGtbbW5kXe745QdA5yJFfFp2oHnZdutXOur6Xoi/8h7nXUjGGME4eeok1oGc92iZ+UffeDmRNp44gK+C+ekbpUbDGYoqPHyoy37U9/YNJsnZnxR0aFewxFGCZDVbzpirsH+VqXWVry4BSseutr51gWDtnm+k7gwp6G/WQ2Y6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857090; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RuLkuN6qYZZFkB58VCvqz7mMm2jVG9P1AWo3rZc52xk=; b=Zf+47m2HGtfQzXj4+2gS0Q6NbHoF26woJ4idFND7gB57J2P5oXvMKOhugvPd3hIlfoXRoWrb8dXd+ya9vVbASmDTNcjCd/VqAzTTH2QK6k8HE+Fuy6OurvN4jFFOG5Xrq3hIDup049UFoxpTAn529O/ao/qW+kdqA4iBR2wqZxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285709083210.021895028521726; Tue, 30 Jun 2026 15:04:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegYf-0004Y7-VU; Tue, 30 Jun 2026 18:04:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYF-0003sw-6W for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:34 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYD-0004BH-LI for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:30 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDalv2959923 for ; Tue, 30 Jun 2026 22:03:28 GMT Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j9113t4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:28 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7377e2f1a62so836564137.2 for ; Tue, 30 Jun 2026 15:03:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bfc32992sm9074735e9.11.2026.06.30.15.03.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RuLkuN6qYZZFkB58VCvqz7mMm2jVG9P1AWo3rZc52xk=; b=WVHklZzBF9PJHOQT Bbx7SdY27TxMGNKMoBGNCPn8rbygryqluHyfh4qIELhziibB1lxVfZ7OMmEdD79i UbjkWG7ME8x+rOLbCdfzH7+ylN5Wsa+vGjotmyWLPs2dFCfmz2Iyug8+uSOdVefq CaxXBAtnFgnPtgutaNWW24gQ/eSlynLIeL0PZ24OcwrtSljImItObKab23swLgaL 7DBDfhVTL9ONREt8nz5YMfNrvfgsHYdbQ6QCQsJwd/1vIMWJUNEOC5/hlaNvJ/lt EhOaJTFEE7OJHOjDUmi+EbN3FjdGMGfztkbck3yQqTPJIqzkP+rurHi4ZHxJEVFR 3gbTfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857007; x=1783461807; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RuLkuN6qYZZFkB58VCvqz7mMm2jVG9P1AWo3rZc52xk=; b=SuPv0VbLVNyi2Z/FCyKOpyfFr/Iz8Sm144pHXRRZA+RaK/1AVSoVNDoR0RE6jJ/QIh PWpIViQxn6UiDG1Ffi3nWngwStTYsJpHDfsj88UqV2kax+XrvyLvA+qjgPSGT8E4TypL fpkVE/wTVewOgjixqaqmuOpJHqkKm56FPaeH4H/XpfJ1aBXFCtbElbcbB5AGzxHpwTvA jH3MqPsDcaCLSv2O/rKz+XxW6SWilURg15Xv5EbEPj9SUJR6RRama33iCve6eKXyD05r /yE4bSfuRs7SWaAzKhWbhMD/usRnju6ouE7Izts9j+UZ2LGz2ENFOYelg5uvHPW8fMft iK7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857007; x=1783461807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RuLkuN6qYZZFkB58VCvqz7mMm2jVG9P1AWo3rZc52xk=; b=R+VB9uifLw8Cd8RCTPPKqUMXSo0FFZvCfG9hZ0AgXf5uwq5QeBStFe/otpoIADjm82 PdlvPXPEhdl8e2l7o/JwxsQbqdSgij5Iv0TX9gHKrdGeJAinWhuLuN9plz/CD/uOwUly KCHOGGvggdKtKC9hmyB4lqvI9hGrnsRRGq+ai8te6YiQ31cBn5y9rJDtfYmEBHxLF2Jw oYDhkbRvsmf27/zM6uzk1spaxpmLbqUv9ymvLauJ7YU2sGMYEZzkQ88x91W2aE5yO5gb +kw/X3o7PyPsF44DzjBAkhKujpSN7U79MJ9Gsy/ppvGPIPGSNhMW+6T7rTl/RGZDniuR DMYQ== X-Gm-Message-State: AOJu0YwblPK7MvQ48A+j8knErsVOx01WPLH4tZQ+EPBf2bzira7o8b8n l5j6HjV7Q1gIF1HVRRSYGSeBcY52cFGi3BKoKuh9iFBXKu694OxTE3kt7aAwSCgNM7U7fQSwR1R kSaKKEkiMkeT2l0p9c4xGlisjGiTqAmG2mMG10pgworxoxW48RixBH9X56md4ZsO4KQ== X-Gm-Gg: AfdE7cnS6K73binFIXg2VpDvjw0+RHVW+HO2W0t9/OB71azH34HifCUEH8y2Q1VOQNV UEVU53xUmbAVr6Z8oPojkobfQMABhclByAkOL5Xlwys9CDpMq223O4UtcuhSSC6/noO6lpwWmPO 1GcX9H/Ld7HHVoeecTuFYTDOWHdESTs35WJN0QXIKrHhdwMcQTxZPUH2Le8cJ0AS0YTe5wyrZos kV36J/56yL4xCLx6M83+69kdXmZyT2PUXnbzdLy1a5YBJfcIH77Q9Xt215F9WwTodccV+S7GnSa osvP8BXKRkFj156XFcx8usK32URAkVjwmC6f76G6t4nUgjQ7lOIDiYWLznc/n3/x19GzGqaXDwO eH+uoU0qDKBjqMUDU5CGjIH5XCDQpnQPRjGdaMVrvGkJaA7/3ZWYEANwBDOV3/pJsayKP X-Received: by 2002:a05:6102:3047:b0:738:ecd7:1984 with SMTP id ada2fe7eead31-73a35cf53cbmr2538066137.3.1782857007030; Tue, 30 Jun 2026 15:03:27 -0700 (PDT) X-Received: by 2002:a05:6102:3047:b0:738:ecd7:1984 with SMTP id ada2fe7eead31-73a35cf53cbmr2538047137.3.1782857006576; Tue, 30 Jun 2026 15:03:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 19/33] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints Date: Wed, 1 Jul 2026 00:00:46 +0200 Message-ID: <20260630220100.1289-20-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: e6nHdBw-c9uDbH0LawJMzhG74oK31eqC X-Authority-Analysis: v=2.4 cv=ftfsol4f c=1 sm=1 tr=0 ts=6a443d30 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Ucb4Co1tYGy3ov5cU_AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: e6nHdBw-c9uDbH0LawJMzhG74oK31eqC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX0/uPN2yKSqKs ViFChPHNggXCx9JkpZjt+r6S7GvPnh18frYHyNLSPei8Md+L+CZFDPyEdUs1H44/hJoin3pMTA8 G6z+9cfToIKwJTrN9Mjd3kmuvVIw6I7y5lecRxRsOKMHtaivWOYjFQhCCAoKqkqyCyGTUGt/8Sc 4rz4ckuSEu6xL0M8/BH3iYcj+bCkCQp/6aTBL+OOyjFzGc/O/+PQoeHMPReaWwiaK2kL+o+BEpZ +K80nBMXCdi+4ON28uDczrZ6IYLwzRCCTZMw3B2nkhDnPkP+ptwoy/Bu0FeCK/wHCs3cGKhsoBy 1V8EpjGHLyMZe/C6QRl/gZw43sVKo5S2cQe2zgpLGK1/EkXHE4Onzkc70vzOEIqiIE8AeMDEEld Qyi6zhGG/tRvJxhxtTrSpwh1EELlx8+yWVXf5oZ1lr0ugTjfU1qVGt/MYu3OXjz4sbBMmISNzHw c49xqlkDLsIm0/8FDng== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX6NdcmNEytjce fKoQj4dfhC83D8qKuLcwe4KBqCa8aaJPEL2kYuTn+YMPGsXvc2HkNfp9n3pFMQ/fGY7zMoed6rl A5j4uk0E2x8h94D/N5+LXuCm9X04U/s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857092396158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 26d34c72d9a..c54acc770e3 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static inline void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857229; cv=none; d=zohomail.com; s=zohoarc; b=G7DXby8OmYS91m4wwKuOl0Zcq41jqn9HxcMq8y4mtxIwR088a6qSZgIcjRb6+Ebj5eaAA2GBPkDpdHlRiiOnAkKVj92uHKmeSnsQAO6bw4YDsrO/0iUR9sYRrDuVhA8CJjUtQRuMv+DIZ8O5HfrlNnq0NktiQZJQmSAAPCwZlcs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857229; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GVNbbIjqhbtFIpRBVLuj1zsz36lqLsE5BS8cy9LUoPk=; b=Ogz7VNY4Ncjx8aeI/sfPpt2+Ni+0bnzSIf6z+Tb2ZY4uGrtuWuC5Pj74qDkz2fOhvsg1ylBYyxqWelRW5esEhzxYhhfYQLGJwlc5Df+UXILEo5PsQrmGC6ap2TWAFeIEFXczPLx0olLOfr8pfrENt/gCjiRh8HXGIMS4bxAUsBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857229485668.440891139549; Tue, 30 Jun 2026 15:07:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegaj-00014Z-8r; Tue, 30 Jun 2026 18:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYM-0003zk-Ba for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:38 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYK-0004Fo-SG for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:38 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDX7x2942523 for ; Tue, 30 Jun 2026 22:03:35 GMT Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j99h474-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:35 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-9692df7e2feso1397960241.0 for ; Tue, 30 Jun 2026 15:03:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2bc5sm25438705e9.5.2026.06.30.15.03.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GVNbbIjqhbtFIpRBVLuj1zsz36lqLsE5BS8cy9LUoPk=; b=Yl67PqgNv0DM+FZQ B1WFowkx77MIUQTQgt50cnjscJzkYP0EL55PxCrXf2fWJ7sVvTA56534BewkrvGS dgFnHH+2Dbp4T5uUolyAYGNnsfYyE83JiLXQz3cwmJ9GhZ1zP81Lm0TELH824M2l w9OG/uoZ5Ms1w1uw/YzOsSm+4mQm7rAo+HeSdzsQD6DlfJyrujfW2m6XuXQL/9+M giR7cCMVNrC7aPilI2olhLpR2WrLfyyYf6zmuKm87UXWlGAbRbICZt/KFYPhEY+H C5TKhnHck17/uG4CMEY/ifDdeTONQpdfXpxsd2jREbZTPYV9wuNt0tKrRkx52QPd SJyYfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857014; x=1783461814; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GVNbbIjqhbtFIpRBVLuj1zsz36lqLsE5BS8cy9LUoPk=; b=JVB17yhNrCCX8E120V+gNYunhUiwPJi/+dOTuA/Y/5zMgJWULdA1sb/qZVgKXNQE1+ IHsUJXBVbVmF3yt902bqxFNDK2AnveaYo2jmizz+xYlC/OpQhIGKLFr6s+G8FzZs9JEU xDsulLUQf/ogX7msytRX/T6P8FOO4OhpYdhZADu7pafAbguCRikq9ClMNtBcLIlRR5UP QBh5JeKVO6GsB0HrZ+82PFRUHk0zoKqFcErJeLs7x1rV2wtGG+VNlrfuT/yFzOcNPzoT DXlmKgyFLKhD3y2P5t3Ns20lglz/nwDvc8YalD8dMcsZ2FuRbto3aZE/UyghiBdeINqT crNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857014; x=1783461814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GVNbbIjqhbtFIpRBVLuj1zsz36lqLsE5BS8cy9LUoPk=; b=Ll/TUqan0aL3AnTbLztABLQfJwrgQaSmX1KKe9m3f4fLIoNcfFUYZKySZP44hXOJ/7 Y5mECklkI37VNwAXFvFLF3svprFANfmg/D2APaAry5wKX+o24NXZzXs+SheySAMXy+pE f77X2wZJJ4GOhyaaZKUJn+lC+Xf/BKCwLPvu0ZHuFrbAV8WiWOERF56B7jrLdL6mSVBb oVqWh0gy1H687Ve1bRjdYqSL2/Cc14w7JijdtaIcf6CPZjXGzYoTeBycLmGd7ekJnz4m 807upwzOQHTYpsxauzT8bkrELz7DFLODPUAuCSvCqB63lex60hGciqb0bX/M5LvhPpnc or6g== X-Gm-Message-State: AOJu0YzjnhLz9wJcdHNBWPfVjkb/VnmgOwMlKJcPMAFGMm/aLWhLu2PK Cvx6Y1F6EoRrj+xT6pe/nBdey1eAs/3AV1aC/Ald640u4gDk8BnwWPF9T6XKwMFhqoMXDRDNR8+ /VTqAZdykoz72rnvmFGOuImeupx0QOs1a2BX1LVhBt2GPoEPPkpsAQcXtBmXETsUujQ== X-Gm-Gg: AfdE7ckFvHIjeX8UU0Oilb6b3f4rRGAxUV7xTQFcoPcC2N+BLoIbVa/wvwZ+u3WhjRX 19jv3KPhDG8sVGs2Yepoccpehb/CwvI5xg9FHunVmsJgxw73MzNAhWInyY0CQIpfkhFMCPytBTK Ei9JzYVnIvzeXgpEjbt5HhoIT+npqnStSOJSSYJVfBzZshfyKkTPlR/6aoYu0Qnq7v8aHzOTbxv w4/T0VdE+Kpb+XOmedsNSx4yaQBFgM3VcbTTJ/2oFLJ/x35nhxueLI3pVFiGPj3AD5XHdOhEM/L keZpH+hz0ISGgR2msA5JM/wzEoVFJYOERgoxX2uLbCrlMLb6qfNuuJ4x2xfJ4J8/0EUe4S/3fS3 CRbJXpLwU4A3OOoH6DJQXCCHUc4jkwLZIACRL2sInNtsNJ2WjfF/dAaXgR6ucRsEADg/g X-Received: by 2002:a05:6102:6442:b0:737:9003:ac4c with SMTP id ada2fe7eead31-73a36bf1f6dmr2269273137.10.1782857014311; Tue, 30 Jun 2026 15:03:34 -0700 (PDT) X-Received: by 2002:a05:6102:6442:b0:737:9003:ac4c with SMTP id ada2fe7eead31-73a36bf1f6dmr2269251137.10.1782857013903; Tue, 30 Jun 2026 15:03:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 20/33] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode Date: Wed, 1 Jul 2026 00:00:47 +0200 Message-ID: <20260630220100.1289-21-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX/tReSmcmr2cZ wNpKfrWcNcFgT9tVD3zc5YUCMghm9twNRe4MyGA5pdcJlZVcVroSgE3gDxxdTPJ1nWLHNHt9+w0 8CnbbD8Gqc0OBt8QY7MIigWz6ujHLek= X-Proofpoint-ORIG-GUID: 4n4xqrwSkXHYFPNuTswSghsN2zmBk4jX X-Proofpoint-GUID: 4n4xqrwSkXHYFPNuTswSghsN2zmBk4jX X-Authority-Analysis: v=2.4 cv=bNcm5v+Z c=1 sm=1 tr=0 ts=6a443d37 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=zxLOgqzoZ8asriTz2EMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX1T/JC8LQtPfJ 8fsip9HVqatkSZgC2p/7cp8nL6dZlGSKnXYQUbH1Zy/UwnWhrlwvMYAQEU3w6EorbKt6jymbZiD rxMX3u9uJm4l5Oj+5ikLLn9IjWwlbfBZLX3d7yvsOgE/XAzoTGD0I5k9RYKBuBB7NSxiiAPPrjJ W1BKcPZnkiwoQ6jfd7WCRiOcqucxdY69QZdBG2rTzh3l5Wcj6ZkqJiGawVryJx1M0MDgowbGZVS ic2ctJhJxJU1BGN+M2bs3NuFQ3YOGVn/E7uhc5wlSmlvifV4gZSLOjxaDrp23JRRl9ml4Q0uSMS X0XY3IiG8p0ih6ICfk/xqTnTSzzQkBttBOmXzlw+NxYefL8WGrtTfVna1kn5by0wvWNe5/+93Nd NwO1FzLXVLU5mjg0+TJxj4ebGcKUip5m6ZvpQ2XEDUVJF7oQ1Hzjb0K+jmOMjZOcftPnu48JG7s Rh5lYLLBwqdKkQgwNpA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857230954158500 No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 299388b9f71..90d6ee49fb5 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu) close(gdbserver_user_state.fd); gdbserver_user_state.fd =3D -1; CPU_FOREACH(cpu) { - cpu_breakpoint_remove_all(cpu, BP_GDB); + gdb_breakpoint_remove_all(cpu); /* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step(cpu, 0); } --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857092; cv=none; d=zohomail.com; s=zohoarc; b=WSZ85qqdp85R7xETVp3Dx18qx97Y+UFnK4ciWz0XlWWBK44ZRre4XWFTObAxTpPGktKr2m/Fo3NIYpYWjCFd2KnhJtnD2xeC/hyE/2scjc16OzFfZKK3I16bGVPBZnt90kNupuhL0euVRtWJn3jkdWC1G+ww7RZitm3Nje3qvfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857092; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4afQmHo8cpFkcr3t656DgTb/EAnwe6mE3Xep8ewUoKU=; b=FuAPacCxQiU0g4TaRceBa4gPCMUAj8IbR01HIfZY6EMklNli+S48V9Nyv7oFDMOEVZDHKOCb/sJaSdFxwEdUBAptQ34h2aF/n7O1QdCJ4UtsLXUV8uD2avSsOMOqWrXFgwjeoDGBZsnOM4erYoIO4eeJf9xXemesqGpKxBv000k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857092523811.6912026764307; Tue, 30 Jun 2026 15:04:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegZJ-00055l-GK; Tue, 30 Jun 2026 18:04:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYd-0004Y5-8F for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:56 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYb-0004JG-RS for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:03:55 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDn112937324 for ; Tue, 30 Jun 2026 22:03:43 GMT Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a413-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:42 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-967973f71fcso2595181241.3 for ; Tue, 30 Jun 2026 15:03:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4bfdd5sm43078185e9.1.2026.06.30.15.03.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4afQmHo8cpFkcr3t656DgTb/EAnwe6mE3Xep8ewUoKU=; b=POHChKvgmtAcRdWC pvomBsUrTYNhJCm4GqTyidl2K73+2jGexg2ffnHdiPA59dGWdL0WqtpcCh+3M2pZ ixPHHUiaIbE6llxT81W+kRTKjtOBiuHhTYkA994ZLqM3dD+kLTtlHqi1jZF7rbIU FRSUvq6u4DWXUTnyibM1oijvBAx+Z4MBNQAMYT3kA7GJcM9xz0EW/sj7tASyQUDx dST8UGz+PowlxjQXts2hbjr39x2PnfqJSIkfSpzTNel/+L81Q2yuV/Y6Hd/XI/WH kNRoJhx2rktCBR96FZwmGacJwXhOtRIDeKY3ow/zcpdnCavKNzDhYOtmXzkkOAUA K2CXWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857022; x=1783461822; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4afQmHo8cpFkcr3t656DgTb/EAnwe6mE3Xep8ewUoKU=; b=IMXwXmABZai76iR0tWtqS6OAi4aADjqTQFWbpefLnvJols1CcBzU9+s9EAzBlvEhX7 IAVlUjFwcpYeI20PaCA/5/o7OduzuFZi825I9bLzCQRBeH0kUp+tKOHGpmyjvEHNMA46 x/+kyeM6lDI5dTiMt8XgRyzw6iCMn8Wf6jkSWE3u2AC2QYSouiK+apbfkMZH0/ZcTk7O ojLoi9BSIys/7mXcuHd28pF84NCJ4uajnz3tuccUujCR+pJBhbaCc5f/OHt/8uGaEcjR /g7A1x2+AauplfknOiYgQpa2lw0IHVQMQFdsJ0KRoMzPyYfrLJs+L5hhqlf4gVv78lds bigQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857022; x=1783461822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4afQmHo8cpFkcr3t656DgTb/EAnwe6mE3Xep8ewUoKU=; b=dylZ1bInzD2cPzzxw56sCf3h0yJdyZbVdGo7B8wR/+yZ40YZopQmQGAYp04B6DyXK7 /z1kwtYFkBG/rsdhiWrt5ABf8tDOd0qr4PKiEvuL1NF6LgCrIQotDCHGFq75lFR9WWQA 9geSSZQS8mYiRkdmvY72/ikqU/BFnyUEDsRIEdoSIFgaDqZJ+xogZtf3KpIG6m3agpOV 3pfOnuU5teCfzbxFppKSH0allmO4uHdTJBew4Y4eIKyhs7QxLLxK/HpG839Bo+smLOCN yhmvkHaLlTUtcrwAb7GKBqnKG9c8JhAJ1nHZQCPDje16m5gejm1hqVTOD9pJM6sgWdFD rOzA== X-Gm-Message-State: AOJu0YxeklgMYEy1npvZXuRmkMalQu588hHryHOGOv5UMP98XYj4dETe CA98NQ0nrjevVhn2QXVDrPvxaZzfWyxKrO7WfW3DPAzWdCZybs2PBqfSoYIpSHX5ZfJ7y02uxrN JjEfZDC9Gy1JuuTHFaVIE77VwK3ayE/SXY+WicdxtybIDKwBVMLond7ARKcoLIh3org== X-Gm-Gg: AfdE7cnWi/LvyN7NJGysM1Zavb+pk5yizGG3ivvpP9yR2xzExNkuRcXgrMctTQy0Goi LdcfH9ARA1LiDfJs6M151enN967erjggT8w1FThzdqa3bbgEuVhrZSUEs2WlUBrgo0IeSPqjQkz 4yQ0qsTruIRV12IPK6yBheh9lIdlNYy3pJHVhYectJo0GNP9W/+ayL2t9XY1osw6xip1jxrF0C1 XYf0nT3+zNcDGWzjDU3NVEe2Yv1ZmLaHYv8q3V1c8Zbc3Oy0hS5v7ULGmLpkhDHg2uzrXbJldza UjEY6pJw0FHRoenciugwNW61ybVqmLBnFZibpfq/JiJk8QGcAJ13H+HoO3ay5BqirV3+YFPKq3u 19qfuKHpkJrmP5s84XS6JafFt/RPzckX+pUECM6xUCdrMTiPTavEHMgcd6GBxBEdQQq5d X-Received: by 2002:a05:6102:3581:b0:632:29a5:2b28 with SMTP id ada2fe7eead31-73cb8965054mr1529419137.6.1782857022074; Tue, 30 Jun 2026 15:03:42 -0700 (PDT) X-Received: by 2002:a05:6102:3581:b0:632:29a5:2b28 with SMTP id ada2fe7eead31-73cb8965054mr1529387137.6.1782857021344; Tue, 30 Jun 2026 15:03:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 21/33] gdbstub: Reduce @type variable scope Date: Wed, 1 Jul 2026 00:00:48 +0200 Message-ID: <20260630220100.1289-22-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX9EqmaCPUmdNT /4WXTB0kojVdFpSDTIZ8z1CE6+vqdZNkDPqwsLvyzyRqRC7xMWV8+ImKm5BK56Do+4B3aM/kIMG WUL9cqfK5iv0tCXUQlNhsWTbWMjj93VxuZn/p5vhkSNlQv5IV8MEGM8cBA8ECPT/9O80wF4C3ht HwNploxnfWsjWVKn4sqbxtOFhHKjYqirxi6nYDuYu/dWD059n9EKOk3wRFoe6fKLxoxfHOx/bO+ t6RssEIk7GRjeCBoZKXvPIeiRc1LXbqxcLQ2yki8LMGvl0oEkK3OoXRWZpTbnM3aEg8zYshVhwn dz3cxhubb3b5W2oWBZnM4oEeTlQSITK8yBxAAJQAGWCy0cZwLYnV8tioZ/d/2zpLCkAztOP4xpk zPNhYiBPIam9mCsmPP5TGm/ZIxLdu3+3hwdgcA4T2kMCNlkZe8+lJhapu+PtcZlTQ//I9pQPGe3 R3uViB5iLAFwy1clJaA== X-Proofpoint-GUID: jUD3gWBHWZrBAkvkSxjwdBDPO8XFiotU X-Proofpoint-ORIG-GUID: jUD3gWBHWZrBAkvkSxjwdBDPO8XFiotU X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443d3e cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=hlJWfxa9TtAqEMqpIbYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXx/TN8f3h6jXt Mhy/iuZ0fQqBqz3fBDXrccCuL2dlAnMdM5+Bh0vd7B1I2qR6TNuWQLY4aqVsNq8EMVzGk2NRb/l l6Uqb/nDtunB7w8LsPgwPGX7bgV5Bk4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857094166158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbstub/system.c b/gdbstub/system.c index 414aef431ec..d5e09802323 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -126,7 +126,6 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) CPUState *cpu =3D gdbserver_state.c_cpu; g_autoptr(GString) buf =3D g_string_new(NULL); g_autoptr(GString) tid =3D g_string_new(NULL); - const char *type; int ret; =20 if (running || gdbserver_state.state =3D=3D RS_INACTIVE) { @@ -152,6 +151,8 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) switch (state) { case RUN_STATE_DEBUG: if (cpu->watchpoint_hit) { + const char *type; + switch (cpu->watchpoint_hit->flags & BP_MEM_ACCESS) { case BP_MEM_READ: type =3D "r"; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857215; cv=none; d=zohomail.com; s=zohoarc; b=Ear3Acvw8BCRiCg8AfDaMp+1z2lmaAIUp8y/Q5Jn2N4VNrpfAeuxAZF2a01e5fDBX/IDDuc7xIvbhC+HfAd203W16NtUhsyj3obbup7439Ei+bpmLKjfMZQ0xTCPpgKon2RDFbyZKfKaEVcCXPtceupM+SW17kLljbfkHnob2m4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857215; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XqsW3jF+bUaGdQ+jOxxItYl0PoxDnV9eiRVyCqh6JoU=; b=SV/cem1T7nfuzB2rAg/k8r9jrWsI0WKCPTD/+mJ+srbDLMKBoNZAkL/8mSkxY5ZwE+kYLAjSGXkNsM0qcj9YRNW85aVNl/z8lnMUMt72UCwQmTSxHdVu6znZ3nqaVG8kgykSgfIxREQ0pXE1jLOrkxtvgRRakv3xAkYJRqk+KBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857215128969.8532344580032; Tue, 30 Jun 2026 15:06:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegZy-0006KE-NZ; Tue, 30 Jun 2026 18:05:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYk-0004mg-NR for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:05 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYj-0004Mm-5r for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:02 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDmlx2937291 for ; Tue, 30 Jun 2026 22:03:50 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a41j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:50 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5e38fbc5so458581885a.2 for ; Tue, 30 Jun 2026 15:03:50 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475641e4542sm11945682f8f.10.2026.06.30.15.03.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XqsW3jF+bUaGdQ+jOxxItYl0PoxDnV9eiRVyCqh6JoU=; b=OIk5jXMxqRu0IuWT hypuhKyrCHZtUL6K6KbQ2/qQ9F7k5lYynIDL9Cmu05T7PUpP6E4P6C5EPD6lhxIF N8MK2ywW/F5VToTYQjSuY7+iSkeLcfi4Z2K/MQnnpfuEipm0eKu6hqDCjZHNIMYS YzdjxJBnRYQcDHXcUSO9WgzjxvMTx10MbxhdOaxBjy3S76VrClP6ELWbInr1Ve+q nZx/eiquWILa9j8YDmYmeDFQMw8BeHijFhxlbxeBAVM9LfaHSjNsWFpf+WyN3LXh rydbOTWcWq+A7Z0OkhYo1ogVML/ABjjk2AfyE1pn2447DNOShmgtn/2KmPqEnCUA AEVcZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857030; x=1783461830; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XqsW3jF+bUaGdQ+jOxxItYl0PoxDnV9eiRVyCqh6JoU=; b=THBP++4TSRafKzj6qdp5GaMSe9EEQqG3DQjSy/sa3CyARW0TwSzK39bm+5lqU3IAXB S+X8alPOInjzISkdVJj9ZadTR+yLZ1sno1c1TrUfgzpLXlqG2IqqZWL4zjNsCYCDpvk/ feisctZtrxpomTPwiLGL8MpuJ2gBb7e+oXyCi2rQSGCqTTVKZG//pgZJYNhDcdrrFUId Ee9dV0Qi5YyXarUWEMPOMhT0/p69kvBeLYhrqRY1uvRD6s/HhMgGyZypxf7KtvEfI7Yd QsMfoO69icxQHPqTYZd64qKOZDr5t1lRDWe3cC7rtB8AVE+UC3+B7p/Nofa7HfKBCdEg +WMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857030; x=1783461830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XqsW3jF+bUaGdQ+jOxxItYl0PoxDnV9eiRVyCqh6JoU=; b=Eq9nV+Mb603sYu0Dll08y2oInbb62L02qtNb3X/XiZ9bvE03g2/v1Bgcn+FxwBKHZr vMdkIElrtiij9iTM/PuCc/3cjaOKXgwxj1Nymd4FnT8dyRwbxUrkk2xUHmZ/Up3Mu3UH h/9egMSFmR/Hi7meLKtbxqTuW0OB9kTmaXdfht1hJHhBsGdl2AeFZc6i9wp/aalyzTfg ku70dLRPo74H/ov2aBB9TOFBeRah+nUwkdyNQPgdL/v2Fwnw0SnD3yM6rt0Lnh9vih84 gi6XrNdjLDjJ3GFqcXR89CquS7aaC9GAZgHpMYlq8wC/pc2R2H7v8z2wdzKJ2MO9IVPT fwpQ== X-Gm-Message-State: AOJu0YxRGZu/8PPNmaSopkry5H74jxjPvJn6ZU/O3ExaNHFlSnK3epKA nRNe23rYP/e7cRbKmSIfZU5tG2MXvauTGx+ntTwpzgPu1chwsP9l8zguvqI+p0k1lsS0TiFQO0S DyN4nbysi+s5is/9qbcE1FFKbecsl3r96zy2XWSjuT/67GJPEGKBVOSG0S5Kvjtowiw== X-Gm-Gg: AfdE7cn9ZSu0tWJ9vVYvxkv1GIXPr3wVv9Ecf+dGz1PoBNJnoY8pmLvmJxJQE4hS7eO o0yi9ZtnKCjyiSPAYqF07Zj2Vf2+AAaAeZtBk+Ujj+23XSbcpFO6lTv4JD2ZAGuOmyZbffX7rMY BKKkenl0xP8WuETQ+ddqMhVBWQUuFitXYzDCaErDHPyyCRLE8NuHv8WopDTqYXXqvrzhCPjQ1XQ T1tLwFKoL2DJ0HQ50UDtueLFg08cbV8JvXFcdvW4at4el3a/88G40KneheLZ5YET/XlgM9rg+0k mKVabD1sHYuuY4MbRkR5H6USX+O+kpsZU6NPhcCuPVvLZFZhgnqjOb2jsArAeyTER12Lq1jI2uP 5rBnUk57H0np7iVQhLpOLucWOYpIwItR/u5+a1/btzqCrqdNi3iNHUUbpa+v+dUrIgueq X-Received: by 2002:a05:620a:2316:20b0:92e:6a0e:a194 with SMTP id af79cd13be357-92e6a0eb438mr396068685a.36.1782857029477; Tue, 30 Jun 2026 15:03:49 -0700 (PDT) X-Received: by 2002:a05:620a:2316:20b0:92e:6a0e:a194 with SMTP id af79cd13be357-92e6a0eb438mr396063285a.36.1782857028942; Tue, 30 Jun 2026 15:03:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 22/33] gdbstub: Introduce GdbBreakpointType enumerator Date: Wed, 1 Jul 2026 00:00:49 +0200 Message-ID: <20260630220100.1289-23-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX84ud3q284qg0 FPwZvJj9nKQbnr09MSNDitajUlciJl1kS95wRvlcBg2Z+AVgonkLvXTq2wmoMUf8xc0CNtb8Vly s3Sq7T0mgfkkQN/zJwUZ6eObDTWbJQ2Ls6V7HPRmV2m2qdBWj1xr2yz3PGVzVxEdqyq+hB112IO szwVU12ZN4QABWrbItdQRlRQkrJmtqSq6JtdHwSGBw03aWr1n9uhxHSXXFhojr2243PVDjzP3Uv ggXSaiD4ukoJEGEH1tDDwwAXkW+zBaLF+ivQeqM+PekeFDGclUDOtxG6sfQjXgWjolu4PutQTeF B49CvdTrukMCe0zbng7R7jibTt63GttosqBQiE01Nkqi09lHrnmEmRkZQZh2hvkYg52WeBcttJA MRIEcwqJHFelEm9yqlalWGkoAqnikTSXSSWTM1YrhbUegVSUdVxS6Oh8v7uWKAu2mm/DgS/61pG k8z4h069saVjIQYsDVg== X-Proofpoint-GUID: bi9MdumjqH5HHDZC9Y5wCDVthec0KoLN X-Proofpoint-ORIG-GUID: bi9MdumjqH5HHDZC9Y5wCDVthec0KoLN X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443d46 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=z_0bWbdd-CfuK1dINPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXyQ4HJR991iFO HRf1sEbJM2EtGKWAUKk+oWVw0BTrIqIGvbYy38my92aA2hz4YPSMBXFjR9P4y98JpVGSBwxhuUM G6saWnyAvXTVk/bxgTcrAaX4ldnfzxo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857216932158500 Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index dbae07d2577..32f2520d2ea 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -10,6 +10,7 @@ #define GDBSTUB_INTERNALS_H =20 #include "exec/cpu-common.h" +#include "gdbstub/enums.h" =20 /* * Most "large" transfers (e.g. memory reads, feature XML @@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); =20 /** diff --git a/include/gdbstub/enums.h b/include/gdbstub/enums.h index c4d54a1d083..e4e2043d92c 100644 --- a/include/gdbstub/enums.h +++ b/include/gdbstub/enums.h @@ -12,10 +12,12 @@ #define DEFAULT_GDBSTUB_PORT "1234" =20 /* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { + GDB_BREAKPOINT_SW =3D 0, + GDB_BREAKPOINT_HW =3D 1, + GDB_WATCHPOINT_WRITE =3D 2, + GDB_WATCHPOINT_READ =3D 3, + GDB_WATCHPOINT_ACCESS =3D 4, +} GdbBreakpointType; =20 #endif /* GDBSTUB_ENUMS_H */ diff --git a/gdbstub/system.c b/gdbstub/system.c index d5e09802323..abeeebea8e2 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -624,7 +624,8 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->insert_breakpoint) { @@ -633,7 +634,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) return -ENOSYS; } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->remove_breakpoint) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 90d6ee49fb5..9e6f9a6f376 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) } } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857232; cv=none; d=zohomail.com; s=zohoarc; b=SbNirikjX9TBdeSxymBU3/wkh4oR/2b/Wob6R6si1p0BDEFyvfINU99GyEAsXNxyykW9Sjf95+jO8+UaBeLd/nP9XvzSydxFhHxGyMhSw9wCKZf6aPQ2Kf+BlwTL2wU0L0N3fB+epBz6Ug+Yvjh9X2rb8ONfiVusHJrr+VL5MmY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857232; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7aTagKYur6HTG2r0Mh3fw7QvUNonzShR5oBYBSVVdGM=; b=WoG9Ql9OH4DGcfaMuvLf/X5lSnU2WXQjrQDVCjXDkNIwlQQq5OZsAOK4ZQ0q7zttdUkJ8grxFx1+ItNHZRPPp6ZjCoRrTtLmUZywGrjnKPcSPYNJ6Nvkh1VBpBpjBTF5n5hDI0noCWs+j5Gy/ab3BTCl/fDmlxU06941+O4rj+c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857232342494.647324945983; Tue, 30 Jun 2026 15:07:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbX-00028n-HN; Tue, 30 Jun 2026 18:06:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYu-0004ya-Uw for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:18 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYr-0004Nv-CZ for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:12 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDdYc2920076 for ; Tue, 30 Jun 2026 22:03:58 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8ujf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:03:58 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92ac0a54110so945706085a.2 for ; Tue, 30 Jun 2026 15:03:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4bfdd5sm43108475e9.1.2026.06.30.15.03.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7aTagKYur6HTG2r0Mh3fw7QvUNonzShR5oBYBSVVdGM=; b=U790P6LSdRgEMn7F 3De9Kgj8zyi9tMoB0nV1/ruWoZTB8SrvzxHzzEtJ/mv9nKAfmi6RmDgWxQAyY5W2 IHUO+x2l6+xf5G9A+l1STTfEBZXW4U9EhkfIODxAhPpadETqf4ycAUhtku5YYmw7 oqusqX2Hk7l8mkFlWgPG16ct3uUMn+NqlCGbIf7p/W7MCeXtdZCRHwe3Pw8yx9Nq G24w6qfpb25UoNWAkoxQosVTl9SRUQAVOReYYdIpwZCDKz97+klFjf1a77PHxxkb fCosCqh6BTrdwZaPj6aJtogAkBjxR7kdlDyVV7Cj1/1FTBiAqsRKG+zvhcr7TzQx xUPOvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857038; x=1783461838; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7aTagKYur6HTG2r0Mh3fw7QvUNonzShR5oBYBSVVdGM=; b=LN95GTBdz1LfYt08X6XGfeDkUsyKa8B36xH04K8RXNp5flOO2p7xgR4w1xbv3E+C+K /z/Vfp/oK3wphb0YQ618f8kwWQ4tfa8QLyElVTBJW5qc00VmP6uwLYF3tBMTbRZnD09m 4vsDNPHrCG+yPv2x9GabyTfMXc8/DPa10hg2x7nMaXPC+p87uFOuU37J8z4A/OrhTs0+ U69QzDZKtiOYsNO/PHYqGQL0HwIckxjpQhjbqE+W1m7p/cGsgRyhqxFfk3MXNU9BpAew dKiQaPthYCrhPZdDGPAfBouuPvJioLQ5TAfzKuuFWyyeUaymHyHcqlC0zPdQVkTJ4S4s SM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857038; x=1783461838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7aTagKYur6HTG2r0Mh3fw7QvUNonzShR5oBYBSVVdGM=; b=ZpMe71x4iUKAc0kWXeQgQj0jDVbq5q6ByiCBo9PTmTF+hRf+7CRvlQyjUAwIXLAFrG utQSCAn2+J5IFq+ouMpGNF9OrVimV81AkqZszsa7P6WzEOpQCV1qyn9fno+olo4+yUc+ I29ui8BhAG/ixWECXvc1drTKt6DKwNjqhx+hb0y+o6fI0ELVvlSfj4KRllRnWOJ3h/ES 3m1jGfEQ5Dys9LVqGnpZnSUcePDRCPusMixIFJcCdqwrP6+Rjb1KuMuoV5mTGyycANwT 7f1u6Pb3WNr7xlNcL3KcHhJ3LPLOQVQyKIl/lHzF9x2Px3QFdVJUTNVG63B/GD2wpyE1 V30A== X-Gm-Message-State: AOJu0YyXQzgbAsxQ7dTs81ldzlR0/q1ZRSFcshbQR/rBfdkVwyyTcIGk tyLGpd20ZCTArNULWaKDbt15tvAwj4rqwFijXHKXBbE2Eh5GX7UKkU737A8WPV19DYTithQajdP yuL5bMKba1ndNVem34jyZHM0ifmnVfPhNmg0j79P+pf0u5idqZoC/55FTDOrUCoVEKw== X-Gm-Gg: AfdE7clWT6D/Rq8CJW1YdlGd5OZfG7aCcD7MiQoaofrev8QoagdNd31IE25Ym1gbVmU Mya2Ob/kSlH1OCipDN7rX1aHmTXN118bhOgXN22keU1v8mAGp2gPk3xjgG50WeCgFZRsBRrHT2k xIwgxLoFbD2AWjnjoSRcaLLl3sNpyUHp+G3/yKwhnYXs7/2exYbPTV0JBBBYqv39wueAU6XSwb0 O/SlfnxRZWbLhslousBHZbTgHxKzR+YhgbdWX/7r3xDO7oYnM82Cc+mvZKX6DOF/DDjfqmzMtkQ t5KNgMle/Cs1vM4rCGzjfcq4nsHDsdCRKQDN2O/dbEras6hBhC1N/LZR4y4AAZcrol0cT46aqSx DLGOi4exjDsM8iPy5v3fh4U/ND6e5te6ykPdOe0nmhWpfA2+6eKWjDia9qdjz1rcHygXW X-Received: by 2002:a05:620a:4587:b0:92e:520f:1631 with SMTP id af79cd13be357-92e6d7dbf63mr417522385a.1.1782857037446; Tue, 30 Jun 2026 15:03:57 -0700 (PDT) X-Received: by 2002:a05:620a:4587:b0:92e:520f:1631 with SMTP id af79cd13be357-92e6d7dbf63mr417511985a.1.1782857036384; Tue, 30 Jun 2026 15:03:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 23/33] accel: Use GdbBreakpointType enum Date: Wed, 1 Jul 2026 00:00:50 +0200 Message-ID: <20260630220100.1289-24-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: grsP-o5Vr8A58Flv3KebibkXni_cdlkX X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX/hhQa8f/U6VU hKGBEDsQ9WTgeTX4OjzdQ0cFEILjkHPrzh0Kad6JxUhZULyn1ppRaoOHwvBqWZunkxV53Si0ywZ jAokk7ROKnB5mXMw4sANmYXjH6eAcpU= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d4e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=3ju8K9RUK9U4PsQW3zkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: grsP-o5Vr8A58Flv3KebibkXni_cdlkX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX2k/XSdwQao6h AGjexe3JweCCRa2fL7lUnaAs8iIAkTP6J1d0RMQ75YcNLMUq2QGJg1SB4axNud7UvtvXUBnArqM MuLL4UCLpAo2shPwbq6CNFBTpTKnaedgpjiWE+Qk8zTSfMSULYOtiCf1LodiiAPR+yJdISqnD66 TZfcpK8lCI6XygsbMqBknsBEeq0kq7FmmEntJb25IuQYUlBvA0wZVq7FeFDszCVsdjxcgbPlaD7 NPrwym0fB3s9y+WwW0MdcY+r2Hsbi78ahPHWngiGqhUEN4HkYicdJxGfrXo8FX3Yc6JQHNbMCDS hTZO7LCNzvV+tb0yiaLgAz/CHXD9qnOEjg2qTjY0y0VmPSVqc90OD1/5ZeqP81U1rxYQEwHCOAO x7hMetforTi8R8Df9SnM2vqFRYoOQz9I/6hbLy6f2FLIua6nvUAFRzz3iNMcXirEANcg2QI9QbW pmFEf5VVTrOjiDBQKtw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857232952158500 Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 3185659562d..bc2dd82e68e 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -10,13 +10,18 @@ #ifndef KVM_CPUS_H #define KVM_CPUS_H =20 +#include "gdbstub/enums.h" + int kvm_init_vcpu(CPUState *cpu, Error **errp); int kvm_cpu_exec(CPUState *cpu); void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -void kvm_remove_all_breakpoints(CPUState *cpu); +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu); + #endif /* KVM_CPUS_H */ diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index b23a0606c7e..f0c7ee7542c 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -13,6 +13,7 @@ #include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" =20 #define ACCEL_OPS_SUFFIX "-ops" #define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX @@ -85,9 +86,11 @@ struct AccelOpsClass { =20 /* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); - int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - void (*remove_all_breakpoints)(CPUState *cpu); + int (*insert_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + int (*remove_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); }; =20 void generic_handle_interrupt(CPUState *cpu, int mask); diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index ca0d4034e0f..9cdc622929e 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -13,6 +13,7 @@ =20 #include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h" =20 @@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu); =20 int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void hvf_arch_remove_all_hw_breakpoints(void); +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void); =20 /* * hvf_update_guest_debug: diff --git a/include/system/kvm.h b/include/system/kvm.h index cdd1856ac5f..714b8c7b011 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -17,6 +17,7 @@ #define QEMU_KVM_H =20 #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h" @@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); int kvm_arch_remove_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void kvm_arch_remove_all_hw_breakpoints(void); +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void); =20 void kvm_arch_update_guest_debug(CPUState *cpu, struct kvm_guest_debug *db= g); =20 diff --git a/target/arm/internals.h b/target/arm/internals.h index fcce3804f34..067c3f2b8bb 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h" @@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc); =20 bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); -int insert_hw_watchpoint(vaddr addr, vaddr len, int type); -int delete_hw_watchpoint(vaddr addr, vaddr len, int type); +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); =20 /* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue(CPUARMState *env); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index ecc0cd1b558..d2276d8513e 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu) return 0; } =20 -static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&hvf_state->hvf_sw_breakpoints, bp, entry); } else { - err =3D hvf_arch_insert_hw_breakpoint(addr, len, type); + err =3D hvf_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D hvf_arch_remove_hw_breakpoint(addr, len, type); + err =3D hvf_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static void hvf_remove_all_breakpoints(CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct hvf_sw_breakpoint *bp, *next; CPUState *tmpcpu; @@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } - hvf_arch_remove_all_hw_breakpoints(); + hvf_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { hvf_update_guest_debug(cpu); @@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_state =3D hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D hvf_cpu_synchronize_pre_loadvm; =20 - ops->insert_breakpoint =3D hvf_insert_breakpoint; - ops->remove_breakpoint =3D hvf_remove_breakpoint; - ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D hvf_remove_all_gdbstub_breakpo= ints; ops->update_guest_debug =3D hvf_update_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 45330327909..c8e7aa38709 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->insert_breakpoint =3D kvm_insert_breakpoint; - ops->remove_breakpoint =3D kvm_remove_breakpoint; - ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D kvm_remove_all_gdbstub_breakpo= ints; #endif } =20 diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 76c9ae6d4d4..e8ed85f9a3d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3838,7 +3838,8 @@ static bool kvm_supports_guest_debug(AccelState *as) return s->have_guest_supported; } =20 -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3861,7 +3862,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); } else { - err =3D kvm_arch_insert_hw_breakpoint(addr, len, type); + err =3D kvm_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3876,7 +3877,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3900,7 +3902,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) QTAILQ_REMOVE(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D kvm_arch_remove_hw_breakpoint(addr, len, type); + err =3D kvm_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3915,7 +3917,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -void kvm_remove_all_breakpoints(CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct kvm_sw_breakpoint *bp, *next; KVMState *s =3D cpu->kvm_state; @@ -3933,7 +3935,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&s->kvm_sw_breakpoints, bp, entry); g_free(bp); } - kvm_arch_remove_all_hw_breakpoints(); + kvm_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { kvm_update_guest_debug(cpu, 0); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c54acc770e3..028265c2efd 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,7 +110,8 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, + GdbBreakpointType gdbtype) { static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, @@ -126,7 +127,8 @@ static inline BreakpointFlags xlat_gdb_type(CPUState *c= pu, int gdbtype) return cpuflags; } =20 -static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_insert_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -157,7 +159,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_remove_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -188,7 +191,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); @@ -216,9 +219,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->insert_breakpoint =3D tcg_insert_breakpoint; - ops->remove_breakpoint =3D tcg_remove_breakpoint; - ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D tcg_remove_all_gdbstub_breakpo= ints; } =20 static void tcg_accel_ops_class_init(ObjectClass *oc, const void *data) diff --git a/gdbstub/system.c b/gdbstub/system.c index abeeebea8e2..108fe4bafb7 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -628,8 +628,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->insert_breakpoint) { - return ops->insert_breakpoint(cs, type, addr, len); + if (ops->insert_gdbstub_breakpoint) { + return ops->insert_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -638,8 +638,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_breakpoint) { - return ops->remove_breakpoint(cs, type, addr, len); + if (ops->remove_gdbstub_breakpoint) { + return ops->remove_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -647,8 +647,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, void gdb_breakpoint_remove_all(CPUState *cs) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints(cs); + if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints(cs); } } =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index f76bd7bf55d..530af305efd 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, stru= ct hvf_sw_breakpoint *bp) return 0; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index bb5969720ce..dda6946ddaa 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) } =20 /** - * insert_hw_watchpoint() + * insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point @@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc) * need to ensure you mask the address as required and set BAS=3D0xff */ =20 -int insert_hw_watchpoint(vaddr addr, vaddr len, int type) +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { HWWatchpoint wp =3D { .wcr =3D R_DBGWCR_E_MASK, /* E=3D1, enable */ @@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) } =20 /** - * delete_hw_watchpoint() + * delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ =20 -int delete_hw_watchpoint(vaddr addr, vaddr len, int type) +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { int i; for (i =3D 0; i < cur_hw_wps; i++) { diff --git a/target/arm/kvm.c b/target/arm/kvm.c index a54ef51ec2a..01f42f42538 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)= "); } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index bb8a070903c..f5c1df18c14 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, st= ruct hvf_sw_breakpoint *bp) return -ENOSYS; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 64cc421abe6..1e09155e92c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) static struct { target_ulong addr; int len; - int type; + GdbBreakpointType type; } hw_breakpoint[4]; =20 static int nb_hw_breakpoint; =20 -static int find_hw_breakpoint(target_ulong addr, int len, int type) +static int find_hw_breakpoint(target_ulong addr, int len, GdbBreakpointTyp= e type) { int n; =20 @@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int = len, int type) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D 0; } diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index d6539c12acd..beda6965f8c 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 2a3711fb1df..6bdfbbd68d6 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu) =20 static struct HWBreakpoint { target_ulong addr; - int type; + GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS]; =20 static CPUWatchpoint hw_watchpoint; @@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struc= t kvm_sw_breakpoint *bp) return 0; } =20 -static int find_hw_breakpoint(target_ulong addr, int type) +static int find_hw_breakpoint(target_ulong addr, GdbBreakpointType type) { int n; =20 @@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, Brea= kpointFlags *flag) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { const unsigned breakpoint_index =3D nb_hw_breakpoint + nb_hw_watchpoin= t; if (breakpoint_index >=3D ARRAY_SIZE(hw_debug_points)) { @@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D nb_hw_watchpoint =3D 0; } diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index f0de5c3071d..3300f6f71b2 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2206,19 +2206,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { /* TODO; To be implemented later. */ } diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index fdef8f9e8ac..195e39df032 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, in= t type) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len= , int type) return insert_hw_breakpoint(addr, len, type); } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int size; struct kvm_hw_breakpoint *bp =3D find_hw_breakpoint(addr, len, type); @@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len= , int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoints =3D 0; g_free(hw_breakpoints); --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857295; cv=none; d=zohomail.com; s=zohoarc; b=TcHJltNku0zyGqI/+shbOEdgH/FJwdXIegpXU9lg5c7dpXSe+WYaVUFiNyMSH3XkrVJUsgiiMzNy0TDQhjcDLImrfoSdr/qW09amJ3ZKL916fgSSOkwPDoRNXbmFAzvbtsSp02rUPexvIZH/lCedq7BEfNX1DzkYqH5/0JQXVVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857295; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ze3VwnuFzJ65mEN2sr5YLNMtfENgVZhXXeqCsKTvnII=; b=CM+pgQ4xTC6VGDR3Nu5neKI713IXwQL8P6lpQ3dJFWDwQbfGK+AZZsaPT2kSHHgl8j1Gk3L5lJ12pyk5j2a836DCFuJXouKH7iQG94Vn8PwxxhMtidijYnkMN7ZjypRj14hCC4LRSTtQjKcbL2G3fsePyotvmhCAZwAgP9oHxaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857295574842.9402332813546; Tue, 30 Jun 2026 15:08:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbk-000351-OB; Tue, 30 Jun 2026 18:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYr-0004ur-CE for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:16 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegYp-0004Oz-K0 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:08 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDZFn2942559 for ; Tue, 30 Jun 2026 22:04:05 GMT Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4j99h49b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:05 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-96927e59ae0so4734507241.1 for ; Tue, 30 Jun 2026 15:04:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef183e7sm17391395e9.2.2026.06.30.15.04.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ze3VwnuFzJ65mEN2sr5YLNMtfENgVZhXXeqCsKTvnII=; b=Gz4OKvlT8Mqe+tsI ChfHOa90uqY2HyYVddnJqd/734VEKSpOo+aFPaFG4Mbw0Jp5Z0Y0rRMh0/XFDWmh Zk49FBgM7lpRDYFkP/PK4yoVbvTXatmOktH5zaP2376VE0I/4kN0FdXxoyZqK93L k46FoP5C/JNdzJUWskKMArsFGh5ay0MTTqd49QxQLc3RNxE07ps5O0v6/sxdTY0r ARNSWod+NRjLVJlLGjiJbJG5pMQo9eOXgUHQzZbLikG/vvRwDt3NgRiUQwDjhsiX 4V0FmHdIgOhmSxlLwMPm4LCKBqet6t4IjvOekfjJEaunC3dwJDZRN9TI9j8npP2e LQutqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857045; x=1783461845; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ze3VwnuFzJ65mEN2sr5YLNMtfENgVZhXXeqCsKTvnII=; b=DfBGLDKa4qPLqb4UlRe2GqQQ5ec4afkONAufkxQp4QDKl8YqETC4Ye1pELHgMOX0kq kc1bVXt0XqDoSAo+40SAx31tSIH9c2ealPsA9ZM6eLIisGJAj6tjqLd/8Gc9HFm8Nx5B FAYLXBVldRwgBjO5rcH96a+ztu6F/bxzGGP26vFYyFiKZEE7Q1VzDKTkJUEZeinrWukM eJ9yhY4W0b3Vh8ELSnOWzTcNnMdCS8hrVSGUk11ok1TUTTNkLR0yzoA9ZEhy1zlnMVnx wbl/XyCL+TZRlufpV72SE3IIUaCluGnfoJefCBNY8xgwZLwE3ySaifwacE75Wu/p6PiD uCIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857045; x=1783461845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ze3VwnuFzJ65mEN2sr5YLNMtfENgVZhXXeqCsKTvnII=; b=rpCPdW6mnsoWc+6jNpobQKwTT1dMK4pwwO4T71RsEBA9YkB7bnDKCcK7ekctSpmJlE 5U6EcDCUPZFtKJDUP/4Q1KfvU1YU6om+XFwObFhtisSkmafhhfABnnOLlBg4RxRrexGO CWNQZhqmVAQQlkcQ6hWJ83XFY59oytakx8aTil2vKR01wswhYasNIHNNmbUp09Xj5mL4 XtnuXB0YBhdPiRzftFJdAtf3iavdOTRwilK5k/O1lONp2UKJkegBVC/FjtAc6fs4W9sN Wgc/tklWkS7actyqxfWc0dbX/jvy7a/o2CrM5/gMFPLO0KQAVVdwQiJuIYg+rTTvNhuA vTDA== X-Gm-Message-State: AOJu0Yz8hQGyDaCuq5+MNNZxs4M/8Gqva8xNm2ITaRDL/cLNcW1lTla/ 2YdJp5zNFfKmA3m1aQXwiuW3tmH5qqJjT7uLMQ/KoJI7M2yEIm3nawl9R13A/DpA99klXu5gfsJ 6LeQBY7KweHWU/+NsvKlb6QZa2zP8nTQZ8FHBKg4s2dg+JGvYA+AKKcQa/XDyBD7q0g== X-Gm-Gg: AfdE7cmLWES9qwGpNKl5XNfLACKtrfvMgTvlU4a9GUnSqsv8Ox4psPsgT2K2l7W212K 5w27SyuQRZ0qFQcBjWaXGvYG4X4nop/U/GDEZ7BZyozP+b50CUmT6cmdX6dG1ixvhmKmS6W7jDT lwikuBYh2S+9LNg0LO6g/nZQJXCeY7n5R7zbSO4Er+PUIYWX/7Tm5/1Toacs5/ODyZF66hS5qiy 4ReRQsJEizA2cTdCzggNOcJkSNJCxXUvH6voZwl5Yr/k5GYXc/UnyHdw8RUJynHU1qg2qMa/2pG lwsoo0NXjAX4GMQcjy14SMP9KD9PNcdJBaVH+TMulRAXSpSZ5U7JqcjDlvfQ4LeprRRBcN16Tn/ VtATUxW5I1aTzhj+/OpLtKu25lx7t1nK4jnVHCdiTaVuxRfRtPLx+h8+zcQeaXwxgL9mS X-Received: by 2002:a05:6102:5986:b0:6c6:432c:84d3 with SMTP id ada2fe7eead31-73a36be6ccfmr2840971137.12.1782857044571; Tue, 30 Jun 2026 15:04:04 -0700 (PDT) X-Received: by 2002:a05:6102:5986:b0:6c6:432c:84d3 with SMTP id ada2fe7eead31-73a36be6ccfmr2840939137.12.1782857044191; Tue, 30 Jun 2026 15:04:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 24/33] target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint() Date: Wed, 1 Jul 2026 00:00:51 +0200 Message-ID: <20260630220100.1289-25-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXy2exCpFZqX/L 9kK7cGwDvTxpwcMLUF1BvKEnfDUIf7JSS1SfMYFHBj2lU/kwcqcMlamzR1Pm5RhFXvO4hEExJUl PQ+swNarRi38jVP8mSzt0tJ+i9uOstc= X-Proofpoint-ORIG-GUID: PIheCbG1m7fmV85BjnwfSAq_oefhwbib X-Proofpoint-GUID: PIheCbG1m7fmV85BjnwfSAq_oefhwbib X-Authority-Analysis: v=2.4 cv=bNcm5v+Z c=1 sm=1 tr=0 ts=6a443d55 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=PgT5FCoeLhrUO_exnl0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX3o+a7lJ0J4EX OU3tp655v29SYccIszfy/8lWJ0GEtkMrA4+wXHbtamNZ7EmsJcIrTdUJCcc9FV2HYk+y3F6RsYB mBNESXhq6smy4R+7Yx8mydv5B8OAEb8qT/bM24uwMkmXnbp5H3jdyP+jF52DkI72/kxnlTNdekg 0BLJS2be0ifgy63q9uybUtIQ88/6N2IszhosMlPJ5F30uvhKuA4UY50d33orkLnmO06ZVKz0Bxh 7sOHR6NJjle4kv6VUeSmr1FGWnnHM0EkIn62g1GCyzzuddraAX0g3k7PlWXICroWrPXhNhDq7ij uE40hh9JzI82qKJ61S+8sG4syxZQEvEp4MaWoFN1Py2Si0NKkI3z++kekkZmFNk+CJmcxGVHtqR 4dgEmUQepmayUjEnLXYNIxuXGAmVoSMIwcXUiNfkv1vCqxkM5pU9J4vzQPECxU9TDpcm6Tg9FNF 9Qr6ZRdRLJ1Y9Y71bJA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857297326158500 check_watchpoints() is called once, by arm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 11043ecd589..7171501d400 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -351,28 +351,6 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_= wp) return true; } =20 -static bool check_watchpoints(ARMCPU *cpu) -{ - CPUARMState *env =3D &cpu->env; - int n; - - /* - * If watchpoints are disabled globally or we can't take debug - * exceptions here then watchpoint firings are ignored. - */ - if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 - || !arm_generate_debug_exceptions(env)) { - return false; - } - - for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { - if (bp_wp_matches(cpu, n, true)) { - return true; - } - } - return false; -} - bool arm_debug_check_breakpoint(CPUState *cs) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -426,8 +404,24 @@ bool arm_debug_check_watchpoint(CPUState *cs, CPUWatch= point *wp) * is also an architectural watchpoint match. */ ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + int n; =20 - return check_watchpoints(cpu); + /* + * If watchpoints are disabled globally or we can't take debug + * exceptions here then watchpoint firings are ignored. + */ + if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 + || !arm_generate_debug_exceptions(env)) { + return false; + } + + for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { + if (bp_wp_matches(cpu, n, true)) { + return true; + } + } + return false; } =20 /* --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857154; cv=none; d=zohomail.com; s=zohoarc; b=eYYJLsE7kpK4LpYehBk5/PNMLPNjPYL57jT1fE56kJ3sBao6xu9y7XwgXgpVjU7uSAUHHrEIPWoxmRXU3ccb+mt8mJrTMVJ6T0H+uDkzbVDogS8598WxXVWfQEaXfEzB8dhWkmEWTmRmaWBQzgKygTSfSM/IeUrAB0weG/mLGOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857154; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kfOhLANeVRTcU6AZF6U667w89IySuXAQrAYpIb1NK20=; b=X//Wb9z/xkdiGv0c4+JAR/KZHKVyI0d2NGSmEMlo5UBchOvoI0sMXkBqsOCBRRGb6h2/PgOYrLOeb0Vwa4dmK9rT1PbECd0Vpsc+201GF19EB89/ctMGhaSWy417+HQAfJvTXRm0ts+q0F3stT7/jdF98G4PJOPs6Hbfl92ICE8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857154134645.9321796856012; Tue, 30 Jun 2026 15:05:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegaC-0007R2-Pb; Tue, 30 Jun 2026 18:05:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZ7-00058K-L9 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:34 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZ6-0004Q2-9Z for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:25 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDjee2879934 for ; Tue, 30 Jun 2026 22:04:13 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4hfy9cpg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:12 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92d1cae5740so667885a.0 for ; Tue, 30 Jun 2026 15:04:12 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47567a6f351sm11258341f8f.36.2026.06.30.15.04.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kfOhLANeVRTcU6AZF6U667w89IySuXAQrAYpIb1NK20=; b=czzL1N9gAlJma4qr cQ5Td0d7Ag8pVyHPYirwWgQ189gzHyIn8eZuCLfVH1H3LKykqF97y890oIrLNiQJ ONFPBVVOzvD+mmyrzvWM4W/3xRhZMyfbDKHmJhSZI1f40dR8elNUXGSSITyM+C4j p9B3PTekCdI+OUWtWz/ZItgzLFYkqB+sJzUEwufQxd0y9DrHeZ1driczZMiH6R1B lkfYwEVbF0WJHz6qezdyB5hBGFk+ZMRCwDMuWhBPJy8+x9gn452prl2IPrpcoBbt jA+un5aF9QG0DWP1/ze9snYxaSr7Sek2F5ciRPdFHC5jCkEkQW2KjQwdAXJBSgDF MFokLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857052; x=1783461852; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kfOhLANeVRTcU6AZF6U667w89IySuXAQrAYpIb1NK20=; b=B5dEd4kSC3FwiNvfdojI/yXKCsIHiMPbCOnSYKgoicLRfJ6+3QUH76HY4/CE5tZXSu GtUVIZ3eyTao1ygA0XZbq9grazPBSgcpMf+mTU7L6iLJTzGnHQ731ptiU/N2mJOA8UXz xqX74RpRA2+zxsJzCl2MJX3HEz9OR9SV48DBlfgKylqDOKAMxJsXktlR9Mjgw5HaaYMI WyyeCTEXInWLqOgYKHQs1mk0ckqdGUYH/VZJQZL4nVisn8PrTKTJOkp6nObIcLno0Uiv iG5KLd01Fsi2fKZUg6alHljtallmB++QL1WkYieoazP0zLeyQpYV7LmFN5icKJ5gmif+ pHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857052; x=1783461852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kfOhLANeVRTcU6AZF6U667w89IySuXAQrAYpIb1NK20=; b=noAqN0bVEI8R5EdWTs/TnWmw/yOtSfE/hC46mjduglDEm+8+LQviB/PYDoJkJ+OU55 5jSoStgGNovIVGOFQ1jei5u6bQCNJG6nMWeoFQHIoZNnhVh3NIDzQLrntmlCb1iSoPMQ 1fZsg+OKPUOtF6gptAfVWkXU5zsUqIHMSIAtEFCzpDMrxLSHYLbC9wlpHjWRgaXrW1F1 JJERM2zdAkyixUQgFn47/r/edK//bvLNaERoZ5QuYaCrH4UcQkNJsHrV4q9PJICIpQ0V t3Erln029sQVYiYYujDqIjBuGsK4nlkcNK+zHCjD738fcUNQr2FACnIr495jlmDMPLWp +/kw== X-Gm-Message-State: AOJu0YyW/kq7bCMQV7VgvT2GYaafPaWbLjt9Ylw0vg5QEwOMs7eKmtBc NnAHhXYBZ77fbVtTCiVoCgTvwSj3epWSuTp3Fv8QVUkAyy2BTTGOkfUibccj/EZsZ3IMmDIwL5p faZlfseu3LcsaYKnoHWUpWesRwwDE/Or/j2DYG5ey6rp7/Frv/O9xqhUzIt/02FPXfw== X-Gm-Gg: AfdE7clZdla2RxmoVsOc6KDHYO7LP7mVWTJgfM0dAZnmMpzlOc87MdNYtUGkadgnVbX OLQfA6f30lmzBO95qNe3NQtklE+eQ4PzwKyuvNvTgds4XtCt0gYM7RuQHlXUphm3M1i5LTMjHt+ 5m9Lrkgg2xjkcWODqtuFULm9Ck2rB/7PFPREF+OZ3vbNcWr+Y4jVZC0DL20f0UZVMJT+QTkzt7t X1e9jrfuHoqFkGP8qcM4g9JmkohDmCUm69pltLnJ7bS/hfyRJLAndNFiKncHiG2wPeT+OiwzUfq wpOtj87zRvL9/HKxdIwVSKCGXwLLJRuUpoQdV60BOfg9MnmrVwgNt+rMZgT0DZ/W65WJcyBGVL0 BlgxAJT1iX3m1f+xf7AlPbbMW5Xh4EVW/1R+Mm+Pd0PW042MnpLJ+u9xHp+4SrEAo9QQJ X-Received: by 2002:a05:620a:408c:b0:92b:67e6:8acc with SMTP id af79cd13be357-92e627fb238mr838723585a.70.1782857052218; Tue, 30 Jun 2026 15:04:12 -0700 (PDT) X-Received: by 2002:a05:620a:408c:b0:92b:67e6:8acc with SMTP id af79cd13be357-92e627fb238mr838716485a.70.1782857051580; Tue, 30 Jun 2026 15:04:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 25/33] target/arm: Factor arm_check_watchpoint_hit() out Date: Wed, 1 Jul 2026 00:00:52 +0200 Message-ID: <20260630220100.1289-26-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=J5OaKgnS c=1 sm=1 tr=0 ts=6a443d5c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=Hd2jv3Dtlm5kdhFzXvIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: buXcrQ98ZR7Uar7LpcAaCh7OJSFS6pI7 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX1hsfA5yamyOd IK/krRHZls6b+x9PeIluTJNDqp8io5fMH3ZBGwDBXI4mPGnYZsScaRURRww+3QWIOQGFZqxudU+ 1Dl8Z3XoSffOi28zKRFmB4TxCXP8RPY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX3Jhm6mLgGocn adxGTJgRcafO/61JnJkikgDiV/A24BZFqTCW4tJc1u4/2bdG0vHggxK411Bnz2WJ7xryD5l4WZ6 8qxOC89iQR5JzO1YDY1Z5GWPFq4Mc42FXmPNs7oviP2f0sRbIHPjh46vir8sB5QY4yppmkYXRht XLZQQfNVV3f7pc9pmT4c8uh6h6x9H2zppEMEN8tq23FI1WjsokGlGdNs2t7+1Cz9kgwyEbCg0J5 af0wEjfwYi7QiazJSd60ImhSMhpq3BrbtpyN0UuWLtZZp6eYCNC13V6kNqEhcTa9Kn7R5X4x0si 15A9e/YW7/S3hxnpSQcqExDKJmFyNRvTvt4a9hXx/KJev6kKqeGMbb76JreWz2Dd5b67Q+i5HaN mLXb6aPYgZg1o7S7r/FE5EHaS5CLEwTQSCbg3qE8JvcFW0ZutDfLwMeyNdbP8NlwvAbhkQfofj2 MxZSy0vOnj5OTjwrH7Q== X-Proofpoint-GUID: buXcrQ98ZR7Uar7LpcAaCh7OJSFS6pI7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857154554158500 Factor arm_check_watchpoint_hit() out of arm_debug_excp_handler(). No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/debug.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 7171501d400..775f1f04c6d 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -455,28 +455,35 @@ static uint32_t arm_debug_exception_fsr(CPUARMState *= env) } } =20 +static bool arm_check_watchpoint_hit(CPUState *cs) +{ + CPUARMState *env =3D cpu_env(cs); + CPUWatchpoint *wp_hit =3D cs->watchpoint_hit; + bool wnr; + + if (!wp_hit || !(wp_hit->flags & BP_CPU)) { + return false; + } + + cs->watchpoint_hit =3D NULL; + + env->exception.fsr =3D arm_debug_exception_fsr(env); + env->exception.vaddress =3D wp_hit->hitaddr; + wnr =3D (wp_hit->flags & BP_WATCHPOINT_HIT_WRITE) !=3D 0; + raise_exception_debug(env, EXCP_DATA_ABORT, + syn_watchpoint(0, 0, wnr)); + return true; +} + void arm_debug_excp_handler(CPUState *cs) { /* * Called by core code when a watchpoint or breakpoint fires; * need to check which one and raise the appropriate exception. */ - ARMCPU *cpu =3D ARM_CPU(cs); - CPUARMState *env =3D &cpu->env; - CPUWatchpoint *wp_hit =3D cs->watchpoint_hit; + CPUARMState *env =3D cpu_env(cs); =20 - if (wp_hit) { - if (wp_hit->flags & BP_CPU) { - bool wnr =3D (wp_hit->flags & BP_WATCHPOINT_HIT_WRITE) !=3D 0; - - cs->watchpoint_hit =3D NULL; - - env->exception.fsr =3D arm_debug_exception_fsr(env); - env->exception.vaddress =3D wp_hit->hitaddr; - raise_exception_debug(env, EXCP_DATA_ABORT, - syn_watchpoint(0, 0, wnr)); - } - } else { + if (!arm_check_watchpoint_hit(cs)) { uint64_t pc =3D is_a64(env) ? env->pc : env->regs[15]; =20 /* --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857341; cv=none; d=zohomail.com; s=zohoarc; b=Fm4Mfr7d0RPQ6xCnFeu41cV471k4edkC4+5y2LG3PIvzWrp5emJm57GaRjYUM2GPFO1HDQz6f3lEFEGMDTF3UyvsEoz3/+y0+uec23/OEqmeDutuz6axBRT23lQhqNC2wk3cdNT1WmaWiGtjdfdw2luRmjGsnTFeBl1l/oAQevs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857341; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Kxaj7fpgNv8IGwzoF4MRlr4aYlGXFkG9O6uvFK55Lmo=; b=lRdqzCkam6YpKDF5XVQAi2axrtd7dovOfcV8vLBGE6Yr2Uj9huMxrGGoZoTAMnZ19BD7u66ZilzKIJZxuGC8zaIuwn5hRWAdGzR9bHVwsmn82c908KNSvz2LcrqZjR45LydCJ2LASCNyiN2ovr4LI+S3UzG3fb+94jwCIMOJG6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857341400610.1960003448381; Tue, 30 Jun 2026 15:09:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbj-0002uz-Rj; Tue, 30 Jun 2026 18:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZK-0005J3-EJ for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:39 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZD-0004RU-AS for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:36 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDc3V2920057 for ; Tue, 30 Jun 2026 22:04:20 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8uky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:20 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e52306621so445981085a.1 for ; Tue, 30 Jun 2026 15:04:20 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bfe616f5sm4295345e9.1.2026.06.30.15.04.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kxaj7fpgNv8IGwzoF4MRlr4aYlGXFkG9O6uvFK55Lmo=; b=G7liW+w/QBpZVtFW 1recrgGQWkM1whaGtR975WZKz+mLXZuQwY9bDNza94u+d3V31rHUjQ9TcFgA11Ty 9Yk1Hqmb+cLQfGSWNvpytSL7rX15X5odlFIJtRv+tu034xOgDPNEgz+dS8/lt/b9 +r9e6mwKACXEZ03cXkTnzQ2MgASdba8qkVdYdkY857D0CG+nD45DUBYnnt5yJB7y 3ybMZkxQftcygDJzx2WNueWXeU3Z6FIrqWYr7QAMGUIloI5lzWQxqeNNp8SHNpWo ktLga8vSbID7+wfYi7UYFtANT20PO/LXipHiI67h8fSC54dYzsfciHXMLIkznQpt Jd5EfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857060; x=1783461860; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kxaj7fpgNv8IGwzoF4MRlr4aYlGXFkG9O6uvFK55Lmo=; b=Ci3qoMVPg8WHyeM9NItE7q+zWqCqyHdyZpEei0NLK2XINKvTZBxBsidmOC3Xv5YiyT gWVoU/fxTCWELJizKc0WdxnvsWrWkif6yUyatYrpdcBIZWGdFpx1gW+1i0aUgQqWMdOe 9bOgQB0caCwUtN1k6JaMoVLi1lCdWf0My2AhAVh+aqjNQ85xAT8GcLiaJa9RjXwFLL1L 7R14Z0i2v4wQyxXAZXrUMfovG59VK5rAs/FeiJnnI5MTU1JfuVw0SgIvoU1oJYVDqFJE wD4W+/SAeYV8CSRtUJYsyWuFXK0YbMMuniOPCuYkC4UXWune/rBSIJSpQDFsmDRo2O8W 6TDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857060; x=1783461860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Kxaj7fpgNv8IGwzoF4MRlr4aYlGXFkG9O6uvFK55Lmo=; b=GnDYzTEQ9xT9ugAtYUcSlkYicSrJBXHSjVAvTd/wAWC5bg4qwsP164Q65NtZ6nWeSV 7QTfu3rNUtZJ0EZtInjHwKjbFJIqVZ58wmjnXZra0ZE6Ozqatc8ueLNIZjX4E3thhdt7 vGYMe1kWR/BKszKwwmJwhoPchIvzFnvFs27gBJKNFvgGJa2GBu8w+APSzFHhuHgJ5+ZU P4ixB1Oj2EAZ4xPU3D+29Sb9y6BcRsQ8npZtYtOXKS5DKC0VOUS5js8es0hYhA98mynk urKnyUja5M8Km9BxNn5LtyOwMAdSwsPACjawF21efX/XeOdn00f9BzQIGl+PevZapRaO 0IKA== X-Gm-Message-State: AOJu0YyXmMbeBn+gruJsil+o5IjXH/LBHrpWPRnebvxZWfQyP94H9J1/ Y3I96dhcezMIRBdf3NkD3Lbf2k4e6kq8CRfnl0QI1OXQbqp+NDNX3stHaTvqgY/9Hz7L4XunyTu fZqERgTfF+FY/bsRc/jbBSAQE7CL6erdt+FgfV6yuss7pdLOIsZr5ciZuBHpdqkhwTQ== X-Gm-Gg: AfdE7cn8/rCvGostyJUfSb+xmbqLqd3UQ3HeHOmYOBu03ef5WYAczkIcai+L+DMVZY/ djxAfUCNpJ7FzCgsUUQqESZW/Md2G6R2iY51JKm/HmEF5YkH6E5psNrDSHjJeMlRSfXqwevPBSi oYYIUjmExUdXXzmw0WAVmyKePcwaBe3oL/jKAJvWIMx4jScNEoo25qiuiFr/EFc41bigvQKQQmx UDR/bVqG91CV1OJid9zrTYATfngaX6X1nDvrVXmZrDbvsJB54w5pdqYr7p2GZ+m51p/0K85afq1 9Dgrte/uJw9hby7MXRivg3tR+Oba16aXqQAzJmpeEytGp19BRM/zJFsFJLohiSqS7angw+psSmQ kAhSuetAi+bJMWgvlGO2vLssVmjRpTZnFcyrSOMfhli0RzRZb0rG8wHJJNUzCppxv+SgP X-Received: by 2002:a05:620a:4411:b0:92e:6c8a:2a1a with SMTP id af79cd13be357-92e6c8a3c36mr434431985a.7.1782857059415; Tue, 30 Jun 2026 15:04:19 -0700 (PDT) X-Received: by 2002:a05:620a:4411:b0:92e:6c8a:2a1a with SMTP id af79cd13be357-92e6c8a3c36mr434427285a.7.1782857058967; Tue, 30 Jun 2026 15:04:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 26/33] target/xtensa: Move watchpoints handling to check_hw_watchpoints() Date: Wed, 1 Jul 2026 00:00:53 +0200 Message-ID: <20260630220100.1289-27-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: BV3ybp878TcUvF1RjYLWA51fybFskwTh X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX397g+OVj+KCn Pd4Mf8T3nUwNv9rmwda+rKL7f/tGmtKDzWyZsTGtxYEdX5Q9Kpbjro4ZXVzDN4cnghoi9eHx1Jl VQHV84xhpxOBtHAx+GAEvqUdVocczBc= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d64 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=OabgTiWiKDF5Aaswr54A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: BV3ybp878TcUvF1RjYLWA51fybFskwTh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX1G20Z8xPwbSm 5s/xu5sCF1jLqbAek1Sb2t44RQQ6z6U1eYrQ0Gm+VkioEI7ZJSfcebOetcTNvPdZ6t3GFjNz46n UmouIMTXaDDWzxuXMX2aZrvgPm50DjkGraVTzR1trOI9rSoRttU+/ELDzcrjizJzyLTvrTDvoCN 9Wa9M/I/KGP1UaTWTKU1kSm99HwP9I6SJM42vnCWsIHWcl9K3qG3X7Ca7JQgAWzAOfF6pMQcZpM m1bhCVfIXS6Dyt6vnBfPTJwbI34G8ObJJaQz1cSIhi+Kw3MqwpAy8NYauNvkRuFPMldVvazJ1GU eEy2Ar0FwKsfUlQHAr/1Vbd+kWxAjtlFH0UqOMOGAhn2d8hXRexXCVLfDcLECn7wKxxqHy8HaPd NkEajiZq5ue8NVljOfdamfJZPhr5V3K6G5EsIcUP3/KacELXBr96vewdpAngqSJ9SZF+BfdzJc+ YbLcg4y2bIdsRNoWIFw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857341577158500 Rewrite check_hw_watchpoints() by moving related code from xtensa_breakpoint_handler() to it. No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/xtensa/helper.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c index 5a0e8655146..7674a7c1d55 100644 --- a/target/xtensa/helper.c +++ b/target/xtensa/helper.c @@ -30,6 +30,7 @@ #include "cpu.h" #include "exec/cputlb.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "gdbstub/helpers.h" #include "exec/helper-proto.h" #include "accel/tcg/cpu-loop.h" @@ -205,35 +206,36 @@ void xtensa_register_core(XtensaConfigList *node) g_free((gpointer)type.name); } =20 -static uint32_t check_hw_breakpoints(CPUXtensaState *env) +static bool check_hw_watchpoints(CPUState *cs) { - unsigned i; + CPUXtensaState *env =3D cpu_env(cs); + CPUWatchpoint *wp_hit =3D cs->watchpoint_hit; =20 - for (i =3D 0; i < env->config->ndbreak; ++i) { + if (!wp_hit || !(wp_hit->flags & BP_CPU)) { + return false; + } + cs->watchpoint_hit =3D NULL; + for (int i =3D 0; i < env->config->ndbreak; ++i) { if (env->cpu_watchpoint[i] && env->cpu_watchpoint[i]->flags & BP_WATCHPOINT_HIT) { - return DEBUGCAUSE_DB | (i << DEBUGCAUSE_DBNUM_SHIFT); + + uint32_t cause =3D DEBUGCAUSE_DB | (i << DEBUGCAUSE_DBNUM_SHIF= T); + if (cause) { + debug_exception_env(env, cause); + break; + } } } - return 0; + cpu_loop_exit_noexc(cs); + + return true; } =20 void xtensa_breakpoint_handler(CPUState *cs) { CPUXtensaState *env =3D cpu_env(cs); =20 - if (cs->watchpoint_hit) { - if (cs->watchpoint_hit->flags & BP_CPU) { - uint32_t cause; - - cs->watchpoint_hit =3D NULL; - cause =3D check_hw_breakpoints(env); - if (cause) { - debug_exception_env(env, cause); - } - cpu_loop_exit_noexc(cs); - } - } else { + if (!check_hw_watchpoints(cs)) { if (cpu_breakpoint_test(cs, env->pc, BP_GDB) || !cpu_breakpoint_test(cs, env->pc, BP_CPU)) { return; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857265; cv=none; d=zohomail.com; s=zohoarc; b=j7KAiU9e6xFmYiRGIkMUaMby08hOBhtNGwS33LLH3KhbdAx/5/uBhkr8E3YUw5ENrEyLsuePds94ndcs1w1h9Ol7vGHgcm4Z+4O/LBT63/Dacxl7djCnWuXMDqejpxDh+adtAWlXaHEb5Pxz/sb+TOQPmV39QU7usimJCNaEXHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857265; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=flWQ/MPYi5Yw+SwaWjb+CkmEKUB+4nfqA9d8BHOhI8Q=; b=FDbuRcfYUffx/o6v2xFJNu9p27LRD4DDpXNPENYbKy3/YU8yk/rJ8BkVxHchc5QSg6GOvlWDBIN1TaVdbteTdhMb3xEnNsmZMLRKkbVB5HnV5ndhwEhZsfS07gRPX2hZ+SKbFr0UYKL1P65NQaKr5bz4XZ7Up2zziGudV13P5bA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857265147479.41479378228223; Tue, 30 Jun 2026 15:07:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbo-0003Xu-I0; Tue, 30 Jun 2026 18:07:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZP-0005VP-KI for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:45 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZK-0004Xp-Eb for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:39 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDp4K2947914 for ; Tue, 30 Jun 2026 22:04:27 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4h0asjmx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:27 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e61b38eddso483812785a.2 for ; Tue, 30 Jun 2026 15:04:27 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475671d0403sm11724641f8f.29.2026.06.30.15.04.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= flWQ/MPYi5Yw+SwaWjb+CkmEKUB+4nfqA9d8BHOhI8Q=; b=PyR4QLU5zpnp8i/R ZfW7xe7Uye7HNnDVMzqDldlLFwbks8P5zb+ij6Lg0pl4HuEH8z5HtQHl3XnmQR4A uBBJYc5CAOy7qDSR0Em7m7QgX87ZxupolQrTQbiouspcS3bblyDSvoLAsxZUDyqL MEb0EJpLPodRnuZ1sRaMJxablC+ZFjzelOJesWP1vNrO3fLDFaEIeNEkICz8zrCi EyKpdC6XLHPDdkBTN+K6EheCOIZCGavAVnCfT3I88JEWHhhV/4jjsphyZXdpgI4e aPmWcissGrFEo1dQDHVogULuPluPE61Tdzkp77OaAd7lvpUI6DbtGdDUoBbUNkEI eXmzhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857067; x=1783461867; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=flWQ/MPYi5Yw+SwaWjb+CkmEKUB+4nfqA9d8BHOhI8Q=; b=WOdlhkm6owJ0YyHLvHsA+Qbfi8vgfslrldofMunLFFBM96aHdxVnISSrJAHnIKnyDs atZ0+002js3CbT7LOLfFJAnzLPa2Dcu5IUU0FEc5GkS3vK4t8jdoBTIscl17FUsYr1/I vUZWjcuycedTroqeDQrc7DqzJLbl3jWJIF/zpyFHjBqOzbEjlc3f3He04UpgMCc+hd8Y deHzCkGoI/kxrU81Hrhlqigs+kNTnTKDrtT3EX+SLe3CBRIldOryo258ZH4t7DS+Bsqm VzaPmEdHhZ1OCggoDh+QNOqX1PWlEp3FWgxcrlyuOnrsyxt41c2sCdraYQpByDKM5cg2 E0mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857067; x=1783461867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=flWQ/MPYi5Yw+SwaWjb+CkmEKUB+4nfqA9d8BHOhI8Q=; b=hS+2NLQuNFP25jVKCzyv0bMTulz6VB9QyUdZXV/NsJ8DW1TuSzeDjTn/QCQrEGN+Fo DINEzcYTyVr4ByXsn8H2zv3xQ9QET7GpqtZ/0ajSbhon8PkqAY1Tb71mRmGtckp/z+iy oZQ+3Ij8ynJrXrywzPlDXENuhONtSnQYGqGBNN6/0f8kl9Ot78Vcy4mTg9+W3Y6B+ZB3 hdQO1iqlPl9YfbXpX1eiakoHzDYQQmc1YVVPijcA8nCUpUMqcd5mXr37hJXjVbQzvils mPgBMk60d6DH12Qa2XpUFsrdVhFkkyhbfTRESXBnET8sYj1C5nDjTAe+kqG5ZKFBLV2L jeBg== X-Gm-Message-State: AOJu0Yxqc2c2SauOlVos1CHQp2WgHXWzMeFsQANU+6HGXAfr45bIa6m6 wbJZOJXeditq/e4BsHSvT6epOCzoegOTEnniDYmXlkC3rr7r29Z77Yw6ivcmKaMU2m1iwDXnpVH /4TmNoTjVMkKu5qtHA6Jd9DhceKtjIJlvDMf9DBytC/8GIPsDWmkHbkc4F0xta1Uuvg== X-Gm-Gg: AfdE7cliwjIpb99WNGHMTbtMotS5KYs/WzDhsAx4LYQyt/4X25yOeiKLFViAphL8DbQ mpiDNsxh7IY4DTYPW6ujdYAOan7nCwfVHR8c3OId5JMN847jn3OfuoeA5t1eJo9BS/LwaqvR1H6 MSPsBCLWApnlYRhWpUdGGg2FhFeFVV8E32npBMbvT898f/TA78Qa2w3hQyra9FFEp4UkoKbwQni wPTTmb/K4i0FM49//AKz5QD7buwE69Njuvn+I1eGfbFXapVC7GK7O+ROFj9chatkz+lkb97Asbo VUAKd4CMLfXErz8Rp3/4/kO6KuYk82Dfo09Gks0pTEQcXijIO2vnLyI5l+Y1+y4ymDonCe4C0oZ ZMCrt8PSzZZD8NG8naanjegUG3v5s4JcMcDPlTXzPSjkqC9ffxfGFtNqcri3v8+1neroB X-Received: by 2002:a05:620a:2945:b0:92e:5b92:98bb with SMTP id af79cd13be357-92e6d7da61emr427342185a.14.1782857066844; Tue, 30 Jun 2026 15:04:26 -0700 (PDT) X-Received: by 2002:a05:620a:2945:b0:92e:5b92:98bb with SMTP id af79cd13be357-92e6d7da61emr427333185a.14.1782857066229; Tue, 30 Jun 2026 15:04:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 27/33] target/ppc: Ensure TCG is used in ppc_update_daw() Date: Wed, 1 Jul 2026 00:00:54 +0200 Message-ID: <20260630220100.1289-28-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OuF/DS/t c=1 sm=1 tr=0 ts=6a443d6b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=0gApPR3MPTmSQoBs11EA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: iJowD1ua8MhO-eqITCsgMH9eCW6aRHG8 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX/vTXuvojghJB bKf3CQFQVa58J2QMEyRN9SIbcAQTubX2Y9zpOz3aIDa8YH7YAjfnvDun3Sfp4EfeNSHL+ECWoPv dYI0DHCD7pHWpxVwYAQnz/60xkGRUx4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX1RPwNERWRoF8 ZJkaEJ99Kj+uPvuEMB894B9tWMuE8v2OSjcyhbNFQG9w/JQ7SJQt9UOiFoTqHTwqTJXk/DI8R6D SI63Dqvb6cUQp9UDUV2Fz62ksqMDTR7fjacDbzliprjelUP2zpD3Aes1UcOiZXdnamYB1v1V5Vx oOmr2biAVzPkHl/m9f4u2EYFZ/g+5fDS4IdghUW4q0Ql6JgYtdHLcxnw92TbXjWUCZT21En1wYe bBWmlmKEhlcdtZY24a6Bqz3XUL3XVGMroQT8aG6IVm3N9/MTQAbR6q4WU6VnYadI3ftwqtFUu1j 06GLIA+C8CuDpWbolJJio2Wi50+kPh6gikc6HhXqRKn0Y8RDhMZdY8UENOayiCCpeaaR/Nphbli HtC3MAwqL6jJldSfostk2M89xIDV5ZuWzIRFlRthY9Ns49rDG6pXgv4yXeHsc1UEIQKXkiXpiPk TbnDPucQu0j7bb27O1A== X-Proofpoint-GUID: iJowD1ua8MhO-eqITCsgMH9eCW6aRHG8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857267640158500 Per commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented: ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG. ^^^^^^^^^^^^^^^^^^^^^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 913920d55b8..36e1209119d 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid) vaddr len; BreakpointFlags flags; =20 + assert(tcg_enabled()); + if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =3D NULL; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857335; cv=none; d=zohomail.com; s=zohoarc; b=klSYAqB4Og+X52vundlQFJiTm+1trb7WA4kCo0m0Yyr33GdmxxrFVyA25yujTOrZetMzqbu98Ag6sHwpsR4GDoORxsh3pwuMzC6geYTvuZbb3/j4+vXuC63gi4W1SiZBsRpNuRxP7wuxWNIUnHEiyCEhQ3wHDphvwRHm+96X6CA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857335; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pmpe5noT2zIMs8ZNURW+LbS8ZHdMJGt1/AKVCXiYfoM=; b=D0usgY4CXsyj/pXp62isF87mPhSEK6DK/Xh/1yrlIAlWRYI+8BSX2zgqnnYyqFD1ESjbiQAo5RLP0AF5gMoSBD7LCSomNfQnagKIgk8AVNggqZ0Jgq4SJgou3GPoiH87pa4KrjnCqAXCBwDEbQbxrPu3U474kTnDTTcy8zpDDLQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857335901981.9152800479771; Tue, 30 Jun 2026 15:08:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbj-0002oB-9R; Tue, 30 Jun 2026 18:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZX-0005ev-66 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:54 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZR-0004YP-SQ for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:49 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDdvX2920081 for ; Tue, 30 Jun 2026 22:04:34 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8umx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92b4b575561so282355985a.1 for ; Tue, 30 Jun 2026 15:04:34 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566c0deacsm12130253f8f.26.2026.06.30.15.04.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pmpe5noT2zIMs8ZNURW+LbS8ZHdMJGt1/AKVCXiYfoM=; b=oTo3GrZ8YyIWOaJ3 Yy4eWtmWao4AwPyqtq3HnXwNr8bDWd+cATViCXXHrplEHxQrrK94Rso9mSwKf3Dh AfO1gDBS2aCICHWAEZ7Sgzk3qvLgjls73BpglerOvwIidUkQ4PJcGtTNBbjTIN2t qp3dSRs3M+qOmv0JHfOEpSjUG960w9B1kTdGil5tCqoHr+6/C9GV8ROL3Me8JLVa BHh1atLWUWl9E1l4KwHZGpmDsGfzYPV4mKzLEM5QmhlNkTt3hJ0Qit1gpDHe/888 SZMmIaoeioLI2Yx3nRwWg797yeyBDFETb1GeJaNe3eEhwe5urunxwd0u6bO67cRU V0LKUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857074; x=1783461874; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pmpe5noT2zIMs8ZNURW+LbS8ZHdMJGt1/AKVCXiYfoM=; b=ADeMWOnrShxinugwC74b5CcmyIDkRHupZkes2LK/N/j7H05ZGTFh/D5Ogp8dLZv1l9 aNzoMeSpo3Mxz0lHJavXu4ApypBouttvJJll0w+Xgoc2WrKsnWqG6QTo5pchpQwhGzH+ YL9O4Ex4Y9VV/VYogdCM5osjJZFuIB9lNSNJGGEbFtZ6ZbEAXYL0gNGkBZ3bLJZjosDB P8cEZQ5hKBxf+lz0tB8OD2hMDxUSBEP1BapEN+62jup5K0el9EuppFf0/T9cyDBJgUqg 5sZuA9ZMc+b50PANwqLn2J5hImJb8S1sBy5SSqPYUCVBisLK3lHMkzlNh7+5w97S/MGt M3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857074; x=1783461874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pmpe5noT2zIMs8ZNURW+LbS8ZHdMJGt1/AKVCXiYfoM=; b=Bn+gN8IQghdoWkRUMTfDN19uW/6fo+f7RUeVkxgI4TeZnDdokYIH7IXndxm0W3GdWs EOWxnLo7C+UeXuK+IiKvkVIM3CNL9Ve3W2mA89bPkI6KlrkpWXeK+/yGuB47vhsyDED0 So50uip5PXfh9i2fVFmTaZDc7pT5+cnLhCwgQLfzL02CDGaASw2ftDr9XfLpLp3sSkLi QGs7iYHQb0wuPXljNv219+nRXP06td6NkAXsWwMPVPMvXi8Pjfvvp5ji14yMaiF6CLnD 1IQmu6+qFUo/oXxKdlQ3FjtHuWlRkGKMJcnYSPSxO5j/2eVk11y0ZKRQRuKJAS6HGymp 727A== X-Gm-Message-State: AOJu0YwRfO1H/fnUbiUuekNCkpNxHvfdyY+cDlMeFFeiT3KnYIEB3dL+ +fBG5bTkDFcOOOd3o3WhOkf87RynaDQDZ71WsKgz+cPx3r1NlYg1K0oeoSZYs43HP6P3+We1Nc2 46LuLz+U4Nvr99JzbdgnjOgRTzQZDT5qSKeVUgKY8QrRHcIDPX1RHucZUi6e+JemNDw== X-Gm-Gg: AfdE7cm+lfIGp4jFvO8M5oDP4BT4HBhD/Fyyvdb8UI74aUbVUZQD5PcKrr9+5wbS93P vtu+9ee/87T+38mKlkaLkwf9fsDm76fF5YEgZwxrKd9Ngz4S7FmaBV+v6hTlQnwljD/SIDtRUl9 0wu2JJdmeBIasRjEb4sML7GtrYCj4bFTIKNbGAtgx2ueeIg6az0Fl/dse9ApD3o7II61GpmsP6C gmct9c67xz0X6lamf3oFdWyMGXgv/O6INknocRpSyWoE/zLKI1FjUpO8lRRucGv5c66vs9AcvaE a4i5qmuZs2PtuoNpkAMQvIHGyjerZqB/Z1PHFM26AqWW9M814l1OD2ZIX3RLr9V1FWEKA6J1SnF TXKkCQJe8D9Th2HXuEk7Y6anMwoJfeWJJuAtQUu2QFhaRGMDbp9zzG7ZN+JwZibVXJ5M1 X-Received: by 2002:a05:620a:8086:b0:915:fc16:2ae0 with SMTP id af79cd13be357-92e697b4331mr475141685a.25.1782857074111; Tue, 30 Jun 2026 15:04:34 -0700 (PDT) X-Received: by 2002:a05:620a:8086:b0:915:fc16:2ae0 with SMTP id af79cd13be357-92e697b4331mr475134685a.25.1782857073517; Tue, 30 Jun 2026 15:04:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 28/33] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers Date: Wed, 1 Jul 2026 00:00:55 +0200 Message-ID: <20260630220100.1289-29-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 1hTvduxTicv3eM9Hwe2kzbPbWOIIJiIC X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXw40yy68d4BoU CFvE0rIRO3TkXRa8LeMxLztfUemqgEA87xKRKMSsvDdh4A6SWN8m0CD1alnOa5yh6dW+IX/7VOv Gxz23wA7udrt9hL184WXn3UsZPENKvg= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d72 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=oIGtIzObNEvw8K7fi1sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: 1hTvduxTicv3eM9Hwe2kzbPbWOIIJiIC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX+rSQZYpYEvz8 8UJIWD1+iWsDN52oWqPASMPrv2T8kyPFdgWrmMdfFnw90WPGL/3LYVfS7VmfyitbsnwEPgvEqAW yZos9vlxbq98TrDLt/Bf/NDSt37MGMFdTLMND9rkcN1iaOl7Iq4bhnUmLbB3DJsM1MzxbkJDAk/ 1GTPpaPsnquqGQYJYthoDIVPcNHQaXv7xJB3GC7ZwF4jMte8X12CM0Yajtr+hq5ZAO8aV2axGbs QbySo7GItYjC42BCRIedXLzRkj38d5kIrKBywyTtp2IKoSjpV4DE/YKA9mAko3GekA6W/fL6rJN Fi/OWIg05uCVIsd6/Xhkdg6lcqmyJogWct7ko5cFPGblGJOYmQDvNEtNRhI0krVJQz76mU1KLvP fAbB4InpaW2+I4FVnuioKNgF1tB/GpRuAX1Nu9y0meVtTWhWWCHG+ErSHnEagvwsjO4jjn7ylsw b2ebQDUwuuq17M/453A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857337534158500 Commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S") also implemented TCGCPUOps::debug_check_watchpoint for PPC: make the comment generic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index f64d94b2b50..568d82cdd32 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr); =20 /** - * @adjust_watchpoint_address: hack for cpu_check_watchpoint used by A= RM + * @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by = ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu, vaddr addr, int len); =20 /** * @debug_check_watchpoint: return true if the architectural - * watchpoint whose address has matched should really fire, used by ARM - * and RISC-V + * watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu, CPUWatchpoint *wp); =20 --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857235; cv=none; d=zohomail.com; s=zohoarc; b=a1d7HIgZw78WqKu9ker4fSsc6q74ZX2OVOJJX57jr1IPNvtTiGZLQDLGS2YHmpmjzGKIpmHjKhF4EcElKfqijJ2FFcoWYmmLA9taBHI29XvG3mv7SjL4SvVLV/URE2lOezEp0WI9ULm8RuFgzoew43u8sSCNwXHU4GgqlVXOYEI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857235; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+Ws6dQvdsXQmipKgaBrKPksVyQjTVfHzk6V1qVaW2HA=; b=JmLGrAyvzy+tK8klLr9EvsH6Urhug/h+MyEuwL0T7hii+6F81pDH872CzGpXtwTJNSSXGV2z5+kfp4jgUdOKWkGZ6b50jri7SeKTL4U1yywQmtILWynXsqRWLa9NuCZ02sWdvCtw5bQ9YHBC1DT7y50ZRuk8lethCo6//pnpLSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857235394910.1350724434666; Tue, 30 Jun 2026 15:07:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbm-0003Gl-LS; Tue, 30 Jun 2026 18:07:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZl-0005sn-H7 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZZ-0004ZU-CA for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:04:59 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDc7s2920060 for ; Tue, 30 Jun 2026 22:04:42 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvw8unc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:41 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e59b0e0f4so231357485a.1 for ; Tue, 30 Jun 2026 15:04:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756778f015sm11790887f8f.31.2026.06.30.15.04.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +Ws6dQvdsXQmipKgaBrKPksVyQjTVfHzk6V1qVaW2HA=; b=C11j6E1AZvk5Ge0p wlgWoUVSeyb9ATAWQkDsEWunT3LccLQnSPuB9zgRUjyLoJ4sshGMgcVrAGJ8IJoM Q3DnwAh0TxZcfxs2lOQ2JglH3740sVKbj9/RFbTvL9bXO4SkRhORUT7AJifB8+JX ojwIMzQiYNza7qMsdiT9JbSx4hAnC38ui5XZQQG7gUlp9uoEG8wgojnn40/zx51L JEioIsG+O4db1PymHPt7fRaGQfDR8S6HhsXcXoJKVmro7t2U2GqnEqwIFDT7eNOX 4mll+RYcSUJrhr1mm7kdGaWiQP4je2DBSERxqbX+TbZSdmRoAc06nKjkmqsKO0XN eaiPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857081; x=1783461881; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Ws6dQvdsXQmipKgaBrKPksVyQjTVfHzk6V1qVaW2HA=; b=NwvTJNa8fUNQWeYGgtk0XG/+kBb9RkhB3cDd1+QdwUzPNMus7gM4pmmD4mf/3ZFy8z NSm9CfdYCYEkUwDravodzDis0VFQ1LtRZZKfkvDMfbGF/91vdCNl47wCqq58olBTVlDg YpJmoGJstdw0O0tKa892p9Xu4rJ8wvgO2ZR8e0p0x98Dx341m/rXog/5goricU8p0XIo D7/o46vht5cE7xWm3mD80yFKy62jfdsqr+DoKG8EAERKXqcHEu37mshkuUjHhkumC0u/ Ig8i2bfkW3gVCTC/jD46HZqxFOYTey1lJU3Aj8eD/7hxRjFG7EQNNDsGANz/lwWFgkfW 4v8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857081; x=1783461881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+Ws6dQvdsXQmipKgaBrKPksVyQjTVfHzk6V1qVaW2HA=; b=g8p84PBuIaV5my40HPqXiuJrt9sHJu87xXSCzVpl+dx8JQCh2AL7BI8DQ/HVT5UNRG 0UVhvdGn+zDjOl00OxIZvVavtabBFHNQ9kQR5/PaKxmEhlMU2jxcPkLP0hZmpusHhJiW aheyEjIjLsKwESqr/bVAHUBSK2UE10S3S/80XcwNnoH3CQ6yP2gaCRjM7Q1jQtmFb7hL +POmldxpwivbCD01mDcUKTdr3Dkrbh3+BcLg9JW2Qy36x7Qyo409JN+h0UrBYOQWlbi6 dA8szTDfOcm2gh++rP61bredtPNigQ6M7gVA9owJSC5vVRUnfKQBTQaS+tfj/rT39ged YYVA== X-Gm-Message-State: AOJu0Yxfp4PJLdp3X8isY2eW5AVQVn8rwvEcEoz57OJeTv74/SGYbE3j ruLcYiy+YT4amHRKL0FXI6YS55B8zrJVNkQMf3aySiuwKodmow3k8sJxCrtX9qnDOQEGjBYNVe+ /GetBzV1U3s2pDy5d4yX97BWlLaDo2obDrAWjQBC30nszWijkrurd8Gt71lmrhuW+xA== X-Gm-Gg: AfdE7clGrp8ouu/UIlU5rQR/LDrsj2DnbeedRxV2FdAzzjqgR6QzZqmkeuGbCsw0cpp FLMmq/3Jo0nU6fSV6Tk84SSqj2UwAH+hEBkNurQ1+inrOAmmbcm+dHp+8fIpdFnOt2v3X33CCJz XtfcF3Y/17Mp9FCeV/aaeFfFrGOfXseluaz7M2tZga88USpVziqQzvsugR/dZO3Wmp/PJeRVuns s1qTeTnNEROEUZXhQyokDVJ5e09zEQFrVGuTPJtVuA9YhCrvjVQ7HnFG9OKJtwTJGaWxtV6/5lc svKvMQsDsdVpxYl70sqDMrqlmGihH/0HYmEyG4+5KlpkIG2X0lw3SdzK3uXJVo6w3VT+npzaLdx lFpojUnQuU8B8FW952AWcP6kZP2e18qXbglYDDfyNwGok7BPTqCi0zBl7BmBKHCS9RXyK X-Received: by 2002:a05:620a:261d:b0:92e:54b1:2881 with SMTP id af79cd13be357-92e624a24ecmr899078485a.16.1782857081323; Tue, 30 Jun 2026 15:04:41 -0700 (PDT) X-Received: by 2002:a05:620a:261d:b0:92e:54b1:2881 with SMTP id af79cd13be357-92e624a24ecmr899072485a.16.1782857080854; Tue, 30 Jun 2026 15:04:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 29/33] cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h' Date: Wed, 1 Jul 2026 00:00:56 +0200 Message-ID: <20260630220100.1289-30-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: sHythFUDJOxUX6IkKmM35Ci7YkYLwNhM X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXxcJQepXxxMoH zQSehkiM2fG1f184hA+6C1TJlYSihfz3fYVylnmp+8QBi3u6pxEv69DYmaqExtgQ/e3KhKStI/A K0uqxopLo0FGf9znAoBfb5JITsW5cwo= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a443d79 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=HjWuKgUHFhC_F9lk5HkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: sHythFUDJOxUX6IkKmM35Ci7YkYLwNhM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX9+1A90k+uAs0 pvvz0Gj71f2t5JWeG7fGhdYhDnFeH+zrJN7j9CCpX4Z8mhzb2QmChbXWtwYaydssOy5DWtfIWKB 6/egBMUtwucCPbyIgSjGMYD1Mv3ZT2ELwkpJVwNkgfQCg1mTdPLqsBDIr4OtWTJxVvKvgeVEy2J x1E49FTJy7ffA5RRC0CTTAROU9P2W1b2zWBQN02MVJp+pZGOauQQLcV05G7gzZwatNOLcvzoH7c pe7uguJI3H/GBJ4CW8JjFECDmNmt5ZYhM7KnoPadZIzbvaGvU8jssadBVowDiLCl+WPDus8Ll6P sXa0nfRC4cKuI1Rmr73q+qtouJ06Gdf6XZY5hpsDEWPfONzaTcNMYszejvSK2ivw65fmMjj+fKJ 9u68GnQbr/rYAZZ1QdHCggYu+HWc3VW0WpxR5fqUe1bsZjuylM5O8DIyA3AQHCDhUYGfH/GDS1C bsBl12tnL3begqtoapw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857237061158500 Define CPUWatchpoint in "exec/watchpoint.h", including this header where appropriate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/accel/tcg/cpu-ops.h | 1 + include/exec/breakpoint.h | 9 --------- include/exec/watchpoint.h | 12 ++++++++++++ target/arm/internals.h | 1 + gdbstub/system.c | 1 + target/arm/hyp_gdbstub.c | 1 + target/i386/kvm/kvm.c | 1 + target/ppc/kvm.c | 1 + target/s390x/kvm/kvm.c | 1 + 9 files changed, 19 insertions(+), 9 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 568d82cdd32..d5994781c39 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -20,6 +20,7 @@ #include "exec/memop.h" #include "exec/mmu-access-type.h" #include "exec/vaddr.h" +#include "exec/watchpoint.h" #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-mo.h" =20 diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 0c3cc0c8ff3..9d0dd89e7c9 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -33,13 +33,4 @@ typedef struct CPUBreakpoint { QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; =20 -typedef struct CPUWatchpoint { - vaddr vaddr; - vaddr len; - vaddr hitaddr; - MemTxAttrs hitattrs; - int flags; /* BP_* */ - QTAILQ_ENTRY(CPUWatchpoint) entry; -} CPUWatchpoint; - #endif diff --git a/include/exec/watchpoint.h b/include/exec/watchpoint.h index ba148eff3d1..7b72de35aa5 100644 --- a/include/exec/watchpoint.h +++ b/include/exec/watchpoint.h @@ -8,7 +8,19 @@ #ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H =20 +#include "qemu/queue.h" #include "exec/breakpoint.h" +#include "exec/memattrs.h" +#include "exec/vaddr.h" + +typedef struct CPUWatchpoint { + vaddr vaddr; + vaddr len; + vaddr hitaddr; + MemTxAttrs hitattrs; + BreakpointFlags flags; + QTAILQ_ENTRY(CPUWatchpoint) entry; +} CPUWatchpoint; =20 int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, BreakpointFlags flags, CPUWatchpoint **watchpoin= t); diff --git a/target/arm/internals.h b/target/arm/internals.h index 067c3f2b8bb..72ef3a2bf9c 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "exec/watchpoint.h" #include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" diff --git a/gdbstub/system.c b/gdbstub/system.c index 108fe4bafb7..3dccd31cbc0 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -19,6 +19,7 @@ #include "gdbstub/syscalls.h" #include "gdbstub/commands.h" #include "exec/hwaddr.h" +#include "exec/watchpoint.h" #include "accel/accel-ops.h" #include "accel/accel-cpu-ops.h" #include "system/address-spaces.h" diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index dda6946ddaa..62dd91169dd 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -10,6 +10,7 @@ */ =20 #include "qemu/osdep.h" +#include "exec/watchpoint.h" #include "cpu.h" #include "internals.h" #include "gdbstub/enums.h" diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 1e09155e92c..372781ae715 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -70,6 +70,7 @@ #include "migration/blocker.h" #include "exec/memattrs.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "trace.h" =20 #include CONFIG_DEVICES diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 6bdfbbd68d6..85b15602396 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -41,6 +41,7 @@ #include "trace.h" #include "gdbstub/enums.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "system/ramblock.h" #include "system/hostmem.h" #include "qemu/cutils.h" diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 195e39df032..bb329883c97 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -49,6 +49,7 @@ #include "hw/s390x/ipl.h" #include "hw/s390x/ebcdic.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "hw/s390x/s390-virtio-ccw.h" #include "hw/s390x/s390-hypercall.h" #include "target/s390x/kvm/pv.h" --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857245; cv=none; d=zohomail.com; s=zohoarc; b=SoX6nSE2kjeSvKz82r9SUhBXQe8Q1wSrNd/N0V5odg0ecvaFxrvTXeEyYRDR8aHJIzdu0f/2lFyT69aRf2TPVf8KnldC4Le/45wnx55cnr+9VNHF7+UuiZQrHBE5SeTAjYQMRlZQOqhFRD9BC6sk24pbJ+8EpbO0Ig8s6r2OC8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857245; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QX/5VAvSqOqOJOe4gWkMq1KSG0RZMviAyB0aJgsDBWc=; b=Za0GrvHj0Qi5qudhjPLpw2vXXHmaAuTl4int2VszYHHczWqbMpEFBqcE2Ykg9StdEbrv0PFHw5XaMdQqzSZo/CkfxAYKjnMsKxEv6/ZNKGLmpxblz61xztHmNcqrI+pPgjchpZNT6nO1JXMF+oE6GaPeD/KbEaoZPr61VquvgWM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285724521273.31625384138113; Tue, 30 Jun 2026 15:07:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbp-0003ah-3p; Tue, 30 Jun 2026 18:07:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZo-0005zE-0A for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:10 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZg-0004bl-V9 for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:07 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDmGG2937313 for ; Tue, 30 Jun 2026 22:04:49 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a45t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:49 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92d4b18b373so1006985a.0 for ; Tue, 30 Jun 2026 15:04:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566743895sm11661368f8f.25.2026.06.30.15.04.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QX/5VAvSqOqOJOe4gWkMq1KSG0RZMviAyB0aJgsDBWc=; b=MVj39ppmUN37oJmg IuEfe+YiV2WJ8XKw7zLKvYeLPZv3moVzB/j+o9Y3lph6PFXV12/gJ550wI58e3+Q pU4vYvnE/zzsS/kggs9h83gx8X2u3qfG7p5ZyPvkDRYcYtC0vbhyT7GOGgY5P210 lY0zQhWMIMxtq2q3ABXCLhoXbjtWkuegLK2cqTH8bwTP+3vmwfW1uA/cEIhQXPrJ 3fYkZbV4qOV8TLBNZYVHBHd+tU5PiBltEUM21g8RHM4PMi7Gfg2TROTJ1tRTfQEw rT8pFI83MXC65Y5qeZRp15aVRSHyhQN0Ksh8mXcDt+TUvcOPmJsF4mc4ZQONMxey oqDL8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857089; x=1783461889; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QX/5VAvSqOqOJOe4gWkMq1KSG0RZMviAyB0aJgsDBWc=; b=BOY8B8sUBjNYEFISXbtqOUMSjn2YmZqPDgTuvbFmgpAlm2ouw6dK0cbsmk70nNMxgQ ETM2RIFSntlZkxekj9o2jWwpq2+q6UFGaAs8OQsByBxARZuDPFzn1cF4DeBITDXtzR7T cYpGH8vfAFRO50ZAwmLyRMnuwUGs+gx70QmYBFI7nWVWed+tcxFRJfMzUQVHQGgq0kAm JIAqi3GIrDtC4T6fme91qjw0lsdrREwgpqH6B6/3lCKaa/t//IvWM8wv+xgo27wp7lnU Xf0yARBu92nGz2fXeEgiFaKsJwitPaKQrGVkh2O2POL44YS+6cgJD9Ygjum8nn+BayUF uzzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857089; x=1783461889; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QX/5VAvSqOqOJOe4gWkMq1KSG0RZMviAyB0aJgsDBWc=; b=onf4ME9EuJ+ILqvWHZIwn2HBti+07ZmJcMt91e0NteUBjTiWGmCnjp988iqQWOPMmq aEX6lCl2upLMuOJo4fepoVzpxHF+sy6j/hjQN8M/U2xFSzRsrtVsLP8LZhdW3vFMU1KM gZbE8G5ojlOzAwPkEaLskwEFWwlwRt+pAmv4kNskJ4xaSUPxd+WSwhGZJjUS971bFDBx zkNB5T4wdTaiFpF2Xk3a3KM1U6EKmv9qq3IOGupBbqF9NuknycuDJH+V9dUjf05TzAOg 6UvfBB5lcC/sjrRK+cKBXp15biUOLfKEHcsynzzjvTaLayMw4vgtiCcOZkNT2eX5VOiy 0imw== X-Gm-Message-State: AOJu0YzoY3r0vynZp3lgSbkS/KHNBlJT67nshu8Le/izKCdfDUaZpW2A 2B/R8sXSHIXtgzl3OB1EKGTRs96aRZI4QgcEcMynB8E05xQ7hXpu6ImSp9pzU0EIlIz8jLr+x2v K7fzCYwW5QDVpmOYJ1yfUYOmTLxormFZp9mWfEDhRnAFCwsWkrXfHhlpDSbu+NiNbdg== X-Gm-Gg: AfdE7cnYETLjbMrQPxg5bSGA142x2ZKtin9oSjV9IC8bzmhnR1jdsUDJHJWsIntdPoV u7Po5m9DtlAM3f0gVa/zLgivv0mr5Ny6eb0xcKX3Kgd1wzh92Wzj/So5B4rRUMhglYN/jT/eG58 HuLLpzdbs411WLDQENyGzdRVYR2IruvT7d7bPAwJCfk4EKtCh+eY0RzCZqpdyu7EWWH6UHrBlW7 Put3JniVRkiBQKoyDYJvZwPPOYLWE4KuAJh//LsHDvz1Lh+9hEChtOspISwvEQ/aF5qHDWpxz4a 4DxuhA1xoqf2wBk5jCCMA+DPlAQJnck1bB6ncVQed+9qMkbPAn9rU7HsXk1/Ifs2YLqv+2BFVbP fXgb7P7dpdO1GqNC1J42NO+c7/XN4BOz1JJ9xdzTyvlET4xj55aNzPuTYmQA+H/f4EipZ X-Received: by 2002:a05:620a:2b9b:b0:92b:855f:e91b with SMTP id af79cd13be357-92e625f6a9fmr851303585a.26.1782857088674; Tue, 30 Jun 2026 15:04:48 -0700 (PDT) X-Received: by 2002:a05:620a:2b9b:b0:92b:855f:e91b with SMTP id af79cd13be357-92e625f6a9fmr851298985a.26.1782857088137; Tue, 30 Jun 2026 15:04:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 30/33] cpu: Better name cpu_single_step() trace event Date: Wed, 1 Jul 2026 00:00:57 +0200 Message-ID: <20260630220100.1289-31-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX8d0eGJuhKd14 E7TivF2gVkpXBBeZsh7Df9xNgkxB5kWOo+adOojQgB++5sSS9gMDM8ORRXvliVdI4O3NhYi1Q8m EvZoUXtvywmUZiakMmJB9gr5XxTBXlKBEwKOitUlzgv5VfAyEK9roc96lXePwxKPb9JPRmjaigm BxN210tCKnxBSOhZ6VOEKpikmJsfSUd3RdC/sxKv06xB6KJO1yaHfT7osOxl1EMSTFA8YHDr6VK F+T6OAHpkRmt7WlkRLk2dsVevZaw3z0lsn7XK7VL7Ua1679VZR8krK6ms8wCGjwWi3kntD3n4mo nKCr0seBFxvdwJ8T/cuZ2ErXOSlvja4jPwES97R4tPkSyLTravt3BkiMrEYQXqv9MvvJqJUI4mu U4DDCnEXlnJ7OJYAe5keYPKiK3mqTitOaYfi9wAJOKXZOS/aRR912Tgz+IJnKFoF8/SkCelSyan UyXWJ8wdgSfyGhJgo1A== X-Proofpoint-GUID: EdAmQUrKX2cncX5ogljHpkTyc3P4Azpt X-Proofpoint-ORIG-GUID: EdAmQUrKX2cncX5ogljHpkTyc3P4Azpt X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443d81 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=fWCg92Okmkq_k9tJrKMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX77JScigseZnF /nlAg3uDUZJK54EI3Ww5i7nJ6sh8yP+5ALM/SiQIAquysw7UydZYnkHikWUahIYRQQEyNpz2c02 kC96iEV5slKQAjXHSyoGSP3xEXCViwI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857247036158500 cpu_single_step() is not related to breakpoints. Rename the trace event. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index f030e2c642e..019906b32eb 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -31,6 +31,8 @@ void cpu_single_step(CPUState *cpu, int enabled) { if (cpu->singlestep_enabled !=3D enabled) { + trace_cpu_change_singlestep_flags(cpu->cpu_index, + cpu->singlestep_enabled, enabled= ); cpu->singlestep_enabled =3D enabled; =20 #if !defined(CONFIG_USER_ONLY) @@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); } #endif - - trace_breakpoint_singlestep(cpu->cpu_index, enabled); } } =20 diff --git a/trace-events b/trace-events index faeba6242fa..ea1d2b11a22 100644 --- a/trace-events +++ b/trace-events @@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=3D%d enable=3D%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "= cpu=3D%d flags=3D0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=3D%d" cpu_exec_end(int cpu_index) "cpu=3D%d" =20 --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857314; cv=none; d=zohomail.com; s=zohoarc; b=W/CHYTJ/pex+Cse3x47u6+yA0ajZvqLVag/DH/74unfe/DgllNqnxQahHuVzZ/4+t2fT/tG4hfr+1bFl/z2g1LhbmyirTgaVeoc5rmOmmoBdL/CHGNjPKWEP+JOzUQ/Z6gJxBsVWWdOXY7Fg47Rl6tvxYkZ9r7Qtb4Q3eXU4Kgk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857314; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iZDYyBNnEfPj66ZQ9jk/9Zd6IeYUHE+uzrWFiFgMvNs=; b=Lz/h+iSNu+SUw+lIuzHXiHIC9Oi6ltHgr3tI80l5gptVEMlgoI9oUQKrXNiuoR/Ftofbe4rUDY6GEMxIuc889geyXPM3ZeTcx3vAc5l/nud44W3Pw3BhXvQcs7snhsMU5ImbRFzxK1NwN53dNqRYlZCm+2kMMfR8qZu+m559+4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857314612357.17028263993564; Tue, 30 Jun 2026 15:08:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegbv-0003zr-4P; Tue, 30 Jun 2026 18:07:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZq-00066X-Ou for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:10 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZo-0004d0-5K for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:10 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDmm72937291 for ; Tue, 30 Jun 2026 22:04:57 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4fc0a46a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:04:56 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92ac0a54110so945923785a.2 for ; Tue, 30 Jun 2026 15:04:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636cf65sm12007815f8f.21.2026.06.30.15.04.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iZDYyBNnEfPj66ZQ9jk/9Zd6IeYUHE+uzrWFiFgMvNs=; b=IHjqzcOB9JF+6iCQ KmWAN1iMNJDExweGRzPsWW6FAZDH6dGOS6fxxJKZq/raMjCkgZj4lFNJCL9CZMTC BcJ64TzhnLDt78aA0FVhXkYFl6HKRqlrc+lI69D6cZaumVZJbsVKtSc8HXRofdzh 7CYqEOv8aMTKEjBKr9w5yeQQFQfmNlMQpZGFEvJ89UgyfsR8efFA7isjtuaRRJg/ S6vWwK+8M3FDvfKABY7wlGbpoDbyavh9KCZnZkKi9WH9GusPemZCQ8n/FirwhDK2 3f6/qTUu7EIoWLTWSHG4ukcRpWYxxYrO48yOlH/O2LLDyg+IEnjIGuFK3l5Uc7mv TBc6vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857096; x=1783461896; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iZDYyBNnEfPj66ZQ9jk/9Zd6IeYUHE+uzrWFiFgMvNs=; b=b2SaZ8EZWlhR/SRjQO67r5JVvGgheZQjAgotz0bYt5yFxlke4yfbz2gzvMyzw/8/yd 6h2XaunbaEIFSAcE5ApzFVNNCtifOknzGdeV2j5Tam1I8fHmYiDRyx2ttga81pCz/2/k N8fFNQTdmALdaM2Pk8/wRe1hNzeKOaz6JSoWNLdSD2v37YKTe21eUq/pOTpngkNQ/6lL xm6+g1cTrmP8ccAyd29PwxgVNkKkClW9Uqb8oY8r1XNJm2FcYHmMjCv0TZVqy1cCcKQh 9zx9gee2K3oGntagA9avr73Clefh82/2SonNUV9gT53zadQUVTQdnBLpK5Jg/A4L6h93 TJfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857096; x=1783461896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iZDYyBNnEfPj66ZQ9jk/9Zd6IeYUHE+uzrWFiFgMvNs=; b=CrTZ51MkCVwFZl47/2s46tJsV1WouAZcyH6e66SD06nOEM/1lqF8YoevtPNYP0gPjG ntm+JXONUfEgPrBCHJhi609qhye9Kmog/ZF6y5pzjpCPjVmkiXEgjDKBT1lPkK9ov2gO lN8cf+d7jwXNPLeqKGmYMpLCfvYkkecxRHGnknvyE0Hr0M36P7ty4VFW5/LKWGPhHCrq l3eKg99493cfx17A3dlDg2kfufYFe2VNorsOnWYNMfcSc6PmIgQrmcXEPgW17azD8geR KDxlYGeo3OWd2jeRoZJyaS8WSpJ8AVtfI6Y/AVwuYPqptxaA2XYG2a88AScX3MxZykHp W4ag== X-Gm-Message-State: AOJu0YzwllujpanOYUQNUvZOzhiQoJaap8P9xdS42xrhyw3iebALGtR1 +gDm27ABowSxBf2K1B2gF54t3XprcQbEkJYfXo0wYc3VNQGwf9Ka0ZFFIZ+ELzUxCeNMXYlzTLn xVSY1Ia7lxgfI10MvNV8XLzN6G39UPM/IcDzlTlcawjpvcclJBhyVC/EYn3mT/uht6g== X-Gm-Gg: AfdE7cmhrqqYbWNYA8TAVrI7TzJSLhPdW7+saRnCFhPhb58EgggONvobOlfo+mT9W83 0bMUtvwnveA7k93WQa/zs8d8yC6a4Vcvl9FJpfI8oLZSCZQRLnCmRJXZw6ymfpyvz+RVh+Fq4Ue eElp4D/xoS6pJ+2tscBOBS/gTKuQmma9DQmeJOIHJo2nLfwl9TyaOdBE4xMc0g6t4qIRQfF/Vzo y8q0y9YfHM4JN7YQnDGOiWvTV31sGq1tU/Nb6pwJG5TCwfx9QVCkKET0D825CyVx0UmyxYMYGot 0RaTgeBVgx+Hg1Swn/PFlW40pfEBi8MTA0LC3mOrmQz1QggfOS3b1y28zWR084yg1NZ+MPusa5W V6QnYm6tDBfALlUHUF1nZehDorJ5GLA4pS1xgkjG8LYujaldzStrTGgkWu9uiA8Fd2q5p X-Received: by 2002:a05:620a:1b9b:b0:92e:5f90:c0de with SMTP id af79cd13be357-92e6d813d7emr391211485a.22.1782857096106; Tue, 30 Jun 2026 15:04:56 -0700 (PDT) X-Received: by 2002:a05:620a:1b9b:b0:92e:5f90:c0de with SMTP id af79cd13be357-92e6d813d7emr391205085a.22.1782857095609; Tue, 30 Jun 2026 15:04:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 31/33] cpu: Introduce cpu_single_stepping() helper Date: Wed, 1 Jul 2026 00:00:58 +0200 Message-ID: <20260630220100.1289-32-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX3tpkTZiUnc0E 3zPUiCdMcvNBoD8wp/3GfKr1iKUx6d7oieaCr/EvoNrC4DIJb5DDbFpGL8Ehi51H4mY4YlnRREX jNRXnb41OLyn6kGcMzSaJriX/mvtv+ttiJu7E922LOU1VPimGkDW2znaq9cZpJQS6aZ7Ojl9yna 7+2lYMr1FO+f9Z+fFi0No6MroMzpp4sUXuwjb5XW3M/KQOV/aZLrspmaKteorXO9FHhS4ir6elz ASCEIiDS3CYbokBndBv6LYjviEgiX3yQLPodxwcha3pa34MlNVOe8S+QYYdybnSJ+DQQlVAmPyg yNb3Twm4unxFyV0RdKHxMCcqZrVegDVffPDbnYyMHO8dgqZBTvluzQaBtJCx65TWUzUyIKPzV/3 /HziUvJNkvQiEbPvWhlLvr99Q7fSYo/8eQFH/odRko/Z1EGRdm9CSulHBe7pruet7fVPngMKROZ 3gsgLcG+oRsw4dIFcGw== X-Proofpoint-GUID: 9E5qE9jZA9BekDk7sU9ovK9AYV7YVivn X-Proofpoint-ORIG-GUID: 9E5qE9jZA9BekDk7sU9ovK9AYV7YVivn X-Authority-Analysis: v=2.4 cv=Ivkutr/g c=1 sm=1 tr=0 ts=6a443d88 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=UzDBcLQVJa3M_3ASbYsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX9yVihUV8vLyn 9CK+Lv8DsXSJTddKiv/dpy+akbo1/UMhc3lT9aYfOZ/eW5Gl3xWWcOcEqtPCwzpGfOXWfriNU6Y lTZe9nTBf1QjzTOctbdkKWa7WDcpdBQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857315652158500 Access CPUState::@singlestep_enabled field with a helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++---- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index bea8e509a19..37ac218bda3 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,6 +1138,17 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 +/** + * cpu_single_stepping: + * @cpu: The vCPU to check + * + * Returns whether the vCPU has single-stepping enabled. + */ +static inline bool cpu_single_stepping(const CPUState *cpu) +{ + return cpu->singlestep_enabled; +} + int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index e8ed85f9a3d..c436b1f3751 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3817,7 +3817,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) =20 data.dbg.control =3D reinject_trap; =20 - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 if (cpu->singlestep_enabled & SSTEP_NOIRQ) { diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index e48ea31373f..44e84344f3b 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -47,7 +47,7 @@ uint32_t curr_cflags(CPUState *cpu) * For singlestep and -d nochain, suppress goto_tb so that * we can log -d cpu,exec after every TB. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cflags |=3D CF_NO_GOTO_TB | CF_NO_GOTO_PTR | CF_SINGLE_STEP | 1; } else if (qatomic_read(&one_insn_per_tb)) { cflags |=3D CF_NO_GOTO_TB | 1; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index d7f91dce9db..0386ac49551 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -308,7 +308,7 @@ static bool check_for_breakpoints_slow(CPUState *cpu, v= addr pc, * so that one could (gdb) singlestep into the guest kernel's * architectural breakpoint handler. */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { return false; } =20 @@ -485,7 +485,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * raise a debug exception. Single-step with another exception * is handled in cpu_handle_exception. */ - if (unlikely(cpu->singlestep_enabled) && cpu->exception_index =3D=3D -= 1) { + if (unlikely(cpu_single_stepping(cpu)) && cpu->exception_index =3D=3D = -1) { cpu->exception_index =3D EXCP_DEBUG; cpu_loop_exit(cpu); } @@ -732,7 +732,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) bql_unlock(); cpu->exception_index =3D -1; =20 - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { /* * After processing the exception, ensure an EXCP_DEBUG is * raised when single-stepping so that GDB doesn't miss the @@ -849,7 +849,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, * raised when single-stepping so that GDB doesn't miss the * next instruction. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cpu->exception_index =3D EXCP_DEBUG; bql_unlock(); return true; diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c index eecc8d15178..6f27a06da49 100644 --- a/linux-user/riscv/cpu_loop.c +++ b/linux-user/riscv/cpu_loop.c @@ -68,7 +68,7 @@ void cpu_loop(CPURISCVState *env) } else if (ret !=3D -QEMU_ESIGRETURN && ret !=3D -QEMU_ESETPC)= { env->gpr[xA0] =3D ret; } - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { goto gdbstep; } break; diff --git a/linux-user/s390x/cpu_loop.c b/linux-user/s390x/cpu_loop.c index 67d2a803fbc..25f19f725e7 100644 --- a/linux-user/s390x/cpu_loop.c +++ b/linux-user/s390x/cpu_loop.c @@ -87,7 +87,7 @@ void cpu_loop(CPUS390XState *env) env->regs[2] =3D ret; } =20 - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { /* * cpu_tb_exec() did not raise EXCP_DEBUG, because it has = seen * that EXCP_SVC was already pending. diff --git a/system/cpus.c b/system/cpus.c index 49f6daec3cd..2270e58d9cf 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -343,7 +343,7 @@ bool cpu_can_run(CPUState *cpu) void cpu_handle_guest_debug(CPUState *cpu) { if (replay_running_debug()) { - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { /* * Report about the breakpoint and * make a single step to skip it diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 530af305efd..e7550cb3b58 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2340,7 +2340,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) case EC_SOFTWARESTEP: { ret =3D EXCP_DEBUG; =20 - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { error_report("EC_SOFTWARESTEP but single-stepping not enabled"= ); } break; @@ -2549,7 +2549,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) assert_hvf_ok(r); =20 /* Handle single-stepping over instructions which trigger a VM exi= t */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { ret =3D EXCP_DEBUG; } } @@ -2868,7 +2868,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) CPUARMState *env =3D &arm_cpu->env; =20 /* Check whether guest debugging is enabled */ - cpu->accel->guest_debug_enabled =3D cpu->singlestep_enabled || + cpu->accel->guest_debug_enabled =3D cpu_single_stepping(cpu) || hvf_sw_breakpoints_active(cpu) || hvf_arm_hw_debug_active(cpu); =20 @@ -2882,7 +2882,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) cpu_synchronize_state(cpu); =20 /* Enable/disable single-stepping */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { env->cp15.mdscr_el1 =3D deposit64(env->cp15.mdscr_el1, MDSCR_EL1_SS_SHIFT, 1, 1); pstate_write(env, pstate_read(env) | PSTATE_SS); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 01f42f42538..d40a6a98591 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1492,7 +1492,7 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu, =20 switch (hsr_ec) { case EC_SOFTWARESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } else { /* diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 372781ae715..aef981f023f 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6251,7 +6251,7 @@ static int kvm_handle_debug(X86CPU *cpu, =20 if (arch_info->exception =3D=3D EXCP01_DB) { if (arch_info->dr6 & DR6_BS) { - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } } else { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 95705522e04..c87bd1d714d 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2271,7 +2271,7 @@ int whpx_vcpu_run(CPUState *cpu) } } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, true, NULL); } =20 @@ -2288,7 +2288,7 @@ int whpx_vcpu_run(CPUState *cpu) break; } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, false, &vcpu->exit_ctx.VpContext.Rflags); @@ -2653,7 +2653,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu->exception_index =3D EXCP_DEBUG; } else if ((vcpu->exit_ctx.VpException.ExceptionType =3D=3D WHvX64ExceptionTypeDebugTrapOrFault) && - !cpu->singlestep_enabled) { + !cpu_single_stepping(cpu)) { /* * Just finished stepping over a breakpoint, but the * gdb does not expect us to do single-stepping. diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index beda6965f8c..48cdb78a4ca 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1440,7 +1440,7 @@ static bool kvm_loongarch_handle_debug(CPUState *cs, = struct kvm_run *run) CPULoongArchState *env =3D &cpu->env; =20 kvm_cpu_synchronize_state(cs); - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a93f14d6e09..8b219afb5dd 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1772,7 +1772,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUS= tate *cs) } =20 /* Finish DISAS_EXIT_* */ - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { gen_raise_exception(dc, EXCP_DEBUG); } else { tcg_gen_exit_tb(NULL, 0); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 85b15602396..b0c446eea7f 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1617,7 +1617,7 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct k= vm_run *run) CPUPPCState *env =3D &cpu->env; struct kvm_debug_exit_arch *arch_info =3D &run->debug.arch; =20 - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return kvm_handle_singlestep(); } =20 diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index bb329883c97..70f450c71ab 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -1875,7 +1875,7 @@ static int kvm_arch_handle_debug_exit(S390CPU *cpu) } break; case KVM_SINGLESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } break; --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857281; cv=none; d=zohomail.com; s=zohoarc; b=bCsgT4gqjcgK2H8asDrwsU/lRN9x0s7XsKOTXlIvL6R9/7Jx9qnkLBH7faVlTdwJvbjXFNsT+vQXhGkirNtURYwbzPRRuRxb3ikVW9rziySXMXDJRvwgoacBm/hMFdzD1f5AsJG0jYPpkFhGMGQQlmPysWPBZqQRBF2JOtfg7s4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857281; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1WKNytV/XJLd2MaJY50QKZBV9y/Pe7TY0TGhaSb2eWk=; b=HGL4BmEdqW1tSEjyXkLsQT2Ynx60wMcEOJ3cEIfBvi0kWTOxf2+PK9KM2sYYFv6tYS5GigvXcawlIX9ZfRv5L1RDEjBLMUPphz22Upz/p9V6QFTfrQ6Fpli2LfNN1ddJM93chd5O/vr7CQ4ynULuMjd1XMzGntizNR0m11FDfhc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178285728102915.718400641724088; Tue, 30 Jun 2026 15:08:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegc2-0004gS-Mn; Tue, 30 Jun 2026 18:07:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZy-0006ol-DG for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:18 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wegZv-0004f6-Lw for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:17 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDkl82946987 for ; Tue, 30 Jun 2026 22:05:04 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4avpucxh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:05:04 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e695a3b28so169610085a.1 for ; Tue, 30 Jun 2026 15:05:04 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2945sm26265545e9.4.2026.06.30.15.05.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1WKNytV/XJLd2MaJY50QKZBV9y/Pe7TY0TGhaSb2eWk=; b=nr7b03ImWeiTy6yZ 8LS25QOtHW038qLgYU3jgU7+YXulTagJAOgANUpAu7/t9eDZMqxHLE2+oHu6cPO2 baPq4ApsEZAWPl9wLKt2N1WB8XIQO/zT8+1QsrAb3BeIkJUaDQJGHVmcbtX5/N6k ek6MakkBMSWD62BOHon5+ryAltR9vREBo2M+6UIGsySGQb3SZnY1vPhASgW3dlQz P4WJhOR9frz/BGwx9ujp48eqNeWqp+dr/dhId4GTcjOBh9Q9rY2H+WgMGLk+1skY DE91DY3iui4QLdtXLZJTwomeRUlcOxdnnTUpXMafksP8CqBtmT7FoIBqe1z5irQh qsIfuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857104; x=1783461904; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1WKNytV/XJLd2MaJY50QKZBV9y/Pe7TY0TGhaSb2eWk=; b=LgorO74Nb0rqnsd85lCWPCLvet5Rl1mTpInH+m90uHcoduRP+wYu2c+oWZQHub+jnu wCUiY9HyXS0YkRWq1edqCaBC8kGSh18zEjEeYHdXpSX1DSGTK7GasXVkkLAhxicww1+i JFWgIO25mdd1HHeNgxwP5JKPI7sMou/x4x5lymzokc9wXOIRQj+MP9GtcHKqcYIp5rgY 8FmhTHmz1G6jMO4i2l55tPj4OIkbd81XCPKtLUbTEFxM53notgB3uxgwQPxsddyB9T78 OTW6NHqcmXvvAJNuiCuYVvwpRBDcDCVVYKnrzd15jIdyfOn4J5WZyAp3fHNYRT2BzAu2 bx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857104; x=1783461904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1WKNytV/XJLd2MaJY50QKZBV9y/Pe7TY0TGhaSb2eWk=; b=IErAD5HOxETw2WvBN7mWFlgaKon6EoqzRCGjfBOGlRxRcMi/EiG8PIsdaV5zP1afoQ lKo392L1KgVixdAObrPp5WSa7r06KuYUsMvh5EQkYaWqoZ8ZIFTHI5OzprTN9th7L4DO dM6XArqZvDTbGtdgcaTd/sqf3SWQSCN/iuNXRoZvlZQ/bbr2hy0NOmebziwGDzqbuR0X OVvTzyomg9H6BJpMa2QkYD+in17h08c5a9YxomdgXV2YPFsvo+lkZlXhWA0513DX80j0 71LaHh+KW3S672miez+nT+ciCjsMFlb2RNlMz2RnL6aA17Xu0THcss9vDBnZ5Kg0/wYQ Cu8A== X-Gm-Message-State: AOJu0Ywkq2eX9uqMxJ1n/ZVvOo4G3kZzwJGFwZ/NDuN9ujG+D5CVqM4z +tiEVu2TDLmmNcZWlOeTmd58dZFy3CUq1mUb2pwWy4CAmm/fOtbw4Zsn1Zpfir9P1pVFIzFiyB0 FjvyXJ0ueQ/uNNP3Fcznwljp/tges+PL6sfpTVmkPDpdv9xcYeN5JWWhevXmZ75GtJQ== X-Gm-Gg: AfdE7cmi5FUZD5ujZplXOVFDzIhndkpFjJvY0GVmxVTx2clAS6Kf1GAdRrT1kPc6xWA uKoNTR7uNYdNCAOSmAwZm3QsWN96bmFcFxLb72TCr+Hp3pDjaxTyEkODPJ1AMlGl8Hv8nPYJsOG h93aW4jwQQ+/lH6fla/R08Oisqi7j+P2PkNU/0qHQNhgY13SrYSrmF/XtQwl4P7904cKLtGrK9Q nmIOrCcXhLqG1mDHaVirdRWV1oqyCo2BUo1K/eYKWDzn4XZY69FXsTSZY56LZavgrQA+Xm+HGOG d/AmSkYm6IYigHskVux7/dlxezrhroKIOhoSg81HhZ2qmzwdPwJgtPce+7/r8x2xhbxXHAs1GPK TAHBDBksPTIZ0jAgCoFtVXyOzS8P+KY5EGLoL/qhMyABlBrHTV4Lus1zBOgmNUHMbSb5G X-Received: by 2002:a05:620a:4587:b0:929:7356:2e51 with SMTP id af79cd13be357-92e696e6c05mr507900385a.11.1782857103577; Tue, 30 Jun 2026 15:05:03 -0700 (PDT) X-Received: by 2002:a05:620a:4587:b0:929:7356:2e51 with SMTP id af79cd13be357-92e696e6c05mr507891585a.11.1782857102921; Tue, 30 Jun 2026 15:05:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 32/33] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags Date: Wed, 1 Jul 2026 00:00:59 +0200 Message-ID: <20260630220100.1289-33-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: dn7-o5iU2QDw8ZDD1ZoPuJl_stXc1RuG X-Authority-Analysis: v=2.4 cv=KqJ9H2WN c=1 sm=1 tr=0 ts=6a443d90 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Psl2LI6oLFdwa_E3teoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfXxpuxVNPo/vDJ cHxSr8NZSXLJmVDPxJPA9/XxHi21FpBM4PtAuAutUEqP20Wv/fBsc2fCqkXQt+PXur1xYFQyD8N CIMbBbNnBo/P0vJ12qn+3lXAYv+tkGj8tuL2GCz7D2kbblVEahu0VDOHDaIJpZk50JX+KNvnrJU jndO8JBym7FhQdynPLpaC7RcZKLOSFE2cn52ay/m09eOyg/9zVQWdaRG5/xQhy73FpFiTRJfUc4 yN1m4vIVga9qv1uBXlsDV1nWypyaSe1z4DqpyDHPSwSRvRUemcLaGGJhRiZ4eoHRResdE6m4AV3 O5IMVuZI1qk4w1Vh+VR5gklg/WV3rEaWeXdH066MkZYYP8pduJqFkwuMKLg7TIBU+UCntlfQqbb 6aLXNpLUpHM5TNoMyOWXLnymbaadjnmYV6jl3rdzDPLgEn6Eg0LmGxUHD+OOM8WRiYkPBEjkpKO vWnYzCUwLSajUOgNN2A== X-Proofpoint-ORIG-GUID: dn7-o5iU2QDw8ZDD1ZoPuJl_stXc1RuG X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX4ULZE3h44CTV hFN9gEl9Zjgg7+87Zo5vDgqd2HkmhHpfidMABz6sMQrDpkIE8hj6PzNcsmwn8Q16xHf/kmz+D6/ DzskwENa7H+k2O/K5VU849mQhpxkPvw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857283355158500 CPUState::singlestep_enabled contains multiple flags since commit 60897d369f1 ("Debugger single step without interrupts"). Rename to avoid mistakes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 8 ++++---- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 20 insertions(+), 20 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 37ac218bda3..27ee0e54327 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -440,7 +440,7 @@ struct qemu_work_item; * @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU - * @singlestep_enabled: Flags for single-stepping. + * @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has) @@ -505,7 +505,7 @@ struct CPUState { int exclusive_context_count; uint32_t cflags_next_tb; uint32_t interrupt_request; - int singlestep_enabled; + int singlestep_flags; int64_t icount_budget; int64_t icount_extra; uint64_t random_seed; @@ -1136,7 +1136,7 @@ void qemu_init_vcpu(CPUState *cpu); * * Enables or disables single-stepping for @cpu. */ -void cpu_single_step(CPUState *cpu, int enabled); +void cpu_single_step(CPUState *cpu, int flags); =20 /** * cpu_single_stepping: @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int enabled); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_enabled; + return cpu->singlestep_flags; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index c436b1f3751..30aab1cf49e 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3820,7 +3820,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 - if (cpu->singlestep_enabled & SSTEP_NOIRQ) { + if (cpu->singlestep_flags & SSTEP_NOIRQ) { data.dbg.control |=3D KVM_GUESTDBG_BLOCKIRQ; } } diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 0386ac49551..257211235db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -828,7 +828,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, return true; } =20 - if (unlikely(cpu->singlestep_enabled & SSTEP_NOIRQ)) { + if (unlikely(cpu->singlestep_flags & SSTEP_NOIRQ)) { /* Mask out external interrupts for this step. */ interrupt_request &=3D ~CPU_INTERRUPT_SSTEP_MASK; } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 5b132d3d5d8..cdaa3e11808 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -274,7 +274,7 @@ static void *rr_cpu_thread_fn(void *arg) current_cpu =3D cpu; =20 qemu_clock_enable(QEMU_CLOCK_VIRTUAL, - (cpu->singlestep_enabled & SSTEP_NOTIMER) = =3D=3D 0); + (cpu->singlestep_flags & SSTEP_NOTIMER) =3D= =3D 0); =20 if (cpu_can_run(cpu)) { int r; diff --git a/cpu-target.c b/cpu-target.c index 019906b32eb..a504540c939 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -28,12 +28,12 @@ =20 /* enable or disable single step mode. EXCP_DEBUG is returned by the CPU loop after each instruction */ -void cpu_single_step(CPUState *cpu, int enabled) +void cpu_single_step(CPUState *cpu, int flags) { - if (cpu->singlestep_enabled !=3D enabled) { + if (cpu->singlestep_flags !=3D flags) { trace_cpu_change_singlestep_flags(cpu->cpu_index, - cpu->singlestep_enabled, enabled= ); - cpu->singlestep_enabled =3D enabled; + cpu->singlestep_flags, flags); + cpu->singlestep_flags =3D flags; =20 #if !defined(CONFIG_USER_ONLY) const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index e7550cb3b58..3cfa8dd2445 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2603,7 +2603,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 do { - if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) && + if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { return EXCP_INTERRUPT; } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3f6d326cef3..06ed2adf105 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -198,7 +198,7 @@ struct DisasContext { bool pmu_insn_cnt; bool bhrb_enable; ppc_spr_t *spr_cb; /* Needed to check rights for mfspr/mtspr */ - int singlestep_enabled; + int singlestep_flags; uint32_t flags; uint64_t insns_flags; uint64_t insns_flags2; @@ -367,7 +367,7 @@ static void gen_debug_exception(DisasContext *ctx, bool= rfi_type) #if !defined(CONFIG_USER_ONLY) if (ctx->flags & POWERPC_FLAG_DE) { target_ulong dbsr =3D 0; - if (ctx->singlestep_enabled & CPU_SINGLE_STEP) { + if (ctx->singlestep_flags & CPU_SINGLE_STEP) { dbsr =3D DBCR0_ICMP; } else { /* Must have been branch */ @@ -3645,7 +3645,7 @@ static void pmu_count_insns(DisasContext *ctx) =20 static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { return false; } return translator_use_goto_tb(&ctx->base, dest); @@ -3653,7 +3653,7 @@ static inline bool use_goto_tb(DisasContext *ctx, tar= get_ulong dest) =20 static void gen_lookup_and_goto_ptr(DisasContext *ctx) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { gen_debug_exception(ctx, false); } else { /* @@ -6559,13 +6559,13 @@ static void ppc_tr_init_disas_context(DisasContextB= ase *dcbase, CPUState *cs) ctx->pmu_insn_cnt =3D (hflags >> HFLAGS_INSN_CNT) & 1; ctx->bhrb_enable =3D (hflags >> HFLAGS_BHRB_ENABLE) & 1; =20 - ctx->singlestep_enabled =3D 0; + ctx->singlestep_flags =3D 0; if ((hflags >> HFLAGS_SE) & 1) { - ctx->singlestep_enabled |=3D CPU_SINGLE_STEP; + ctx->singlestep_flags |=3D CPU_SINGLE_STEP; ctx->base.max_insns =3D 1; } if ((hflags >> HFLAGS_BE) & 1) { - ctx->singlestep_enabled |=3D CPU_BRANCH_STEP; + ctx->singlestep_flags |=3D CPU_BRANCH_STEP; } } =20 @@ -6641,7 +6641,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase, = CPUState *cs) } =20 /* Honor single stepping. */ - if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)) { + if (unlikely(ctx->singlestep_flags & CPU_SINGLE_STEP)) { bool rfi_type =3D false; =20 switch (is_jmp) { --=20 2.53.0 From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782857159; cv=none; d=zohomail.com; s=zohoarc; b=YjcDFc1bImfbQUwQLIqeUjLdBqY2OaaApK2JUeGGo+747yzw+TJY5crNnuA83knPjTw+Ytp98FppE9A9kApm54+58nPZgfsTpxpkiXBvuqSr3UitEduHI+n9t9dI8GD1xpHfQOFbD/8iaQ/KRuopxAykfm6qfkrUo/GLQdXX5Kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782857159; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=p56awPU6THMjJ15KBUtvHFIwjnkrtFhsHZARiLXZCh0=; b=etHiexaYyCmnPU7miwUiLAV9S4hIY3Ez9hDNvuySyolqLyVcra0o+FJjif3NSFD1LEnbtzS5e+lJRcnVYGniTONtWwbEv+EKXC0f2ZGP3kYtPAnTu2h1xybOJkmKBgHllcd2bzz+7OvTBJ/IcgTt5sRbfY4TShQCbJfzG7WJrng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782857159467356.5595556280298; Tue, 30 Jun 2026 15:05:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wegaZ-0000Ob-6U; Tue, 30 Jun 2026 18:05:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wega7-0007G6-DO for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wega2-0004u3-VZ for qemu-devel@nongnu.org; Tue, 30 Jun 2026 18:05:25 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UJDjki2879944 for ; Tue, 30 Jun 2026 22:05:12 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4hfy9csr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 22:05:11 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e4f946461so585780685a.2 for ; Tue, 30 Jun 2026 15:05:11 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47563d19ba6sm10429431f8f.6.2026.06.30.15.05.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Jun 2026 15:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p56awPU6THMjJ15KBUtvHFIwjnkrtFhsHZARiLXZCh0=; b=F59aipw0rUJXLrOz SBp7Jhi/rkdYfOMr0CUXotNevFltwR7oaVVWkoOL6wrctdlQ3it/qSqgErB5roGR ph75eaXlqmxw8lF2tYuOxcJH7sm3eIyHVY62R4sx3q8OFRfCRMK1f+FQVsb4IUf2 UXOqxkDcx2MTwcBTTrhUpagY9k/naUX0vtTJ4jB0CJ/GWD3qReeDMwsnU7UTTI/d kHRN6qzxyZr2J90nQfVsaFK463VJQj3iAIXsZ6ovb9iI3AO0FxjExaQOzV74OkM6 7CY7P7Qu7gtYoJKgkGVAbyRHemh01wucTLXGRQ9UtzzAcv5QIcWWp42nLMvGndUY ZKntaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782857111; x=1783461911; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p56awPU6THMjJ15KBUtvHFIwjnkrtFhsHZARiLXZCh0=; b=OV3BnzDzZbFx5lc8Mp4clg7zZVz0hiNXsNf7phxd2vv9dmMa6z8ilbG/8B3MHlJsEE nZ9CGgwCpCXr2JKsG7x79BPM/qOzJoF4RHY0l+jfIIwruqY1hCH5Zlor3wJWX1lVbjuU EoPnMAMY1AFO+dMF3pSLaKa2uPRCA9CuLWb8+L8QFFeHAjkPGZFXWPuZCi/bFxw370+i xnqasb8Ti2+QogeZFSb3b6SQAxNVILbpajhnnwiLITfdgr58bC4gD8h5hqwxbhZ8I0Sz JuxSfkpa8Ed2EqKsu9cr0XcG+76wO64HL93KgaqQVojGzkt8Z/TRjKnYJ2KI5KA3M5rb gSkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782857111; x=1783461911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p56awPU6THMjJ15KBUtvHFIwjnkrtFhsHZARiLXZCh0=; b=YHS4rcdtSGLzwKrAMPkDtGiJrSDsSSHvOG3aiaam+JdIEgttspUgG1OWC05rwiM+qg Ww0KW/FIxnfg5SbToQNK4Q9dXUMYpJv5uBDXPZiOhsKDAFHFCfeptynJUScqNUhyZC8w oEqlksmHmsu9fZrhfLKMtnaCSsQ1hjtLh4HJ/RmMSklscAfemgB1ezFhYuD8N7mQzxVo r0ZdZJlAd1RQT6M6iy7X2npDP56XO3YygqpF8/Mc2rQhNoGjUTn8Gc/L00SdUEgitvea rOD+vLco4Pd40pVtwy+zLTbaWrfaaIE6ArgKed0TFgxE5n4nJikVogsJAZenZCv+QaYv 1WVg== X-Gm-Message-State: AOJu0YwGVnLhUVvbLqBJdkDmRkboMHeH2KaH8kzDdVOCgjpyxDWFwXLw BZyi0ZdBejG4QnHX+MWYEhm45d/qX74TwqkMnG/GxX6i6kK015GsV+V+bXYlfvd7Jl6JrkKn1bP Rt0zzeKgnRs9BzQLHgFFFFwSEaBIf2rJMYWEBt2qDjM/lLwzrRpI8p5sR/p0PZvcYgg== X-Gm-Gg: AfdE7cnde19gd4sd73maT8oExirLqfGBcUjogrO4vO8WCa3Iqq2c2SjJH3WvzfLlqXw GN/+vlsORF6iLjIzrMMkHmroxYvKH1eg2myw0VLV4GBfKs8nIOuUOpCEanr/fqXCWfE1srpi2T9 nqShonvK8hLVsxwvIpQfy0Smxk365lIR6km8Mc2ejQ4gufOwU4qMhpjTIZ2dwkxmn50OLtnfd8c XpIBH6hPWzMTwczRIpkgv9w70CH2xAkpoatEF/bEZ5valg1GBNpxfVgE7kayPphjKoiZWWU3lWi P60ahwkxMYmJhtNcu1tPBDFFmcy97qDYYZ8eKcgQ78UI3f2KwOiRokMbj7HBQ/NjpsfMuEm/A7Q c0qkw2f6+roVXUFTESJ+xVYTlu3iqq+NdWE8KJvwrNrtHYT8fOd+/dI67YmM6p+40f1Ys X-Received: by 2002:a05:620a:a1d6:10b0:92e:72a4:f291 with SMTP id af79cd13be357-92e72a4f750mr76877585a.35.1782857111306; Tue, 30 Jun 2026 15:05:11 -0700 (PDT) X-Received: by 2002:a05:620a:a1d6:10b0:92e:72a4:f291 with SMTP id af79cd13be357-92e72a4f750mr76871685a.35.1782857110749; Tue, 30 Jun 2026 15:05:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Xiaoyao Li , Chao Liu , Zhao Liu , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Richard Henderson Subject: [PATCH 33/33] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping() Date: Wed, 1 Jul 2026 00:01:00 +0200 Message-ID: <20260630220100.1289-34-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260630220100.1289-1-philmd@oss.qualcomm.com> References: <20260630220100.1289-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=J5OaKgnS c=1 sm=1 tr=0 ts=6a443d97 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=67IpyjWKbRJXbWkAkIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: Ho2_4H5BxTZyyv1bsh0hPHwZ5rbR5lKJ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX0TVZUfTIz9Ym YYi2NAvDbgC19wkG9uUeWEjcpjfP9vN6YdYB2Yks2+ml3eVV3zKcJ61dsR+kXpWGYPXvUZQyJDu Kn6jRNDXCFu9DCP1EFACB94jo6GKXlw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDIxNSBTYWx0ZWRfX4J5f6kn6vc2O pIBgQPdCbdvhjLIQiS2TCyi5OYjdP+Hy3HSXJ5wbmDKiagi80+r6AuYM0+LXR6UJmIDryNbhjKn QNh4yRBGyrevbCoT5hX18eqBH0mdRLOGpqymcwjgwAmoex9yFu1tXZxZ+xu8BCEUewy6ZerJ2fN PJBT36MpKs4S8yUsnuZNrIBNEBF5NYDS2X6L58zuAQ0D15zXttpw9jODidd/CcEFIsq2lSd492W aRNd4hr1O78yUMtUCiCNMEPEXDuoAo8OkO5JXkgUECMAS5RxLqQKtUryDmBsVjPMmv/OzLFxK1a JyV2vC+689pAWZ5NcLTCstJ0poIvNZkw2PUC6ZkSg8cbkbmvccTr+4UqwGWqUPSo1wZwAG51omm 8VGt5xcAqk9l7demF06begdVTiIOHRp9LdwK0vRGKfiU23P+rg6gBHKl+Mq72KGzRUCOOwar1qB JBkn10vKCne6r27QEEQ== X-Proofpoint-GUID: Ho2_4H5BxTZyyv1bsh0hPHwZ5rbR5lKJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_05,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300215 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782857160573158500 Only the SSTEP_ENABLE bitmask means single-step is enabled. Fixes: 60897d369f1 ("Debugger single step without interrupts") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 27ee0e54327..d092ab8aa5b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int flags); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_flags; + return cpu->singlestep_flags & SSTEP_ENABLE; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, --=20 2.53.0