We currently have three methods that a target can use to implement
"translate virtual to physical address for debug purposes":
get_phys_addr_debug, get_phys_addr_attrs_debug, and the new
translate_for_debug.

Only microblaze and i386 implement get_phys_addr_attrs_debug;
convert them to the newer and more flexible translate_for_debug,
and remove the get_phys_addr_attrs_debug handling entirely.

Changes since v2:
 - patch v1: fixed bug, changed mb_cpu_translate_for_debug()
   to the "return a struct initializer" approach RTH suggested

Patches 2 and 3 have been reviewed, only patch 1 needs review.

thanks
-- PMM

Peter Maydell (3):
  target/microblaze: Convert to translate_for_debug
  target/i386: Convert to translate_for_debug
  hw/core: Remove SysemuCPUOps::get_phys_addr_attrs_debug

 hw/core/cpu-system.c             | 11 ++---------
 include/hw/core/sysemu-cpu-ops.h | 14 --------------
 target/i386/cpu.c                |  2 +-
 target/i386/cpu.h                |  4 ++--
 target/i386/helper.c             | 31 +++++++++++++++++--------------
 target/i386/whpx/whpx-all.c      |  2 +-
 target/microblaze/cpu.c          |  2 +-
 target/microblaze/cpu.h          |  4 ++--
 target/microblaze/helper.c       | 16 +++++++++-------
 9 files changed, 35 insertions(+), 51 deletions(-)

-- 
2.43.0

On 28/5/26 18:14, Peter Maydell wrote:

> Peter Maydell (3):
>    target/microblaze: Convert to translate_for_debug
>    target/i386: Convert to translate_for_debug
>    hw/core: Remove SysemuCPUOps::get_phys_addr_attrs_debug

Series queued, thanks!