hw/usb/ehci: Improve migration helper and property naming

[PATCH v1 0/2] hw/usb/ehci: Improve migration helper and property naming

Posted by Jamin Lin 2 weeks, 5 days ago

This patch series is based on the following patch series:

https://patchwork.kernel.org/project/qemu-devel/list/?series=1089061

hw/usb/ehci: Add 64-bit descriptor addressing support

The above patch series has already been applied to the aspeed-next
branch of:
https://github.com/legoater/qemu

This series only contains naming and comment improvements based on
reviewer suggestions.

This patch series depends on the aspeed-next branch of:
https://github.com/legoater/qemu

v1:
 1. Rename migration compatibility fetch address fields
 2. Rename CTRLDSSEGMENT default property

Jamin Lin (2):
  hw/usb/hcd-ehci: Rename migration compatibility fetch address fields
  hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property

 hw/usb/hcd-ehci.h       | 23 +++++++++++++++++------
 hw/arm/aspeed_ast27x0.c |  2 +-
 hw/usb/hcd-ehci.c       | 14 +++++++-------
 3 files changed, 25 insertions(+), 14 deletions(-)

-- 
2.43.0

Re: [PATCH v1 0/2] hw/usb/ehci: Improve migration helper and property naming

Posted by Cédric Le Goater 2 weeks, 1 day ago

JAmin,

On 5/6/26 05:26, Jamin Lin wrote:
> This patch series is based on the following patch series:
> 
> https://patchwork.kernel.org/project/qemu-devel/list/?series=1089061
> 
> hw/usb/ehci: Add 64-bit descriptor addressing support
> 
> The above patch series has already been applied to the aspeed-next
> branch of:
> https://github.com/legoater/qemu
> 
> This series only contains naming and comment improvements based on
> reviewer suggestions.
> 
> This patch series depends on the aspeed-next branch of:
> https://github.com/legoater/qemu
> 
> v1:
>   1. Rename migration compatibility fetch address fields
>   2. Rename CTRLDSSEGMENT default property
> 
> Jamin Lin (2):
>    hw/usb/hcd-ehci: Rename migration compatibility fetch address fields
>    hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property
> 
>   hw/usb/hcd-ehci.h       | 23 +++++++++++++++++------
>   hw/arm/aspeed_ast27x0.c |  2 +-
>   hw/usb/hcd-ehci.c       | 14 +++++++-------
>   3 files changed, 25 insertions(+), 14 deletions(-)
> 

I still haven't read comments on v6 ... Since we have time for
QEMU 11.1, please wait a bit before resending.

Thanks,

C.

Re: [PATCH v1 0/2] hw/usb/ehci: Improve migration helper and property naming

Posted by Philippe Mathieu-Daudé 2 weeks, 3 days ago

On 6/5/26 05:26, Jamin Lin wrote:
> This patch series is based on the following patch series:
> 
> https://patchwork.kernel.org/project/qemu-devel/list/?series=1089061
> 
> hw/usb/ehci: Add 64-bit descriptor addressing support
> 
> The above patch series has already been applied to the aspeed-next
> branch of:
> https://github.com/legoater/qemu
> 
> This series only contains naming and comment improvements based on
> reviewer suggestions.
> 
> This patch series depends on the aspeed-next branch of:
> https://github.com/legoater/qemu

Since this isnt' it /master, it makes me wonder why not squash directly.

> 
> v1:
>   1. Rename migration compatibility fetch address fields
>   2. Rename CTRLDSSEGMENT default property
> 
> Jamin Lin (2):
>    hw/usb/hcd-ehci: Rename migration compatibility fetch address fields
>    hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property
> 
>   hw/usb/hcd-ehci.h       | 23 +++++++++++++++++------
>   hw/arm/aspeed_ast27x0.c |  2 +-
>   hw/usb/hcd-ehci.c       | 14 +++++++-------
>   3 files changed, 25 insertions(+), 14 deletions(-)
>