From nobody Mon May 25 14:42:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1778038087; cv=pass; d=zohomail.com; s=zohoarc; b=oH3+onMCAVuW8fBwSzLNq6wrG3K/dbrfGSHuoFgEZ9mFRQeNUIkEg+lKRonKDBS2o6/PiCYn4IaqFhP1Lr5yZEI101Hvot8DYeURlNxfYc37hwYji36F5urBot3zrhjE0gT+Lf6wwKas3ScOcIU3Sl08oppltmCm/7aW5gRxYT0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778038087; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/0Z3fhDJh/SxiuCFbf2Spdj7BoLHYafuISJw2v/PxPI=; b=CuIfOD/PH3sQV4SNubrHlTal+sr6ZG5HgnvBS8zO3Q0QCC/aq5BwAUqCAJObUvzvhsZuoAS8hT0+HGl6cOYtpqqDOo2lsr9fVZdBJpKdPJdhE/o3eef69jDVjnv3ASLa1CPhkQZEhmolci032tZkArJVzKlrUbWKhXD9JBAFFgY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778038086722317.2585900374968; Tue, 5 May 2026 20:28:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wKSua-0007oy-7I; Tue, 05 May 2026 23:27:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKSuY-0007oA-P5; Tue, 05 May 2026 23:26:58 -0400 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKSuX-00052y-5W; Tue, 05 May 2026 23:26:58 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by JH0PR06MB7325.apcprd06.prod.outlook.com (2603:1096:990:a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May 2026 03:26:45 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%2]) with mapi id 15.20.9870.023; Wed, 6 May 2026 03:26:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L+9wuz9zq6/FvbU/RjmhjP486/jpDnT75k41H37OCeKl0y/t1WPB+g5yBK1HH0nf4B96GRhRGabX4cPQ+dgGfrb4d/sXhbr9nomftkbi3J9DL2ciYwh/dhJTRR0Tr6tep+7GfmzydsSMPvqSZGiIfsnN4yzC9IofiO8jOkDAT8sUDdY4FpSmmPu8FxjuOsLyJVAxv3SxUdJEBqS5jJ6RrFF5/AF5APfb/+08WxJQlDveyP2uY6C+198BimFb8S/Y3GW3aW0Q9SEudr5hinIeorGXrkvbreJBnjCbuHMa0Bd5Onz+CyHYfMPIXjpyBXPmmERucj18gOKS9K6CgGPRLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/0Z3fhDJh/SxiuCFbf2Spdj7BoLHYafuISJw2v/PxPI=; b=fLvGvFrJcACX+u97/Q6OrI0Lxx9Ip303Uy4XH9WAoKKCqOG155aomS/YGphHlEfDiTi51KsS14ZnTInZFKqJnELTXgf8NdSzjpOnTRfevIH/C7/xxicG5AVjS2gu3cUwy4PNpi+0qZGQNina1cYql28wb1GEwcztJTHgC+KgpSvSGs0tGkXmxqaVXlVo8aKP9ujZFSQxWXHwx540MmndYVmChnQmG2AxxcLEak2sIr4ekJSkwFMHcRxizsMDldIP9zgJS7kkLYdJIvH4ueWCMDTu2cSb2pidHhJifm+/tGuqTTXSmWI3gZj+doZuf4aPtJIGnLyI52PEGwPc801D0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/0Z3fhDJh/SxiuCFbf2Spdj7BoLHYafuISJw2v/PxPI=; b=CujhCG9HgounMFYOppEixGvas+lnXaoopYp6MGkV+fCO+7/XRNAi1SqLUOiYCwYdV7lgNqBpZchIFKaCWA5QWKZ5iqoYUZRUwrL16gPI8WKfhkAKNnZ3tFo3meOQLtTsNRCunbRPGwywfFjUsZwvk1v2fPXqSXLwXoaosAs3lJTE3SKsSvw7bF91RB17nd5HSIEkA05d2Fr+LM9u1L+yZ4y5M6LnEC9X1Q/fEM1ElE2E1NP4tzT0vy5bJFQqsgXWhrPfBBsAFwp5e6hbqz7SXIVW2v05TKdYxN/qwTKilsJqH0h/6A+QzYQ+sUKntAi+3NyCXvSGhx4TA0yExo02PA== From: Jamin Lin To: "philmd@linaro.org" , "peterx@redhat.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "farosas@suse.de" , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v1 1/2] hw/usb/hcd-ehci: Rename migration compatibility fetch address fields Thread-Topic: [PATCH v1 1/2] hw/usb/hcd-ehci: Rename migration compatibility fetch address fields Thread-Index: AQHc3Qgqcy8dSi89vkGRdd4mbz53gQ== Date: Wed, 6 May 2026 03:26:44 +0000 Message-ID: <20260506032643.2510575-2-jamin_lin@aspeedtech.com> References: <20260506032643.2510575-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260506032643.2510575-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|JH0PR06MB7325:EE_ x-ms-office365-filtering-correlation-id: f00a3af2-3724-453d-9577-08deab1f4c8b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|7416014|376014|921020|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: 2gej/5wjYxGyvHXI2G4d3DNr4Mk8JSxJ71GsXmsjDqOgD1Otj+ZokqDIP4oKvCVcQxJrEggLZIitpjKw3R6cCXhI6JdQyZgWEe7EWKnskFFzCYRLATXiL19i+F6aJEik15fTEMVpXKRjDSy8bMTsUwbH3e1I3TxLybGZrbMcYQqyUXn4+MU0V4koDol2JxWgDh35PBXKqKqTMAWh3LpK/TbBaOJTN9nPnXMjw8vLJU3ZXqyRCjGnrEYPv5CB3RhOR0SegyjhVgKKvASIH7rMnYex7XuuF0gr8s/6ZuCcHu65hKfOuFVfX2p7gTKgLaDdzATTS0RjdrNxyHsQPAbC/pr6Mq1WJr5sasnsQrV4YoVfqqeusxSIquYpQ+P2/bBKNmt0SPHIn73MtmiVE0LmNFgbXxK1R7VFIZP77T66YOhVZ6/RCVkRLumWBQVwJX1xX1kICoF6pZH9FG/ocIiHoKYkbUzRQfU6cw0TbC/vyGu6IBg21nL56oNZmaA0a5owe42oqsVZ2XOvU0BD83iPTG9vAlLYCXGmJMunqE3o3DME6/g2dXDrR/KolZMz16yqLx8FRSvxHEt6IrZzBtD0whyprOSPHjB3icEAh2IkghtqX5IAnYTw4Rvx+ujaH62zXRYSGMzO8SWnOHj5m7EG6c+b7C7Tcr5BPaDXn24oZDfyik1Emm1dSASEP88tM/gvzkAieDCibNw2azSdrx7zrJHLyiUGhAOPk+IlOgACTYuQaJ+KH3Tq3OrcEPBB+yFNnxvUzFE0dyaojmVKPbSQOg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?i6e/1Z5n4NMylGfjeU5aYLcATSSWMoAWkU1YLs/9I9loRbgZRCpFlM3Fvm?= =?iso-8859-1?Q?dcuuRMIzmi6Hf7DM1RKAzFlWqfJ3UEFBX/JbUvEQ5KtyjDOb8Duj1zbCRH?= =?iso-8859-1?Q?KQOl2HLAKW/3OqTct7/BQcdIUhcEw5gTLJvY2FT8DqMs6Ld44Mm9W8+F//?= =?iso-8859-1?Q?cn3IE4C5IpGcPD2bKzQPhD+1nSCyC4bXDcaNTuBDbn48WnBsQ1XVBHZWMQ?= =?iso-8859-1?Q?oK9dFSbk+tZ0pR1Gc4qKQEgRjUTOTMPv6cWo0bqLb9TcUW5E6By+nWYRR9?= =?iso-8859-1?Q?AlFj0DsQKRWyUrp5pXTEMmbFWAfVAZ9m6o78eRDp6DeXK3jCqv9V15wnNk?= =?iso-8859-1?Q?mjQ5MvM3ERWovC4oxDl2cpcNUlrtm+CWia8VYEJNwD+3ZW9bUIj7qiVAEv?= =?iso-8859-1?Q?PTkxNKGfVTCCIpbZpCGN+LcNpDwS6OLOGlXkizz+aUxFSimYMN2S4Nwq9Z?= =?iso-8859-1?Q?6IZjblwBEn5rVe94Oveu0N8EcPd2hVsrxHU3jA65rcUjkDAhlBUknRJjoF?= =?iso-8859-1?Q?zXu6/ESul9GGhTHpZtQ26m+uPl68EJwAOFqYMe/gw9qZ++akGcX4d/RPZn?= =?iso-8859-1?Q?0ZWEc7AdGl0ta7Gxvrub/BsySatIEZF+q6WIxbmm5xRtxHLNZbVzPLJEhg?= =?iso-8859-1?Q?2A4DF0rCjUZlzcOlvxe0LGED6sh8YHl/M51gfmL62k99sNWXg/4xCVK9pH?= =?iso-8859-1?Q?0Lu7ZPPXYjC3hmBASkUivslfuiXQGPixSViSQAmAgNxpV9dc5bE4NCq/B7?= =?iso-8859-1?Q?OAwOMB18qE5Zm/kac3K44ywQb9qwcnq/uYwbSLvbmsCZuTSKkhXb//Hcvd?= =?iso-8859-1?Q?xsOqB6p2mGkHCfHfO5YwMQfff2hineMhTbWG/Tf3GK7eoh7iKkCP8hf3Gr?= =?iso-8859-1?Q?thwfMTg8N37qGA7ncSLotw5yvpngxKZgBobzFlW1xWQYT241a80nu2beST?= =?iso-8859-1?Q?l5bUcDDnL/PIJAjWxWAFJHuGTfRU5U0Hc+1xQ5ExqmeHAMAfJLYEqjGR4A?= =?iso-8859-1?Q?sIZ/95UJ2A3Mb6St1bqZTKVTLn2k0ionCByMK1FM7/I2fskpbPTGYqTMGQ?= =?iso-8859-1?Q?Re4oWtneD/oHeQq5USP+huyvrEbWWrC3HaZImEw8zon9ddwCmOGefEx2Vn?= =?iso-8859-1?Q?W/ARl6c0toVUZFsqrrUNHU0EN+Nl8j6zHkF8+SDhIgEbhJ6tK/m4GcGMIp?= =?iso-8859-1?Q?MJ/C87et0y/+Oci8D0QiG/gAfmb+KVuEkuaKjkv/uwewArn6RkOjHwyNVt?= =?iso-8859-1?Q?bgAOD06tZgh/Puw7UR59p8zpdRQ1aOZ67E+88t8P8GR5yGy9w2+vmdKfgg?= =?iso-8859-1?Q?gXTP8oQPQ6ituOi2yT8ye74Nd2WaNGL3YG1xbuhKT2RrgMA39Utr/H6lB7?= =?iso-8859-1?Q?Kv/5B1uZH3q/i+5j/x2dwRQ4MlQMKTaeajUBOxlC0Ecik+tRMPLQLjbmfa?= =?iso-8859-1?Q?EOTg0fW5QOmn3zHogemsTfRT+BKg5D7XNb+aEGP0V7bgL3qUc61p896BJb?= =?iso-8859-1?Q?EsjHI8uzmR6IopeJN+muo5R0uVfGQ7o44sCzTrZmI9PUk1kchoOVGDYRrC?= =?iso-8859-1?Q?T4CZjTvxiSfWXGD0+p//5RlILPMg1Zndzj04T3QSLEcIb1OvPrzwWKmm/Y?= =?iso-8859-1?Q?XKMgLZ5HKggffJsy4CLpIMHDAYjfVGqOo0IOJ+CW7y2tFZdyytK7pOI1p4?= =?iso-8859-1?Q?/JDjYa3btOwmShBsBXTVrku1hR6IQdLm5HQ2VIcEe9itlPLLWJXsGqiGRc?= =?iso-8859-1?Q?NPSTzV5rkVfUWAWDi6XrIQivmR8NWQZZc3pYMcqWCFwaR9rdPRDpFXhZDs?= =?iso-8859-1?Q?xxTsWe31Pw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: QMrSbmy9e5AG6o8nW3PdxI1VZk66afdMDJQ0GLDzim4b2D4x7s1kdwegRKApKLCSLigidDyf7nwYCz6KhCG4QJZv56qyUdtdyWjjTZVf7MaWs/EiQV9zcRR+G0EbLQLPT+8vv5lgJk6mzabYlqXgAwGGsqNFckg7MnZu78AHKpfBdg3otKo5YuG+iufYPS48D+h3rPHDQs+EITRcgjvdwEXBhBkVtb9xIUag5Y2yTHfLoZ1IMkO5YJXDo3JD824+PlEU/nsabvCQm1/Kkz+P2CPRE8xnx/2Ddi5bAxdouPQCKTN1HCyXTiF+pYSmxcc0sRJAx8d2GoKlf4EYtSuN6Q== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f00a3af2-3724-453d-9577-08deab1f4c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2026 03:26:44.9258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mJTYtT2Njzxpyb43fTczh7zmUt/hr09vy0vKxSDhxrsdUNwcqdGlcJJ3S+EOT4Bvw/L366SyH06uio5mmH8OB7CvEku6zLQ9zreBGcvSbOA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7325 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1778038090185158500 Content-Type: text/plain; charset="utf-8" Rename the 32-bit fetch address migration helper fields to make their purpose clearer. These fields are only used for migration compatibility with older machine types that transfer 32-bit fetch addresses in the migration stream. They are not runtime fetch address state. Also add comments to clarify the relationship between the migration compatibility fields and the runtime 64-bit fetch address fields. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-ehci.h | 17 ++++++++++++++--- hw/usb/hcd-ehci.c | 12 ++++++------ 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 3d57e1de5f..b5ac9c8670 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -262,6 +262,10 @@ struct EHCIState { =20 /* properties */ uint32_t maxframes; + /* + * Controls migration stream compatibility for old machine types. + * Old machine types only transfer 32-bit fetch addresses. + */ bool migrate_fetch_addr_64bit; bool caps_64bit_addr; uint32_t ctrldssegment_default; @@ -302,9 +306,16 @@ struct EHCIState { EHCIQueueHead aqueues; EHCIQueueHead pqueues; =20 - /* which address to look at next */ - uint32_t a_fetch_addr_32; - uint32_t p_fetch_addr_32; + /* + * which address to look at next + * + * Migration compatibility fields for old machine types that only + * support 32-bit fetch addresses in the migration stream. + * + * New machine types migrate the full 64-bit runtime fetch address. + */ + uint32_t migrate_a_fetch_addr; + uint32_t migrate_p_fetch_addr; uint64_t a_fetch_addr; uint64_t p_fetch_addr; =20 diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 62c3770ac5..56ac8f6ae5 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2482,8 +2482,8 @@ static int usb_ehci_pre_save(void *opaque) ehci->frindex =3D new_frindex; =20 if (!ehci->migrate_fetch_addr_64bit) { - ehci->a_fetch_addr_32 =3D ehci->a_fetch_addr; - ehci->p_fetch_addr_32 =3D ehci->p_fetch_addr; + ehci->migrate_a_fetch_addr =3D ehci->a_fetch_addr; + ehci->migrate_p_fetch_addr =3D ehci->p_fetch_addr; } =20 return 0; @@ -2507,8 +2507,8 @@ static int usb_ehci_post_load(void *opaque, int versi= on_id) } =20 if (!s->migrate_fetch_addr_64bit) { - s->a_fetch_addr =3D s->a_fetch_addr_32; - s->p_fetch_addr =3D s->p_fetch_addr_32; + s->a_fetch_addr =3D s->migrate_a_fetch_addr; + s->p_fetch_addr =3D s->migrate_p_fetch_addr; } =20 return 0; @@ -2571,9 +2571,9 @@ const VMStateDescription vmstate_ehci =3D { /* schedule state */ VMSTATE_UINT32(astate, EHCIState), VMSTATE_UINT32(pstate, EHCIState), - VMSTATE_UINT32_TEST(a_fetch_addr_32, EHCIState, + VMSTATE_UINT32_TEST(migrate_a_fetch_addr, EHCIState, ehci_fetch_addr_32_needed), - VMSTATE_UINT32_TEST(p_fetch_addr_32, EHCIState, + VMSTATE_UINT32_TEST(migrate_p_fetch_addr, EHCIState, ehci_fetch_addr_32_needed), VMSTATE_UINT64_TEST(a_fetch_addr, EHCIState, ehci_fetch_addr_64_needed), --=20 2.43.0 From nobody Mon May 25 14:42:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1778038073; cv=pass; d=zohomail.com; s=zohoarc; b=e1S6xEC7RuADl1laCFHqYzgVFQdfb2uPO6vJpexI8Bak5S/H/8XvNfqEhCmoSo4+jjHo/fnEcxmqWXsy4kpzTpl2xhCitDxxDdq9GzdzQFB3M5uJ2FJ25dS/Ns9qtLIcHNuJBbG73cgSHjpj1GqMsWYhuCVL5+EvRIVfsKsseyw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778038073; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7i3YzYGoCDFNANobA1O5weyk1InX22deCeDRyPf91Rw=; b=nTE8Gk109jy3usS6uwI1E4qzG2vc2ONvSoCKbXxa0q7MQWbEWovuWYS0Cxq1x+K/GIYVk7Uet+RfhPRylXJHdMOjysLhCS2fFr2yvtN1FXSt6gM5aW0UKYShpVZyQLyHYHDkWVM3csF0iIpnsezTAMNDmhw0WAnxPFeeZ60oKVU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778038073490493.2009830865062; Tue, 5 May 2026 20:27:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wKSud-0007pg-J6; Tue, 05 May 2026 23:27:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKSuc-0007pT-34; Tue, 05 May 2026 23:27:02 -0400 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKSuZ-00052y-M9; Tue, 05 May 2026 23:27:00 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by JH0PR06MB7325.apcprd06.prod.outlook.com (2603:1096:990:a1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May 2026 03:26:45 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%2]) with mapi id 15.20.9870.023; Wed, 6 May 2026 03:26:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BRTsmBMPJZ4dEY/vRv2mE1GJj17I4Vi7ueUl1BI8o36/r6XRRucRhruh9KH/fYz83K8MurL0nstfU3dICjUjO3jsXvBPxuG4Cuqn6qtYgbvSRom6HLp6RN4A/4QdyGllDM5TPMqRZtxZfbnFtPif8m+kFC0UAQU4HaEYGkuJxtlQ3KwbVld/vFIP5U98IXj8UVqPRA2r8B03RbK3FFSQ6nafzIrKN1P1hNotmmksbHu7UDsJ06e+eipjoR1cyX6a95v0wCUNkEiZYDBFEjNVotYvZ47tZL1EpSnIab1I+yE3eSsO7/B+Zp2RPsxCuOLUXlS7hvRrmalQOaidJyZRyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7i3YzYGoCDFNANobA1O5weyk1InX22deCeDRyPf91Rw=; b=rlwDB3Amnr7C2lx5mzV4aEZzWI6Tkiaonapf9LT4JuL7xiE4slJ0Z62Fq2EIa5cHZ8JKhbsqDTtlm6MiyYhW5KvnuwZAKnNvu/D7JyRzKYxIq9YB0lO+LhxF8zRTrPlV4r82VvZrTlZdyJ6VmCk8qZNuqUS0WrF0DKusmCz3qMwKbMvkLULOer+6Y+N7WAgqU6p7Dz+vLYaHUj9YdfFz6yS+nK8z7B2snpIXYEr97/R2tNnu9mkH4XH8Kq37Mp0ivR8vtDnpVP9tB2s1wtUoRyZA1gDQyNzjE+RcRkxAuP4q0SHkfDw0/lro01236FSuvNaygVDRdVS2o92pKwMQ3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7i3YzYGoCDFNANobA1O5weyk1InX22deCeDRyPf91Rw=; b=PmXCTQV9loG5P67vjRHZgl9WZQT+QWeAu5PpWAQl7S3suTBuoKSJl3RGmLQhEIWOgCo+3Q7vJa/KOKqdUgI7Z6YRlauDUY3gqYdK44hkBgrNFxKa7rW1AjysTAx3aaHwrrIGWD8n/6l53Wz0XUeaIhooEOfGuuOcnHJmggAjQ6sZEDUjVmjTvdCwUYioJOeMq/N484ZrAuEdIRKMClA+HJEDmfL1vCt+INf884M7usi2M5VEYIauORnSI/7BRe/TXmn3UpoIP4XPtpWHYDI6iDUxRpeI9MFVSXAONqvpAOUszuoCTZATCqwINX4vpMSCSJcnCFpiCwXQSPEjAepU5g== From: Jamin Lin To: "philmd@linaro.org" , "peterx@redhat.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "farosas@suse.de" , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v1 2/2] hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property Thread-Topic: [PATCH v1 2/2] hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property Thread-Index: AQHc3QgqzNLaW74uAEm3Jq1rhXKk0w== Date: Wed, 6 May 2026 03:26:45 +0000 Message-ID: <20260506032643.2510575-3-jamin_lin@aspeedtech.com> References: <20260506032643.2510575-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260506032643.2510575-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|JH0PR06MB7325:EE_ x-ms-office365-filtering-correlation-id: 4ef2f64c-3846-45f3-d124-08deab1f4d10 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|7416014|376014|921020|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: 7GT4Dm26sYBToPTEmNPTr48uprQStuSDJCST/1RqgtpAYoWKz1kB2TSjzNpbT/D5fADaJZcW1M87CzQ7POeQ29IZFh8eaOwxgU7zR0QaDbBd6lwrni/cDc6bPF11GqOWIf9UrfbW8f9sbVphiq1fte/RmL3p7vkgP4fQ6xSr6iiaKnM7BntnMbEJ9ql5OZ5zCO6xOO9F5DfVMcltLWBfRcLRJKoKcWRSzvgs9Ni4niD1PjbOZb9SG3w11gXXA4uoHjWgqCsGGCWc2qLNCHmHN1Fj+EOik3pMqzCGci4QV1uLNXLfCuvuwNMnLyQ5eDf6WsBQaq7jPegRTjfuEmUoMa5bN6evRQxvv/nQnrpbqtgm/PXAP5ps1aRRSFZBWMPalcg+7uIE/g5OwlZXbE0cE8rDuTAzdM3yqOtR/XmZqW6Jt3rFC6vd2SBi9yfEXb2ozlDc5Q0XZdRQ96/CASZJj6+csBIfZDU7pvuZJHNpAKy1PMzMaNYXo6akmXKYvwPmRDBJe+hqaEkKqAyAUtEDb0bd6FXpD+VTdJb9Bbm1tGau59zeohw4s6SyrQCDPAbTlDc/L14LxNGSN/gE6O+QKBQ/+I2+u1vtqMqceuREAQhDwO39F3ogMvxVM38KCElYRBd/F9y+ycHFVhNiCLhA2X1XrnEVzm6iOul3m80YSLRu+TiFSL7HZANtLSxBZHxTyTxqgP9tLQkE20uInSJPz0yQY6pFH3LFaKFmbQvoTsmIUB4shK0qR6S9QVXkJheQH0ZZke4udrJbOTgitQ+KYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dBvqAil+VvV/QCqYfpQ6U5+CpJ8JycmZCdjWv/M8CY7RhA5ofFHk8OJa59?= =?iso-8859-1?Q?BiAyvdk5eIZZ2a9iGLKstIwR35367vCt64I3QJwyTMDeX74Fp4PVdfqPcf?= =?iso-8859-1?Q?btFcSYpMGm75GzJmFHWQYEXLt5VsNreBO1vMex+ggsm5/ySrc5ms5nt/Ku?= =?iso-8859-1?Q?kSK6GrTpTOmRRPe5Bx6lmGYXXG/sJ3JAcsNZ4DuqTIJvAhpJQnHWPbpCB5?= =?iso-8859-1?Q?QOfSLx1O+BA7h6znGoxMkU3tITDEo4RlJf8zrOATolTVybEj0u7sDXL01W?= =?iso-8859-1?Q?LO4BOu4qo4RPm1y2p8dgm/WnMHedMdYNanNHwI7dzSpBCF+++zO9aKd7L9?= =?iso-8859-1?Q?jwZbdnjmSm4gZfJ4U+WcJqd9npyNirIBg/dw9m6DbKVXMnVjh6IOJTCX/u?= =?iso-8859-1?Q?t8GQyg3rlMhSIF6UW/K9II6iQH20x8ebJBiQSnc1waGrVS0Tr4r2IZDxG0?= =?iso-8859-1?Q?4lgCtyf9bcKdifNtoXKuVh/toZwWZMYzmZOqnQ0pwUdlDB7EXlGLFJSPg8?= =?iso-8859-1?Q?IfWlyd+xb50Cvu/9lwnC5sbHEibscEl1Sox8Tc4TjEQViu1kGe67Cbm6Kv?= =?iso-8859-1?Q?peK6EUhkxzPXESIkB1RNsAH2ijpvW1Wh3glI87LFYb2szcfZDVP8n1e/ek?= =?iso-8859-1?Q?7yvTKimW2HwQhBezK5lPPrWbQjV6y8AU3J0mxCqEmJGJBQ9mZuJj/5cNji?= =?iso-8859-1?Q?Tx6gfEg3gxokWUwi5F6TahRSWBI7zDVK4OmPORd4oNGuBVTDg17/YPR0/o?= =?iso-8859-1?Q?+PyfaGUFPUGdPHNtiCEpzAaO2mm/kC1ng3bXxTwBu1MQRxPbKk6SRPuSQT?= =?iso-8859-1?Q?7b2QObtlv72XHPzSCFPMW8u2gZqIEX8eX/K1QprM1j+FeLJpVK35Eotbtr?= =?iso-8859-1?Q?0kO39l21x1+JTDxwNsxShUm8Cb0W84YNN0wv4mLV6uPM2+uWDsK74d2DkA?= =?iso-8859-1?Q?ou67Sq2MhpL5OoCQ2NoMzWjBLVtTLyam9HJ+v3gPd9DNiuOR/Zq4qNz5X0?= =?iso-8859-1?Q?z9oK6xXcvXtqxFvWA3pfDlu/uuR1+yW9Rkwq1MY4co2JTbaYk16ilTAKMn?= =?iso-8859-1?Q?3qlUqPl+WxO9Qv9H3JlFkUMZZEMsGbTNk4y6NrqwijC+OfwaAxjqAArdGm?= =?iso-8859-1?Q?Ic5yae0Cpn+vm+0AJQUSZOoORQv3QFj5c68Hb2RyLwu62bJr6Ti0Wcy39X?= =?iso-8859-1?Q?DUaiABqOe6WByqouj5DaUO5v+SH7y5c5B9JWoDZmXHabZAxnybxHbtQPLj?= =?iso-8859-1?Q?r6Gbb9oTZvTZ2c4YJPmycH9SWcF2czzm5C6uxY/hArnT2B7glwecvdl8Sp?= =?iso-8859-1?Q?xoPzQaDkzebjVQ6duwMMU9lQoS/V7NbErKEh4zpO/aIsxNkMyCxgPfGdmj?= =?iso-8859-1?Q?ksT6RWCWlK7p3zgxu6vC4WaVLG9pB0r8MRdp9w0jY+Ll8LvhuC5XZHHOPe?= =?iso-8859-1?Q?tDUrBvsbu+Wlxy0g1pH8Z/B9WR1M/Xj6QhdDuq420wi5eGAAD/TtSpBCRW?= =?iso-8859-1?Q?ulyvMUaXa3E7W00c+w1nOG6cNCCs2qNL+Fi4epRfMqFA46SBeWXUh9SXDO?= =?iso-8859-1?Q?Xvlhf45sjxx5SmiEuHk2v4Inj8xD+ClnGyJwcns3C1rwhQZk67f46kifyw?= =?iso-8859-1?Q?4eNr+0fl8ezxGU/JD1OW2KvET+IsIm2bmU2Vr3C/X7ULxkfOOqoluq/Mi6?= =?iso-8859-1?Q?xc2oUCT/QDqP4CnUZRVJJ6zkUGzcYafGZsegWbK7nNZcnumOM2W+4iei90?= =?iso-8859-1?Q?HWvxlcjhkmaQmBo7C438hvlvQu7zTb8xehDzx+bnndtOlYLk7ZikvhbH9g?= =?iso-8859-1?Q?gB4ezop+UA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: fxiV3CBfA0C2R5C/Qk0O0W7XVuPqwBsA5pT2quUc9PZOFTwlh+iCBbv+7ph90e/ZyUe4EI3IYQikrbqARphZWWpFxmT+UKXo1fssryrEAD5g81qZUbv35EmuEKPSkKNg7rh4t4xfhU6Ilk2kSCXI704Flkiw11ziqjqw8O/iioy2/2de2aXIUUpClClxpfkEpwNEy19KVQnKLPo8wamASH/NI69AxSNgOJ1vLNFcw59QxVoHyreaUZfTLVDbA7aDqCTmabO2QbVm8oR6KKoh1sGRjq3Aq+hhgv+bhwOSlAanH/RTsDwl6mezG7b9nT/O7CMGA8JM9ath8TCxXuJrRQ== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ef2f64c-3846-45f3-d124-08deab1f4d10 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2026 03:26:45.8451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W7A6zs0TVJouGhtq5xUmBwKISXLAhVk8Kkq5YgOAg6k7ggrlxywzj/eDJNdSzasPqlRWJLo30anAyU6kBLCHzVc4QG6c1PVMqoaEBHN2leQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7325 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1778038076590154100 Content-Type: text/plain; charset="utf-8" Rename the EHCI CTRLDSSEGMENT default property and internal field to improve readability. No functional change. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 6 +++--- hw/arm/aspeed_ast27x0.c | 2 +- hw/usb/hcd-ehci.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index b5ac9c8670..b739c81870 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -268,7 +268,7 @@ struct EHCIState { */ bool migrate_fetch_addr_64bit; bool caps_64bit_addr; - uint32_t ctrldssegment_default; + uint32_t ctrl_ds_segment_default; =20 /* * EHCI spec version 1.0 Section 2.3 @@ -335,8 +335,8 @@ struct EHCIState { ehci.migrate_fetch_addr_64bit, true), \ DEFINE_PROP_BOOL("caps-64bit-addr", _state, \ ehci.caps_64bit_addr, false), \ - DEFINE_PROP_UINT32("ctrldssegment-default", _state, \ - ehci.ctrldssegment_default, 0) + DEFINE_PROP_UINT32("ctrl-ds-segment-default", _state, \ + ehci.ctrl_ds_segment_default, 0) =20 extern const VMStateDescription vmstate_ehci; =20 diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index a8f0bc389c..5865894658 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -856,7 +856,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev= , Error **errp) =20 /* EHCI */ for (i =3D 0; i < sc->ehcis_num; i++) { - object_property_set_int(OBJECT(&s->ehci[i]), "ctrldssegment-defaul= t", + object_property_set_int(OBJECT(&s->ehci[i]), "ctrl-ds-segment-defa= ult", sc->memmap[ASPEED_DEV_SDRAM] >> 32, &error_abort); object_property_set_bool(OBJECT(&s->ehci[i]), "caps-64bit-addr", t= rue, diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ac8f6ae5..133501b0f4 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1134,7 +1134,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, "64-bit addressing capability is disabled\n"); return; } - val |=3D s->ctrldssegment_default; + val |=3D s->ctrl_ds_segment_default; break; =20 case ASYNCLISTADDR: --=20 2.43.0