Misc QGA changes to allow building with Windows Clang

[PATCH 0/7] Misc QGA changes to allow building with Windows Clang

Kostiantyn Kostiuk posted 7 patches 2 days, 13 hours ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260330113906.168002-1-kkostiuk@redhat.com

Maintainers: Kostiantyn Kostiuk <kkostiuk@redhat.com>, Michael Roth <michael.roth@amd.com>

qga/commands-win32.c        |  2 +-
qga/meson.build             | 12 +++++-------
qga/vss-win32/requester.cpp |  2 +-
qga/vss-win32/vss-common.h  | 15 ---------------
4 files changed, 7 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/7] Misc QGA changes to allow building with Windows Clang

Posted by Kostiantyn Kostiuk 2 days, 13 hours ago

Kostiantyn Kostiuk (7):
  qga/win: Use swprintf instead of snwprintf
  qga/meson: Remove unused lib stdc++
  qga/meson: Use windows.compile_resources instead of custom_target
  qga/meson: Allow to use MSVC message compiler 'mc'
  qga/vss: Use MAX_PATH instead of PATH_MAX
  qga/vss: Remove unused undefs
  qga/vss: Drop unused define uuid(x)

 qga/commands-win32.c        |  2 +-
 qga/meson.build             | 12 +++++-------
 qga/vss-win32/requester.cpp |  2 +-
 qga/vss-win32/vss-common.h  | 15 ---------------
 4 files changed, 7 insertions(+), 24 deletions(-)

--
2.52.0

Re: [PATCH 0/7] Misc QGA changes to allow building with Windows Clang

Posted by Paolo Bonzini 1 day, 18 hours ago

On 3/30/26 13:38, Kostiantyn Kostiuk wrote:
> Kostiantyn Kostiuk (7):
>    qga/win: Use swprintf instead of snwprintf
>    qga/meson: Remove unused lib stdc++
>    qga/meson: Use windows.compile_resources instead of custom_target
>    qga/meson: Allow to use MSVC message compiler 'mc'
>    qga/vss: Use MAX_PATH instead of PATH_MAX
>    qga/vss: Remove unused undefs
>    qga/vss: Drop unused define uuid(x)

What is missing after these?

Thanks,

Paolo

Re: [PATCH 0/7] Misc QGA changes to allow building with Windows Clang

Posted by Kostiantyn Kostiuk 1 day, 18 hours ago

On Tue, Mar 31, 2026 at 10:01 AM Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 3/30/26 13:38, Kostiantyn Kostiuk wrote:
> > Kostiantyn Kostiuk (7):
> >    qga/win: Use swprintf instead of snwprintf
> >    qga/meson: Remove unused lib stdc++
> >    qga/meson: Use windows.compile_resources instead of custom_target
> >    qga/meson: Allow to use MSVC message compiler 'mc'
> >    qga/vss: Use MAX_PATH instead of PATH_MAX
> >    qga/vss: Remove unused undefs
> >    qga/vss: Drop unused define uuid(x)
>
> What is missing after these?
>
>
If I am not mistaken, the next patches

- Remove getopt from qga
- support clang-cl and lld-link with 128bit
- use __try1 only if it is defined
- add compatibility header with missing types/includes


Thanks,
>
> Paolo
>
>