From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870983; cv=none; d=zohomail.com; s=zohoarc; b=YJersuz6/cJzphiyvaa5NfajSGFE5PuzEUyKNFGLIis1a5qWqisVD17rWe5uG9E8fDBJ87B0Tt1io5B1lCP/sgswNRNGO3+Oa2Mc2DpGG5SPQEJ2mznU80xNyoPIl8vFLk2GtvpIalxCS2mneVvbdt7i1o0WLg+syBl18w2Ez/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870983; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TaKW6zYLKuhfhXTrC9qv3bYFrJ/5Ahy0GlR0n7eHG+4=; b=QkynxmKnX+h0gNQXDxlrgq21nQd5w4HqNmB+Wq+avktaJQfwYsA0DQAL4qUsnlyEmNkpH78NP8Ih4vsZAYuKuzaQyuy6gjO2QlX0Mqxf30DmcIEfIoMW1CXsvuS0PDwvbcbiCT+AXMXD0xaRnmTD8pGX89lyBV8dZ+7vPSPRc2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870983920403.1259375049583; Mon, 30 Mar 2026 04:43:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0G-0005NQ-22; Mon, 30 Mar 2026 07:41:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axu-0003uE-Cx for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axk-0003YU-H5 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:29 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-0v7yuxpzOfCO3nU7j-5HCw-1; Mon, 30 Mar 2026 07:39:15 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 753651944ABE; Mon, 30 Mar 2026 11:39:13 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A6891800767; Mon, 30 Mar 2026 11:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TaKW6zYLKuhfhXTrC9qv3bYFrJ/5Ahy0GlR0n7eHG+4=; b=KhSF6N/RE2FUpCrv9sOwFySDLvfRV4pDISFOxkdbzNSF67jmfXXVS/qu6k6JHpTCG8ucLV qQT/W6vBwywU663bS1KzAhYuTiOUAQ6TRrs/UC4UQMOO9z8denSDrCJ1SbIE5KPmMruHpj kJe2suIQ+d5Knuq0yBA//bxyCy+fo5I= X-MC-Unique: 0v7yuxpzOfCO3nU7j-5HCw-1 X-Mimecast-MFC-AGG-ID: 0v7yuxpzOfCO3nU7j-5HCw_1774870755 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 1/7] qga/win: Use swprintf instead of snwprintf Date: Mon, 30 Mar 2026 14:39:00 +0300 Message-ID: <20260330113906.168002-2-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870986341154100 Content-Type: text/plain; charset="utf-8" snwprintf is a Microsoft extension, and according to the MSVC spec, it is called _snwprintf. MinGW defines both snwprintf and _snwprintf, while MSVC defines only _snwprintf. We can also use swprintf here. The only difference between the two is the return value, and we are not using it. So change the function to support MSVC build env. Signed-off-by: Kostiantyn Kostiuk --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index c0bf3467bd..2bf5581aaa 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -1590,7 +1590,7 @@ static DWORD get_interface_index(const char *guid) ULONG index; DWORD status; wchar_t wbuf[INTERFACE_PATH_BUF_SZ]; - snwprintf(wbuf, INTERFACE_PATH_BUF_SZ, L"\\device\\tcpip_%s", guid); + swprintf(wbuf, INTERFACE_PATH_BUF_SZ, L"\\device\\tcpip_%s", guid); wbuf[INTERFACE_PATH_BUF_SZ - 1] =3D 0; status =3D GetAdapterIndex (wbuf, &index); if (status !=3D NO_ERROR) { -- 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870975; cv=none; d=zohomail.com; s=zohoarc; b=AntTLgvetkKEQqcormAtzHpoRGXguFUFidlCxbh7JknhiDCN0GqmxDQOM3A3+B9x5Sre5KdzCGUTGi65bMGFJDahN6AM6WfcB6q26ztYwkkPIteC8hEzROWir4qcmdn7couhNm8Lam2zOpsdaQPdhSyVO80IEmoeR4lRI3SnPgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870975; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bfc4T2vj0Pe+EBn2cpn+TmY05bZsugb2dsZfvsgDHaw=; b=Fy881BhMpFSF63c32BHQo594DcgrB0hKr/d/BA9M4MKskBn2Z02L1hFER28mzvEi3bWU4/SmIg9X6l68DkGouXw+rbcsjQhmn3cJv3Pwpx6DoMuIeIyueODkdOIIbOsKp0mVxIJhrJUBIjqFro6QwGHuCWnfpv4uz4D7NiHWriI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870975009770.6070080428058; Mon, 30 Mar 2026 04:42:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0D-0005Jz-9a; Mon, 30 Mar 2026 07:41:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axr-0003sw-Ce for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axj-0003Y3-Is for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:20 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-E1N9nf9LOz-m6cTm0-E-Og-1; Mon, 30 Mar 2026 07:39:17 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C09B61944F01; Mon, 30 Mar 2026 11:39:15 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E143D180075B; Mon, 30 Mar 2026 11:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfc4T2vj0Pe+EBn2cpn+TmY05bZsugb2dsZfvsgDHaw=; b=cZgi8un2y4QOidoIUN4s+6ozAtUT4XmQJCECRuPclOl1Q+TdCSO/JVg23YJT33y3Ur7U0h SBujHOX28JUSp4Q3r2bv+2Bu9Q2UuefIbjEgPxdWLLMhEleaHmTuKpOxPnaOaf2y0yZvli H2sQnmVh4Ln3RcfbU9Av8mj8ltW04MQ= X-MC-Unique: E1N9nf9LOz-m6cTm0-E-Og-1 X-Mimecast-MFC-AGG-ID: E1N9nf9LOz-m6cTm0-E-Og_1774870756 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 2/7] qga/meson: Remove unused lib stdc++ Date: Mon, 30 Mar 2026 14:39:01 +0300 Message-ID: <20260330113906.168002-3-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870976685158500 Content-Type: text/plain; charset="utf-8" qga_libs are libraries for guest agent linking. Guest Agent is a pure C-language application and doesn't need any C++ libs. VSS linking dependencies are placed in a separate file. Signed-off-by: Kostiantyn Kostiuk --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/meson.build b/qga/meson.build index 89a4a8f713..1c6433ef25 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -97,7 +97,7 @@ if host_os =3D=3D 'windows' qga_libs +=3D ['-lws2_32', '-lwinmm', '-lpowrprof', '-lwtsapi32', '-lwin= inet', '-liphlpapi', '-lnetapi32', '-lsetupapi', '-lcfgmgr32', '-luserenv', '-lpdh' ] if have_qga_vss - qga_libs +=3D ['-lole32', '-loleaut32', '-lshlwapi', '-lstdc++', '-Wl,= --enable-stdcall-fixup'] + qga_libs +=3D ['-lole32', '-loleaut32', '-lshlwapi', '-Wl,--enable-std= call-fixup'] subdir('vss-win32') endif endif --=20 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870956; cv=none; d=zohomail.com; s=zohoarc; b=js+rgb1kzVcpBUFkzHTGTZRAIcVqg6/X8ktzpTtvBq4EnrRhMQVvYe89MOEoeOg+rpK/TMbcAcvIP9EO7WzO8nhBiCJ6JR9dbt5pw97Ndy1LcD3tgFyufQrW4dfKay0CXy7ITsbY4X64VonIdUrHZr9hVFsbjuKsTWk/a9Q0yaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870956; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Kl2QNqUkqVsIFA+KbG8OvMYBLCj/RG5LGqEkMcQuTo=; b=VtRiXVJ0i+qBtYoyhf/zzegdfGOT5YVVOsTbfCStJw/Hoj1rkHfmo5grxa5MsdtWNHGvBav9tHxZsMXt23bXG9ThVNZIDayi31/ULXv1xX/zO8xZWqz1v6weHgyTUMQVEGtevvYg034Ov8Kj7m+WzD8smRsBR2Obr0AxiEwuudc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870956215236.23486819533696; Mon, 30 Mar 2026 04:42:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0E-0005LV-DN; Mon, 30 Mar 2026 07:41:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axu-0003uD-C5 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axr-0003Yp-Nh for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:29 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-0NwQ1hb6OsSikxXHumlQ_A-1; Mon, 30 Mar 2026 07:39:18 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD8A818005B6; Mon, 30 Mar 2026 11:39:17 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B067180036E; Mon, 30 Mar 2026 11:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Kl2QNqUkqVsIFA+KbG8OvMYBLCj/RG5LGqEkMcQuTo=; b=g0ZcF9V2+yw4rle/QuPUAG8AsiQbDe+P3GegJxBToo/TO1p2SyopDDfbVHkh6kcXJzvc8l cugKv2EUYA9DYQ65ew+Md3V8L4tLIC1SalRFUCJe/tCXz4vmnDEBNgmcWwKHmlt+eofBxE YcWeLxF/WqIVu45f0isQq1j0GZ4nkog= X-MC-Unique: 0NwQ1hb6OsSikxXHumlQ_A-1 X-Mimecast-MFC-AGG-ID: 0NwQ1hb6OsSikxXHumlQ_A_1774870758 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 3/7] qga/meson: Use windows.compile_resources instead of custom_target Date: Mon, 30 Mar 2026 14:39:02 +0300 Message-ID: <20260330113906.168002-4-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870956724158500 Content-Type: text/plain; charset="utf-8" windows.compile_resources supports more compiles and works in both MinGW and MSVC environment. While 'windres' is a MinGW specific tool. Signed-off-by: Kostiantyn Kostiuk --- qga/meson.build | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qga/meson.build b/qga/meson.build index 1c6433ef25..85bdacf7e2 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -105,16 +105,14 @@ endif qga_objs =3D [] if host_os =3D=3D 'windows' windmc =3D find_program('windmc', required: true) - windres =3D find_program('windres', required: true) =20 msgrc =3D custom_target('messages-win32.rc', input: 'messages-win32.mc', output: ['messages-win32.rc', 'MSG00409.bin', 'mes= sages-win32.h'], command: [windmc, '-h', '@OUTDIR@', '-r', '@OUTDIR= @', '@INPUT@']) - msgobj =3D custom_target('messages-win32.o', - input: msgrc[0], - output: 'messages-win32.o', - command: [windres, '-I', '@OUTDIR@', '-o', '@OUTP= UT@', '@INPUT@']) + + windows =3D import('windows') + msgobj =3D windows.compile_resources(msgrc[0]) =20 qga_objs =3D [msgobj] endif --=20 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870932; cv=none; d=zohomail.com; s=zohoarc; b=OltQaN7v7mO3QlU/dyLIe0U7Att0fE8dca52fiAkKJIkpb6vKqrbRtq5s32CnOq1PRfnEU2czvMxld+OOksIZE/KN6+ySD8mAlJAk+ZbOT+7VH2ROx3VJbBxN6lwzNeY19Hkq1iuU49FuptXPJ2ofPwdnhXdsr35H0GB3fJZmlQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870932; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XImS7Cj7FDvc5aweGbm0H1hwlQjvAMKaO2475aFZIUs=; b=IvOIraqCLV54M9nzxbmdkZC0o10IEEloTeGQgyuxwjtLShkZmxgdv7KgKkaPbNsvS1KfM/sOAdpTFQkthKivwFIZ9zKZ+6+pEuPyhpUmBPVk7Qm9b882JCRU0ZeXjmql6lPMmR7IhQyeQJbZ/lTh1God6Wh8oF9itQy7dbpS+HI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870932086768.8875413612074; Mon, 30 Mar 2026 04:42:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0H-0005Nr-00; Mon, 30 Mar 2026 07:41:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axt-0003u9-Rm for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axr-0003Yq-5N for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:29 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-RovqcOtAPYycNzGM8uNYFA-1; Mon, 30 Mar 2026 07:39:21 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0DBA218002C7; Mon, 30 Mar 2026 11:39:20 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 570FC180075B; Mon, 30 Mar 2026 11:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XImS7Cj7FDvc5aweGbm0H1hwlQjvAMKaO2475aFZIUs=; b=TAHHs213KGJr8bfDU168re1gBuH61rxYKL8Hb4F5Pu+00URZ8zlvqEL+N3njqr7mu1z3x0 AYrHPgm+m38+KImtV6cZmvKi030FLpPOe+iupd19VlvF/ZwSn/H6/eDq1PbTyTFXQRt5/F 4c6kkFOAfMSQEpcoy0j8oCucCdqSscs= X-MC-Unique: RovqcOtAPYycNzGM8uNYFA-1 X-Mimecast-MFC-AGG-ID: RovqcOtAPYycNzGM8uNYFA_1774870760 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 4/7] qga/meson: Allow to use MSVC message compiler 'mc' Date: Mon, 30 Mar 2026 14:39:03 +0300 Message-ID: <20260330113906.168002-5-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870933566154100 Content-Type: text/plain; charset="utf-8" Signed-off-by: Kostiantyn Kostiuk --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/meson.build b/qga/meson.build index 85bdacf7e2..cfa2157efb 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -104,7 +104,7 @@ endif =20 qga_objs =3D [] if host_os =3D=3D 'windows' - windmc =3D find_program('windmc', required: true) + windmc =3D find_program('windmc', 'mc', required: true) =20 msgrc =3D custom_target('messages-win32.rc', input: 'messages-win32.mc', --=20 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870932; cv=none; d=zohomail.com; s=zohoarc; b=JiUA38Q53gHLCJQTfkbiZu3awm4NjAMK4uCMtYwwjWqOECYGxxQee4IQ2Kln5lN+BlUesH2UNhT/xsYlhGzG2WBHhMYbrHIPJgO0a4LcLzgp9jqslGRGpk6IwDzn4ABVsRLV4V2EdhQX94knCMGcWAszXqEWRiu3RCSCA8WVKEU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870932; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=viN63nWdzRV4A7CosbhXrSsrcAnBV7+Zk6YYqXyl/Hg=; b=OQKWTc2tjekVxmEYKMo0wdbxgmxWZxFzimFXHrxl8T6DHP8kOhjVB30HPBwc6dmWAcb0dhxIeuCydLuRNJI4OSt3uw+ZhgjxIIZEe1drlFgolJ9Uqv0djKoqbJTNOnKkHSAKqOC7FwAObRgTj6HzFbopl+tkzQo0ZcQZFY+aWns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870932595914.4855547334076; Mon, 30 Mar 2026 04:42:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7Azy-0005Au-Ed; Mon, 30 Mar 2026 07:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axv-0003uQ-N1 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axs-0003ZR-12 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:30 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-IevpmJvWNZSd4zUt8MalVA-1; Mon, 30 Mar 2026 07:39:23 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2591718005B3; Mon, 30 Mar 2026 11:39:22 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B4E3180075B; Mon, 30 Mar 2026 11:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=viN63nWdzRV4A7CosbhXrSsrcAnBV7+Zk6YYqXyl/Hg=; b=EJkF4L2+Oyelz6un+T7xwLQ18MPis1UZvXOwQJwX6AhNNybvLfk0U14oIs9CVuqPSTK5la R/1G5gm7rXX/NULwYiYz0X7uDqlyOH3ULl90ySkwRg+d4vYr120VuU1bk54yfqTu25V3Xi 5SpOj8K2eRjs+53G/gTFuNV9VskvUtE= X-MC-Unique: IevpmJvWNZSd4zUt8MalVA-1 X-Mimecast-MFC-AGG-ID: IevpmJvWNZSd4zUt8MalVA_1774870762 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 5/7] qga/vss: Use MAX_PATH instead of PATH_MAX Date: Mon, 30 Mar 2026 14:39:04 +0300 Message-ID: <20260330113906.168002-6-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870934466158500 Content-Type: text/plain; charset="utf-8" MAX_PATH defined in windows.h This is more correct way for Windows. Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 626d6ab1ff..493ecd5717 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -444,7 +444,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) hr =3D vss_ctx.pVssbc->AddToSnapshotSet(short_volume_name, g_gProviderId, &pid); if (FAILED(hr)) { - WCHAR volume_path_name[PATH_MAX]; + WCHAR volume_path_name[MAX_PATH]; if (GetVolumePathNamesForVolumeNameW( short_volume_name, volume_path_name, sizeof(volume_path_name), NULL) && --=20 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870987; cv=none; d=zohomail.com; s=zohoarc; b=VXuc85m6KRGO3T+L1wQans1uTBxMD2j96mvjhS2njYE/Np/q2vFnfzsDVqXh73LC9Xi6WLdjO42Y0iSjkash34wgN8IhfqRJdmftwnkvN8Z7Y9/gjwf+AjckV3lPN9jhJkwjdnpaL49XIfshMz3qN4EOSvo5KQdfDYrClxMhhqg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870987; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/AYVBGV9kCCmNP1aEjPgIRE1RHKwWqOWlM+Y9O5E0oE=; b=dPeuTVp95CUdcRXx+8UlmPIJk620oKkZ/bTP8YuIIBXcPgXlbiYnJUZSDNiGRBxA7Cd4hXuc91LPCuBcYzJlyXf7OOCZHg+RAgC/0WPh3V23LX3M4KlSX0g/k8LsOQTxyF+ZnslgFhmoReAaFR+aLbygYsh9TsPhtytI62iKdc4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177487098767649.04093626318161; Mon, 30 Mar 2026 04:43:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0G-0005Ne-H4; Mon, 30 Mar 2026 07:41:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axv-0003uP-M0 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axr-0003Zn-NN for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:30 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-V5KUNUJyM6WYd7PwbeIP5w-1; Mon, 30 Mar 2026 07:39:25 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FA991955DB6; Mon, 30 Mar 2026 11:39:24 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 93E5C1800760; Mon, 30 Mar 2026 11:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/AYVBGV9kCCmNP1aEjPgIRE1RHKwWqOWlM+Y9O5E0oE=; b=J42eMfotodkqDGtfarHL4mUIMbrb4ipjNbdvxgtFD0IOJVR/jvcn+ZevHDXtSTL4G+2p2B 0hzlvv9wETzn1od7yhBkBRFUMemQ4+gOfbFrLU3P1hTHZBHPIb1abiKaV1ti/RioUW3vby lVsY2ENt9rq1HtDH1WOaxwS9YuwKczk= X-MC-Unique: V5KUNUJyM6WYd7PwbeIP5w-1 X-Mimecast-MFC-AGG-ID: V5KUNUJyM6WYd7PwbeIP5w_1774870764 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 6/7] qga/vss: Remove unused undefs Date: Mon, 30 Mar 2026 14:39:05 +0300 Message-ID: <20260330113906.168002-7-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870988780158500 Content-Type: text/plain; charset="utf-8" We don't include any headers that provides VSS_E*, so no need to undefine it before including vss.h Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/vss-common.h | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/qga/vss-win32/vss-common.h b/qga/vss-win32/vss-common.h index 0e67e7822c..db849127c2 100644 --- a/qga/vss-win32/vss-common.h +++ b/qga/vss-win32/vss-common.h @@ -33,19 +33,6 @@ #undef uuid #define uuid(x) =20 -/* Undef some duplicated error codes redefined in vss.h */ -#undef VSS_E_BAD_STATE -#undef VSS_E_PROVIDER_NOT_REGISTERED -#undef VSS_E_PROVIDER_VETO -#undef VSS_E_OBJECT_NOT_FOUND -#undef VSS_E_VOLUME_NOT_SUPPORTED -#undef VSS_E_VOLUME_NOT_SUPPORTED_BY_PROVIDER -#undef VSS_E_OBJECT_ALREADY_EXISTS -#undef VSS_E_UNEXPECTED_PROVIDER_ERROR -#undef VSS_E_INVALID_XML_DOCUMENT -#undef VSS_E_MAXIMUM_NUMBER_OF_VOLUMES_REACHED -#undef VSS_E_MAXIMUM_NUMBER_OF_SNAPSHOTS_REACHED - #include #include "vss-handles.h" =20 --=20 2.52.0 From nobody Thu Apr 2 02:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1774870956; cv=none; d=zohomail.com; s=zohoarc; b=PxtiEKxiRwqdvlANFpfSgu6qmiE+1A/ntxdNLxsqH1LfM/53RUiCA05AIkE7CqCA7W1T35mUAErSM7ogZFvwnvPSdqDoWkKNqxImHMe1Zkc9O1Y+G1dSroOVHyCQZnJFK2+4qGBva8xmj/ruNbtvCh2D4729o1ls1/iXxsoR+nU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774870956; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xw56F0rtktmpTY6+GvDgBlLp89XVj2CAus1OJMVrEo8=; b=d9BbNRg0MWQ+3Ks5t6+f8yvWvk7uel4z7fzSLuhqVh8chlBrfiz8EdWn6OCQIzqe2YMZHYqNP8E7eO9tGwov3wiHZ3GQ9CTpMj5rRnWhcqUoYMB+io5KB84+NqWagzU+735koh00bAy7MLix34JeNjLbjiDMMXzeC8ViDuTH92I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774870956538708.5225778066043; Mon, 30 Mar 2026 04:42:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w7B0F-0005MZ-78; Mon, 30 Mar 2026 07:41:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axw-0003ul-Tc for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w7Axv-0003bU-K7 for qemu-devel@nongnu.org; Mon, 30 Mar 2026 07:39:32 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-Btnh3ynwP92gmi-Vnwl0cQ-1; Mon, 30 Mar 2026 07:39:27 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62EB5195609E; Mon, 30 Mar 2026 11:39:26 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.33.150]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD7E4180075B; Mon, 30 Mar 2026 11:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774870770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xw56F0rtktmpTY6+GvDgBlLp89XVj2CAus1OJMVrEo8=; b=NlSuwXtj0SQbHWvIldcib6xTFKbo19kG9vyam6FgeKKK+to7de1XAOSO8AA3zULLgq9ytv p9eaPkoEpJcge5cXrUXsKVZHMmY65EpnN4TTHq4M8vKu5pvXwQ5loOe5BWYCLwLIfgLKw7 yYup5UZhCHiBlhHSWF+ttp9AtUa5vH0= X-MC-Unique: Btnh3ynwP92gmi-Vnwl0cQ-1 X-Mimecast-MFC-AGG-ID: Btnh3ynwP92gmi-Vnwl0cQ_1774870766 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yan Vugenfirer , Kostiantyn Kostiuk , Michael Roth Subject: [PATCH 7/7] qga/vss: Drop unused define uuid(x) Date: Mon, 30 Mar 2026 14:39:06 +0300 Message-ID: <20260330113906.168002-8-kkostiuk@redhat.com> In-Reply-To: <20260330113906.168002-1-kkostiuk@redhat.com> References: <20260330113906.168002-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1774870958583158500 Content-Type: text/plain; charset="utf-8" There is no place in code where we use uuid(x), at the same time MSVC vss.h use it and this define broke compilation. Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/vss-common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/qga/vss-win32/vss-common.h b/qga/vss-win32/vss-common.h index db849127c2..5e993f9eda 100644 --- a/qga/vss-win32/vss-common.h +++ b/qga/vss-win32/vss-common.h @@ -30,8 +30,6 @@ #define __RPC__out_ecount_part(x, y) #endif #define _declspec(x) -#undef uuid -#define uuid(x) =20 #include #include "vss-handles.h" --=20 2.52.0