target/s390x: Forbid to use legacy ldst_phys() API

[PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API

Philippe Mathieu-Daudé posted 5 patches 2 days, 17 hours ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260319185203.11799-1-philmd@linaro.org

Maintainers: Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>

configs/targets/s390x-softmmu.mak |  1 +
target/s390x/cpu-system.c         |  2 +-
target/s390x/kvm/kvm.c            | 12 ++++++++----
target/s390x/mmu_helper.c         |  5 +++--
target/s390x/tcg/excp_helper.c    | 21 +++++++++++++--------
target/s390x/tcg/mem_helper.c     | 12 +++++++-----
6 files changed, 33 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API

Posted by Philippe Mathieu-Daudé 2 days, 17 hours ago

Replace legacy ld/st_phys() by address_space_ld/st()
then lock the target again further legacy API uses.

Philippe Mathieu-Daudé (5):
  target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu)
  target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu)
  target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg)
  target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm)
  configs/targets: Restrict the legacy ldst_phys() API on s390x target

 configs/targets/s390x-softmmu.mak |  1 +
 target/s390x/cpu-system.c         |  2 +-
 target/s390x/kvm/kvm.c            | 12 ++++++++----
 target/s390x/mmu_helper.c         |  5 +++--
 target/s390x/tcg/excp_helper.c    | 21 +++++++++++++--------
 target/s390x/tcg/mem_helper.c     | 12 +++++++-----
 6 files changed, 33 insertions(+), 20 deletions(-)

-- 
2.53.0

Re: [PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API

Posted by Matthew Rosato 1 day, 17 hours ago

On 3/19/26 2:51 PM, Philippe Mathieu-Daudé wrote:
> Replace legacy ld/st_phys() by address_space_ld/st()
> then lock the target again further legacy API uses.
> 
> Philippe Mathieu-Daudé (5):
>   target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu)
>   target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu)
>   target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg)
>   target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm)
>   configs/targets: Restrict the legacy ldst_phys() API on s390x target

For the series:

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

For good measure I also ran some s390x kvm regression tests, took a less comprehensive spin with a tcg s390x guest (on s390 host), and forced a few of these codepaths as a sanity check.

> 
>  configs/targets/s390x-softmmu.mak |  1 +
>  target/s390x/cpu-system.c         |  2 +-
>  target/s390x/kvm/kvm.c            | 12 ++++++++----
>  target/s390x/mmu_helper.c         |  5 +++--
>  target/s390x/tcg/excp_helper.c    | 21 +++++++++++++--------
>  target/s390x/tcg/mem_helper.c     | 12 +++++++-----
>  6 files changed, 33 insertions(+), 20 deletions(-)
>

Re: [PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API

Posted by Philippe Mathieu-Daudé 21 hours ago

On 20/3/26 20:28, Matthew Rosato wrote:
> On 3/19/26 2:51 PM, Philippe Mathieu-Daudé wrote:
>> Replace legacy ld/st_phys() by address_space_ld/st()
>> then lock the target again further legacy API uses.
>>
>> Philippe Mathieu-Daudé (5):
>>    target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu)
>>    target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu)
>>    target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg)
>>    target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm)
>>    configs/targets: Restrict the legacy ldst_phys() API on s390x target
> 
> For the series:
> 
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> 
> For good measure I also ran some s390x kvm regression tests, took a less comprehensive spin with a tcg s390x guest (on s390 host), and forced a few of these codepaths as a sanity check.

Thank you very much Matthew!