From nobody Sun Mar 22 14:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773946366; cv=none; d=zohomail.com; s=zohoarc; b=ZHB67UhXAxfFCta+njicDID0o8tERLzbOM/M9ipjSPA1l9OjYR+kTXITjAPRzn8gZ3cB9GAUA+XwiBouEHrpj/D15L3pEL6UPVZPdCg8JinFFZASxbWm83+VMlFMpliDeeSMXqphQM6IHd5ypaGusszREfuLnM3Sg4JsWHcVOqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773946366; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=99Agaah8svWMvp88jjgollb/i/IbGwJRUZgPwXncGK8=; b=MdOwfyzeSXKwVATKerGWHzw7sa1iSlhnZih1LNkX1voTCi1wwEwfeJ//FgxeHcQWsh2OiR4mqbQtBPUzCrjBN+9M6YCzqRBJAOMvgPW86s+TvqUyGSUZdzEcH2iTroyw8EZxUxwdyLcItVAlgPZgbCipJjblzPc/a8kBx7e6n2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773946366215645.2972321678035; Thu, 19 Mar 2026 11:52:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3ITl-0003Kb-I0; Thu, 19 Mar 2026 14:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3ITj-0003Jj-6Y for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:19 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3ITg-0000zU-Vc for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:18 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-483487335c2so9769215e9.2 for ; Thu, 19 Mar 2026 11:52:16 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe6d9896sm8408145e9.2.2026.03.19.11.52.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 11:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773946334; x=1774551134; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=99Agaah8svWMvp88jjgollb/i/IbGwJRUZgPwXncGK8=; b=XAOLDHQwoThKWVTUvvVXwrPn6RxvuTAHKqn638ge+pYQXfkAb86u31LiVcrx4xWd1Y I8BeSwp8B0lQB0VFtFR/9l4MEmyiMHNDZvO0aZwPFgo8OKxyHxprOUkjEvwfAN+VLMNP bwgNZ+j7iB8kcU89Ts+yiXgbuH7mc4X4h9pDLFNAhIzMSXv8Cc1Kv32gqOyqTxHvPEJl rdtrWE/S0RapyCGeAcrgJjMOpgo/rHSsKozYDcHDtgDd9HQi4p/6T2z/e/YNBaxVWAcS IGSojXffp0SWq8z/LfsIUasMXqkF3849/N4LA2D5T7jAPH14cDBlDz0TzGA1/zUXKZ9C sjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946334; x=1774551134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=99Agaah8svWMvp88jjgollb/i/IbGwJRUZgPwXncGK8=; b=I16nT0UE6osTaL0MwuygKsFx8k67pzvLokgiPDbg6x7Ha+NjBsDDsG1TN6VG1u3p9L dAUs1o06DTzvokhAb0/zMIoelCtmSrOQcEXU8s/5UaUyy04ck1KgtrF8ZF71is9MhpQF EdSI7MeyrWtq0wn0RYDpET2UkwaRHibJfC571ftnrV8ydNvoH6Gh8CEo5zfy1bKAv75S VHyLQINgmNRz41/WUjia6Mq8wDcqQ64ZA/fGX/Kyjx+1v4H0dNX+XY1W4KAnd3MY3DqC RwxvXCfKteEyEJnMRVKgIDHbmZYrJLmxTYctSpODcM3SKdtZrhipmd6bxtHVM3mQS5hc TK1Q== X-Gm-Message-State: AOJu0YzUQbIWWKfxTjDyRmcvTYtYew8BYkMBzFqIknMY5IfYFEI+Dhi4 yZLMj4coRibB7Q2l+o/jgDDk3enyvjBYgTgFx5EY6rhjGBVTMHzFPHxR7CKUWNYYgfMlDSxHnLw bxb1vZNo= X-Gm-Gg: ATEYQzy4B0kAZCkqcNHfOUoI5rT3L33iSymhzMj0iDJrsnPJm+2RcP4kx4Qx6eYIxN0 ozWMAvzcTRmZYbhg1pynNm4sxUNrj9l6+fgAXJXT1WYhJznpcN0aJPODiaec9ZbCqL5GUjOKzCq S8C/5cxnnsP2hw48UNMuYu5ONGQ6j21YpynMsiNGgwRWb+bhq5OeInV9VpD7QgpxDMnZUALJ78T DwO+wbEklD5Tr3uBgFJdgYrBRWZ7GC6kshWhoHc/94fIwQkDcOHFgqZJCMmesgR7Y5ANJXx/ODV ADsdHg0SijiIpmtuMCFy5spZsx+nhNee9e3oIuGX+wPrIUN9ogPnCUCeZH0rHQDJLIG/p+uo+nA Zxg/8L5u7Oz5uHCXV3MyWe/ReQ/IS9E5oBNna7jmgr9ASb8vb75yekxNgO1aHE2hVEe/DDtGfyB 9+h6vVwe635UnxjqYqXPa12SKZVQtvOV5CeH3jT8Vw2tIDZuuXJ8L+jh4pZJysz2fj4m1xoN4R X-Received: by 2002:a05:600c:3d90:b0:485:3c8f:e4d9 with SMTP id 5b1f17b1804b1-486fee1d9e6mr2730975e9.26.1773946334418; Thu, 19 Mar 2026 11:52:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Ilya Leoshkevich , Anton Johansson , Eric Farman , Christian Borntraeger , Matthew Rosato , Richard Henderson , Halil Pasic , qemu-s390x@nongnu.org, David Hildenbrand , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu) Date: Thu, 19 Mar 2026 19:51:59 +0100 Message-ID: <20260319185203.11799-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319185203.11799-1-philmd@linaro.org> References: <20260319185203.11799-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773946367338158500 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result). No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Matthew Rosato --- target/s390x/tcg/excp_helper.c | 21 +++++++++++++-------- target/s390x/tcg/mem_helper.c | 12 +++++++----- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index 41b0017d767..05e448d3f20 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/target/s390x/tcg/excp_helper.c @@ -54,8 +54,9 @@ G_NORETURN void tcg_s390_data_exception(CPUS390XState *en= v, uint32_t dxc, g_assert(dxc <=3D 0xff); #if !defined(CONFIG_USER_ONLY) /* Store the DXC into the lowcore */ - stl_be_phys(env_cpu(env)->as, - env->psa + offsetof(LowCore, data_exc_code), dxc); + address_space_stl_be(env_cpu(env)->as, + env->psa + offsetof(LowCore, data_exc_code), dxc, + MEMTXATTRS_UNSPECIFIED, NULL); #endif =20 /* Store the DXC into the FPC if AFP is enabled */ @@ -71,8 +72,9 @@ G_NORETURN void tcg_s390_vector_exception(CPUS390XState *= env, uint32_t vxc, g_assert(vxc <=3D 0xff); #if !defined(CONFIG_USER_ONLY) /* Always store the VXC into the lowcore, without AFP it is undefined = */ - stl_be_phys(env_cpu(env)->as, - env->psa + offsetof(LowCore, data_exc_code), vxc); + address_space_stl_be(env_cpu(env)->as, + env->psa + offsetof(LowCore, data_exc_code), vxc, + MEMTXATTRS_UNSPECIFIED, NULL); #endif =20 /* Always store the VXC into the FPC, without AFP it is undefined */ @@ -619,11 +621,14 @@ void monitor_event(CPUS390XState *env, uint64_t monitor_code, uint8_t monitor_class, uintptr_t ra) { + const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; + AddressSpace *as =3D env_cpu(env)->as; + /* Store the Monitor Code and the Monitor Class Number into the lowcor= e */ - stq_be_phys(env_cpu(env)->as, - env->psa + offsetof(LowCore, monitor_code), monitor_code); - stw_be_phys(env_cpu(env)->as, - env->psa + offsetof(LowCore, mon_class_num), monitor_class= ); + address_space_stq_be(as, env->psa + offsetof(LowCore, monitor_code), + monitor_code, attrs, NULL); + address_space_stw_be(as, env->psa + offsetof(LowCore, mon_class_num), + monitor_class, attrs, NULL); =20 tcg_s390_program_interrupt(env, PGM_MONITOR, ra); } diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index 2a79a789f63..8474a694110 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -41,6 +41,7 @@ #else #include "hw/s390x/storage-keys.h" #include "hw/core/boards.h" +#include "system/memory.h" #endif =20 #ifdef CONFIG_USER_ONLY @@ -958,13 +959,14 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0= , uint32_t r1, uint32_t r2) inject_exc: #if !defined(CONFIG_USER_ONLY) if (exc !=3D PGM_ADDRESSING) { - stq_be_phys(env_cpu(env)->as, - env->psa + offsetof(LowCore, trans_exc_code), - env->tlb_fill_tec); + address_space_stq_be(env_cpu(env)->as, + env->psa + offsetof(LowCore, trans_exc_code), + env->tlb_fill_tec, MEMTXATTRS_UNSPECIFIED, NU= LL); } if (exc =3D=3D PGM_PAGE_TRANS) { - stb_phys(env_cpu(env)->as, env->psa + offsetof(LowCore, op_access_= id), - r1 << 4 | r2); + address_space_stb(env_cpu(env)->as, + env->psa + offsetof(LowCore, op_access_id), + r1 << 4 | r2, MEMTXATTRS_UNSPECIFIED, NULL); } #endif tcg_s390_program_interrupt(env, exc, ra); --=20 2.53.0 From nobody Sun Mar 22 14:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773946351; cv=none; d=zohomail.com; s=zohoarc; b=lNUVKgFSmNa4mo7hsThhEKkUgNjLHXhYi4rO8+NhDtNsHPxZJmiYBkfGmUzolX8/Nav67C5MwI2XYAQJmIsrsRw+kRys1eLtdr2jRYcrj+41v/3cehxCgoZU8Z9+a6xLupIMnM7Io0V20JORTKLafIVQet9WhA/S3T1I8BRVwJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773946351; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=06PbSn9Pduw968j+IvDOdjXCS1Zr8HZL4HWuUI+RKJQ=; b=emwizEkvN7QWwN8bTGGHq6FrR9sCDGGNN86d8FYGipegnqwnrgRGpsFv02blVEGf9RSsvsTNQyq6pU/wDkvCRmcZk4rMh4L8bS8NvWu7+G0iGs3YCfywFz3dQHhMzqNFJf5/Ghtye7a6v8jcPNenZ4wGDj8r4P86GrtrkQGmM6I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773946351410633.8325323411051; Thu, 19 Mar 2026 11:52:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3ITr-0003NB-7a; Thu, 19 Mar 2026 14:52:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3ITp-0003MI-DA for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:25 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3ITo-00011F-0o for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:25 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-485445e80bdso11289615e9.0 for ; Thu, 19 Mar 2026 11:52:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8aacc73sm74068155e9.0.2026.03.19.11.52.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 11:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773946342; x=1774551142; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=06PbSn9Pduw968j+IvDOdjXCS1Zr8HZL4HWuUI+RKJQ=; b=RNRR5ip9VuvsFjuaCFZivUfNJPrr2zh1UbCeMd/r9RMtq4BbRkl5XbDv5aMcwDAF32 vpSmRufxXkX53MVz94V/mTFCEtg2lpNtRgwye6ro+Zdz1IE6IDxxaOvZ+ucpdKddQGD+ Phofs//I9Ly1qhNTXEOvUwRiY7QYhMT2kTbwVmrPof+3w70ya6R+6YibRpaHLM/0x49D +3LJjLrukBOGVrSlcYlZEcptko11+11OABLzryElc45esaGUIBKJIWyLW1INR4HKsJg3 eOaqNtsJxb43Q0mjlChpRHH/Wl94cDOoDrxWjaELf0Z0/P4PObLZHAyXAt9wyyL7K9RF olIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946342; x=1774551142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=06PbSn9Pduw968j+IvDOdjXCS1Zr8HZL4HWuUI+RKJQ=; b=G49RQATqsTXVhTBZHCB/kvmvUEIpMKLFacdfJevW+OzubfvKjJ1tBdEQ8cll1fKBRO QtT/NA3ciVeOYmEdax+nQi5QS18DwScnsyC5fmz3pTP1Q0ZYneA76ml8eM+cmSWQxJ5w 9YmsbF4f1mKJCwwBGHzIhGkSGom8H0tcL8rn+635HC9/4RAjDpL3EiBh4vjOuZaFtyVg lUZ6Cr/xk6Asl712a565jRS4YvP3cJWmSJoRYt8sqZMW82VYvoyxOI2FEIZWUSySJZnD 2fnW1MACt1/4SaNkiuoEzTNO53cUpuiHKWjTshX0OyhV/mZmb8htt8MWtZ8qoYPZ+MHU ICRg== X-Gm-Message-State: AOJu0YwCoE1zOH3gJV8JDtzwKXP+YpfqdReMAN6Sm0HInRUHroe+CJEN kiBV5FGqQ/tO0YEkD4PzlO7jXaDFRExTEHwdGtDDXbdjaTQAULZNmqclWjW0xagFcNq6oj53aCR 2mpQcyGE= X-Gm-Gg: ATEYQzxEEP6owVKTNgJ1dXR2kl0Hq2m95BTLvhg3AeQTXrAEiA/DiOzifXsHTPNRY78 ZyCTsP4k5nfgQjAX+d7tRhU6gqRg30I6AdLFfAfEz8VK4gxT1ruXjp6d0aJx5/X9wYsccpgvI0K OGIywVpl6ivU0AP/hRbnIQVPaP+JSKrqWxMjiUvXE3MW8pbb0UecSUj7AMaqldiBQg3qqQT0S0S jj96ZhlFm8HwY31cqvCEQOtbH5HGXt1ELZDseaaIIPVRc0/h95+n0OmLcL5y/YlftNXyoSDZ37w qcbV4uk41kRK+O554Fgw16TNWqKNn/KJir1uUsVIPYKQ4dWK2MaaEbsJ1rIEwdU5LYGaNhAYhzy JrgSeMXf1UMlK548QfMSJxt8B3JqnAM/2OTqwCxit7XTF/agq3IsKNlxKZ+LOJTxyMcktYs5/Zo UUOT+9+rzagBNUc6LLuYviqb6zI1qQo5EYATP09YA19sM+XNnjsMrzKcAtRnc2TS+OG1c88R6z X-Received: by 2002:a05:600c:450b:b0:47a:7fd0:9eea with SMTP id 5b1f17b1804b1-486fede7341mr3242055e9.3.1773946342300; Thu, 19 Mar 2026 11:52:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Ilya Leoshkevich , Anton Johansson , Eric Farman , Christian Borntraeger , Matthew Rosato , Richard Henderson , Halil Pasic , qemu-s390x@nongnu.org, David Hildenbrand , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu) Date: Thu, 19 Mar 2026 19:52:00 +0100 Message-ID: <20260319185203.11799-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319185203.11799-1-philmd@linaro.org> References: <20260319185203.11799-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773946353755158501 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result). No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Matthew Rosato --- target/s390x/mmu_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 246573ff642..255271b9d34 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -44,8 +44,9 @@ static void trigger_access_exception(CPUS390XState *env, = uint32_t type, } else { CPUState *cs =3D env_cpu(env); if (type !=3D PGM_ADDRESSING) { - stq_be_phys(cs->as, env->psa + offsetof(LowCore, trans_exc_cod= e), - tec); + address_space_stq_be(cs->as, + env->psa + offsetof(LowCore, trans_exc_co= de), + tec, MEMTXATTRS_UNSPECIFIED, NULL); } trigger_pgm_exception(env, type); } --=20 2.53.0 From nobody Sun Mar 22 14:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773946374; cv=none; d=zohomail.com; s=zohoarc; b=Xskxe2HUWW2e4QmgNgCN1HfXKMPpqwjXAcEXmGBkRNZl032J59TH+rqVhNkYwmy25RuqDXkdisD418EU7GeXYUXvh2mjGbYO+saYf2TcSePJxRnVobECEL1HjWDOi5oCB+mtsIaC0Jq+4u+g7gTd0vllVU1k+krtaRqxSCrQ6bI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773946374; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=m5+9Mze0q86tdRWOd/Rf1eSQxbgALAi5yY69KbTLuW0=; b=Lz9KUeZHHsMdXf7ry3j+kAzsQMVuO0esfd1FUFZpVV7zfBdPWDcc4a+rZ61dg/lGcLW9U0H0PhhE0uInd1VHRv04GapaezrnrN0vK/AktU4nLB0ldVp4lO5pIATaIBuJDnreGXfg0u/Ef6U93tl8coigFOc0pPK/h97tS7GKzhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177394637426596.43050204045619; Thu, 19 Mar 2026 11:52:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3ITz-0003UN-D3; Thu, 19 Mar 2026 14:52:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3ITx-0003RY-V8 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:33 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3ITw-00012F-Fz for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:33 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso14150775e9.0 for ; Thu, 19 Mar 2026 11:52:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd923sm543334f8f.12.2026.03.19.11.52.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 11:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773946351; x=1774551151; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m5+9Mze0q86tdRWOd/Rf1eSQxbgALAi5yY69KbTLuW0=; b=LqILi/iBFqYivgJiJEYhmm6g6UJLsHpT+nXSDGizB3NG9Da5+hHY8VmIkOPSAebvsc yuzHIu3pWLWXkeVIVbj43WrjHgRGYAzGvPrNBgp62gGTRLHOv/7Cp1tcw6HH14Ae6A4X z8FT1SAZxLOo2Z7ysLvloYKlUO+Q/JV/VuPYfku40Qxzs/bz96diRffSFzOezpDCveQQ 8XCMjwnHgvsa19WfwSLkJ2xOVUeBuwfo3JNvE7TNrMWJiXQqRdU6iScast8WZGMjPaQp 5flUG8G/ukay3c4RaDQPERuGytVQxXzou5FAqOjKdjklfAv3RphM2e/MgHruwBybDLIJ 3Tnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946351; x=1774551151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m5+9Mze0q86tdRWOd/Rf1eSQxbgALAi5yY69KbTLuW0=; b=TVJeDZTemuBYqUJKw/anO4VOVoaW4xD/qzGkIiXbr1eOjxelF5VMVO4uTtfbWlFbqW yWkEUUF2sKztVDoSyMWy5tuAK0Iwt79RH7ZwgD6FWEnCRZbK0rZvR0sLR+OADQS3n/TP T5enEE9Ajsyb4E6DItBKngEDnIq0kkGTZoslPZSIuY59oG72gWGR3X0yqliS7QKAkLlt qMACTs46ftZQ/0vd1Wb6upR5vQTO2tylQRYgECMCxeyaLmo89J8rRct127o5DPedhDWY l+vl5DRtJFBfugdOBwggW/dxOcWd17KwdUttc50z3vRet8/SAxQIzi+5v1ydfrZU1q8/ liPQ== X-Gm-Message-State: AOJu0YwapTJ9gKzYFKEFlNTNHySiiU32Yn9GizllyqFFvxGVTK3RyW4N m5NLCLZuFbcy/vG7zZ1JjhvDp4JebhInqvqgi7I2QECDjIgAbD9OYveV1Ge4Xi8FxhZsqcZLqY/ 86w9ZjNA= X-Gm-Gg: ATEYQzwaNRlP8XPKPuaWERRu7cn9M4TlwnbJwaeV3MDlI7nWouixjnstLrePRyKSRiq +yAw8DM074MG7cqSDkLcPFK21AQtdf9oi1SuQ4WC3NbqFlSrkUWen1J8eJeAB20lxiMeAJNaksq K1jD8ZnQPAU1kZF0ccQmQ5QYNbxeEO0oFOBt8xK9YPYEm5pUc7e1y9C22XsJUbvuUO/uEGY65E8 d8sPah3NwYemgP6Hj5O4eWTtO1LGy3G9oYdf3+U80gnupKazJBv9qgcRkcCCMZbvV9QPYHbo3DP 276wCCoFfoxrN+HQ8TaTPU+bhcsCNRN7ASkMcvQzQFfo84gi5Wvh3Y4hlDz7rM1EuLWZFI8wuh0 zNsKhVE+M9pX2oGpas3K8YTsQ1xowa2SKQ+cXN2wSX9FawB3DifpRJn7cFa3qjfHONTRdogEG/x gZy51MS/ZhfxKVNxbXu/hEleN9cWgYxj5L3UXUzo9qJkZXezfwTm9euW+g1YGHH2dZnC8Cnrcz+ em2jEUaWdo= X-Received: by 2002:a05:600c:4fc9:b0:485:2ce2:4c8a with SMTP id 5b1f17b1804b1-486fede737dmr3537345e9.1.1773946350604; Thu, 19 Mar 2026 11:52:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Ilya Leoshkevich , Anton Johansson , Eric Farman , Christian Borntraeger , Matthew Rosato , Richard Henderson , Halil Pasic , qemu-s390x@nongnu.org, David Hildenbrand , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg) Date: Thu, 19 Mar 2026 19:52:01 +0100 Message-ID: <20260319185203.11799-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319185203.11799-1-philmd@linaro.org> References: <20260319185203.11799-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773946375689158500 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result). No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Matthew Rosato --- target/s390x/cpu-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cpu-system.c b/target/s390x/cpu-system.c index 881171d71a2..285f5999661 100644 --- a/target/s390x/cpu-system.c +++ b/target/s390x/cpu-system.c @@ -63,7 +63,7 @@ static void s390_cpu_load_normal(CPUState *s) uint64_t spsw; =20 if (!s390_is_pv()) { - spsw =3D ldq_be_phys(s->as, 0); + spsw =3D address_space_ldq_be(s->as, 0, MEMTXATTRS_UNSPECIFIED, NU= LL); cpu->env.psw.mask =3D spsw & PSW_MASK_SHORT_CTRL; /* * Invert short psw indication, so SIE will report a specification --=20 2.53.0 From nobody Sun Mar 22 14:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773946370; cv=none; d=zohomail.com; s=zohoarc; b=XLCcTaTGiO7b1BppP8Mm8lOUy3jrqvl6Qosd/KzGxaxaABiC6G65EjHu9LSMVGkFG0Vs3JiUPxnpsHS+I8yDieKvOkp2PeUksy52H4QewRuBgeAfdDNAdu6isZ0QSJaFUJbyr2fkaw0o1Zxw/yBDkHESFRUpcVzIBI9ttdxlzzU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773946370; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eQpjTeiDB4ugZhG/LoGHrXNYNzWgqM1WygHLL3iJQjU=; b=MmE25rs3bwVYWqSZNG9Grp6PY960ZF/xIf3cVXSIcT/zGS1aUZGu2oGtDDPqJFPO2bL6m+F+3gOHMPrqzeiYXUZN2PsAKj1O+cmOkFWT4Op+gPVPbgE3pB5EFpUX2sNO2G1PGayDE06QFnq7M4nmvbM89tu5alw1D6k5w7d/Ikk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773946370913632.065615793845; Thu, 19 Mar 2026 11:52:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3IU7-0003sZ-Tz; Thu, 19 Mar 2026 14:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3IU7-0003rw-2H for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:43 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3IU5-00013a-GM for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:42 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so11625035e9.2 for ; Thu, 19 Mar 2026 11:52:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm934755e9.1.2026.03.19.11.52.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 11:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773946360; x=1774551160; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eQpjTeiDB4ugZhG/LoGHrXNYNzWgqM1WygHLL3iJQjU=; b=tAI3AB8kfSdXS/KHCDsmL8ar70j2yxuKN89KBiVRUem04c0y/dzOXmzT29EfEmgCXV vuIPu0Cl3X5cD1k2JljpfmkCkWYQ0ayAXi2n6yht5WcAhTiYXDuhECI7hglCcEcvi2ls ntUwjxwb5vtlhnakq3jotEXxcm2O41Vctn72uZoiRG+pONqTaEr36as8N2ZrbK+8qSxo 054WQnd5Gm8G7f1qv0Y4KWVPPsHJCbJ722f5LSLACXceVh1rIMg2cXXSOaSsVl3dSIr/ 5e9d9xctuyZd1fsvivgdPuQ1n/gQ9vjX6reLHhl4C8Kf6X8f8fgYgniFavYbpQtd8hp1 PXww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946360; x=1774551160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eQpjTeiDB4ugZhG/LoGHrXNYNzWgqM1WygHLL3iJQjU=; b=FY4dZjO90/s0nWCngAgLDvCtqQG46/9pNC9pa/6BvuJqULQpTcRKz4aEthw4vZhgJj ieD6bCA58+RIHZ/hRQJ7oxDm1q062yVBP1XZS9qVvQAfqbwlSuW8dY4ZXEqxhriY40jz hSU2i3M2925V/zXyNfW12LUQMaCqPXoceF7217SzlKevBcAnZDj0A8CM7c9qm/QTtb4c hxV2OBDfmH1r9lTLFiwXSkhATK9bDXbCtF0TH+rq72FHc1W6h8FRkUXQ3qn459q5iTHx bUefq3nqrLqCz4OayO8bJHg8gMEei2KXryc7o7c97WPMf3jm+PfzK4V3aL2hFOiGe+B6 ru0g== X-Gm-Message-State: AOJu0YyFr8CivmK5NyymmEgnaCJ6zqOBbrb8g9+B3wx/WSN4VwL5uF/w oj7UyWUVOUjKNqysAO2yllwNRIjNpDE8hboOXkYfWN0oOSNr5jTis33GgV/PoGINbULbM/i5xeC EOnwaWuA= X-Gm-Gg: ATEYQzwBbOmvKt6RWTlwC6479MIUmR4KHtVBp4bV5D3a+3pXs9+DyuzULkYLqK+6gvC xOifibRcPBCbCJHkbgu5B9anu51vfPSu7KqJ6u+wdoiAVeHJEd+Zfuz6KoM6El3OJgWHnzudltb ggm60eC4zve7FXFKdRJyLW6mfGAf9ZAHyBSQRxrhsHlRhn30fpeS1uCNKVk7WUW5m3Zsy3abdqK scxsXuUXy600Z8cHcIEahT/ZQOgvv2l2DpB0weEvQoHjrOorihZf7+VIj0bKnJ5IKfm9NgA5Mzv /K+oOOIVPi8VGPIznMHFSgFj1kSJpqPJKo9PyASAXiyYQYeyb4E7IR1Imvdavpap7xs0T8FNrRB UzVZALbJJxpnEZQHDQpC6MuqiwXrW2BFWE+9TPP9SkWD7aaLy/ayheohupP8BW3Jh6iVxZ1KcTr XAuhF3qEVbYq7crdl1T/4BNHqh8EyHkUKSb5cwbsahFLMdrUxnbmKtsN0cgoRiB8swmMTXB3m8 X-Received: by 2002:a05:600c:8b24:b0:485:3dfc:57c with SMTP id 5b1f17b1804b1-486fee0fcf6mr2504505e9.21.1773946359546; Thu, 19 Mar 2026 11:52:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Ilya Leoshkevich , Anton Johansson , Eric Farman , Christian Borntraeger , Matthew Rosato , Richard Henderson , Halil Pasic , qemu-s390x@nongnu.org, David Hildenbrand , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm) Date: Thu, 19 Mar 2026 19:52:02 +0100 Message-ID: <20260319185203.11799-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319185203.11799-1-philmd@linaro.org> References: <20260319185203.11799-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773946371517158500 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result). No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Matthew Rosato --- target/s390x/kvm/kvm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 54d28e37d4d..bd22f6f0188 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -36,6 +36,7 @@ #include "qemu/main-loop.h" #include "qemu/mmap-alloc.h" #include "qemu/log.h" +#include "system/memory.h" #include "system/system.h" #include "system/hw_accel.h" #include "system/runstate.h" @@ -1664,13 +1665,16 @@ static void unmanageable_intercept(S390CPU *cpu, S3= 90CrashReason reason, /* try to detect pgm check loops */ static int handle_oper_loop(S390CPU *cpu, struct kvm_run *run) { + const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; CPUState *cs =3D CPU(cpu); PSW oldpsw, newpsw; =20 - newpsw.mask =3D ldq_be_phys(cs->as, cpu->env.psa + - offsetof(LowCore, program_new_psw)); - newpsw.addr =3D ldq_be_phys(cs->as, cpu->env.psa + - offsetof(LowCore, program_new_psw) + 8); + newpsw.mask =3D address_space_ldq_be(cs->as, cpu->env.psa + + offsetof(LowCore, program_new_psw), + attrs, NULL); + newpsw.addr =3D address_space_ldq_be(cs->as, cpu->env.psa + + offsetof(LowCore, program_new_psw) = + 8, + attrs, NULL); oldpsw.mask =3D run->psw_mask; oldpsw.addr =3D run->psw_addr; /* --=20 2.53.0 From nobody Sun Mar 22 14:10:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773946385; cv=none; d=zohomail.com; s=zohoarc; b=QEc5J+YkNHaVNpnJIJBIdlgrN2FqX6oNCqnyFSWxhrt4evQD+/U+y2+KXHDfjsIF6A/Ck6lpSack6wAFOsKO/RANKSCvpZfCcuhXt60Pf/Wsr2yXNwggpWQj61HoMz75CEmvFnSXg9FFpMo07PVH6dAExvIwfNuO/PJh0dwsJ4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773946385; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EHvV98N1vBG7Msqj+ig/zOVtTID7C0EI/MEHDz7oGBk=; b=XclB4maaZxUWMmq1JCenfTpc2ACa7WI9mLdysnyWyLTiq+jRwjnqrw80jfLOpYYuIvc1JmZmWyjCvQuicH+AN9xYdDRFdfw9DpeFEloxPYG+WYWtllo6KAp3i6yfQYsDN5jo3uYbDwyVLN2/TmFkhFHHgeq7SX9XNbo4qTsG4ew= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773946385278771.6420374959084; Thu, 19 Mar 2026 11:53:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3IUF-00043A-Qs; Thu, 19 Mar 2026 14:52:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3IUF-00041z-12 for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:51 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w3IUD-00015h-MC for qemu-devel@nongnu.org; Thu, 19 Mar 2026 14:52:50 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4853aec185aso8255875e9.1 for ; Thu, 19 Mar 2026 11:52:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff173756sm242435e9.0.2026.03.19.11.52.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 11:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773946368; x=1774551168; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EHvV98N1vBG7Msqj+ig/zOVtTID7C0EI/MEHDz7oGBk=; b=N0C/rhgoR/KzYHX/xpNZTM/r7LTFlOtkpWC4z5xW35jExNDqu6EsCOp+Ju/F/+oPeB gA0v9t7xuKqog2C+f6U7xBrU+H1LAgQdUibMPqbYJpmXP04qyLmIcowgye7kzDhf59Qm jm4jQLM6zeH6SzvkeOngE8TD1A6Pmle3LhVRP4Ikw9/0lcqAYwWqBVvWw3ot+9knGDQT I7P+OrXHijEbubPa4ThTRlVqevAcbup3eQU8eR7Jcae0q3ymN0Nvt2pKnf1utu0bvr0v bjSBm2CqsVsLB8wSg8l5Rv9PByOEcFiGHFfyXYwCl/fogVMueLviEz71DfuTYNC2cjsZ 857g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946368; x=1774551168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EHvV98N1vBG7Msqj+ig/zOVtTID7C0EI/MEHDz7oGBk=; b=V91eQ9hul5HdMdoLAwIQCLxr6PWoVF6BQ4ZgzprRwCE9ROA0/gIxQTOnioBmTPpZC2 xfnDcbPpd5wBTqpzREtcYXOGfEvtWdDxKO0CqizuGHuRFqYMlx8uhziQOvJFu7fg0F8U HLVlCcNtV6YM4fW17PffJ+LektypcmnAjA44DQ3JvlVUEMQBCAQnOHIp1kG4gRoEjbIl 1oeLKgeLp3vOr4d9xzFgVwRmT2Ug/PsL1cNp3FrWmTi6hkuHpdoKaPqng9AXD0OC0UqS t4YJubC72GusPhtKOYdNYbh7Ze/SivqQ/ESKVn7Lv8eqGcAO5d408mKcvXlcJuD69CPL ThOA== X-Gm-Message-State: AOJu0YwvQk5sIm8nTkHxmh2f+5FVVf9Et7k2mf5pXVNbq71TKz0Vy6TJ YoeBzbIZ4EiCDS/sScMZhMEDn1O955BGE7yzGPq4XCpnvIyFCKrVNNh9lp8Th4fXIyIavcjOzHZ +qq0IuwU= X-Gm-Gg: ATEYQzx+40dPA0qE/uGfXx6hcU63IkJj9U9/GmrZrzt76L4drzFH17qz1iqLhRU62Gz oSQ6yWpdd6GYvKeKKI9Olf3z92VaOdZkdGt5djKhe2xJaSxi1IQ8EGs9Jvcnsl0njmvydhWHM6r LX6Fb1wo8cnqveaPjYgfmBW14vG04mstgaSxadOpzuBrJDvoFEa3kvhlTZXxgljRJKJgg245Zgq VHWuTSjBEOA2mYZFOSCQGI7Jc2aYpdbjXHD6zDpEX6v3+L7QCTEd43h9uWezE5UV45lEujg4m3B TIi6LvZKWRv7GCk65rDkmpsjC0VL/9FEvn1FD5mWiLpYkLg26YCpS3MArmRszw7ca0eyF+PjYs6 p7A6hwHs7eyfZfmVY6nO4B/57a1ragboNHBduKY0sdXg/MOXcm7yLS9Jli3h4qPSkKCed45YMGG VD7TBqbwctPjUzauc7HtQskBBYlovaB6HCHuRj/tP20dZnxNZC/cbrb/N4Bqy3H8pLZPRjyzsP X-Received: by 2002:a05:600c:a4a:b0:486:fe83:8621 with SMTP id 5b1f17b1804b1-486fee1ab20mr2575835e9.23.1773946367782; Thu, 19 Mar 2026 11:52:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Ilya Leoshkevich , Anton Johansson , Eric Farman , Christian Borntraeger , Matthew Rosato , Richard Henderson , Halil Pasic , qemu-s390x@nongnu.org, David Hildenbrand , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/5] configs/targets: Restrict the legacy ldst_phys() API on s390x target Date: Thu, 19 Mar 2026 19:52:03 +0100 Message-ID: <20260319185203.11799-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319185203.11799-1-philmd@linaro.org> References: <20260319185203.11799-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773946387848154100 The s390x target doesn't use the legacy ldst_phys() API anymore. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the legacy API to the qemu-system-loongarch64 binary, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Matthew Rosato --- configs/targets/s390x-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/targets/s390x-softmmu.mak b/configs/targets/s390x-soft= mmu.mak index e273075f1a9..478988e6d4a 100644 --- a/configs/targets/s390x-softmmu.mak +++ b/configs/targets/s390x-softmmu.mak @@ -4,3 +4,4 @@ TARGET_KVM_HAVE_GUEST_DEBUG=3Dy TARGET_XML_FILES=3D s390x-core64.xml s390-acr.xml s390-fpr.xml s390-vx.xml= s390-cr.xml s390-virt.xml s390-virt-kvm.xml s390-gs.xml TARGET_LONG_BITS=3D64 TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.53.0