[PATCH] rust/hpet: remove stale TODO comment

Mohd Kashif Khan posted 1 patch 1 week, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260126210910.28889-1-kashif04x@gmail.com
rust/hw/timer/hpet/src/device.rs | 1 -
1 file changed, 1 deletion(-)
[PATCH] rust/hpet: remove stale TODO comment
Posted by Mohd Kashif Khan 1 week, 4 days ago
The irq binding is already implemented in the following line, so the TODO comment is obsolete.

Signed-off-by: Mohd Kashif Khan <kashif04x@gmail.com>
---
 rust/hw/timer/hpet/src/device.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/device.rs
index 4757bf5fd5..ebf715d399 100644
--- a/rust/hw/timer/hpet/src/device.rs
+++ b/rust/hw/timer/hpet/src/device.rs
@@ -725,7 +725,6 @@ fn set_cfg_reg(&self, regs: &mut HPETRegisters, shift: u32, len: u32, val: u64)
             self.irqs[0].lower();
             self.irqs[RTC_ISA_IRQ].lower();
         } else if deactivating_bit(old_val, new_val, HPET_CFG_LEG_RT_SHIFT) {
-            // TODO: Add irq binding: qemu_irq_lower(s->irqs[0])
             self.irqs[0].lower();
             self.pit_enabled.set(true);
             self.irqs[RTC_ISA_IRQ].set(self.rtc_irq_level.get() != 0);
-- 
2.43.0
Re: [PATCH] rust/hpet: remove stale TODO comment
Posted by Paolo Bonzini 1 week, 3 days ago
Queued, thanks.

Paolo
Re: [PATCH] rust/hpet: remove stale TODO comment
Posted by Zhao Liu 1 week, 3 days ago
On Tue, Jan 27, 2026 at 02:39:10AM +0530, Mohd Kashif Khan wrote:
> Date: Tue, 27 Jan 2026 02:39:10 +0530
> From: Mohd Kashif Khan <kashif04x@gmail.com>
> Subject: [PATCH] rust/hpet: remove stale TODO comment
> X-Mailer: git-send-email 2.43.0
> 
> The irq binding is already implemented in the following line, so the TODO comment is obsolete.
> 
> Signed-off-by: Mohd Kashif Khan <kashif04x@gmail.com>
> ---
>  rust/hw/timer/hpet/src/device.rs | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>