From nobody Sat Feb 7 05:49:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1769462106; cv=none; d=zohomail.com; s=zohoarc; b=WbjNTIKW1Iuv4365Tl05YIDhGVtKftnZNJ8Lt0lEfxx2EcSMdrxclEJ/qiJUtqNmMhNTmtaYIkPF9pqhasNWkj5LS2l7LhQ00qf7S2SHyWBq2qKTFmzGthED5XvYt4k+VAWGqW8J93bidFNDB2Y03s5cg3nJcjZn/A5a3v5VP8s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769462106; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kosn0WAQuevoMsLu0uEvasVX+DCTWkopGnDCnhcTRFo=; b=V6MfBfTnDWdb5eEH5j1XAI/8l15pgGIgEw9FCn1mMqqj8YosH4L/w8/KtWW1izsiLOyuHGPX5p2f8GkQf9maTeHAUv9arQ/pE/gXxw6NbkWGzmG5kUECSyjXT37WmBlWMq7OaJEkbp/OUG0fl9sqsMJ3GYdzRHTa1ToLIN7Dn54= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769462106982935.6340536141241; Mon, 26 Jan 2026 13:15:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vkTuk-00086s-8g; Mon, 26 Jan 2026 16:14:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkTpo-0004Xj-BW for qemu-devel@nongnu.org; Mon, 26 Jan 2026 16:09:20 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vkTpm-0005j9-UU for qemu-devel@nongnu.org; Mon, 26 Jan 2026 16:09:20 -0500 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-81e8b1bdf0cso2664796b3a.3 for ; Mon, 26 Jan 2026 13:09:17 -0800 (PST) Received: from Third.localdomain ([157.49.1.62]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a3f1ebesm9350512a12.19.2026.01.26.13.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 13:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769461756; x=1770066556; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kosn0WAQuevoMsLu0uEvasVX+DCTWkopGnDCnhcTRFo=; b=laVIgp7T+lDJFDCz6yf2xIGEjD8s3pPZb9DQShjk797hf4bxxV18v5J3li92gNFOIx 6Wf+Wh8t8Mv58OctKpM6Hc10io2kFz5fb9/ekBuE/XhFHtWvumHowVsXgrN7BkBcVgCB TFnIA9HtBE8iVwapjr4h0BQPFr8KN2YeDChSEpbNjVmX5P+TUMioIrhQra1egdxy/0ZQ UxLOBYAz4IL9MPNCRXU3WFwTofnDLW0hHbcDmM5cA9rfagiwjYsT9AGcNWQjNlgjSqgl KlihK/YZc/Qz5VUvuOgdtbdb+3gi6p9Yu/a38WK7q3ZjXoIiBqqBUCIKju1G9P37CqWn k+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769461756; x=1770066556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kosn0WAQuevoMsLu0uEvasVX+DCTWkopGnDCnhcTRFo=; b=bgv70fTY8c3pb4SCfDLJPGdL1pB9vxgFz0FmzMO/k+LmZHwy7dPhYPhUDx5x8zvHfE o4CX9AuWxFan0e1uaqBIfRoRJwG2bMEmdlsbF9YopihIoVqC3nw/cJbAf1RojE6q38Hj 8ivdu4vFZJX3rejEsV4AESOtwy8kyF+FEaJlDb4HQtwSdVSbXCT+dg2FvGETPLYVLBJ7 m1dpDAdh0vY7FKgeYjd6hiOP0/x9qHQk3JAY9YzUBVpqQaWD6ulO49UhQJmLpcC323eW w/U509jFPbfHcDKEXV+q0ydRAFXfN1C2VZSxdNig/tLas4NhSBwU/qRaeaN0nXnV9K7c oQVw== X-Gm-Message-State: AOJu0YzPPYKXgNnSejL82+U0vDpodBDccMsuDXvSk3cnhdDBRQPC7saM aF56QRgU8Qh4YZsGc3G4uOkWn5haBg6AWfSyaBcitF9XZtmXBGuEOC6FLppo4Q== X-Gm-Gg: AZuq6aLozDZyo162iCzew7LAgfvjwzcI0l+uDxSwLJZfgrx6BA4sS55tYZw8LE/Vbsy MFk/bHJ3tpSalLVqSx8VFyCkV0eVBOZkZ7Y6xmCrsIef5HYRgdU65YS6BuA9hrr3EBQEQlaEoyl 8dNtuXbP6HMMTH0Wod9JUu1niVxuHEKRczcFnLZTraEH74BITY8AhnS0eelITGAY190YmMZttcr xom81M416Nw/q+HpDv4V5+CHokGbzNdQ3pa8M5kDTlJJFhHbd1CerMTl3Tv/pAPPd9ceyd1QIKx abCJ6MOGNpJv9FyGGlLRGjD3rlYb6B4xLoy+ZaeGwoWWEaZCl5lODI1TsLTX+Ha3/mduht+se3j oW7wK7kpH4bdxUMXCunqGULjnhfmxCa05GNvS0ReOSkqqtgF6PDBHin1QVBP1PpUQi/3xxpJS2L La1asLR7CUwVnN0Ybi+g== X-Received: by 2002:a05:6a20:1604:b0:35f:5fc4:d88b with SMTP id adf61e73a8af0-38e9f0e9b7fmr5841985637.12.1769461755876; Mon, 26 Jan 2026 13:09:15 -0800 (PST) From: Mohd Kashif Khan To: qemu-devel@nongnu.org Cc: qemu-rust@nongnu.org, Mohd Kashif Khan Subject: [PATCH] rust/hpet: remove stale TODO comment Date: Tue, 27 Jan 2026 02:39:10 +0530 Message-ID: <20260126210910.28889-1-kashif04x@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=kashif04x@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Jan 2026 16:14:22 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1769462108985158500 Content-Type: text/plain; charset="utf-8" The irq binding is already implemented in the following line, so the TODO c= omment is obsolete. Signed-off-by: Mohd Kashif Khan Reviewed-by: Zhao Liu --- rust/hw/timer/hpet/src/device.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index 4757bf5fd5..ebf715d399 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -725,7 +725,6 @@ fn set_cfg_reg(&self, regs: &mut HPETRegisters, shift: = u32, len: u32, val: u64) self.irqs[0].lower(); self.irqs[RTC_ISA_IRQ].lower(); } else if deactivating_bit(old_val, new_val, HPET_CFG_LEG_RT_SHIFT= ) { - // TODO: Add irq binding: qemu_irq_lower(s->irqs[0]) self.irqs[0].lower(); self.pit_enabled.set(true); self.irqs[RTC_ISA_IRQ].set(self.rtc_irq_level.get() !=3D 0); --=20 2.43.0