[v4] vhost refactoring and fixes

[PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path

Vladimir Sementsov-Ogievskiy posted 23 patches 3 weeks ago

Diff against v2 v3 v5
Download mbox

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, zhenwei pi <zhenwei.pi@linux.dev>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Raphael Norwitz <raphael@enfabrica.net>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Jason Wang <jasowang@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Christian Borntraeger <borntraeger@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, "Alex Bennée" <alex.bennee@linaro.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

Expand all Fold all

[PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path

Posted by Vladimir Sementsov-Ogievskiy 3 weeks ago

We leak notifier initialization on that failure path. Let's
cleanup it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 hw/s390x/virtio-ccw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 6855e20d09..ba55bf4fe9 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1038,6 +1038,7 @@ static int virtio_ccw_set_guest_notifier(VirtioCcwDevice *dev, int n,
             if (r) {
                 virtio_queue_set_guest_notifier_fd_handler(vq, false,
                                                            with_irqfd);
+                event_notifier_cleanup(notifier);
                 return r;
             }
         }
-- 
2.52.0

Re: [PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path

Posted by Halil Pasic 2 weeks, 5 days ago

On Mon, 19 Jan 2026 21:52:11 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:

> We leak notifier initialization on that failure path. Let's
> cleanup it.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

Re: [PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path

Posted by Eric Farman 2 weeks, 6 days ago

On Mon, 2026-01-19 at 21:52 +0300, Vladimir Sementsov-Ogievskiy wrote:
> We leak notifier initialization on that failure path. Let's
> cleanup it.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  hw/s390x/virtio-ccw.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Farman <farman@linux.ibm.com>

Re: [PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path

Posted by Thomas Huth 2 weeks, 6 days ago

On 19/01/2026 19.52, Vladimir Sementsov-Ogievskiy wrote:
> We leak notifier initialization on that failure path. Let's
> cleanup it.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   hw/s390x/virtio-ccw.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index 6855e20d09..ba55bf4fe9 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -1038,6 +1038,7 @@ static int virtio_ccw_set_guest_notifier(VirtioCcwDevice *dev, int n,
>               if (r) {
>                   virtio_queue_set_guest_notifier_fd_handler(vq, false,
>                                                              with_irqfd);
> +                event_notifier_cleanup(notifier);
>                   return r;
>               }
>           }

Reviewed-by: Thomas Huth <thuth@redhat.com>