From nobody Tue Feb 10 09:40:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1768848867; cv=none; d=zohomail.com; s=zohoarc; b=lkDMwxiu0brVwxQr3UdAaV4ZdiPiEgNUONgfIx40AOTVVSgoecBGnboXolsOYJcqv5HxdjEkjdsvrUW5aVGwxEgkRz29VVwYhTVWfgI7wnHFo325+4hLvH4q5krXG0/yIZG2/C7saEythDWlT2f+vqBd1fiOMcfcM+64S7XU4l8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768848867; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jgwyRL487Sc6PAURrYwWU1dEaoHIWWSkYtd7+IgD4R8=; b=TPtedEBGddRKqj4CoAltfgxzHDa2I8JKBS/K4S/5wWGHGtXzvjY7gaqO5OewCiLtlZVPRM7/kOY+aORMR0AyhgaoQbRe9zXfNXXETJpYH/5shzLkstiUGemK+D+YuM1td58azxXywNcd2/eL7rn2U21IlULOgu7lIUBswelQkWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768848867526392.0566585947678; Mon, 19 Jan 2026 10:54:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vhuNE-0006Yy-3e; Mon, 19 Jan 2026 13:53:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhuMx-0006Ge-Kq; Mon, 19 Jan 2026 13:52:57 -0500 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhuMv-0005rZ-EZ; Mon, 19 Jan 2026 13:52:54 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:5c05:0:640:ff67:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 45CF0806F0; Mon, 19 Jan 2026 21:52:50 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:934::1:38]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id dqetGa1BQGk0-iN53xzna; Mon, 19 Jan 2026 21:52:49 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1768848769; bh=jgwyRL487Sc6PAURrYwWU1dEaoHIWWSkYtd7+IgD4R8=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=cjLsbepAnsVqtAGvbpbFzu22WYW8WxXlrhEXSZYtG1GOvSlCkgabD0mFwWz3r7G/J L6WUriqm9OvhyGrxsSVP2FLYjvOTE33KY0e7/wcAamjUwtJ4kMfdYhdgbX5EfPsfNK 11gbA6BgA5L08ypOFCcsn4n4EPQ/GzYjq4IGDaVs= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: mst@redhat.com Cc: sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, Cornelia Huck , Halil Pasic , Eric Farman , Thomas Huth , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Christian Borntraeger , Matthew Rosato , qemu-s390x@nongnu.org (open list:virtio-ccw) Subject: [PATCH v4 07/23] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path Date: Mon, 19 Jan 2026 21:52:11 +0300 Message-ID: <20260119185228.203296-8-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260119185228.203296-1-vsementsov@yandex-team.ru> References: <20260119185228.203296-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1768848870736154100 Content-Type: text/plain; charset="utf-8" We leak notifier initialization on that failure path. Let's cleanup it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Farman Reviewed-by: Halil Pasic Reviewed-by: Thomas Huth --- hw/s390x/virtio-ccw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 6855e20d09..ba55bf4fe9 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -1038,6 +1038,7 @@ static int virtio_ccw_set_guest_notifier(VirtioCcwDev= ice *dev, int n, if (r) { virtio_queue_set_guest_notifier_fd_handler(vq, false, with_irqfd); + event_notifier_cleanup(notifier); return r; } } --=20 2.52.0