[v1] hw/scsi/ncr53c710: Fixing defects reported by Coverity Scan for QEMU

[PATCH] hw/scsi/ncr53c710: Fixing defects reported by Coverity Scan for QEMU

Soumyajyotii Ssarkar posted 1 patch 1 week, 6 days ago

Diff against v2 v3
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251031224838.229154-1-soumyajyotisarkar23@gmail.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>

There is a newer version of this series

hw/scsi/ncr53c710.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH] hw/scsi/ncr53c710: Fixing defects reported by Coverity Scan for QEMU

Posted by Soumyajyotii Ssarkar 1 week, 6 days ago

From: RemZapCypher <soumyajyotisarkar23@gmail.com>

Fixed Null pointer dereference & Async/Sync IDENTICAL_BRANCHES defects
reported by Coverity Scan.

Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
---
 hw/scsi/ncr53c710.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c
index b3d4593b72..dd9884c8bf 100644
--- a/hw/scsi/ncr53c710.c
+++ b/hw/scsi/ncr53c710.c
@@ -834,13 +834,11 @@ void ncr710_transfer_data(SCSIRequest *req, uint32_t len)
         }
     }
 
-    /* Host adapter (re)connected */
-    s->current->dma_len = len;
     s->command_complete = NCR710_CMD_DATA_READY;
-
     if (!s->current) {
-        return;
+        s->current = (NCR710Request *)req->hba_private;
     }
+    s->current->dma_len = len;
 
     if (s->waiting) {
         s->scntl1 |= NCR710_SCNTL1_CON;
@@ -1367,11 +1365,6 @@ again:
         case PHASE_DI:
             s->waiting = NCR710_WAIT_DMA;
             ncr710_do_dma(s, 0);
-            if (s->waiting != NCR710_WAIT_NONE) {
-                /* Async - stop and wait */
-                break;
-            }
-            /* Sync - continue execution */
             break;
         case PHASE_CO:
             ncr710_do_command(s);
-- 
2.49.0