From nobody Fri Nov 14 17:01:15 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761951052; cv=none; d=zohomail.com; s=zohoarc; b=Tndc1/Mvg7p7whLTpxzjgn4Cx8+Hc6+VelmKalyxwZVrmCOHlmXjsLuN24T9uNnMPzSPKS96h/1hoDTcWRum7LiGiiZoQOA19eF7H8Z76WPc6r5jpOf3L+5waqa8X8XaujzRwQ8/PfFSm1NI+wnlucZ5EVMOCEz/vdewWLF56u8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761951052; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O88KYOjUwqb1BPlw/7cvHlppXwsxo2scBXj/TdGXXgk=; b=asfY/pqIR0EswPxrav3IrpbWKyWIroO8TqHhBh+jr4lFHvrgf0DwDW0T3RTAtQFb3BhD0yMlUgTYZtfWSwVaBiTGBCJndq1KLu9MpsgiV14V8Yq+npPOFyiOwXXmEgk9Vu31aQUassDg/SWFcZcrTe+uKdZVmjAHzdVcXD/+wc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761951052299198.61558392423774; Fri, 31 Oct 2025 15:50:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vExvX-00032Q-QY; Fri, 31 Oct 2025 18:48:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vExvV-00031Q-3M for qemu-devel@nongnu.org; Fri, 31 Oct 2025 18:48:57 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vExvM-000882-1L for qemu-devel@nongnu.org; Fri, 31 Oct 2025 18:48:56 -0400 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-28e7cd6dbc0so34545865ad.0 for ; Fri, 31 Oct 2025 15:48:47 -0700 (PDT) Received: from fedora.. ([103.2.232.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-340a079b9e2sm920786a91.10.2025.10.31.15.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 15:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761950925; x=1762555725; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=O88KYOjUwqb1BPlw/7cvHlppXwsxo2scBXj/TdGXXgk=; b=hWtuHC1GjS45KEXQLDsdRo0ZebQQ+hLA0dqawEpwat5XkKDM8FmBazrR6bWE19ld5b gmFHRBpKNb8oTFd/bHWQkT+SEevuT5rEMQYy7TAK4FqWr6ZUBVPD16vB5y6IBb5R0JsT nLZSvdiWq36p9RaanRuQuMbTFZDHNLCiAVJixR5ngpduq4sm1RSrBHodcTydIUOnzXew ojTE69KRZa0icQPl4EQwoH4SuWf9X98UnCMvdb9OHgEQ248cdTMlzPrr1Akw/u2dL1k7 cK7wtGIHYBw2u7CmerdlII7RBHviAM5jSqhXtmurfEBO3HnakStfV8iF2Y9dh+U2FDbW fJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761950925; x=1762555725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O88KYOjUwqb1BPlw/7cvHlppXwsxo2scBXj/TdGXXgk=; b=MieXU3n9KFPR5wLdLjbGv1pCP5dtXekWHWT3U8+xtNJUZA70f4yWo7HrxoYheYPyGh A3Hi3HfZH4CaDK96JkjlNsw4G7pqtbb4mQeYHg29CjKHcE0PmJViOVaIiESQDTSXBiU2 m4o9wKrRadFRjk+2kmGXdQpDprGyq6AYFDpVnT8TdKx1ahtRlxPxIGhpliK1gj9PSUiR N6U1phZwPkI+C68S9XvNApFRYCgv4/sEneIS8Hvxnt/ZHp1BBP3odLNnDDr13FFiiT4e SWS9z0w/pZs2GOMjqybEF3o8qA6uB8o18wjngZg64G9jFnCfBaT9g7f1IObEo95fYYrG AKYQ== X-Forwarded-Encrypted: i=1; AJvYcCU9ji3A/0wsjVxr3T6CTUNvW8cOo1N0lAmdpzeKBg1A7AljxNJFVzhYO3haORL/wNR4uz1IYV7pujkO@nongnu.org X-Gm-Message-State: AOJu0Yzh6YEIiDjtFlpziIfrSogB1207bi74eqo2NrwzzBKNnHDnDlOh hkKl1hGA0OVwMLScuvYtT5u2vgivUMPsucOFV5XgfgsgVCzoqa91lMXV X-Gm-Gg: ASbGnctucUBOFIgTXsnkyLjnrddQtLYHMVDtwt+7mYwabjMK1mUyjg0Tn7G/wpA8YnW lOpGEte9XHVx0GsdCyevMOfAMRQhRO8CnNj4IIE+7eQkDToZzxCOoh82Y2d2TtBispK1jxn+srn NABmoo0WF5DA+bZefb5x0Q//5ek9/kcTko4efif7pxi0XBOES7xeIwyJi6nYRhxISQqqrHHfWSq Q0aiLqUD/FvkBDNl6YpTuG05VCzlsZQeteEYCCDVQ7GZn7geEZAVciB4klZTRaxMOZAGMMMKUXH DPaYDKX5QQvDDU/6JxyT1s8tFW/g/o69BpN1zU3Dxgd3y3mtjgz6XKNbkyhPsdXQ35wqRKqcFqL Q6+W141z0vKpIwHPF2clO+mmOHItLnx9Q4Jmc+bK8IXTXrJ75j7HCWnk0u2hMFDAgXfzUZEVNMp U5N5MdnEI1geZOQSBUkzwMQsklEBneh4IPSUdpABg= X-Google-Smtp-Source: AGHT+IEoefgVJTA/rHvfo9nnY6eibwlSBgP1I1bgkzLc5H4SP28QHGZsOSJbvUZO5ApHpPUSezu47g== X-Received: by 2002:a17:902:f542:b0:295:4d62:61a9 with SMTP id d9443c01a7336-2954d62663cmr17508755ad.38.1761950924850; Fri, 31 Oct 2025 15:48:44 -0700 (PDT) From: Soumyajyotii Ssarkar To: sarkarsoumyajyoti23@gmail.com, qemu-devel@nongnu.org Cc: Fam Zheng , Paolo Bonzini , RemZapCypher , Stefan Hajnoczi Subject: [PATCH] hw/scsi/ncr53c710: Fixing defects reported by Coverity Scan for QEMU Date: Sat, 1 Nov 2025 04:18:38 +0530 Message-ID: <20251031224838.229154-1-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pl1-x644.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761951060651158500 Content-Type: text/plain; charset="utf-8" From: RemZapCypher Fixed Null pointer dereference & Async/Sync IDENTICAL_BRANCHES defects reported by Coverity Scan. Reported-by: Stefan Hajnoczi --- hw/scsi/ncr53c710.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index b3d4593b72..dd9884c8bf 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -834,13 +834,11 @@ void ncr710_transfer_data(SCSIRequest *req, uint32_t = len) } } =20 - /* Host adapter (re)connected */ - s->current->dma_len =3D len; s->command_complete =3D NCR710_CMD_DATA_READY; - if (!s->current) { - return; + s->current =3D (NCR710Request *)req->hba_private; } + s->current->dma_len =3D len; =20 if (s->waiting) { s->scntl1 |=3D NCR710_SCNTL1_CON; @@ -1367,11 +1365,6 @@ again: case PHASE_DI: s->waiting =3D NCR710_WAIT_DMA; ncr710_do_dma(s, 0); - if (s->waiting !=3D NCR710_WAIT_NONE) { - /* Async - stop and wait */ - break; - } - /* Sync - continue execution */ break; case PHASE_CO: ncr710_do_command(s); --=20 2.49.0